PR: https://github.com/tianocore/edk2-platforms/pull/81
Implements SpcrDeviceLib for AmdMinBoardPkg.
Cc: Abner Chang
Cc: Abdul Lateef Attar
Abdul Lateef Attar (1):
AMD/AmdMinBoardPkg: Implements SpcrDeviceLib library
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 6 ++
.../Library/SpcrD
Implements SpcrDeviceLib library for AMD common boards.
Cc: Abner Chang
Signed-off-by: Abdul Lateef Attar
---
.../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 6 ++
.../Library/SpcrDeviceLib/SpcrDeviceLib.inf | 23 +
.../Library/SpcrDeviceLib/SpcrDeviceLib.c | 84 +++
Thank you Vincent -- I didn't know anything about the MP approach to
edk2 networking, but even more interestingly, I never thought there had
been (successful) attempts to sneak interrupt driven device drivers
(back) into UEFI / edk2. I've always thought (somewhat vaguely perhaps)
that the timer tic
This patch set simplify the page table creation code, remove some
hard-code, combine files and support 5 Level paging.
V4:
Refine comments and update below macro names:
PG_NLE -> PAGE_NLE
PTE_2MB -> PDE_2MB
PDP_1G -> PDPTE_1GB
PAGE_BLP_ATTR -> PAGE_BLE_ATTR
No code logic impact
V5:
Update below
This patch only renames macro, with no code logic impacted.
Two purpose to rename macro:
1. Align some macro name in PageTables1G.asm and PageTables2M.asm, so
that these two files can be easily combined later.
2. Some Macro names such as PDP are not accurate, since 4 level page
entry also uses this
Currently, page table creation has many hard-code values about the
offset to the start of page table. To simplify it, add Labels such
as Pml4, Pdp and Pd, so that we can remove many hard-code values
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Debkumar De
Cc: Catharine West
Combine PageTables1G.asm and PageTables2M.asm to reuse code.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Debkumar De
Cc: Catharine West
Signed-off-by: Zhiguang Liu
---
UefiCpuPkg/ResetVector/Vtf0/Vtf0.nasmb| 8 +--
.../X64/{PageTables1G.asm => PageTables.asm} |
In ResetVector, if create page table, its highest address is fixed
because after page table, code layout is fixed(4K for normal code,
and another 4K only contains reset vector code).
Today's implementation organizes the page table as following if 1G
page table is used:
4G-16K: PML4 page (PML4[0]
Add a macro USE_5_LEVEL_PAGE_TABLE to determine whether to create
5 level page table.
If macro USE_5_LEVEL_PAGE_TABLE is defined, PML5Table is created
at (4G-12K), while PML4Table is at (4G-16K). In runtime check, if
5level paging is supported, use PML5Table, otherwise, use PML4Table.
If macro USE_
From: Gua Guo
Windows command prompt have 8191 character limitation,
enhance it to make command too long can be resloved.
Change-Id: I7f1d8d46274f1c0104572d47253d499900effe76
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Michael Kubacki
Signed-off-by: Gua Guo
---
.../HostBasedUnitTestRunner.py
[AMD Official Use Only - General]
Hi Minh,
Just let you know your PR is just merged.
Thanks
Abner
From: Minh Nguyen
Sent: Friday, May 5, 2023 2:50 PM
To: Chang, Abner ; Minh Nguyen
; devel@edk2.groups.io
Cc: patc...@amperecomputing.com; nick...@nvidia.com; ig...@ami.com;
n...@os.amperecomputin
Update mock-up file and use computer system schema version 1.5.0 in
order to support Boot.BootOrder attribute.
Update UUID of 2M220101SL for working with Redfish Profile Simulator.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../redfish/v1/Systems/2M220100SL/index.json
Updates the Python module dependency for Redfish Profile Simulator.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
Tools/Redfish-Profile-Simulator/requirements.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Tools/Redfish-Profile-Simulator/requirements.txt
b/To
Remove attribute check during patch of computer system and return
content-type with JSON format in HTTP header.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../v1sim/resource.py | 4 ++-
.../v1sim/systems.py | 28 +++
Implement ETag support in HTTP header
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../v1sim/resource.py | 10 +--
.../v1sim/systems.py | 28 +++
2 files changed, 25 insertions(+), 13 deletions(-)
diff
Add missing module import for conditional, RfCollection, RfResource,
RfResourceRaw, hashlib and OrderedDict
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
Tools/Redfish-Profile-Simulator/v1sim/redfishURIs.py | 5 -
Tools/Redfish-Profile-Simulator/v1sim/resource.py|
Update mock-up file and use Bios schema version 1.0.9 in order to
support BIOS configuration driver.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../redfish/v1/Systems/2M220100SL/Bios/index.json | 2 +-
.../redfish/v1/Systems/2M220101SL/Bios/index.json
From: VictorX Hsu
- TraceHub UniversalPayload Spec:
https://github.com/UniversalScalableFirmware/documentation/pull/52 (Industry
Standard)
- MipiSysTLib Wrapper:
https://github.com/MIPI-Alliance/public-mipi-sys-t.git (Industry Standard)
- TraceHubDebugLib: Intel(R) Trace Hub
Hi @Kinney, Michael D
All conflicts were fixed
thanks
-Original Message-
From: Kinney, Michael D
Sent: Monday, May 8, 2023 8:45 AM
To: Guo, Gua ; devel@edk2.groups.io; Hsu, VictorX
Cc: Chiu, Chasel ; Prakashan, Krishnadas
Veliyathuparambil ; K N,
Karthik ; Chan, Laura ; Kinney,
Mi
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4443
Add Google Mock Library for PciHostBridgeLib
Cc: Michael D Kinney
Cc: Hao A Wu
Cc: Ray Ni
Cc: Chris Johnson
Signed-off-by: Gua Guo
---
MdeModulePkg/MdeModulePkg.dec | 1 +
MdeModulePkg/Test/MdeModulePk
Hi Pedro,
Firstly, thanks for your comments, let me explain.
- "C99 flexible array members have been well defined and well supported
for maybe 20 years in GCC (https://godbolt.org/z/9qxKar4f6)" => *Yes, I
agree and there's no**
**comment from my side* *but this is completely different with curr
From: VictorX Hsu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
This Library is NULL library of TraceHubDebugSysTLib.
Cc: Michael D Kinney
Cc: Guo Gua
Cc: Chan Laura
Cc: Prakashan Krishnadas Veliyathuparambil
Cc: K N Karthik
Signed-off-by: VictorX Hsu
---
.../TraceHubDebugSys
From: Gua Guo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4443
PR: https://github.com/tianocore/edk2/pull/4335
V2:
Fixed Azure build failure
V1:
Add google mock support for HobLib
Add google mock support for PciHostBridgeLib
Add google mock support for PeiServicesLib
Gua Guo (2):
M
From: VictorX Hsu
Update reviewers and maintainers for TraceHubDebugSysTlib.
Signed-off-by: VictorX Hsu
---
Maintainers.txt | 18 ++
1 file changed, 18 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 09d04af27a..30e2d2686d 100644
--- a/Maintainers.txt
+++ b/
Hi Pedro,
I just re-sent in readable format.
Thanks,
Minh Nguyen
On 5/7/2023 12:39 PM, Minh Nguyen wrote:
Hi Pedro,
Firstly, thanks for your comments, let me explain.
- "C99 flexible array members have been well defined and well
supported for maybe 20 years in GCC (https://godbolt.
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4443
Add Google Mock Library for HobLib
Add Google Mock Library for PeiServicesLib
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Chris Johnson
Signed-off-by: Gua Guo
---
MdePkg/Test/MdePkgHostTest.dsc
From: VictorX Hsu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
This Library provides functions consuming MIPI SYS-T submodule.
Cc: Michael D Kinney
Cc: Guo Gua
Cc: Chan Laura
Cc: Prakashan Krishnadas Veliyathuparambil
Cc: K N Karthik
Signed-off-by: VictorX Hsu
---
.gitmodule
From: VictorX Hsu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
This Library provides API to dump Trace Hub message.
Cc: Michael D Kinney
Cc: Guo Gua
Cc: Chan Laura
Cc: Prakashan Krishnadas Veliyathuparambil
Cc: K N Karthik
Signed-off-by: VictorX Hsu
---
.../Include/Guid/Trac
Hi Gua,
Can you add summary of change made to the commit message?
I think it is changes passing many coverage files in single command line to
breaking it up into many command lines with one coverage file per command line.
Right?
Mike
> -Original Message-
> From: Guo, Gua
> Sent: Mon
Apologies for the late review. I added my comments on GH. Aside from a request
for more context for
https://github.com/tianocore/edk2/commit/b7387dae40cc3a72562c6461d007d20087ab7414#comments,
I think this patch set from a functionality standpoint looks good enough to be
submitted.
Reviewed-by:
Hi Victor,
Comment on SwapBytesGuid() API below. I believe there is a significant logic
issues and an opportunity to simplify. Please let me know if you found a
different algorithm to perform GUID LE <-> BE conversions.
A second comment on the limit on max instances being 5. Why is 5 selecte
Update to INF to simplify [BuildOptions] section below.
Mike
> -Original Message-
> From: Hsu, VictorX
> Sent: Sunday, May 7, 2023 10:32 PM
> To: devel@edk2.groups.io
> Cc: Hsu, VictorX ; Kinney, Michael D
> ; Guo, Gua ; Chan, Laura
> ; Prakashan, Krishnadas Veliyathuparambil
> ; K N, Ka
The proposed implementation is fine and I will reviewed-by and push if that is
the desired direction.
My question is if we generally like the design of doing compression in common
MinPlatform code, decompression in board specific FSP wrapper code. The
alternative design is to do compression an
Hi Isaac,
Just my thoughts, I would vote for platform/bootloader to decide compressing
the variable data before saving to NVRAM or not.
It should be optional and when platform having big SPI flash they might not
want to do this.
Thanks,
Chasel
> -Original Message-
> From: Oram, Isaa
From: Gua Guo
Windows command prompt have 8191 characters limitation,
enhance it to make command too long can be resloved.
Provide an example, if have to many *.cov, it causes to run single
command over the 8191 characters limitation.
> OpenCppCoverage
> --export_type binary:coverage.cov
> --w
From: Gua Guo
Windows command prompt have 8191 characters limitation,
enhance it to make command too long can be resloved.
Provide an example, if have too many cov files, it causes to run single
command over the 8191 characters limitation.
> OpenCppCoverage
> --export_type binary:coverage.cov
>
Reviewed-by: Isaac Oram
A few superficial things that could be fixed now or later.
Typo: EFI_STASTUS
There is a mismatch between function names and parameter names that looks like
a cut/paste from prior function. Updating would probably match the spirit of
"no functional changes", but it
At TPL_HIGH_LEVEL, CPU interrupts are disabled (as per the UEFI
specification) and so we should never encounter a situation in which
an interrupt occurs at TPL_HIGH_LEVEL. The specification also
restricts usage of TPL_HIGH_LEVEL to the firmware itself.
However, nothing prevents a rogue UEFI applic
NestedInterruptTplLib relies on CPU interrupts being disabled to
guarantee exclusive (and hence atomic) access to the shared state in
IsrState. Nothing in the calling interrupt handler should have
re-enabled interrupts before calling NestedInterruptRestoreTPL(), and
the loop in NestedInterruptRest
At TPL_HIGH_LEVEL, CPU interrupts are disabled (as per the UEFI
specification) and so we should never encounter a situation in which
an interrupt occurs at TPL_HIGH_LEVEL. The specification also
restricts usage of TPL_HIGH_LEVEL to the firmware itself.
However, nothing prevents a rogue UEFI appli
When reviewing the Variable feature that adds integrity and confidentiality,
I suggested that the interface between the Variable services and the NVStorage
could provide an abstraction to encode/decode the stored data that would
support encryption, compression, or both. Could also support a platfo
This patch-set replaces the OVMF specific SataControllerDxe with the
MdeModulePkg/Bus/Pci one.
They were both forked from the same code, and are code-and-functionality
similar. As such, there
seems to be no need for duplication here.
First I manually replayed OvmfPkg/SataControllerDxe's patches
ASSERT (Private != NULL) already covers this check.
See commit 81310a6.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Pedro Falcato
---
.../Pci/SataControllerDxe/SataController.c| 44 +--
1 file changed, 21 insertions(+), 23 deletions(-)
diff --gi
Previously, OVMF had forked DuetPkg's SataControllerDxe (see commit
12e92a2). However, in commit fda951d a generic SataControllerDxe was
added to MdeModulePkg/Bus/Pci.
Since they are most similar (both code-wise and functionally), let's
unify them and de-duplicate code.
Tested by booting in QEMU,
Hello Pedro,
Technically speaking ASSERT (Private != NULL) doesn't cover this branch.
It should crash before as result of UninstallMultipleProtocolInterfaces() call.
Obviously it make no sense in release target (under normal condition
when assertion is turned off), while this code does.
But I woul
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, May 8, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1886465 )
*Description:*
TianoCore
On Mon, May 8, 2023 at 11:28 PM Mike Maslenkin wrote:
>
> Hello Pedro,
> Technically speaking ASSERT (Private != NULL) doesn't cover this branch.
> It should crash before as result of UninstallMultipleProtocolInterfaces()
> call.
> Obviously it make no sense in release target (under normal condi
*Tools, CI, Code base construction meeting series*
*When:*
Monday, May 8, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1886465 )
*Description:*
TianoCore community
On Thu, Mar 9, 2023 at 3:48 AM Isaac Oram wrote:
>
> We are doing some work to enable CI on edk2-platforms and would like to add
> QemuOpenBoardPkg to the CI list. I do think that this will become more
> active over time.
>
> Is there a V2 coming? If so, I found a compiler issue with VS2019 an
From: Gua Guo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4443
PR: https://github.com/tianocore/edk2/pull/4335
V3
Remove EBC and fix some coding rule
V2:
Fixed Azure build failure
V1:
Add google mock support for HobLib
Add google mock support for PciHostBridgeLib Add google mock suppo
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4443
Add Google Mock Library for HobLib
Add Google Mock Library for PeiServicesLib
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Chris Johnson
Signed-off-by: Gua Guo
---
MdePkg/Test/MdePkgHostTest.dsc
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4443
Add Google Mock Library for PciHostBridgeLib
Cc: Michael D Kinney
Cc: Hao A Wu
Cc: Ray Ni
Cc: Chris Johnson
Signed-off-by: Gua Guo
---
MdeModulePkg/MdeModulePkg.dec | 1 +
MdeModulePkg/Test/MdeModulePk
Series Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guo, Gua
> Sent: Monday, May 8, 2023 5:04 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua
> Subject: [edk2-devel] [PATCH v3 0/2] Add more google mock library
>
> From: Gua Guo
>
> R
Improve the extent tree node validation by validating the number of
entries the node advertises against the theoretical max (derived from
the size of on-disk structs and the block size (or i_data, if inline
extents).
Previously, we did not validate the number of entries. This could be
exploited fo
We had added support for CSUM_SEED but accidentally forgot to advertise
it in gSupportedIncompatFeat. This made it (erroneously) impossible to
mount CSUM_SEED filesystems.
Detected by attempting to mount a relatively new mkfs.ext4'd filesystem.
Cc: Marvin Häuser
Signed-off-by: Pedro Falcato
---
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Pedro Falcato
> 发送时间: 2023年5月7日 11:51
> 收件人: Rebecca Cran
> 抄送: devel@edk2.groups.io; Liming Gao ; Bob
> Feng ; Yuwei Chen ; Andrew
> Fish ; Leif Lindholm ;
> Michael D Kinney
> 主题: Re: [edk2-devel] [PATCH 1/1] Remove bash
Improve the extent tree node validation by validating the number of
entries the node advertises against the theoretical max (derived from
the size of on-disk structs and the block size (or i_data, if inline
extents).
Previously, we did not validate the number of entries. This could be
exploited fo
We had added support for CSUM_SEED but accidentally forgot to advertise
it in gSupportedIncompatFeat. This made it (erroneously) impossible to
mount CSUM_SEED filesystems.
Detected by attempting to mount a relatively new mkfs.ext4'd filesystem.
Cc: Marvin Häuser
Signed-off-by: Pedro Falcato
---
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, May 9, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-
Hi @Ray Ni ( ray.ni@... ) , @Zhichao Gao ( zhichao.gao@... ) ,
Could you please help to review this change?
Thanks,
Simon
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104313): https://edk2.groups.io/g/devel/message/104313
Mute This T
All,
Can you check if the meeting time is ok for you?
It will be in this week:
* PDT Thursday 07:00
* Paris Thursday 16:00
* Shanghai Thursday 22:00
Thanks,
Ray
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, May 2, 2023 1:59 AM
> To: Oliver Smith-Denny ; Ard Biesheuvel
I would prefer next week as well.
Mike
> -Original Message-
> From: Oliver Smith-Denny
> Sent: Monday, May 8, 2023 7:03 PM
> To: Ni, Ray ; Kinney, Michael D
> ; Ard Biesheuvel ;
> devel@edk2.groups.io
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Sami Mujawar ;
> Michael Kubacki ; Sean Brogan
Fix some issues in BaseTools:
- When the Pip BaseTools are used, make sure PYTHONPATH is set.
- Fix Tests\TestTools.py so it works on Windows.
- Cleanup toolsetup.bat
Rebecca Cran (3):
BaseTools: Update toolsetup.bat to not use BASETOOLS_PYTHON_SOURCE
BaseTools: only print the environment onc
The BASETOOLS_PYTHON_SOURCE environment variable is only used temporarily to
set PYTHONPATH. Since it doesn't help improve clarity, remove it.
While here, make sure we set PYTHONPATH when we're using Pip BaseTools
so that build etc. can be found.
Signed-off-by: Rebecca Cran
---
BaseTools/toolse
Avoid printing %PATH% twice: move the printing of the environment down
to print_python_info.
Signed-off-by: Rebecca Cran
---
BaseTools/toolsetup.bat | 35 +---
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
index
I'd like this to go in for the edk2-stable202305 tag.
--
Rebecca Cran
On 5/8/23 18:53, gaoliming wrote:
Reviewed-by: Liming Gao
-邮件原件-
发件人: devel@edk2.groups.io 代表 Pedro Falcato
发送时间: 2023年5月7日 11:51
收件人: Rebecca Cran
抄送: devel@edk2.groups.io; Liming Gao ; Bob
Feng ; Yuwei Chen
Could someone from CryptoPkg add a "Reviewed-by" tag please?
I'd like this to go into the upcoming edk2-stable202305 release.
--
Rebecca Cran
On 5/5/23 07:43, Rebecca Cran wrote:
Since CLANG35 and CLANG38 toolchains have been deleted from
tools_def.template, delete the build flags for them f
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, May 8, 2023 10:52 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 1/6] Tool/Redfish-Profile-Simulator:
> Upda
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, May 8, 2023 10:52 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 2/6] Tool/Redfish-Profile-Simulator:
> Upda
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, May 8, 2023 10:52 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 3/6] Tool/Redfish-Profile-Simulator:
> Upda
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, May 8, 2023 10:52 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 4/6] Tool/Redfish-Profile-Simulator:
> Add
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, May 8, 2023 10:52 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 5/6] Tool/Redfish-Profile-Simulator:
> Add
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, May 8, 2023 10:52 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 6/6] Tool/Redfish-Profile-Simulator:
> Upda
On Fri, May 05, 2023 at 08:33:41AM -0600, Rebecca Cran wrote:
> Gerd,
>
>
> Does this series need rework following this discussion, or is it ready to
> merge?
I think we are good to go. The ASSERT suggested by Ard here ...
>
> > > So it would be better to ASSERT() on non-empty GOT, and ignore
[AMD Official Use Only - General]
Hi @Ray Ni,
Could you please help to review this patch set as the Hard Freeze is coming
soon?
Thanks
Abner
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Saturday, May 6, 2023 12:07 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul
On Sat, May 06, 2023 at 09:36:56AM +0530, Abdul Lateef Attar wrote:
> PR: https://github.com/tianocore/edk2/pull/4341
>
> V11: Delta changes
> Drop the OVMF implementation of MmSaveStateLib
Tested-by: Gerd Hoffmann
Acked-by: Gerd Hoffmann
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
[AMD Official Use Only - General]
Thanks, I will correct it before pushing it to edk2-platform.
Abner
> -Original Message-
> From: Oram, Isaac W
> Sent: Tuesday, May 9, 2023 5:19 AM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Nickle
> Wang ; Tinh N
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Monday, May 8, 2023 3:03 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner
> Subject: [PATCH v1 0/1] AMD/AmdMinBoardPkg: Implements Sp
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Friday, May 5, 2023 1:24 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Abdul Lateef Attar
> ; Nickle Wang ; Tinh Nguyen
>
> Subject: [edk2-platforms][PATCH] ManageabilityPkg/IpmiCommand
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Friday, May 5, 2023 1:24 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Abdul Lateef Attar
> ; Nickle Wang ; Tinh Nguyen
>
> Subject: [edk2-platforms][PATCH] ManageabilityPkg/IpmiCommand
80 matches
Mail list logo
