Re: [edk2-devel] [PATCH V2 2/5] RedfishPkg: Fix condition checking of error status

2023-05-04 Thread Nickle Wang via groups.io
Thanks for fixing this issue. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Minh Nguyen > Sent: Thursday, May 4, 2023 12:20 PM > To: devel@edk2.groups.io > Cc: patc...@amperecomputing.com; abner.ch...@amd.com; Nickle Wang > ; ig...@ami.com; n...@os.amperecomputi

[edk2-devel] [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm:add Ap Rendezvous check in PerformRemainingTasks.

2023-05-04 Thread Li, Zhihao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4424 In Relaxed-AP Sync Mode, BSP will not wait for all Aps arrive. However, PerformRemainingTasks() needs to wait all Aps arrive before calling SetMemMapAttributes and ConfigSmmCodeAccessCheck() when mSmmReadyToLock is true. In SetMemMapAttribut

回复: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug entry read error after it is found

2023-05-04 Thread gaoliming via groups.io
Ard: > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ard > Biesheuvel > 发送时间: 2023年4月28日 17:21 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: Michael Kubacki > 主题: Re: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug > entry read error after it is found > > On Fri, 28 Ap

[edk2-devel] 回复: [PATCH 1/2] MdePkg/IndustryStandard: Add SMBIOS anchor string & length defines.

2023-05-04 Thread gaoliming via groups.io
Giri: > -邮件原件- > 发件人: Giri Mudusuru > 发送时间: 2023年4月29日 2:53 > 收件人: devel@edk2.groups.io > 抄送: Giri Mudusuru ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Andrew Fish > 主题: [PATCH 1/2] MdePkg/IndustryStandard: Add SMBIOS anchor string & > length defines. > > REF: https://bugzilla.

[edk2-devel] 回复: [PATCH 2/2] ShellPkg/UefiShellDebug1CommandsLib: Replace hardcoded SMBIOS strings.

2023-05-04 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Giri Mudusuru > 发送时间: 2023年4月29日 2:53 > 收件人: devel@edk2.groups.io > 抄送: Giri Mudusuru ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Andrew Fish > 主题: [PATCH 2/2] ShellPkg/UefiShellDebug1CommandsLib: Replace > hardcoded SMBIOS strings. > >

Re: [edk2-devel] [PATCH V2 3/5] RedfishPkg: Create RestEx child on selected interface

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Minh, please check my comment inline, > -Original Message- > From: Minh Nguyen > Sent: Thursday, May 4, 2023 12:20 PM > To: devel@edk2.groups.io > Cc: patc...@amperecomputing.com; Chang, Abner > ; nick...@nvidia.com; ig...@ami.com; > n...@os.amperecom

回复: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v3 3/3] MdePkg/IndustryStandard: Add Interface Capabilities definitions

2023-05-04 Thread gaoliming via groups.io
Tinh: For the patch subject, I suggest to add IPMI key word to specify this change is for IPMI, such as MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Tinh Nguyen > via groups.io > 发送时间: 2023年5月3日 19:24 > 收件人:

Re: [edk2-devel] [PATCH v10 5/9] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Thursday, May 4, 2023 2:39 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ; Chang, Abner > ; Eric Dong ; Ray Ni > ; Rahul Kumar ; At

Re: [edk2-devel] [PATCH v10 7/9] UefiCpuPkg: Implements MmSaveStateLib for Ovmf

2023-05-04 Thread Gerd Hoffmann
On Thu, May 04, 2023 at 12:09:19PM +0530, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 > > Implements MmSaveStateLib library interfaces > to read and write save state > registers for Ovmf/Qemu. Not needed, ovmf can use AmdMmSav

[edk2-devel] purpose of EFI_LOCK

2023-05-04 Thread Laszlo Ersek
Hi, what benefit does EFI_LOCK add, over direct gBS->RaiseTPL() and gBS->RestoreTPL() calls? Considering just the two APIs EfiAcquireLock() and EfiReleaseLock(): - The "Lock" field (effectively, lock status field) is useless; it is only written to, never read (outside of ASSERT()s) - The "Owner

Re: [edk2-devel] [PATCH v3 1/3] OvmfPkg/Xen: export search of RSDP into a library function

2023-05-04 Thread Gerd Hoffmann
On Wed, May 03, 2023 at 09:32:03AM +0200, Corvin Köhne wrote: > Xen and bhyve are placing ACPI tables into system memory. So, they can > share the same code. Therefore, create a new library which searches and > installs ACPI tables from system memory. Series: Acked-by: Gerd Hoffmann -=-=-=-=-=

Re: [edk2-devel] [PATCH 1/1] ShellPkgDisconnect: zero-initialize handles

2023-05-04 Thread Gerd Hoffmann
Ping. Any comments on this? On Wed, Apr 26, 2023 at 01:39:27PM +0200, Gerd Hoffmann wrote: > In case ShellConvertStringToUint64() fails the Handles are left > uninitialized. That can for example happen for Handle2 and Handle3 in > case only one parameter was specified on the command line. Which

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: replace SECURE_BOOT_FEATURE_ENABLED with PcdSecureBootSupported

2023-05-04 Thread Gerd Hoffmann
Ping. On Fri, Apr 21, 2023 at 08:55:44AM +0200, Gerd Hoffmann wrote: > Drop the '-D SECURE_BOOT_FEATURE_ENABLED' compile time option, > use a new FeaturePcd instead. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/OvmfPkg.dec | 3 +++ > OvmfPkg/CloudHv/CloudHvX64.d

Re: [edk2-devel] [PATCH v5 00/10] BaseTools: remove duplicate includes.

2023-05-04 Thread Gerd Hoffmann
Ping. On Fri, Apr 21, 2023 at 06:45:25AM +0200, Gerd Hoffmann wrote: > There is alot of code duplication between BaseTools and MdePkg (and also > MdeModulePkg). This patch series starts reducing this by removing some > header files. BaseTools are switched over to use the include files in > MdePk

Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

2023-05-04 Thread Gerd Hoffmann
Ping. On Fri, Apr 14, 2023 at 10:33:21AM +0200, Oliver Steffen wrote: > ArmVirtXen.dsc allows setting the firmware version > string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > via FIRMWARE_VER variable conveniently on the build command line. > > These two patches add this behavio

Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 12:13, Gerd Hoffmann wrote: > > Ping. > I'll pick these up - thanks for the reminder. > On Fri, Apr 14, 2023 at 10:33:21AM +0200, Oliver Steffen wrote: > > ArmVirtXen.dsc allows setting the firmware version > > string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionStr

[edk2-devel] 回复: [PATCH v5 00/10] BaseTools: remove duplicate includes.

2023-05-04 Thread gaoliming via groups.io
Gerd: I have no other comments for this patch set. This change is great to reduce the duplication definitions. Reviewed-by: Liming Gao Besides, GCC49 tool chain doesn't define USING_LTO macro. If GCC49 is verified, it will be better. Thanks Liming > -邮件原件- > 发件人: Gerd Hoffmann

Re: [edk2-devel] [PATCH v5 00/10] BaseTools: remove duplicate includes.

2023-05-04 Thread Rebecca Cran
Sorry for the delay. For the series: Reviewed-by: Rebecca Cran On 5/4/23 04:11, Gerd Hoffmann wrote: Ping. On Fri, Apr 21, 2023 at 06:45:25AM +0200, Gerd Hoffmann wrote: There is alot of code duplication between BaseTools and MdePkg (and also MdeModulePkg). This patch series starts reduc

Re: [edk2-devel] [PATCH v6 00/16] BaseTools,CryptoPkg,EmulatorPkg,MdePkg,others: Delete CLANG35,CLANG38,VS2008-2013,EBC, deprecate GCC48,GCC49,GCC5, add GCC and GCCNOLTO, update CLANGDWARF

2023-05-04 Thread Rebecca Cran
I'd really like to get this merged: we're running out of time for the upcoming stable tag. I'm still waiting on reviews for the CryptoPkg, EmulatorPkg and IntelFsp2Pkg changes. -- Rebecca Cran On 5/1/23 10:08, Rebecca Cran wrote: Update the toolchain definitions: - Delete the CLANG35 and

Re: [edk2-devel] [RFC PATCH v1 06/30] ArmVirtPkg: Add Arm CCA Realm Service Interface Library

2023-05-04 Thread Sami Mujawar
On Tue, Apr 25, 2023 at 09:04 AM, Sami Mujawar wrote: > > +/** RSI interface Version > + See Section B4.4.3, RMM Specification, version A-bet0. > + The width of the RsiInterfaceVersion fieldset is 64 bits. > +*/ > +#define RSI_VER_MINOR_MASK 0x00FFULL > +#define RSI_VER_MAJOR_MASK 0x7F00ULL > +#d

[edk2-devel] [PATCH v2 1/4] OvmfPkg: add IndustryStandard/VirtioSerial.h

2023-05-04 Thread Gerd Hoffmann
Add header files with structs and defines for the virtio serial device. The virtio serial device also known as virtio console device because initially it had only support for a single tty, intended to be used as console. Support for multiple streams and named data ports has been added later on.

[edk2-devel] [PATCH v2 0/4] OvmfPkg: add virtio serial driver

2023-05-04 Thread Gerd Hoffmann
v2: - implement driver stop code paths. - misc fixes here and there. - rebase to latest master. Gerd Hoffmann (4): OvmfPkg: add IndustryStandard/VirtioSerial.h OvmfPkg/VirtioSerialDxe: add driver OvmfPkg/VirtioSerialDxe: wire up in OvmfPkg* OvmfPkg/PlatformBootManagerLib: setup virtio s

[edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioSerialDxe: add driver

2023-05-04 Thread Gerd Hoffmann
Add a driver for the virtio serial device. The virtio serial device also known as virtio console device because initially it had only support for a single tty, intended to be used as console. Support for multiple streams and named data ports has been added later on. The driver supports tty ports

[edk2-devel] [PATCH v2 3/4] OvmfPkg/VirtioSerialDxe: wire up in OvmfPkg*

2023-05-04 Thread Gerd Hoffmann
Add the driver to the ovmf builds. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 1 + OvmfPkg/OvmfPkgIa32.dsc| 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 1 + OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/Microvm/MicrovmX64.fdf | 1 + OvmfPkg/OvmfPkgIa32.fdf| 1 +

[edk2-devel] [PATCH v2 4/4] OvmfPkg/PlatformBootManagerLib: setup virtio serial console

2023-05-04 Thread Gerd Hoffmann
In case a virtio-serial device is present in the system register the first serial port as console. Signed-off-by: Gerd Hoffmann --- .../PlatformBootManagerLib/BdsPlatform.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPla

[edk2-devel] [PATCH 0/3] OvmfPkg: remove PlatformBootManagerLibGrub

2023-05-04 Thread Gerd Hoffmann
An attempt to reduce code duplication a bit. PlatformBootManagerLibGrub is an (outdated) copy of PlatformBootManagerLib with some policy changes. Add a PCD to enable this policy and add support for that to PlatformBootManagerLib, which in turn allows to remove PlatformBootManagerLibGrub. Gerd Ho

[edk2-devel] [PATCH 1/3] OvmfPkg/PlatformBootManagerLib: add PcdBootRestrictToFirmware

2023-05-04 Thread Gerd Hoffmann
Add new PCD PcdBootRestrictToFirmware. When set to TRUE restrict boot options to EFI applications embedded into the firmware image. Behavior should be identical to the PlatformBootManagerLibGrub library variant. Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfPkg.dec |

[edk2-devel] [PATCH 2/3] OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub

2023-05-04 Thread Gerd Hoffmann
Use PlatformBootManagerLib with PcdBootRestrictToFirmware set to TRUE instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.dsc | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc index 943c4eed98

[edk2-devel] [PATCH 3/3] OvmfPkg: drop PlatformBootManagerLibGrub

2023-05-04 Thread Gerd Hoffmann
Not used any more, remove. Signed-off-by: Gerd Hoffmann --- .../PlatformBootManagerLibGrub.inf| 73 - .../PlatformBootManagerLibGrub/BdsPlatform.h | 185 -- .../PlatformBootManagerLibGrub/BdsPlatform.c | 1604 - .../PlatformBootManagerLibGrub/PlatformData.c | 21

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, May 4, 2023 #cal-reminder

2023-05-04 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, May 4, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.

Re: [edk2-devel] [PATCH v2 1/1] ArmPkg/PlatformBootManagerLib: Add path to boot UEFI Shell over UiApp

2023-05-04 Thread Ard Biesheuvel
On Tue, 25 Apr 2023 at 13:27, wrote: > > From: Pierre Gondois > > The UEFI Shell is a non-active boot option, at the opposite of UiApp. > If no valid boot option is found, UiApp is selected. UiApp requires a > human interaction. When installing a new EDKII image in CIs or when > scripting is requ

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: replace SECURE_BOOT_FEATURE_ENABLED with PcdSecureBootSupported

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 12:09, Gerd Hoffmann wrote: > > Ping. > Queued up now - thanks. > On Fri, Apr 21, 2023 at 08:55:44AM +0200, Gerd Hoffmann wrote: > > Drop the '-D SECURE_BOOT_FEATURE_ENABLED' compile time option, > > use a new FeaturePcd instead. > > > > Signed-off-by: Gerd Hoffmann > > --

Re: [edk2-devel] [PATCH v2 0/4] OvmfPkg: add virtio serial driver

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 15:12, Gerd Hoffmann wrote: > > v2: > - implement driver stop code paths. > - misc fixes here and there. > - rebase to latest master. > > Gerd Hoffmann (4): > OvmfPkg: add IndustryStandard/VirtioSerial.h > OvmfPkg/VirtioSerialDxe: add driver > OvmfPkg/VirtioSerialDxe

[edk2-devel] Now: TianoCore edk2-test Bug Triage Meeting - Thursday, May 4, 2023 #cal-notice

2023-05-04 Thread Group Notification
*TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, May 4, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.com?subjec

Re: [edk2-devel] [PATCH 0/3] OvmfPkg: remove PlatformBootManagerLibGrub

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 15:33, Gerd Hoffmann wrote: > > An attempt to reduce code duplication a bit. PlatformBootManagerLibGrub > is an (outdated) copy of PlatformBootManagerLib with some policy > changes. Add a PCD to enable this policy and add support for that to > PlatformBootManagerLib, which

Re: [edk2-devel] [PATCH V2 3/5] RedfishPkg: Create RestEx child on selected interface

2023-05-04 Thread Minh Nguyen
Hi Abner,  Let me check in my system and will give the confirmation to you. Thanks, Minh Nguyen On 5/4/2023 3:00 PM, Chang, Abner wrote: [AMD Official Use Only - General] Hi Minh, please check my comment inline, -Original Message- From: Minh Nguyen Sent: Thursday, May 4, 2023 12:

Re: [edk2-devel] [PATCH 0/3] OvmfPkg: remove PlatformBootManagerLibGrub

2023-05-04 Thread Yao, Jiewen
We should remove duplication. Acked-by: Jiewen Yao > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, May 4, 2023 9:33 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Aktas, Erdem > ; Xu, Min M ; Tom > Lendacky ; Justen, Jordan L > ; Stefan Berger ; Julien > Grall ; Anthony

Re: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug entry read error after it is found

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 09:49, gaoliming via groups.io wrote: > > Ard: > > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Ard > > Biesheuvel > > 发送时间: 2023年4月28日 17:21 > > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > > 抄送: Michael Kubacki > > 主题: Re: [edk2-devel] [PATCH] MdePkg BasePeC

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub

2023-05-04 Thread James Bottomley
On Thu, 2023-05-04 at 15:32 +0200, Gerd Hoffmann wrote: > Use PlatformBootManagerLib with PcdBootRestrictToFirmware > set to TRUE instead. > > Signed-off-by: Gerd Hoffmann > --- >  OvmfPkg/AmdSev/AmdSevX64.dsc | 10 -- >  1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Ov

[edk2-devel] [edk2-redfish-client][PATCH 1/8] RedfishClientPkg: Facilities of EDK2 Redfish Feature driver Env.

2023-05-04 Thread Nickle Wang via groups.io
Initial common header file and meta files for feature drivers. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientPkg.dec | 5 +- .../Include/Guid/RedfishClientPkgTokenSpace.h | 20 +++ .../EdkIIRedfishResourceConfigProtocol.h | 12

[edk2-devel] [edk2-redfish-client][PATCH 2/8] RedfishClientPkg: Add EDKII ETag driver

2023-05-04 Thread Nickle Wang via groups.io
Implement EDKII ETag protocol to manipulate ETag of HTTP content. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishETagDxe/RedfishETagDxe.inf | 45 + .../Protocol/EdkIIRedfishETagProtocol.h | 76 ++ .../RedfishETagDxe/RedfishETagDxe.h |

[edk2-devel] [edk2-redfish-client][PATCH 3/8] RedfishClientPkg: Add EDKII ETag driver to build

2023-05-04 Thread Nickle Wang via groups.io
Add EDKII ETag driver to RedfishClientPkg build. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientPkg.dec| 2 ++ RedfishClientPkg/RedfishClientComponents.dsc.inc | 1 + RedfishClientPkg/RedfishClient.fdf.inc | 1 + 3 files

[edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe

2023-05-04 Thread Nickle Wang via groups.io
Action in StartupContext is not set properly. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishF

[edk2-devel] [PATCH 0/7] ArmCpuInfo improvements

2023-05-04 Thread Marcin Juszkiewicz
This changeset was supposed to add SVE/SME information but got some updates to improve output of ArmCpuInfo application a bit too. Probably would need to definition of system registers for older toolchains. Marcin Juszkiewicz (7): ArmPkg: fix reading of first nibbles in ArmCpuInfo ArmPkg: sho

[edk2-devel] [PATCH 1/7] ArmPkg: fix reading of first nibbles in ArmCpuInfo

2023-05-04 Thread Marcin Juszkiewicz
First nibbles of DFR0/ISAR1/ISAR2/MMRF2/PFR0 system registers were read in wrong way -- second one was used instead. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ArmPkg/Application/

[edk2-devel] [PATCH 2/7] ArmPkg: shorten register field in ArmCpuInfo

2023-05-04 Thread Marcin Juszkiewicz
It is hard to fit in 80 columns so let drop extra spaces and ID_AA64 prefix from system register names. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 36 +++--- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/ArmPkg/Application

[edk2-devel] [PATCH 3/7] ArmPkg: add functions to read SVE/SME info

2023-05-04 Thread Marcin Juszkiewicz
ID_AA64ZFR0_EL1 and ID_AA64SMFR0_EL1 system registers are needed for ArmCpuInfo application to show state of SVE/SME support. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Library/ArmLib/ArmBaseLib.inf | 5 + ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 12 ArmPkg/

[edk2-devel] [PATCH 5/7] ArmPkg: format output in one place in ArmCpuInfo

2023-05-04 Thread Marcin Juszkiewicz
Having two places with same formatting is error-prone. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c ind

[edk2-devel] [PATCH 4/7] ArmPkg: skip empty system registers in ArmCpuInfo

2023-05-04 Thread Marcin Juszkiewicz
If system register is empty (value == 0) then do not display information from it. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 35 +++--- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo

[edk2-devel] [PATCH 6/7] ArmPkg: handle SVE/SME in ArmCpuInfo

2023-05-04 Thread Marcin Juszkiewicz
If cpu supports SVE or SME then display information of supported features. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 344 + 1 file changed, 344 insertions(+) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Applicatio

[edk2-devel] [PATCH 7/7] ArmPkg: cleaning output of ArmCpuInfo

2023-05-04 Thread Marcin Juszkiewicz
There is no point of having double spaces. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Application/ArmCpuInfo/Arm

[edk2-devel] [edk2-redfish-client][PATCH 5/8] RedfishClientPkg: Add RedfishLib.h

2023-05-04 Thread Nickle Wang via groups.io
RedfishLib.h is the header file of RedfishLib library under RedfishClientPkg. RedfishLib is used by EDKII Redfish feature drivers. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../PrivateInclude/Library/RedfishLib.h | 616 ++ 1 file changed, 616 ins

[edk2-devel] [edk2-redfish-client][PATCH 6/8] RedfishClientPkg: Add Redfish Feature Utility library

2023-05-04 Thread Nickle Wang via groups.io
This is the helper library for EDKII Redfish feature drivers to manipulate Redfish properties. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientPkg.dec |3 + RedfishClientPkg/RedfishClientLibs.dsc.inc|3 + RedfishClientPkg/Re

[edk2-devel] [edk2-redfish-client][PATCH 8/8] RedfishClientPkg: Update RedfishCollectionCommon.h

2023-05-04 Thread Nickle Wang via groups.io
Update RedfishCollectionCommon.h header file. Remove the "Event" field from REDFISH_COLLECTION_PRIVATE because the feature driver is not started up by the EFI event that is registered by feature driver itself anymore. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishC

[edk2-devel] [edk2-redfish-client][PATCH 7/8] RedfishClientPkg: RedfishLib

2023-05-04 Thread Nickle Wang via groups.io
(This one is the same as RedfishLib under RedfishPkg. The one under RedfishPkg will be removed because RedfishLib is used by EDKII feature drivers which is belong to EDK2 Redfish client implementation) EDK2 port of DMTF libredfish project. We clone the necessary files from open source project libr

Re: [edk2-devel] [PATCH] ShellPkg: Add a condition to print accurate type0 Bios Size in smbiosview.

2023-05-04 Thread Nickle Wang via groups.io
Hi @Ray Ni, @Zhichao Gao, Could you please help to review this change? Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Thejaswani > Putta via groups.io > Sent: Friday, April 21, 2023 9:00 AM

[edk2-devel] [PATCH] MdePkg/BasePeCoffLib: Deal with broken debug directories

2023-05-04 Thread Ard Biesheuvel
Older versions of GenFw put the wrong value in the debug directory size field in the PE/COFF header: instead of putting the combined size of all the entries, it puts the size of the only entry it creates, but adds the size of the NB10 payload that the entry points to. This confuses the loader now t

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, May 4, 2023 #cal-reminder

2023-05-04 Thread Group Notification
*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, May 4, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join

[edk2-devel] Now: TianoCore Community Meeting EMEA/NAMO - Thursday, May 4, 2023 #cal-notice

2023-05-04 Thread Group Notification
*TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, May 4, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join on the we

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub

2023-05-04 Thread Gerd Hoffmann
On Thu, May 04, 2023 at 10:16:05AM -0400, James Bottomley wrote: > On Thu, 2023-05-04 at 15:32 +0200, Gerd Hoffmann wrote: > > Use PlatformBootManagerLib with PcdBootRestrictToFirmware > > set to TRUE instead. > > > > Signed-off-by: Gerd Hoffmann > > --- > >  OvmfPkg/AmdSev/AmdSevX64.dsc | 10 +++

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub

2023-05-04 Thread James Bottomley
On Thu, 2023-05-04 at 17:08 +0200, Gerd Hoffmann wrote: > On Thu, May 04, 2023 at 10:16:05AM -0400, James Bottomley wrote: > > On Thu, 2023-05-04 at 15:32 +0200, Gerd Hoffmann wrote: > > > Use PlatformBootManagerLib with PcdBootRestrictToFirmware > > > set to TRUE instead. > > > > > > Signed-off-b

Re: [edk2-devel] [RFC PATCH v1 00/30] Support for Arm CCA guest firmware

2023-05-04 Thread Jean-Philippe Brucker
Hello, On Tue, Apr 25, 2023 at 05:03:58PM +0100, Sami Mujawar wrote: > We are happy to announce an early RFC version of the Arm Confidential > Compute Architecture (CCA) support for the Kvmtool guest firmware. > The intention is to seek early feedback in the following areas: > * Integration of th

Re: [edk2-devel] [RFC PATCH v1 00/30] Support for Arm CCA guest firmware

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 17:13, Jean-Philippe Brucker wrote: > > Hello, > > On Tue, Apr 25, 2023 at 05:03:58PM +0100, Sami Mujawar wrote: > > We are happy to announce an early RFC version of the Arm Confidential > > Compute Architecture (CCA) support for the Kvmtool guest firmware. > > The intention

[edk2-devel] [PATCH v1] MinPlatformPkg: Update ACPI 6.5 definition

2023-05-04 Thread Chen, Aryeh
From: Aryeh Chen https://bugzilla.tianocore.org/show_bug.cgi?id=4442 Update ACPI 6.5 definition on MinPlatformPkg Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Cc: Jiewen Yao Signed-off-by: Aryeh Chen --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Acp

Re: [edk2-devel] OvmfPkg PlatformCI: Should iasl dependency be updated from 20190215.0.0 ?

2023-05-04 Thread Michael D Kinney
Sean, Can a GitHub release area for each dependency be used as an alternative to nuget? Mike From: devel@edk2.groups.io On Behalf Of Sean Sent: Wednesday, May 3, 2023 12:51 PM To: devel@edk2.groups.io; rebe...@bsdio.com; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; Gerd Hoffmann Cc: Se

Re: [edk2-devel] [PATCH v6 2/3] MdePkg: Support FDT library.

2023-05-04 Thread Michael D Kinney
Hi Benny, A couple comments below. Mike > -Original Message- > From: Lin, Benny > Sent: Wednesday, May 3, 2023 10:57 PM > To: devel@edk2.groups.io > Cc: Lin, Benny ; Kinney, Michael D > ; Gao, Liming ; Liu, > Zhiguang ; Pedro Falcato > > Subject: [PATCH v6 2/3] MdePkg: Support FDT libr

Re: [edk2-devel] [PATCH] Maintainers.txt: Update for IntelFsp2Pkg and IntelFsp2WrapperPkg.

2023-05-04 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2/commit/d992a05ade3d1bebc6e7a81aaf700286e0e217c8 Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Monday, April 24, 2023 11:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone,

[edk2-devel] [PATCH] UefiPayloadPkg: Use clearer debug flags with more flexibility

2023-05-04 Thread Benjamin Doron
The default behaviour is that RELEASE builds have all DebugLib macros removed by MDEPKG_NDEBUG. Currently, UefiPayloadPkg has been using USE_CBMEM_FOR_CONSOLE to disable this behaviour, but it's unclear that this option changes DEBUG build behaviour too. Therefore, add a new build flag, RELEASE_LO

Re: [edk2-devel] [PATCH v6 2/3] MdePkg: Support FDT library.

2023-05-04 Thread Chiu, Chasel
Hi Mike, Please see my reply below inline. Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Thursday, May 4, 2023 11:02 AM > To: Lin, Benny ; devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Pedro Falcato ; Kinney, > M

[edk2-devel] [PATCH v7 0/3] Support FDT library.

2023-05-04 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) and refer to LibcLib implementation by Pedro. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Cc: Mi

[edk2-devel] [PATCH v7 1/3] Tianocore: Support FDT library.

2023-05-04 Thread Chiu, Chasel
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) Add submodule libfdt and update ReadMe for the licence. Reviewed-by: Leif Lindholm Reviewed-by: Michael D

[edk2-devel] [PATCH v7 3/3] .pytool: Support FDT library.

2023-05-04 Thread Chiu, Chasel
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) Add RequiredSubmodule object for CI setting. Reviewed-by: Michael D Kinney Cc: Sean Brogan Cc: Michael K

[edk2-devel] [PATCH v7 2/3] MdePkg: Support FDT library.

2023-05-04 Thread Chiu, Chasel
From: Benny Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) and refer to LibcLib implementation by Pedro. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Acked

Re: [edk2-devel] [PATCH] Securitypkg/hddpassword: Update HddPasswordDxeInit to use Variable Policy

2023-05-04 Thread Yao, Jiewen
Sounds good. Thank you very much! Reviewed-by: Jiewen Yao > -Original Message- > From: Liu, Linus > Sent: Thursday, May 4, 2023 11:51 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: FST-FIR-PRC ; FST FIR Server > ; Chu, Maggie > Subject: RE: [PATCH] Securitypkg/hddpassword: Update Hd

Re: [edk2-devel] 回复: [edk2-devel] [PATCH] Support GLOBAL_REMOVE_IF_UNREFERENCED in GCC5/11

2023-05-04 Thread JoeX Lu
Hi Liming, For question1: We might declaim some variables/functions only used in DEBUG mode and those are necessary variables/functions for debugging but will trigger warning message in RELEASE build. For question2: Yes -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to

[edk2-devel] [PATCH v2 1/2] MdePkg/IndustryStandard: Add SMBIOS anchor string & length defines.

2023-05-04 Thread Giri Mudusuru via groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3805 Add SMBIOS spec defined anchor strings & length defines. - '_SM_' chapter 5.2.1 SMBIOS 2.1 (32-bit) Entry Point - '_SM3_' chapter 5.2.2 SMBIOS 3.0 (64-bit) Entry Point Changes from v1 to v2: - Replace non-ASCII characters Cc: Michael D

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Update ACPI 6.5 definition

2023-05-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Chen, Aryeh > Sent: Thursday, May 4, 2023 10:11 AM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric ; > Yao, Jiewen > Subject: [PA

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/8] RedfishClientPkg: Facilities of EDK2 Redfish Feature driver Env.

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, May 4, 2023 10:22 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 1/8] RedfishClientPkg: Facilities of EDK2

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/8] RedfishClientPkg: Add EDKII ETag driver

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, May 4, 2023 10:22 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 2/8] RedfishClientPkg: Add EDKII ETag > d

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/8] RedfishClientPkg: Add EDKII ETag driver to build

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, May 4, 2023 10:22 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 3/8] RedfishClientPkg: Add EDKII ETag > d

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, May 4, 2023 10:22 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on > Redfi

Re: [edk2-devel] [edk2-redfish-client][PATCH 5/8] RedfishClientPkg: Add RedfishLib.h

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, May 4, 2023 10:25 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 5/8] RedfishClientPkg: Add RedfishLib.h >

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/8] RedfishClientPkg: Facilities of EDK2 Redfish Feature driver Env.

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Correct email address Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Friday, May 5, 2023 8:55 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: Re

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/8] RedfishClientPkg: Add EDKII ETag driver

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Correct email address Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Friday, May 5, 2023 8:56 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: Re

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/8] RedfishClientPkg: Add EDKII ETag driver to build

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Correct email address Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Friday, May 5, 2023 8:56 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: Re

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Correct email address Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Friday, May 5, 2023 8:56 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: Re

Re: [edk2-devel] [edk2-redfish-client][PATCH 5/8] RedfishClientPkg: Add RedfishLib.h

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Correct email address Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Friday, May 5, 2023 8:56 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: Re

Re: [edk2-devel] [edk2-redfish-client][PATCH 6/8] RedfishClientPkg: Add Redfish Feature Utility library

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, May 4, 2023 10:26 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 6/8] RedfishClientPkg: Add Redfish > Feat

Re: [edk2-devel] [edk2-redfish-client][PATCH 7/8] RedfishClientPkg: RedfishLib

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, May 4, 2023 10:28 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 7/8] RedfishClientPkg: RedfishLib > > Ca

Re: [edk2-devel] [edk2-redfish-client][PATCH 8/8] RedfishClientPkg: Update RedfishCollectionCommon.h

2023-05-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, May 4, 2023 10:29 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 8/8] RedfishClientPkg: Update > RedfishCo

[edk2-devel] 回复: [PATCH v2 1/2] MdePkg/IndustryStandard: Add SMBIOS anchor string & length defines.

2023-05-04 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Giri Mudusuru > 发送时间: 2023年5月5日 8:17 > 收件人: devel@edk2.groups.io > 抄送: Giri Mudusuru ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Andrew Fish > 主题: [PATCH v2 1/2] MdePkg/IndustryStandard: Add SMBIOS anchor string & > length defines. > > R

[edk2-devel] [PATCH v1 1/2] MdeModulePkg: Add more PciHostBridgeLib gmock support

2023-05-04 Thread Guo, Gua
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4443 Add Google Mock Library for PciHostBridgeLib Cc: Michael D Kinney Cc: Hao A Wu Cc: Ray Ni Cc: Chris Johnson Signed-off-by: Gua Guo --- MdeModulePkg/MdeModulePkg.dec | 1 + MdeModulePkg/Test/MdeModulePk

[edk2-devel] [PATCH v1 2/2] MdePkg: Add more HobLib/PeiServicesLib gmock support

2023-05-04 Thread Guo, Gua
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4443 Add Google Mock Library for HobLib Add Google Mock Library for PeiServicesLib Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Chris Johnson Signed-off-by: Gua Guo --- MdePkg/Test/MdePkgHostTest.dsc

[edk2-devel] [PATCH v1 0/2] Add more google mock library

2023-05-04 Thread Guo, Gua
From: Gua Guo Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4443 PR: https://github.com/tianocore/edk2/pull/4335 V1: Add google mock support for HobLib Add google mock support for PciHostBridgeLib Add google mock support for PeiServicesLib Gua Guo (2): MdeModulePkg: Add more PciH

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Use clearer debug flags with more flexibility

2023-05-04 Thread Guo, Gua
Could you also create Edk2 PR ? -Original Message- From: Benjamin Doron Sent: Friday, May 5, 2023 6:36 AM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Use clearer debug flags with more flexibility The default

[edk2-devel] 回复: [PATCH] MdePkg/BasePeCoffLib: Deal with broken debug directories

2023-05-04 Thread gaoliming via groups.io
Reviewed-by: Liming Gao Tested-by: Liming Gao > -邮件原件- > 发件人: Ard Biesheuvel > 发送时间: 2023年5月4日 22:48 > 收件人: devel@edk2.groups.io > 抄送: gaolim...@byosoft.com.cn; michael.kuba...@microsoft.com; Ard > Biesheuvel > 主题: [PATCH] MdePkg/BasePeCoffLib: Deal with broken debug directories > > O

Re: [edk2-devel] [PATCH] MdePkg/BasePeCoffLib: Deal with broken debug directories

2023-05-04 Thread Michael Kubacki
Acked-by: Michael Kubacki On 5/4/2023 10:47 AM, Ard Biesheuvel wrote: Older versions of GenFw put the wrong value in the debug directory size field in the PE/COFF header: instead of putting the combined size of all the entries, it puts the size of the only entry it creates, but adds the size of

回复: [edk2-devel] [PATCH v6 08/16] Add GCC and GCCNOLTO toolchains to tools_def.txt and update packages

2023-05-04 Thread gaoliming via groups.io
Rebecca: I understand this change is to add GCC and GCCNOLTO toolchain. GCC is same to GCC5, GCCNOLTO is same to GCC49. So, new tool chain copies the same changes from origin one. Right? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2023年5月2日 22:23 > 收件人:

Re: [edk2-devel] [PATCH v6 08/16] Add GCC and GCCNOLTO toolchains to tools_def.txt and update packages

2023-05-04 Thread Yao, Jiewen
Thanks Liming. I am not sure below change is expected or not. Please feedback if possible. Thank you! > Why we add "-flto" for "NOLTO" ? >>> + *_GCCNOLTO_IA32_CC_FLAGS = -flto >>> + *_GCCNOLTO_IA32_DLINK_FLAGS = -flto > -Original Message- > From: gaoliming > Sent: Friday, May 5, 202

Re: 回复: [edk2-devel] [PATCH v6 08/16] Add GCC and GCCNOLTO toolchains to tools_def.txt and update packages

2023-05-04 Thread Rebecca Cran
Yes, that's correct. On 5/4/23 20:00, gaoliming wrote: Rebecca: I understand this change is to add GCC and GCCNOLTO toolchain. GCC is same to GCC5, GCCNOLTO is same to GCC49. So, new tool chain copies the same changes from origin one. Right? Thanks Liming -邮件原件- 发件人: devel@edk2.g

  1   2   >