[edk2-devel] [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib

2023-04-27 Thread JoeX Lu
CC: Jiewen Yao CC: Jian J Wang Signed-off-by: JoeX Lu --- .../HashLibBaseCryptoRouterPei.c| 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c b/SecurityPkg/Library/HashL

Re: [edk2-devel] [edk2-platforms][PATCH V3 0/5] Enable SoC expansion block and Virtio-P9 for RD-N2 variants

2023-04-27 Thread Sami Mujawar
Merged as 8758130fdbbb..0ed7b18b92e4 Thanks. Regards, Sami Mujawar On 24/03/2023 11:02 am, Vivek Gautam wrote: Arm reference design Fixed Virtual Platforms (FVPs) such as the RD-N2 platform variants have multiple IO virtualization blocks that allow connecting PCIe root bus or non-PCIe SoC per

Re: [edk2-devel] [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib

2023-04-27 Thread Yao, Jiewen
Hi I am not sure if I can understand the patch. Would you please clarify what the problem is in the original code? > -Original Message- > From: Lu, Pen-ChunX > Sent: Thursday, April 27, 2023 2:59 PM > To: devel@edk2.groups.io > Cc: Lu, Pen-ChunX ; Yao, Jiewen > ; Wang, Jian J > Subject:

Re: [edk2-devel] [PATCH v1] Securitypkg/hddpassword: Update HddPasswordDxeInit to use Variable Policy

2023-04-27 Thread Linus Liu
Hi Jiewen Could you help to review the patch ? Thanks -Original Message- From: Liu, Linus Sent: Wednesday, April 19, 2023 11:21 AM To: devel@edk2.groups.io; Liu, Linus Cc: Yao, Jiewen ; Chu, Maggie ; Zhang, Qi ; Kumar, Rahul R Subject: RE: [edk2-devel] [PATCH v1] Securitypkg/hddpassw

Re: [edk2-devel] [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib

2023-04-27 Thread JoeX Lu
Hi, It means the code might be possible return local variable address when we used the function. So I allocate a resource to local variable to avoid this. Best Regards, Joe Lu -Original Message- From: Yao, Jiewen Sent: Thursday, April 27, 2023 3:51 PM To: Lu, Pen-ChunX ; devel@edk2.g

Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Add AUTH_SIG_NOT_FOUND Action

2023-04-27 Thread Yao, Jiewen
Thanks Nhi, to provide the fix. The UEFI specification (https://uefi.org/specs/UEFI/2.10/32_Secure_Boot_and_Driver_Signing.html) defines below error code. #define EFI_IMAGE_EXECUTION_AUTH_SIG_FAILED 0x0001 #define EFI_IMAGE_EXECUTION_AUTH_SIG_PASSED 0x0002 #define EFI_IMAGE_EXEC

Re: [edk2-devel] [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib

2023-04-27 Thread Yao, Jiewen
Could you please show me how this function returns *local variable*? return BuildGuidDataHob (&mHashLibPeiRouterGuid, &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); I don't understand the analysis. > -Original Message- > From: Lu, Pen-ChunX > Sent: Thursday, April 27, 2023

Re: [edk2-devel] [PATCH v1] Securitypkg/hddpassword: Update HddPasswordDxeInit to use Variable Policy

2023-04-27 Thread Yao, Jiewen
This patch is unreadable to me. Would you please regenerate it with right format? > -Original Message- > From: Liu, Linus > Sent: Thursday, April 27, 2023 3:57 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chu, Maggie > ; Kumar, Rahul R > Subject: RE: [edk2-devel] [PATCH v1] Securit

Re: [edk2-devel] [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib

2023-04-27 Thread Yao, Jiewen
This seems false alarm to me. Unless you can prove there is real issue, I don't think this is right patch. Nacked-by: Jiewen Yao > -Original Message- > From: Lu, Pen-ChunX > Sent: Thursday, April 27, 2023 4:55 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: R

Re: [edk2-devel] [PATCH v2 edk2-platforms] Platform/ARM: Add build docs for Arm plats FVP and Juno

2023-04-27 Thread Sami Mujawar
Hi Jose, Thank you for this patch. I have some minor updates that I will do before merging. These include a note to indicate that the same FVP firmware binary can be used for both FVP Base AEMvA-AEMvA and FVP Base RevC models. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 08/03/2023

Re: [edk2-devel] [PATCH v2 edk2-platforms] Platform/ARM: Add build docs for Arm plats FVP and Juno

2023-04-27 Thread Sami Mujawar
Merged as  0ed7b18b92e4..24d22fe163c4 Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103711): https://edk2.groups.io/g/devel/message/103711 Mute This Topic: https://groups.io/mt/97470584/21656 Group Owner: d

[edk2-devel] [PATCH v2 1/1] MdeModulePkg/RegularExpressionDxe: Fix Arm build error

2023-04-27 Thread Nickle Wang via groups.io
Arm CI build error: - ArmPkg/Library/CompilerIntrinsicsLib/memset.c:39:1: warning: type of ‘memset’ does not match original declaration [-Wlto-type-mismatch] MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c:123:1: note: type ‘char’ should match type ‘int’ - multiple definition of `me

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/RegularExpressionDxe: Fix Arm build error

2023-04-27 Thread Nickle Wang via groups.io
Hi @Liming Gao, I send out version 2 patch for review. Could you please help me to review this? https://edk2.groups.io/g/devel/message/103712 The pull request is here: https://github.com/tianocore/edk2/pull/4298 Thanks, Nickle From: devel@edk2.groups.io On B

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Revert "Platform/Sgi: Fix missing FdtLib instance issue"

2023-04-27 Thread Sami Mujawar
Merged as 24d22fe163c4..64b06a4d19ad Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103714): https://edk2.groups.io/g/devel/message/103714 Mute This Topic: https://groups.io/mt/96197163/21656 Group Owner:

Re: [edk2-devel] [PATCH 1/2] SecurityPkg: add TIS sanity check (tpm2)

2023-04-27 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, April 27, 2023 12:24 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Pawel Polawski > ; Oliver Steffen ; Yao, > Jiewen ; Gerd Hoffmann > Subject: [edk2-devel] [PAT

Re: [edk2-devel] [PATCH 2/2] SecurityPkg: add TIS sanity check (tpm12)

2023-04-27 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, April 27, 2023 12:24 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Pawel Polawski > ; Oliver Steffen ; Yao, > Jiewen ; Gerd Hoffmann > Subject: [PATCH 2/2] SecurityPkg: add TIS sanity check (tpm12)

Re: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug entry read error after it is found

2023-04-27 Thread Ard Biesheuvel
On Thu, 27 Apr 2023 at 07:17, gaoliming via groups.io wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4425 > > This change is to support the pre-built EFI image on the old Edk2 code. > Old Edk2 GenFw tool generates the wrong debug entry in EFI image. > Those pre-built images can be l

[edk2-devel] [PATCH] BaseSynchronizationLib: Fix LoongArch64 synchronization functions

2023-04-27 Thread Dongyan Qian
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4432 The sc.w/sc.d instruction will destroy the reg_t0 Use reg_t1 to avoid context reg_t0 being corrupted. Optimize function SyncIncrement and SyncDecrement. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Chao Li Signed-off-by: Don

Re: [edk2-devel] [PATCH v4 1/1] MdePkg/BaseRngLib: Add a smoketest for RDRAND and check CPUID

2023-04-27 Thread Pedro Falcato
On Wed, Apr 26, 2023 at 10:54 PM Benjamin Doron wrote: > > Hi, > Is there merit to removing the assert statement? When this instance of the > RngLib class is used, the platform builder says there's RNG support. Asserts > are a little easier to see than debug prints, especially when they stall th

[edk2-devel] [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true

2023-04-27 Thread paytonx . hsieh
From: PaytonX Hsieh REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4427 1. Since UART speed is slower than CPU, BIOS need to check the write buffer is empty, to avoid overwrite the buffer content. 2. LPSS UART might disable MMIO space for Windows debug usage during ExitBootServices ev

Re: [edk2-devel] [PATCH] Maintainers.txt: Update for IntelFsp2Pkg and IntelFsp2WrapperPkg.

2023-04-27 Thread Mohapatra, Susovan
Reviewed-by: Mohapatra, Susovan mailto:susovan.mohapa...@intel.com>> From: S, Ashraf Ali Sent: Tuesday, April 25, 2023 12:22 AM To: Chiu, Chasel ; devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Duggapu, Chinni B ; Ng, Ray Han Lim ; Chen, Gang C ; Zeng, Star ; Kuo, Ted ; Moha

[edk2-devel] [edk2-docs] edk2-docs.gitbook.io offline

2023-04-27 Thread jolly_thompson
edk2-docs.gitbook.io seems to be offline. Stating "This space has been deleted" -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103722): https://edk2.groups.io/g/devel/message/103722 Mute This Topic: https://groups.io/mt/98539178/21656 Gro

Re: [edk2-devel] [edk2-docs] edk2-docs.gitbook.io offline

2023-04-27 Thread Michael D Kinney
Hello, All docs were migrated to github tianocore-docs organization about 3 years ago. https://github.com/tianocore-docs The following 2 wiki page has links to all the documents https://tianocore-docs.github.io/ https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Draft-Specification T

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true

2023-04-27 Thread Benjamin Doron
Hi, Can you deduplicate this code by moving the functions into a common, or "base" file, and DXE's constructor and event into a separate file? As I see it, it should be alright to reuse DXE's functions for other phases, the ` mBaseSerialPortLibHobAtRuntime` variable will never be changed in this

Re: [edk2-devel] [PATCH v5 00/13] BaseTools,CryptoPkg,EmulatorPkg,MdePkg,others: Delete CLANG35,CLANG38,VS2008-2013,EBC, deprecate GCC48,GCC49,GCC5, add GCC and GCCNOLTO, update CLANGDWARF

2023-04-27 Thread Michael D Kinney
Hi Rebecca, There is an issue in the updates to build.py. If -t is provided in the build command line, it works. If -t is not provided and the tools chain tag is parsed from Conf/target.txt, then python gets a stack trace. Traceback (most recent call last): File "/home/mdkinney/GitHub/tia

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix issues when MULTIPLE_DEBUG_PORT_SUPPORT is true

2023-04-27 Thread Guo, Gua
Hi Payton For BaseSerialPortLibHob.inf please use BaseSerialPortLibHob.c For DxeSerialPortLibHob.inf please use BaseSerialPortLibHob.c and DxeSerialPortLibHob.c and remove redundant code. Have any limitation, please share for us. Thanks, Gua From: devel@edk2.groups.io On Behalf Of Benjamin Do

Re: [edk2-devel] [PATCH] BaseSynchronizationLib: Fix LoongArch64 synchronization functions

2023-04-27 Thread Chao Li
Reviewed-by: Chao Li Thanks, Chao 在 2023/4/27 22:51, Dongyan Qian 写道: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4432 The sc.w/sc.d instruction will destroy the reg_t0 Use reg_t1 to avoid context reg_t0 being corrupted. Optimize function SyncIncrement and SyncDecrement. Cc: Michael D

Re: [edk2-devel] [PATCH v5 00/13] BaseTools,CryptoPkg,EmulatorPkg,MdePkg,others: Delete CLANG35,CLANG38,VS2008-2013,EBC, deprecate GCC48,GCC49,GCC5, add GCC and GCCNOLTO, update CLANGDWARF

2023-04-27 Thread Rebecca Cran
Thanks, I've fixed the code to use MyBuild.ToolChainList where we know MyBuild isn't None instead. Have you made any progress with the CLANGDWARF issue where a command wasn't being run due to missing quotes (i.e. C:\Program)? -- Rebecca Cran On 4/27/23 13:56, Kinney, Michael D wrote: Hi

[edk2-devel] [PATCH] Support GLOBAL_REMOVE_IF_UNREFERENCED in GCC5/11

2023-04-27 Thread JoeX Lu
CC: Michael D Kinney CC: Liming Gao CC: Zhiguang Liu Signed-off-by: JoeX Lu --- MdePkg/Include/Base.h | 4 1 file changed, 4 insertions(+) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 6597e441a6..951fce43ee 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.

[edk2-devel] [PATCH v1] Securitypkg/hddpassword: Update HddPasswordDxeInit to use Variable Policy

2023-04-27 Thread Linus Liu
From: Linus Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4408 Cc: Jiewen Yao Cc: Maggie Chu Cc: Kumar Rahul Signed-off-by: Linus Liu --- SecurityPkg/HddPassword/HddPasswordDxe.c | 20 +--- SecurityPkg/HddPassword/HddPasswordDxe.h | 1 - SecurityPkg/HddPa

[edk2-devel] [PATCH v3] MinPlatformPkg: Update HWSignature filed in FADT

2023-04-27 Thread VincentX Ke
From: VincentX Ke REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428 Calculating CRC based on checksum from all ACPI tables. Update HWSignature filed in FADT based on CRC while ACPI table changed. Signed-off-by: VincentX Ke Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming G

Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Add AUTH_SIG_NOT_FOUND Action

2023-04-27 Thread Nhi Pham via groups.io
Thanks Yao Jiewen for reviewing. I will make further investigation for other cases based on your findings. In the meantime, could you help merge my patch? -Nhi On 4/27/2023 3:19 PM, Yao, Jiewen wrote: Thanks Nhi, to provide the fix. The UEFI specification (https://uefi.org/specs/UEFI/2.10/3

Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Update HWSignature filed in FADT

2023-04-27 Thread Ni, Ray
Vincent, It's an interesting patch. The original logic is to use the HardwareSignature field to indicate any changes in adding/removing PCI devices. Your new logic is to expand this field to indicate any changes in any tables when FADT version is > 6.3. Why? > -Original Message- > Fro

Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Update HWSignature filed in FADT

2023-04-27 Thread VincentX Ke
Hi, Ray Based on ACPI Spec 6.5, "Hardware Signature" filed changed the description. Here is the new description. "The only thing that determines the hardware signature is the ACPI tables. If any content or structure of the ACPI tables has changed, including adding or removing of tables, then th

[edk2-devel] [PATCH v4] MinPlatformPkg: Update HWSignature filed in FADT

2023-04-27 Thread VincentX Ke
From: VincentX Ke REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428 Calculating CRC based on checksum from all ACPI tables. Update HWSignature filed in FADT based on CRC while ACPI table changed. Signed-off-by: VincentX Ke Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming G

Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Update HWSignature filed in FADT

2023-04-27 Thread VincentX Ke
Dear All, Patch v4 updated. Please let me know if there is any suggestion. Thanks [PATCH v4] https://edk2.groups.io/g/devel/message/103738 BR, Vincent -Original Message- From: Ke, VincentX Sent: Friday, April 28, 2023 11:30 AM To: Ni, Ray ; devel@edk2.groups.io Cc: Chiu, Chasel ; Desimon

Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Update HWSignature filed in FADT

2023-04-27 Thread Ni, Ray
RSDP points to RSDT or XSDT. RSDT/XSDT contains multiple tables, one of which is FADT, others are SSDTs. FADT contains two pointers, one pointing to FACS, the other pointing to DSDT. So: 1. Your code assume if Table->Checksum is not changed, the Table is not changed. I don't think it's a valid as

[edk2-devel] [PATCH 0/2] Add IPMI SSIF definitions

2023-04-27 Thread Tinh Nguyen via groups.io
The first of a series of patches for IPMI SSIF support. Tinh Nguyen (2): MdePkg/IndustryStandard: Adds definitions for IPMI SSIF MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions MdePkg/MdePkg.dec | 26 ++ MdePkg/Include/IndustryStandard/IpmiNetFnA

[edk2-devel] [PATCH 1/2] MdePkg/IndustryStandard: Adds definitions for IPMI SSIF

2023-04-27 Thread Tinh Nguyen via groups.io
Specification reference: https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html Signed-off-by: Tinh Nguyen --- MdePkg/MdePkg.dec | 26 ++ MdePkg/Include/IndustryStandard/IpmiSsif.h | 98 2

[edk2-devel] [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions

2023-04-27 Thread Tinh Nguyen via groups.io
This adds more definitions for the IPMI Get System Interface Capabilities command. Signed-off-by: Tinh Nguyen --- MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 31 1 file changed, 31 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h b/MdePkg/Incl

[edk2-devel] [PATCH] BaseSynchronizationLib: Fix LoongArch64 synchronization functions

2023-04-27 Thread Dongyan Qian
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4432 There is a return value bug: The sc.w/sc.d instruction will destroy the reg_t0, use reg_t1 to avoid context reg_t0 being corrupted. Adjust Check that ptr align is UINT16. Optimize function SyncIncrement and SyncDecrement. Cc: Michael D Kinn

[edk2-devel] [PATCH v2] BaseSynchronizationLib: Fix LoongArch64 synchronization functions

2023-04-27 Thread Dongyan Qian
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4432 There is a return value bug: The sc.w/sc.d instruction will destroy the reg_t0, use reg_t1 to avoid context reg_t0 being corrupted. Adjust Check that ptr align is UINT16. Optimize function SyncIncrement and SyncDecrement. Cc: Michael D Kinn

Re: [edk2-devel] [PATCH v2] BaseSynchronizationLib: Fix LoongArch64 synchronization functions

2023-04-27 Thread Chao Li
Reviewed-by: Chao Li Thanks, Chao 在 2023/4/28 12:20, Dongyan Qian 写道: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4432 There is a return value bug: The sc.w/sc.d instruction will destroy the reg_t0, use reg_t1 to avoid context reg_t0 being corrupted. Adjust Check that ptr align is UINT

Re: [edk2-devel] [PATCH] Support GLOBAL_REMOVE_IF_UNREFERENCED in GCC5/11

2023-04-27 Thread Pedro Falcato
On Fri, Apr 28, 2023 at 3:47 AM JoeX Lu wrote: > > CC: Michael D Kinney > CC: Liming Gao > CC: Zhiguang Liu > Signed-off-by: JoeX Lu > --- > MdePkg/Include/Base.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h > index 6597e441a6..951

Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Update HWSignature filed in FADT

2023-04-27 Thread Ni, Ray
"Measure" checksum is not sufficient to detect ACPI table change because if one field in the table is changed from value x to x+1, and another field is changed from y to y-1, the Checksum doesn't change. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Fri

Re: [edk2-devel] [PATCH v1] Securitypkg/hddpassword: Update HddPasswordDxeInit to use Variable Policy

2023-04-27 Thread Linus Liu
Hi Jiewen and Rahul R Please help to review the patch. Thanks -Original Message- From: Liu, Linus Sent: Friday, April 28, 2023 10:56 AM To: devel@edk2.groups.io Cc: Liu, Linus ; Yao, Jiewen ; Chu, Maggie ; Kumar, Rahul R Subject: [PATCH v1] Securitypkg/hddpassword: Update HddPasswordD

回复: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/RegularExpressionDxe: Fix Arm build error

2023-04-27 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Nickle Wang > via groups.io > 发送时间: 2023年4月27日 18:18 > 收件人: devel@edk2.groups.io > 抄送: Jian J Wang ; Liming Gao > ; Michael D Kinney > ; Nick Ramirez > 主题: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/RegularExpressionDxe: Fix

[edk2-devel] 回复: [PATCH 1/2] MdePkg/IndustryStandard: Adds definitions for IPMI SSIF

2023-04-27 Thread gaoliming via groups.io
Tinh: I suggest to separate this patch. The header file follows the industry standard. New PCDs in DEC are for EDK2 implementation. They are different changes. Please separate them. Thanks Liming > -邮件原件- > 发件人: Tinh Nguyen > 发送时间: 2023年4月28日 12:00 > 收件人: devel@edk2.groups.io > 抄送: pat

[edk2-devel] 回复: [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions

2023-04-27 Thread gaoliming via groups.io
Tinh: Please use the specific word in the subject. For example, add Capabilities definitions. > -邮件原件- > 发件人: Tinh Nguyen > 发送时间: 2023年4月28日 12:00 > 收件人: devel@edk2.groups.io > 抄送: patc...@amperecomputing.com; michael.d.kin...@intel.com; > gaolim...@byosoft.com.cn; zhiguang@intel.co

Re: [edk2-devel] [PATCH] Support GLOBAL_REMOVE_IF_UNREFERENCED in GCC5/11

2023-04-27 Thread JoeX Lu
Hi Pedro, Thanks for your comment. I hope this attribute can silent Wunused in GCC build. Because it will be nice to declaim GLOBAL_REMOVE_IF_UNREFERENCED before unusd variable than #ifdef example1: #ifdef (UNUSED_CONDITION) static Boolean samplvariable; // which will be triggered the Wunused

回复: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug entry read error after it is found

2023-04-27 Thread gaoliming via groups.io
Ard: > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ard > Biesheuvel > 发送时间: 2023年4月27日 22:47 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: Michael Kubacki > 主题: Re: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug > entry read error after it is found > > On Thu, 27 Ap

[edk2-devel] [PATCH v3 1/5] UefiCpuPkg/ResetVector: Rename macros about page table.

2023-04-27 Thread Zhiguang Liu
This patch only renames macro, with no code logic impacted. Two purpose to rename macro: 1. Align some macro name in PageTables1G.asm and PageTables2M.asm, so that these two files can be easily combined later. 2. Some Macro names such as PDP are not accurate, since 4 level page entry also uses this

[edk2-devel] [PATCH v3 2/5] UefiCpuPkg/ResetVector: Simplify page table creation in ResetVector

2023-04-27 Thread Zhiguang Liu
Currently, page table creation has many hard-code values about the offset to the start of page table. To simplify it, add Labels such as Pml4, Pdp and Pd, so that we can remove many hard-code values Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Debkumar De Cc: Catharine West

[edk2-devel] [PATCH v3 3/5] UefiCpuPkg/ResetVector: Combine PageTables1G.asm and PageTables2M.asm

2023-04-27 Thread Zhiguang Liu
Combine PageTables1G.asm and PageTables2M.asm to reuse code. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Debkumar De Cc: Catharine West Signed-off-by: Zhiguang Liu --- UefiCpuPkg/ResetVector/Vtf0/Vtf0.nasmb| 8 +-- .../X64/{PageTables1G.asm => PageTables.asm} |

[edk2-devel] [PATCH v3 5/5] UefiCpuPkg/ResetVector: Support 5 level page table in ResetVector

2023-04-27 Thread Zhiguang Liu
Add a macro USE_5_LEVEL_PAGE_TABLE to determine whether to create 5 level page table. If macro USE_5_LEVEL_PAGE_TABLE is defined, PML5Table is created at (4G-12K), while PML4Table is at (4G-16K). In runtime check, if 5level paging is supported, use PML5Table, otherwise, use PML4Table. If macro USE_

[edk2-devel] [PATCH v3 4/5] UefiCpuPkg/ResetVector: Modify Page Table in ResetVector

2023-04-27 Thread Zhiguang Liu
In ResetVector, if create page table, its highest address is fixed because after page table, code layout is fixed(4K for normal code, and another 4K only contains reset vector code). Today's implementation organizes the page table as following if 1G page table is used: 4G-16K: PML4 page (PML4[0]