Re: [edk2-devel] [edk2-platforms][PATCH V3 01/14] ManageabilityPkg: Add more helper functions

[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: 21 April 2023 10:53 To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang ; Igor Kulchytskyy Subject: [edk2-platforms][PATCH V3 01/14] Man

Re: [edk2-devel] [edk2-platforms][PATCH V3 03/14] ManageabilityPkg: Add HeaderSize and TrailerSize

[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: 21 April 2023 10:53 To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang ; Igor Kulchytskyy Subject: [edk2-platforms][PATCH V3 03/14] Ma

Re: [edk2-devel] [edk2-platforms][PATCH V3 04/14] ManageabilityPkg: Add PldmProtocolLib

[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: 21 April 2023 10:53 To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang ; Igor Kulchytskyy Subject: [edk2-platforms][PATCH V3 04/14] Ma

[edk2-devel] [PATCH] ShellPkg: Add a condition to print accurate type0 Bios Size in smbiosview.

As per the SMBIOS spec, in smbios type0 table, if the Bios size is greater than 16MB, extended bios size is used to update size information and bios size is set to 0xff. when this data is printed by smbiosview, both bios size and extended bios size is printed if the smbios version is beyond 3.1, wh

[edk2-devel] [PATCH] BaseTools/Plugin: Report error if code coverage failure

From: Gua Guo If code coverage exist failure, CI/CD need to catch it Cc: Michael D Kinney Cc: Sean Brogan Cc: Michael Kubacki Signed-off-by: Gua Guo --- .../HostBasedUnitTestRunner/HostBasedUnitTestRunner.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Bas

[edk2-devel] [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure

From: Gua Guo If code coverage exist failure, CI/CD need to catch it Cc: Michael D Kinney Cc: Sean Brogan Cc: Michael Kubacki Signed-off-by: Gua Guo --- .../HostBasedUnitTestRunner/HostBasedUnitTestRunner.py| 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Bas

[edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool

From: Gua Guo Azure should install code coverage tool (lcov), it didn't exist on Fedora and Ubuntu by default. Cc: Michael D Kinney Cc: Sean Brogan Cc: Michael Kubacki Cc: Oliver Steffen Signed-off-by: Gua Guo --- .azurepipelines/Ubuntu-GCC5.yml | 4 1 file changed, 4 insertions(+) d

Re: [edk2-devel] [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure

Reviewed-by: Michael D Kinney > -Original Message- > From: Guo, Gua > Sent: Saturday, April 22, 2023 6:22 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Kinney, Michael D > ; Sean Brogan ; > Michael Kubacki > Subject: [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage > f

Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool

Reviewed-by: Michael D Kinney > -Original Message- > From: Guo, Gua > Sent: Saturday, April 22, 2023 6:22 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Kinney, Michael D > ; Sean Brogan ; > Michael Kubacki ; Oliver Steffen > > Subject: [PATCH v2 2/2] .azurepipelines: Install code cov

Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool

Sorry a little late to review this. It looks like these are container based builds. If that is the case we should handle this by updating the container. The whole point of the container is to get the requirements all included in the container. @Chris Fernald can yo