[edk2-devel] [Patch V1 2/3] BaseTools: FMMT replace output file is not generated successfully

2023-04-18 Thread Yuwei Chen
For replace function, when target Ffs and new ffs are with same size, the output file can not be generated successfully. This patch fixes this issue. Cc: Rebecca Cran Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yuwei Chen --- BaseTools/Source/Python/FMMT/core/BiosTree.py | 4 ++-- BaseTools/

[edk2-devel] [Patch V1 3/3] BaseTools: FMMT support ELF UPLD parser

2023-04-18 Thread Yuwei Chen
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103156): https://edk2.groups.io/g/devel/message/103156 Mute This Topic: https://groups.io/mt/98340352/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/deve

[edk2-devel] [Patch V1 3/3] BaseTools: FMMT support ELF UPLD parser

2023-04-18 Thread Yuwei Chen
FMMT add new function to support the .elf file parsing. Using '-v' option, the UPLD info will be printed out. ''' - UNIVERSAL_PAYLOAD_INFO - 4 bytes align (BOOLEAN) - Identifier - SpecRevision - Attribute - Revision - Capability - ProducerId - ImageId UPLD Buffer '''

Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table

2023-04-18 Thread duntan
Hi Tom, I added a new patch in my code branch. This new patch removes the code that may apply AddressEncMask to smm page table non-leaf entries when splitting page table. Could you please help test if this code branch works? https://github.com/td36/edk2/tree/SmmPageTable_V2 Thanks, Dun -O

Re: [edk2-devel] [Patch V1 1/3] BaseTools: fixing FMMT ShrinkFv issue

2023-04-18 Thread Yuwei Chen
For edk2-basetools repo, have made a PR for these three patches: https://github.com/tianocore/edk2-basetools/pull/95 Thanks, Christine (Yuwei) > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yuwei > Chen > Sent: Tuesday, April 18, 2023 5:53 PM > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-04-18 Thread Gerd Hoffmann
Hi, > > Underlying problem is that x64 ProcessorBind.h sets visibility to > > hidden (anyone knows why?). > > Yes. Toolchains tend to assume that you are generating code for a > shared library once you enabled -fpic, and this results in lots of > pointless indirections via the GOT. (This has to

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-04-18 Thread Ard Biesheuvel
On Tue, 18 Apr 2023 at 13:52, Gerd Hoffmann wrote: > > Hi, > > > > Underlying problem is that x64 ProcessorBind.h sets visibility to > > > hidden (anyone knows why?). > > > > Yes. Toolchains tend to assume that you are generating code for a > > shared library once you enabled -fpic, and this res

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-04-18 Thread Gerd Hoffmann
On Tue, Apr 18, 2023 at 01:59:43PM +0200, Ard Biesheuvel wrote: > On Tue, 18 Apr 2023 at 13:52, Gerd Hoffmann wrote: > > > > Seems to work fine on fedora 37, even without adding --relax, maybe this > > is enabled by default (there is a --no-relax switch after all). I'll go > > try older distros /

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: Reduce System Memory Size for FVP with RME extensions

2023-04-18 Thread Leif Lindholm
Hi Sami, On Mon, Apr 17, 2023 at 14:22:49 +0100, Sami Mujawar wrote: > For older FVPs (without support for RME extension) the top 16MB of > DRAM1 is reserved as Trusted DRAM. However, the latest FVP Base RevC > AEM Model [1] has support for RME extension. When RME extension is > present the top 64

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-04-18 Thread Marvin Häuser
> On 18. Apr 2023, at 15:20, Gerd Hoffmann wrote: > > On Tue, Apr 18, 2023 at 01:59:43PM +0200, Ard Biesheuvel wrote: >> On Tue, 18 Apr 2023 at 13:52, Gerd Hoffmann wrote: >>> >>> Seems to work fine on fedora 37, even without adding --relax, maybe this >>> is enabled by default (there is a --

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: Reduce System Memory Size for FVP with RME extensions

2023-04-18 Thread PierreGondois
Hi Sami, Tested-by: Pierre Gondois On 4/17/23 15:22, Sami Mujawar wrote: For older FVPs (without support for RME extension) the top 16MB of DRAM1 is reserved as Trusted DRAM. However, the latest FVP Base RevC AEM Model [1] has support for RME extension. When RME extension is present the top 64

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: add virtio serial driver

2023-04-18 Thread Ard Biesheuvel
On Mon, 17 Apr 2023 at 11:03, Gerd Hoffmann wrote: > This seems useful - how do I use it? > > > Gerd Hoffmann (4): > OvmfPkg: add IndustryStandard/VirtioSerial.h > OvmfPkg/VirtioSerialDxe: add driver > OvmfPkg/VirtioSerialDxe: wire up in OvmfPkg* > OvmfPkg/PlatformBootManagerLib: setup

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-04-18 Thread Ard Biesheuvel
On Tue, 18 Apr 2023 at 15:20, Gerd Hoffmann wrote: > > On Tue, Apr 18, 2023 at 01:59:43PM +0200, Ard Biesheuvel wrote: > > On Tue, 18 Apr 2023 at 13:52, Gerd Hoffmann wrote: > > > > > > Seems to work fine on fedora 37, even without adding --relax, maybe this > > > is enabled by default (there is

Re: [edk2-devel] [PATCH v2 1/6] MdePkg/BaseLib: RISC-V: Support getting satp register value

2023-04-18 Thread Andrei Warkentin
Looks reasonable to me. Reviewed-by: Andrei Warkentin > -Original Message- > From: Tuan Phan > Sent: Friday, April 14, 2023 1:58 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; > suni...@ventanamicro.com; g...@danielschaefer.me; Warkentin, Andrei

Re: [edk2-devel] [PATCH v2 0/6] RISC-V MMU support

2023-04-18 Thread Andrei Warkentin
Hi Tuan, Do you mind sharing the GitHub branch as well? It would help with the review immensely. A > -Original Message- > From: Tuan Phan > Sent: Friday, April 14, 2023 1:58 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; > suni...@ventanamicro.c

[edk2-devel] [PATCH v1 1/1] BaseTools/Plugin: Clarify code coverage failure message

2023-04-18 Thread Michael Kubacki
From: Michael Kubacki HostBasedUnitTestRunner.py is a build plugin responsible for locating and executing host-based unit tests. Recently, commit 6bb00aa introduced support for the plugin to generate code coverage reports via lcov and OpenCppCoverage. The plugin has discovered unit tests by sea

Re: [edk2-devel] [PATCH v2 2/6] MdePkg/Register: RISC-V: Add satp mode bits shift definition

2023-04-18 Thread Andrei Warkentin
Looks reasonable to me (but my email view of the patch is corrupted... so please follow up with a link to a Github branch) Reviewed-by: Andrei Warkentin > -Original Message- > From: Tuan Phan > Sent: Friday, April 14, 2023 1:58 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Ga

Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-04-18 Thread Leif Lindholm
(apologies, still catching up from being away last week) +Hao, Ray as MdeModulePkg/Bus maintainers. On Wed, Apr 12, 2023 at 04:25:35 +, Chang, Abner wrote: > [AMD Official Use Only - General] > > Hi Richard and Pedro, > Understand that is the standard USB communication class device, that > i

Re: [edk2-devel] [PATCH v2 1/3] Tianocore: Support FDT library.

2023-04-18 Thread Leif Lindholm
On Thu, Apr 13, 2023 at 02:36:04 +0800, benny@intel.com wrote: > From: Benny Lin > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 > Add FDT support in EDK2 by submodule 3rd party libfdt > (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) > > Add submodule libfdt and u

Re: [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers

2023-04-18 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: Sunday, April 16, 2023 10:57 PM > To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) > ; Ard Biesheuvel > ; Leif Lindholm ; > Kinney, Michael D > Cc: Chang, Abner > Subject:

Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM SMBIOS definitions

2023-04-18 Thread Michael D Kinney
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Saturday, April 1, 2023 6:57 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang > ; Nickle Wang ; Igor Kulchytskyy > ; Oram, Isaac W > ; Abdul Lateef

Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM Base definitions

2023-04-18 Thread Michael D Kinney
I see PldmSmbiosTransfer.h includes this file. Are there any other files that will include this file? Could this content be folded into PldmSmbiosTransfer.h to reduce total number of include files? Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > vi

Re: [edk2-devel] [PATCH] MdePkg: Add DEBUG_MANAGEABILITY print error level

2023-04-18 Thread Michael D Kinney
Do we really need a new debug level? The DEBUG_INIT/WARN/INFO/VERBOSE levels can be enabled/disabled in individual modules. I imagine even within the set of manageability components you will want to use those different levels to adjust verbosity of the debug log. Mike > -Original Message-

Re: [edk2-devel] [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C

2023-04-18 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: 17 April 2023 18:26 To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang ; Tinh Nguyen Subject: [edk2-platforms][PATCH V2 2/3] Manageabil

Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library

2023-04-18 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[AMD Official Use Only - General] Hi Ray, From open-source code I can see OVMF still implements SmmCpuFeaturesReadSaveStateRegister. Hence, we can't directly use SmramSaveStateReadRegister in PiSmmCpuDxe driver, until we implement the MmSaveStateLib for Ovmf. I think it's better t

[edk2-devel] [PATCH 0/4] Trace Hub debug library support

2023-04-18 Thread victorx . hsu
From: VictorX Hsu - TraceHub UniversalPayload Spec: https://github.com/UniversalScalableFirmware/documentation/pull/52 (Industry Standard) - MipiSysTLib Wrapper: https://github.com/MIPI-Alliance/public-mipi-sys-t.git (Industry Standard) - TraceHubDebugLib: Intel(R) Trace Hub

[edk2-devel] [PATCH 1/4] MdePkg: Add MipiSysTLib library

2023-04-18 Thread victorx . hsu
From: VictorX Hsu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144 This Library provides functions consuming MIPI SYS-T submodule. Cc: Michael D Kinney Cc: Guo Gua Cc: Chan Laura Cc: Prakashan Krishnadas Veliyathuparambil Cc: K N Karthik Signed-off-by: VictorX Hsu --- .gitmodule

[edk2-devel] [PATCH 3/4] MdePkg: Add NULL library of TraceHubDebugSysTLib

2023-04-18 Thread victorx . hsu
From: VictorX Hsu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144 This Library is NULL library of TraceHubDebugSysTLib. Cc: Michael D Kinney Cc: Guo Gua Cc: Chan Laura Cc: Prakashan Krishnadas Veliyathuparambil Cc: K N Karthik Signed-off-by: VictorX Hsu --- .../TraceHubDebugSys

[edk2-devel] [PATCH 2/4] MdeModulePkg: Add TraceHubDebugSysTLib library

2023-04-18 Thread victorx . hsu
From: VictorX Hsu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144 This Library provides API to dump Trace Hub message. Cc: Michael D Kinney Cc: Guo Gua Cc: Chan Laura Cc: Prakashan Krishnadas Veliyathuparambil Cc: K N Karthik Signed-off-by: VictorX Hsu --- .../Include/Guid/Trac

[edk2-devel] [PATCH 4/4] Maintainers.txt: Update reviewers and maintainers for Trace Hub dbg lib.

2023-04-18 Thread victorx . hsu
From: VictorX Hsu Update reviewers and maintainers for TraceHubDebugSysTlib. Signed-off-by: VictorX Hsu --- Maintainers.txt | 18 ++ 1 file changed, 18 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 455afdbc69..8fe82f5378 100644 --- a/Maintainers.txt +++ b/

Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

2023-04-18 Thread Michael D Kinney
Hi Ray, There are other discussions to add more arch specific content to MdeModulePkg https://edk2.groups.io/g/devel/message/101104 The tradeoff here is moving a lib class from UefiCpuPkg to MdePkg vs defining a new lib class/instance and requiring all downstream DSC files to be updated for th

Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table

2023-04-18 Thread Lendacky, Thomas via groups.io
On 4/18/23 04:57, Tan, Dun wrote: Hi Tom, I added a new patch in my code branch. This new patch removes the code that may apply AddressEncMask to smm page table non-leaf entries when splitting page table. Could you please help test if this code branch works? https://github.com/td36/edk2/tree/S

Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Add AUTH_SIG_NOT_FOUND Action

2023-04-18 Thread Min Xu
On Friday, April 14, 2023 1:18 PM, Nhi Pham wrote: > Hi, > > Ping for reviewing. > > Let me know if I need anything for this patch. Do you test the change and what's the test result? Can you provide the validation result? Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all mes

Re: [edk2-devel] [PATCH v7 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

2023-04-18 Thread Andrei Warkentin
Hi Sunil, Not saying it's right, but I followed a specific pattern seen elsewhere, e.g. ./MdeModulePkg/Core/PiSmmCore/PiSmmIpl.uni, where the two sentences are either the same or mildly rephrased. A > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunil V L > Sent: Wedn

Re: [edk2-devel] [PATCH] MdePkg: Add DEBUG_MANAGEABILITY print error level

2023-04-18 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] I was hesitated having a new debug level for just RedfishPkg, until I realized not only RedfishPkg but also ManageabilityPKg and edk2-redfish-client need a specific debug level. The scope look to me big enough to create a new individual debug level due to lot o

[edk2-devel] [PATCH v2 0/5] Introduce EDKII Redfish Platform Config Protocol

2023-04-18 Thread Nickle Wang via groups.io
Introduce EDKII Redfish Platform Config Protocol and corresponding libraries. This protocol is the interface between UEFI platform configuration and Redfish property. It could handle different firmware implementation and the implementation here is to map EDK2 HII questions to the properties defin

[edk2-devel] [PATCH v2 1/5] RedfishPkg: introduce EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL

2023-04-18 Thread Nickle Wang via groups.io
EDKII Redfish Platform Config Protocol defines the protocol interfaces that abstracts the platform configuration format and storage from EDK2 Redfish Feature driver. This protocol provides the interfaces to get and set platform configuration with the format and configuration storage agnostic to the

[edk2-devel] [PATCH v2 4/5] RedfishPkg: Helper library of EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL

2023-04-18 Thread Nickle Wang via groups.io
This is the helper library for using EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPkg.dec | 5 + .../RedfishPlatformConfigLib.inf | 41 +++ .../Library/Redfish

[edk2-devel] [PATCH v2 5/5] RedfishPkg: Add Redfish Platform Config Protocol to RedfishPkg

2023-04-18 Thread Nickle Wang via groups.io
Add RedfishPlatformConfigDxe driver and corresponding library to RedfishPkg. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/RedfishComponents.dsc.inc | 3 +++ RedfishPkg/RedfishLibs.dsc.inc | 2 ++ RedfishPkg/Red

Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM Base definitions

2023-04-18 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] There are couple subordinate specifications base on PLDM base spec. There is possible someone introduces another PLDM C header file that includes PLDM base definitions. So PLDM base definitions should be separated. Abner > -Original Message- > From: de

Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM SMBIOS definitions

2023-04-18 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney via groups.io > Sent: Wednesday, April 19, 2023 1:48 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Gao, Liming ; Liu, Zhiguang > ; Nickle Wang ; Igor > Kulchytskyy ;

[edk2-devel] 回复: [PATCH v1 1/1] BaseTools/Plugin: Clarify code coverage failure message

2023-04-18 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: mikub...@linux.microsoft.com > 发送时间: 2023年4月19日 0:11 > 收件人: devel@edk2.groups.io > 抄送: Rebecca Cran ; Liming Gao > ; Bob Feng ; Yuwei Chen > ; Michael D Kinney ; > Sean Brogan > 主题: [PATCH v1 1/1] BaseTools/Plugin: Clarify code coverage failure me

Re: [edk2-devel] [PATCH v1] Securitypkg/hddpassword: Update HddPasswordDxeInit to use Variable Policy

2023-04-18 Thread Linus Liu
Hi Zhang and Kumar Could you help to review this patch ? Thanks. From: Linus Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4408 Change-Id: I3c4b466ef318766d6d70c9f73e36b94b5f10832c Cc: Jiewen Yao Cc: Maggie Chu Signed-off-by: Linus Liu --- SecurityPkg/HddPassword/HddPasswordDxe.

回复: [ ** SPAMMAIL ** ]Re: [edk2-devel] [edk2][PATCH v2 1/1] MdeModulePkg: Add EDKII Platform Boot Manager Protocol v2

2023-04-18 Thread gaoliming via groups.io
Tinh: By design, EfiBootManagerRefreshAllBootOption() is used to find the available boot options; EfiBootManagerSortLoadOptionVariable() is used to sort the boot option order. They are both called in PlatformBootManagerLib. So, I think you should handle this issue in PlatformBootManagerLib. T

Re: [edk2-devel] [PATCH] CryptoPkg: Enable DXE_CORE support in DxeCryptLib.inf

2023-04-18 Thread Yao, Jiewen
Merged https://github.com/tianocore/edk2/pull/4284 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Friday, April 14, 2023 6:50 PM > To: Li, Yi1 ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin > Subject: Re: [edk2-devel] [PATC

[edk2-devel] [PATCH V2] MdePkg/Include: Add DMTF PLDM SMBIOS definitions

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang BZ #4396 This change adds definitions for DMTF PLDM SMBIOS Transfer specification. Spec ref: https://www.dmtf.org/sites/default/files/standards/documents/DSP0246_1.0.1.pdf Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang Cc:

Re: [edk2-devel] [PATCH v2 1/5] RedfishPkg: introduce EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL

2023-04-18 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Wednesday, April 19, 2023 10:12 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH v2 1/5] RedfishPkg: introduce > EDKII_REDFISH_PLATFORM_CONFIG_PROTOC

Re: [edk2-devel] [PATCH v2 4/5] RedfishPkg: Helper library of EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL

2023-04-18 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, April 19, 2023 10:12 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH v2 4/5] RedfishPkg: Helper library of > EDK

Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and update smm page table

2023-04-18 Thread duntan
Hi Tom, This PF happened because that CR0.WP is set and DxeMemEncryptSevLib sets a part of smm page table as RO before ReadyToLock while CpuSmm driver assumes the smm page table is not marked as RO before ReadyToLock. The code flow to set smm page table to RO is QemuFlashBeforeProbe()-->MemEnc

回复: [edk2-devel] [PATCH V2] MdePkg/Include: Add DMTF PLDM SMBIOS definitions

2023-04-18 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Chang, Abner > via groups.io > 发送时间: 2023年4月19日 13:03 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Nickle > Wang ; Igor Kulchytskyy ; Isaac > Oram ; Abdul Lateef Attar > > 主题: [edk2-dev

Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

2023-04-18 Thread Ni, Ray
Mike, Moving the PageTableLib to MdePkg today also requires all downstream DSC files to be updated to use the instance in MdePkg. Because MpInitLib today depends on PageTableLib already due to the change to put AP in 64bit before handling to OS. But you remind me to search for other modules mani

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: add virtio serial driver

2023-04-18 Thread Gerd Hoffmann
On Tue, Apr 18, 2023 at 05:46:35PM +0200, Ard Biesheuvel wrote: > > This seems useful - how do I use it? bare qemu (with guest console on stdin/stdout): qemu-system-x86_64 \ -enable-kvm -nodefaults -display none \ -bios Build/OvmfX64/DEBUG_GCC5/FV/OVMF.fd \ -chardev stdio

[edk2-devel] [edk2-platforms][PATCH V2 00/14] ManageabilityPkg part II

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang In V2: - Address uncrustify issues. - Use DBBUG_MANAGEABILITY_INFO to output detailed manageability information. DEBUG_INFO is used for the function entry point, while DEBUG_ERROR is used for the error situations. In part II, we had implemented - PLDM protocol -

[edk2-devel] [edk2-platforms][PATCH V2 01/14] ManageabilityPkg: Add more helper functions

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang 1. Add a helper function to output payload binary to debug output device. 2. Add a helper function to split payload into packages according to maximum transfer unit of transport interface. 3. Add a helper function to generate CRC8. Signed-off-by: Abner Chang Cc: Isaac

[edk2-devel] [edk2-platforms][PATCH V2 03/14] ManageabilityPkg: Add HeaderSize and TrailerSize

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang Add HeaderSize and TrailerSize in MANAGEABILITY_TRANSFER_TOKEN structure. Manageability transport interface may used by multiple protocols which have different header and trailer of payload. (e.g. MCTP over KCS and IPMI over KCS). Signed-off-by: Abner Chang Cc: Isaac Oram Cc:

[edk2-devel] [edk2-platforms][PATCH V2 05/14] ManageabilityPkg: Add PldmSmbiosTransferDxe driver

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang Add edk2 driver that supports PLDM SMBIOS Transfer Specification. https://www.dmtf.org/sites/default/files/standards/documents/DSP0246_1.0.1.pdf We currently only support "Push" mode of PLDM SMBIOS transfer. That says only BIOS to BMC direction is supported. The functionality i

[edk2-devel] [edk2-platforms][PATCH V2 04/14] ManageabilityPkg: Add PldmProtocolLib

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang PldmProtocolLib provides the library function to PLDM protocol. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../ManageabilityPkg/ManageabilityPkg.dec | 3 + .../Include/Dsc/Manageability.dsc |

[edk2-devel] [edk2-platforms][PATCH V2 02/14] ManageabilityPkg: Support Maximum Transfer Unit

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang Update GetTransportCapability to support Maximum Transfer Unit (MTU) of transport interface. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../Library/ManageabilityTransportLib.h | 33 --- .../Commo

[edk2-devel] [edk2-platforms][PATCH V2 07/14] ManageabilityPkg: Add definitions of MCTP

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang Add definitions of MCTP manageability transport interface library. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- Features/ManageabilityPkg/ManageabilityPkg.dec | 16 1 file changed, 16 insertions

[edk2-devel] [edk2-platforms][PATCH V2 06/14] ManageabilityPkg/KCS: KCS transport interface

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang - Return Maximum Transfer Unit for MCTP over KCS - Check the parameters Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../Common/ManageabilityTransportKcs.h| 2 +- .../Common/KcsCommon.c

[edk2-devel] [edk2-platforms][PATCH V2 08/14] ManageabilityPkg: Add MCTP manageability header file

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang Add C header file of MCTP manageability transport interface library. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../Library/ManageabilityTransportMctpLib.h | 54 +++ 1 file changed, 54 insert

[edk2-devel] [edk2-platforms][PATCH V2 10/14] ManageabilityPkg: Add MCTP transport interface

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang Add MCTP manageability transport interface library. The functionality is verified by checking the binary debug output of payload. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../ManageabilityPkg/ManageabilityP

[edk2-devel] [edk2-platforms][PATCH V2 09/14] ManageabilityPkg/MctpProtocol: Add MctpProtocol

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang MctpProtocol that transmits MCTP message over manageability transport interface library. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../Include/Dsc/Manageability.dsc | 1 + .../MctpProtocol/Dxe/M

[edk2-devel] [edk2-platforms][PATCH V2 11/14] ManageabilityPkg/PldmProtocol: Add PLDM protocol

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang PldmProtocol that transmits PLDM message over manageability transport interface library. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../Include/Dsc/Manageability.dsc | 1 + .../PldmProtocol/Dxe/P

[edk2-devel] [edk2-platforms][PATCH V2 12/14] ManageabilityPkg: Add Manageability PCDs

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang Add PCDs to control ManageabilityPkg modules. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguyen --- Features/ManageabilityPkg/ManageabilityPkg.dec | 8 .../Include/Dsc/Manageability.dsc

[edk2-devel] [edk2-platforms][PATCH V2 13/14] ManageabilityPkg: Relocate Manageability.dsc

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang Relocate Manageability.dsc to just under \Include folder. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguyen --- Features/ManageabilityPkg/Include/{Dsc => }/Manageability.dsc | 0 Features/ManageabilityPk

[edk2-devel] [edk2-platforms][PATCH V2 14/14] ManageabilityPkg: Add Manageability FDFs

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang Add FDF include files for build in ManageabilityPkg modules to firmware device. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguyen --- .../ManageabilityPkg/Include/PostMemory.fdf | 28 ++

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-18 Thread Ard Biesheuvel
On Tue, 18 Apr 2023 at 08:40, Marvin Häuser wrote: > > > > On 17. Apr 2023, at 23:18, Ard Biesheuvel wrote: > > > > Agree with all of this. > > > > And thanks for tracking this down - must not have been fun :-) > > No worries - it wasn’t. :) It was mere luck Vitaly discovered early it was an > i

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-18 Thread Marvin Häuser
> On 18. Apr 2023, at 10:10, Ard Biesheuvel wrote: > > On Tue, 18 Apr 2023 at 08:40, Marvin Häuser wrote: >> >> >>> On 17. Apr 2023, at 23:18, Ard Biesheuvel wrote: >>> >>> Agree with all of this. >>> >>> And thanks for tracking this down - must not have been fun :-) >> >> No worries -

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-18 Thread Ard Biesheuvel
On Tue, 18 Apr 2023 at 10:18, Marvin Häuser wrote: > > > > > On 18. Apr 2023, at 10:10, Ard Biesheuvel wrote: > > > > On Tue, 18 Apr 2023 at 08:40, Marvin Häuser wrote: > >> > >> > >>> On 17. Apr 2023, at 23:18, Ard Biesheuvel wrote: > >>> > >>> Agree with all of this. > >>> > >>> And thanks fo

[edk2-devel] [PATCH] MdePkg: Add DEBUG_MANAGEABILITY print error level

2023-04-18 Thread Chang, Abner via groups.io
From: Abner Chang Bug #4414 Add DEBUG_MANAGEABILITY print error lever to output debug message of detailed manageability related module information, such as - RedfishPkg: - HTTP header/request/response - JSON plain text - Refish resource - Redfish Host interface information - Redfish cr

[edk2-devel] [Patch V1 1/3] BaseTools: fixing FMMT ShrinkFv issue

2023-04-18 Thread Yuwei Chen
1. FvLength not change issue; 2. FileSystemGuid align with File Size; Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Signed-off-by: Yuwei Chen --- BaseTools/Source/Python/FMMT/core/FMMTOperation.py | 2 +- BaseTools/Source/Python/FMMT/core/FvHandler.py | 10 +++--- 2 files changed, 8 i