Hi Nickle,
Please find my inline comments below
On 4/12/2023 10:17 AM, Nickle Wang wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
This change implements the blob transf
Update the toolchain definitions:
- Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with
CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64
and IA32.
- Mark GCC48, GCC49 and GCC5 as deprecated.
- Add GCC and GCCNOLTO toolchain definitions.
- Remove VS2008, VS
Update the CLANGDWARF toolchain definition in tools_def.template with the
settings from CLANG38, and delete the CLANG35 and CLANG38 toolchains.
The CLANG35 and CLANG38 toolchains were added for compatibility with
ARM's proprietary clang-based toolchain. Things have since moved on, and
with the lat
Remove remnants of Visual Studio 2008-2013 support from
Conf/tools_def.txt and various batch scripts.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 12
BaseTools/Scripts/SetVisualStudio.bat | 22 +--
BaseTools/Scripts/ShowEnviro
With recent changes, Visual Studio versions older than VS2015 are
unable to build EDK2 code.
To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain
definitions from Conf/tools_def.template, leaving only versions that can
be used to successfully build firmware.
Signed-off-by: Rebecca Cra
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from MdePkg.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
MdePkg/Include/Ia32/ProcessorBind.h | 8 ++--
MdePkg/Include/X64/ProcessorBind.h | 8 ++--
2 files changed, 4 inse
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from edksetup.bat.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
edksetup.bat | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/edksetup.bat b/edksetup.bat
ind
Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions
from Conf/tools_def.template.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 4
1 file changed, 4 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTo
The edk2-stable202302 release was the last to support building
EFI Byte Code drivers. Since the Intel EFI Byte Code Compiler is no
longer available, a decision has been made to remove support for EBC
from edk2.
Remove the definitions for Intel's EBC compiler from
Conf/tools_def.template.
Signed-o
Update the Visual Studio toolchain descriptions in
tools_def.txt.template:
- The WinDDK is no longer needed.
- Update 3 is required for VS 2015.
- VS 2005 has been removed.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 7 ++-
1 file changed, 2 insertions(+), 5 deletion
Add a 'GCC' toolchain that's a copy of the existing GCC5 definition.
Add a 'GCCNOLTO' toolchain that's a copy of the existing GCC48
toolchain.
Signed-off-by: Rebecca Cran
---
UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +
IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc |
Avoid calling LoadConfiguration twice, in both InitPreBuild and
InitBuild. Since InitPreBuild is called first, delete the second call
from InitBuild.
Signed-off-by: Rebecca Cran
---
BaseTools/Source/Python/build/build.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/Base
The GCC48, GCC49 and GCC5 toolchains will be deleted in the coming
months. Inform users that they're deprecated and tell them what replaces
them.
Signed-off-by: Rebecca Cran
---
BaseTools/Source/Python/build/build.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/BaseTools/S
In order to make it clear for anyone reading tools_def.template, add
a section for deprecated tool chains and move GCC48, GCC49 and GCC5
into it.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 31 +++-
1 file changed, 23 insertions(+), 8 deletions(-)
diff --
Bump VERSION to 3.00 and explain the changes made to the toolchains.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index 413087676b
Pushed as
https://github.com/tianocore/edk2/commit/6ded9f50c3aa123fe581c42ff6c03789b9b593c1
.
--
Rebecca Cran
On 12/16/22 15:35, Michael D Kinney wrote:
Hi Pedro,
This is great feature. We may have some other big changes
in our git history that we may want to have an option to ignore
when
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, April 17, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1868164 )
*Description:*
TianoC
On 4/16/2023 5:50 PM, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
[AMD Official Use Only - General]
Tink and Nickle,
Two feedbacks in below,
-Ori
Hi Abner,
On 17/04/2023 10:01, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
[AMD Official Use Only - General]
-Original Message-
From: Tinh Ng
From: "Duggapu, Chinni B"
https://bugzilla.tianocore.org/show_bug.cgi?id=4412
After shrinking the FSP (FV) component using FMMT, Image size
in FSP info header is not in sync with the FV length in FV header.
This enhancement helps to patch the FSP image size offset with
correct length & can be us
[AMD Official Use Only - General]
Sure. I was wondering to use I2C or I2c. I will update it.
Thanks
Abner
> -Original Message-
> From: Attar, AbdulLateef (Abdul Lateef)
> Sent: Monday, April 17, 2023 12:50 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Isaac Oram ; Nickle Wang
> ; Ti
From: Benny Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
Add FDT support in EDK2 by submodule 3rd party libfdt
(https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
and refer to LibcLib implementation by Pedro.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: S
From: Benny Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
Add FDT support in EDK2 by submodule 3rd party libfdt
(https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
Add submodule libfdt and update ReadMe for the licence.
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D
From: Benny Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
Add FDT support in EDK2 by submodule 3rd party libfdt
(https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
and refer to LibcLib implementation by Pedro.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Acked
From: Benny Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
Add FDT support in EDK2 by submodule 3rd party libfdt
(https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
Add RequiredSubmodule object for CI setting.
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Michael D Kinney
C
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Sunday, April 16, 2023 9:23 PM
> To: devel@edk2.groups.io
> Cc: Duggapu, Chinni B ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Zeng, Star ; Kuo, Ted
>
> Subject: [PATCH v3] IntelFsp2Pkg/To
26 matches
Mail list logo
