[edk2-devel] [PATCH 0/5] Platforms cleanup v1

2023-04-02 Thread Chai, Evan
*** BLURB HERE *** Evan Chai (5): Silicon/RISC-V/ProcessorPkg: remove redundant CpuDxe driver Platform/Sifive: remove redundant TimerDxe from Platform Silicon/RISC-V: remove redundant RiscVTimerLib Silicon/RISC-V: remove redundant function code from RiscVCpuLib Platform/ Siliocn/: Fix bu

[edk2-devel] [PATCH 1/5] Silicon/RISC-V/ProcessorPkg: remove redundant CpuDxe driver

2023-04-02 Thread Chai, Evan
UefiCpuPkg/CpuDxeRiscV64 will replace it later. Cc: Daniel Schaefer Cc: Sunil V L Cc: Andrei Warkentin Signed-off-by: Evan Chai --- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 2 +- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf | 2 +- Pla

[edk2-devel] [PATCH 2/5] Platform/Sifive: remove redundant TimerDxe from Platform

2023-04-02 Thread Chai, Evan
It will be replaced by UefiCpuPkg/CpuTimerDxeRiscV64. Cc: Daniel Schaefer Cc: Sunil V L Cc: Andrei Warkentin Signed-off-by: Evan Chai --- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 2 +- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf | 2 +

[edk2-devel] [PATCH 3/5] Silicon/RISC-V: remove redundant RiscVTimerLib

2023-04-02 Thread Chai, Evan
It will be replaced by UefiCpuPkg/Library/BaseRiscV64CpuTimerLib. Cc: Daniel Schaefer Cc: Sunil V L Cc: Andrei Warkentin Signed-off-by: Evan Chai --- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 11 ++- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U

[edk2-devel] [PATCH 4/5] Silicon/RISC-V: remove redundant function code from RiscVCpuLib

2023-04-02 Thread Chai, Evan
They had been implemented in MdePkg/Library/BaseLib Cc: Daniel Schaefer Cc: Sunil V L Cc: Andrei Warkentin Signed-off-by: Evan Chai --- Silicon/RISC-V/ProcessorPkg/Include/Library/RiscVCpuLib.h | 20 +--- Silicon/RISC-V/ProcessorPkg/Library/RiscVCpuLib/Cpu.S | 41 +--

[edk2-devel] [PATCH 5/5] Platform/ Siliocn/: Fix building failure caused by wrong lib.

2023-04-02 Thread Chai, Evan
RiscVSbiLib was implemented in MdePkg/Library/BaseRiscVSbiLib. Cc: Daniel Schaefer Cc: Sunil V L Cc: Andrei Warkentin Signed-off-by: Evan Chai --- Platform/RISC-V/PlatformPkg/Library/ResetSystemLib/ResetSystemLib.c | 4 +++- Platform/RISC-V/PlatformPkg/Library/ResetS

Re: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

2023-04-02 Thread Rebecca Cran
On 3/28/23 7:19 PM, gaoliming wrote: GCC49 is one GCC tool chain without LTO enable option. GCC5 is another GCC tool chain with LTO enable option. They have the different usage. I suggest to keep GCC49 and GCC5 both, and also keep their name as is. Is anything still _using_ GCC49 though? Si

Re: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

2023-04-02 Thread Ard Biesheuvel
On Sun, 2 Apr 2023 at 17:41, Rebecca Cran wrote: > > On 3/28/23 7:19 PM, gaoliming wrote: > > > GCC49 is one GCC tool chain without LTO enable option. GCC5 is another GCC > > tool chain with LTO enable option. > > > > They have the different usage. I suggest to keep GCC49 and GCC5 both, and > >

Re: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

2023-04-02 Thread Michael D Kinney
NOOPT builds can be very valuable to find these types of issues. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Sunday, April 2, 2023 9:37 AM > To: Rebecca Cran > Cc: Gao, Liming ; devel@edk2.groups.io; Oliver > Smith-Denny ; Jiang, Guomin >

Re: [edk2-devel] PR fails due to OVMF time out

2023-04-02 Thread Michael D Kinney
Hi Gerd, I have investigated this failure with enabling -smp 4. I think this is an important feature that should be on by default. I did find that the results where inconsistent at 2 or 4 cpus on my laptop, but going 8 or higher would fail consistently. I used -smp 32 for all the testing below.

Re: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

2023-04-02 Thread Pedro Falcato
On Sun, Apr 2, 2023 at 4:41 PM Rebecca Cran wrote: > > On 3/28/23 7:19 PM, gaoliming wrote: > > > GCC49 is one GCC tool chain without LTO enable option. GCC5 is another GCC > > tool chain with LTO enable option. > > > > They have the different usage. I suggest to keep GCC49 and GCC5 both, and >

Re: 回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

2023-04-02 Thread Rebecca Cran
On 4/2/23 12:38 PM, Pedro Falcato wrote: As expressed off-list on UEFI talkbox, I like GCCNOLTO, but I would rather keep GCC5 as GCC5, for the next future iteration of "lets bump a new toolchain because we need feature X". Given we've gone from GCC 5 through 12 with no new toolchains, I'd pref

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, April 3, 2023 #cal-reminder

2023-04-02 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, April 3, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753772 ) *Description:* TianoCo

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-04-02 Thread Min Xu
On Friday, March 31, 2023 10:49 PM, Joeyli wrote: > On Fri, Mar 31, 2023 at 10:25:09AM +0200, Gerd Hoffmann wrote: > > On Fri, Mar 31, 2023 at 03:59:56PM +0800, joeyli wrote: > > > Hi Gerd, > > > > > > On Thu, Mar 30, 2023 at 09:50:53AM +0200, Gerd Hoffmann wrote: > > > > On Wed, Mar 29, 2023 at 01

回复: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-04-02 Thread gaoliming via groups.io
Patrick: Can you give the reproduce step to generate ELF image that doesn't work with the option max-page-size? > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Marvin > H?user > 发送时间: 2023年3月31日 18:58 > 收件人: gaoliming > 抄送: devel@edk2.groups.io; patrick.rudo...@9elements.com; > guo.d...@intel

Re: [edk2-devel] [PATCHv2 1/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

2023-04-02 Thread Wu, Hao A
Patch merged via: PR - https://github.com/tianocore/edk2/pull/4207 Commit - https://github.com/tianocore/edk2/commit/eb6a74827200eedc81b8f45f332d6e9f3b3d2906 Best Regards, Hao Wu From: Anbazhagan, Baraneedharan Sent: Wednesday, March 29, 2023 10:30 AM To: devel@edk2.groups.io; Wu, Hao A ; Albec

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-04-02 Thread Patrick Rudolph
Hi, I cannot reproduce the issue on my setup. Please ignore it for now. Regards, Patrick Rudolph On Mon, Apr 3, 2023 at 2:52 AM gaoliming via groups.io wrote: > > Patrick: > Can you give the reproduce step to generate ELF image that doesn't work > with the option max-page-size? > > > -邮件原

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary delay.

2023-04-02 Thread Ni, Ray
Chasel, With your changes, the flow is like: 1. check revision of loaded microcode, go to Done if it's not zero 2. find first matching microcode 3. check revision of loaded microcode, go to Done if it equals to the matching one 4. load the matching microcode Done: return fail/success depending on