Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

2023-03-18 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Leif, Thanks to your review. AMD\PlatformPkg is mainly for the modules that are generic to AMD's server, client or other platforms, while AMD\BoardPkg that contains the modules that support MinPlatformrPkg framework. AMD\BoardPkg may also provide the modules

Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

2023-03-18 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] BTW Leif, I don't see any modules under OverdriveBoard, is this package still in use? Do you still remember where is FDF and DSC come from (as there is AMD copyright 2014-2016) back to the moment when you was introduced this package? Thanks Abner > -Origin

Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

2023-03-18 Thread Ard Biesheuvel
On Sat, 18 Mar 2023 at 10:16, Chang, Abner wrote: > > [AMD Official Use Only - General] > > BTW Leif, > I don't see any modules under OverdriveBoard, is this package still in use? > Do you still remember where is FDF and DSC come from (as there is AMD > copyright 2014-2016) back to the moment wh

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.

2023-03-18 Thread Ashraf Ali S
Hi., Chasel RAX holds the FsptImageBaseAddress, the AND operation is performed to clear the upper 32bits of RAX registers. Don't we have to clear the upper 32bit of RAX registers? -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Friday, March 17, 2023 10:51

Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

2023-03-18 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Ard, Thanks for letting us know this history. I know Leo and I will reach out to him if necessary. We are going to relocate OverdriveBoard to under AMD/BoardPkg, hope it won't bring you too much problems. 😊 I can see some people had contributions to Overdrive

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.

2023-03-18 Thread Marvin Häuser
Hi Chasel, If you want to improve the ASM further, maybe opt for “test reg, reg” over “cmp reg, 0”? Best regards, Marvin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101365): https://edk2.groups.io/g/devel/message/101365 Mute This To

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.

2023-03-18 Thread Marvin Häuser
Hi Ashraf, ”mov eax, eax” does clear the high 32 Bits of rax. Best regards, Marvin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101366): https://edk2.groups.io/g/devel/message/101366 Mute This Topic: https://groups.io/mt/97678369/2165