Re: [edk2-devel] [PATCH 0/4] CryptoPkg/BaseCryptLib: avoid certain openssl library calls

Sure. Thanks to remind me. https://github.com/tianocore/edk2/pull/4104. Thank you Yao, Jiewen > -Original Message- > From: kra...@redhat.com > Sent: Tuesday, March 7, 2023 2:54 PM > To: Yao, Jiewen > Cc: devel@edk2.groups.io; Oliver Steffen ; Pawel > Polawski > Subject: Re: [edk2-devel

Re: [edk2-devel] [PATCH 1/2] NetworkPkg/HttpDxe: provide function to disable TLS host verify

Hi @Michael Brown, @Maciej Rabeda, @Siyuan Fu, I got an idea to handle this issue. EFI_HTTP_SERVICE_BINDING_PROTOCOL is defined in UEFI specification for caller to create HTTP protocol on child instance. H

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Improve formatting of DEBUG messages in UsbBusDxe

Merged via: PR - https://github.com/tianocore/edk2/pull/4102 Commit - https://github.com/tianocore/edk2/commit/46f51898ff716e53921b93e8d78af0fc7d06a2f9 Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Hao A > Sent: Monday, February 27, 2023 1:16 PM

[edk2-devel] [PATCH v2 0/2] OvmfPkg: move two include files to Include/Fdf

v2: - rebase to latest master Gerd Hoffmann (2): OvmfPkg: move OvmfTpmPei.fdf.inc to Include/Fdf OvmfPkg: move OvmfTpmDxe.fdf.inc to Include/Fdf OvmfPkg/AmdSev/AmdSevX64.fdf | 4 ++-- OvmfPkg/CloudHv/CloudHvX64.fdf | 4 ++-- OvmfPkg/OvmfPkgIa32.fdf

[edk2-devel] [PATCH v2 1/2] OvmfPkg: move OvmfTpmPei.fdf.inc to Include/Fdf

Signed-off-by: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.fdf | 2 +- OvmfPkg/CloudHv/CloudHvX64.fdf | 2 +- OvmfPkg/OvmfPkgIa32.fdf | 2 +- OvmfPkg/OvmfPkgIa32X64.fdf | 2 +- OvmfPkg/OvmfPkgX64.fdf | 2 +-

[edk2-devel] [PATCH v2 2/2] OvmfPkg: move OvmfTpmDxe.fdf.inc to Include/Fdf

Signed-off-by: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.fdf | 2 +- OvmfPkg/CloudHv/CloudHvX64.fdf | 2 +- OvmfPkg/OvmfPkgIa32.fdf | 2 +- OvmfPkg/OvmfPkgIa32X64.fdf | 2 +- OvmfPkg/OvmfPkgX64.fdf | 2 +-

Re: [edk2-devel] [PATCH] MdePkg/Include: Add IPMI KCS definitions

[AMD Official Use Only - General] Hi Tinh, That depends on if AMD platform enables SSIF as host-bmc transport interface, otherwise I may not work on that because I have no platform to test. Thanks Abner > -Original Message- > From: Tinh Nguyen > Sent: Tuesday, March 7, 2023 3:51 PM > To

Re: [edk2-devel] [PATCH 1/2] NetworkPkg/HttpDxe: provide function to disable TLS host verify

On 07/03/2023 08:21, Nickle Wang via groups.io wrote: I got an idea to handle this issue. EFI_HTTP_SERVICE_BINDING_PROTOCOL is defined in UEFI specification for caller to create HTTP protocol on child instance. How about I propose a new service binding protocol called EFI_HTTP_*NO_TLS_HOST_VE

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

Another kind reminder, thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100799): https://edk2.groups.io/g/devel/message/100799 Mute This Topic: https://groups.io/mt/95706437/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

Another kind reminder, thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100800): https://edk2.groups.io/g/devel/message/100800 Mute This Topic: https://groups.io/mt/95802829/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug

In case the number of CPUs can in increase beyond 255 due to CPU hotplug choose x2apic mode. Signed-off-by: Gerd Hoffmann --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

Hi all, I would like to kindly remind that the final decision on this topic has not been made yet. If I understand correctly we need some more expertise from Intel about potential issues caused by this change on binary based images (which assumes fixed size for this data structure and cannot be ch

Re: [edk2-devel] PATCH v3 1/3 MdeModulePkg: TerminalDxe: set xterm resolution on mode change

Hi all, As a new stable version has been released recently and the freeze is over, if there is a chance for review of this set of patches? They have been already reviewed in the past and the last request was to make commit messages more meaningful for the end user. Best regards, Pawel On Fri, F

Re: [edk2-devel] [PATCH v3 0/4] ArmPkg/SecurityPkg: Fixes for ArmTrngLib/RngDxe

On Tue, 7 Mar 2023 at 08:53, Yao, Jiewen wrote: > > I don’t mind, please go ahead. > Thanks. Merged as #4109 Note that I replaced the 'return EFI_UNSUPPORTED' with 'return EFI_REQUEST_UNLOAD_IMAGE' so that RngDxe is simply unloaded again without an error if no RNG sources are available to it.

Re: [edk2-devel] [edk2-libc Patch 2/2] Incorporated review comments

Sorry, could you send out a v2 patch series with the fixes included please? Thanks. Rebecca Cran On 3/6/23 10:11 PM, Ajay Kadapathri wrote: Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Ajay Kadapathri --- .../PyMod-3.6.8/Modules/edk2module.c | 26

[edk2-devel] [PATCH v4 2/2] SecurityPkg/RngDxe: Check for NULL PcdCpuRngSupportedAlgorithm

From: Pierre Gondois BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4151 The EFI_RNG_PROTOCOL can advertise multiple algorithms through Guids. The PcdCpuRngSupportedAlgorithm contains a Guid that can be configured. It represents the algorithm used in RngLib and using CPU instructions. When

[edk2-devel] [PATCH v4 1/2] SecurityPkg/RngDxe: Simplify Rng algorithm selection for Arm

From: Pierre Gondois The default algorithm to use is the first element of mAvailableAlgoArray. There is no need to iterate through the array to find a valid algorithm. Simplify the Rng algorithm selection by returning the first element of mAvailableAlgoArray. Signed-off-by: Pierre Gondois ---

[edk2-devel] [PATCH v4 0/2] SecurityPkg: Fixes for RngDxe

From: Pierre Gondois v1: - https://edk2.groups.io/g/devel/message/96356 v2: - https://edk2.groups.io/g/devel/message/96434 - Reformulate commit message. - Do not warn if no algorithm is found as the message would be printed on non-Arm platforms. v3: - https://edk2.groups.io/g/devel/topic/952405

[edk2-devel] edk2/basetools python package build is failing.

Hi All, I am trying to build edk2/basetools python package but it is failing with the below error, looks like there is some problem with environment setup. Can some one please suggest a way to build it? Repo Link: https://github.com/tianocore/edk2-basetools Steps to build: 1. Run pip install

[edk2-devel] [PATCH edk2-platforms v1] Add build docs for Arm plats FVP and Juno

Signed-off-by: Jose Marinho Cc: Sami Mujawar Cc: Samer El-Haj-Mahmoud --- Platform/ARM/Readme.md | 315 + 1 file changed, 315 insertions(+) create mode 100644 Platform/ARM/Readme.md diff --git a/Platform/ARM/Readme.md b/Platform/ARM/Readme.md new file

Re: [edk2-devel] [edk2-platforms][PATCH 0/8] Introduce ManageabilityPkg

Hi, I'm not sure if I understand this module completely. This module is another IPMI solution?! we will utilize either ManageabilityPkg or IpmiFeaturePkg. And the IPMI protocol specified in the EDK2 repo is used by ManageabilityPkg. Can we make the IpmiCommandLib more generic so that we don'

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

I would suggest going forward to remove itanium hand-off information. Now that the stable table has been dropped the community can assess the impact of this change over the next few months. I can also follow-up on some of the more formal PI spec clean-up for elision of this info targeting a po

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

Hi Pawel, With suggestion from Vincent, let's remove ItaniumHealthFlags. https://edk2.groups.io/g/devel/message/100812 I recommend adding a note in the comment block for the EFI_SEC_PLATFORM_INFORMATION_RECORD that with the removal of the ItaniumHealthFlags, this union has diverged from the PI

Re: [edk2-devel] [PATCH edk2-platforms 1/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response parsing

Reviewed-by: Isaac Oram -Original Message- From: Mike Maslenkin Sent: Monday, February 27, 2023 3:28 PM To: devel@edk2.groups.io Cc: Mike Maslenkin ; Oram, Isaac W ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH edk2-platforms 1/3] IpmiFeaturePkg: fix IPMI GetSelfTest command

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

Hi Pawel, Can you please also reference the following BZ and commit in the commit message https://bugzilla.tianocore.org/show_bug.cgi?id=1560 https://github.com/tianocore/edk2/commit/4e1daa60f5372c22a11503961061ffa569eaf873 If you post a branch with these small updates and my Rb and send it thro

Re: [edk2-devel] [PATCH edk2-platforms 2/3] IpmiFeaturePkg: remove buffer temporary buffer from BMC instance structure

Mike, Thanks for the fixes. There is one more instance using TempData in SmmGenericIpmi.c. Could you please fix that as well? I noted that it isn't currently built/included by the IpmiFeaturePkg.dsc. I will fix that. Also, please add maintainers and reviewers for the package to commit messa

Re: [edk2-devel] [PATCH edk2-platforms 3/3] IpmiFeaturePkg: refine GetSelfTest function

Coding convention does not allow Hungarian notation, https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/v/release-2.20/4_naming_conventions/43_identifiers#4.3.3-hungarian-prefixes Please change pSelfTestResult to SelfTestResult. Thanks, Isaac -Original Message- From: de

[edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4360 An incorrect format specifier is being used in a DEBUG print, specifically, a variable of type EFI_STATUS was being printed with the %a format specifier (pointer to an ASCII string), thus the value of the Status variable was being treated as

Re: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Darbin Reyes > Sent: Tuesday, March 7, 2023 3:04 PM > To: devel@edk2.groups.io > Cc: Reyes, Darbin ; Narey, Jacob > > Subject: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix >

Re: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception

Great fix. I am wondering why this bug was not found earlier. If Status is 0 (Success), #PF exception would occur when NULL pointer protection is turned on. If Status is 0x8000_x (Error), #GP exception would occur because an address with only the BIT63 set is an invalid address. Thanks, Ray

[edk2-devel][edk2-platforms][PATCH V1 1/1] IpmiFeaturePkg/Build: Fix DSC organization issues

Move libraries from [Components] to [LibraryClasses] Match build to library supported build types Add missing SmmGenericIpmi.inf driver Move common library include to package build as this feature should not choose common libraries for board use Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Is

Re: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception

Hi Ray, It is in an error path. My guess is that this error path has not been used since this bug was introduced. Can you please merge this fix? Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Tuesday, March 7, 2023 3:24 PM > To: devel@edk2.groups.i

Re: [edk2-devel] [PATCH V2] MdePkg/Include: Add DMTF MCTP definitions

Acked-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Chang, Abner via groups.io Sent: Thursday, March 2, 2023 7:25 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Nickle Wang ; Igor Kulchytskyy ; Oram, Isaac W ; Abdul Latee

Re: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception

Sure. I will. > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, March 8, 2023 7:53 AM > To: devel@edk2.groups.io; Ni, Ray ; Reyes, Darbin > > Cc: Narey, Jacob ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: > Fix exception >

Re: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions

Acked-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Chang, Abner via groups.io Sent: Thursday, March 2, 2023 7:17 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Nickle Wang ; Igor Kulchytskyy ; Oram, Isaac W ; Abdul Latee

[edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/DSC: Restore AdvancedFeatures

Include for building Advanced Features was mistakenly removed in an earlier commit. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 5 + 1 file changed, 5 insertions(+) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Pla

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Update MinDsdt device name from PCI0 to MinDsdt_PC00

Reviewed-by: Isaac Oram -Original Message- From: Chiu, Chasel Sent: Wednesday, March 1, 2023 8:03 AM To: Chen, Aryeh ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric Subject: RE: [PATCH v1] MinPlatformPkg: Update MinDsdt device name from PCI

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Update MinDsdt device name from PCI0 to MinDsdt_PC00

Pushed as 65e001a7f2..90ea518edf -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Tuesday, March 7, 2023 4:28 PM To: Chiu, Chasel ; Chen, Aryeh ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: Re: [edk2-devel] [PATCH v1] Mi

Re: [edk2-devel] [PATCH] Platform/Loongson: Allow building with stack protector support

Reviewed-by: Xianglai Li On 2023/3/5 下午12:40, WANG Xuerui wrote: Some toolchains have stack protection enabled by default, so without the appropriate library included the build will fail with missing symbols during link. Cc: Bibo Mao Cc: Xianglai li Cc: Chao Li Cc: Leif Lindholm Cc: Michae

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

This library follows Redfish Host Interface specification and use IPMI command to get bootstrap account credential(NetFn 2Ch, Command 02h) from BMC. RedfishHostInterfaceDxe will use this credential for the following communication between BIOS and BMC. Signed-off-by: Nickle Wang Cc: Abner Chang C

Re: [edk2-devel] edk2/basetools python package build is failing.

Hi All, Did any one faced same issue earlier? Can you please suggest a way to build python package for edk2 basetolls. I am working a small application which I can use to read the capsule file data using python package. Below is the sample code which I want to use: import efilib import struct