Re: [edk2-devel] [PATCH v4 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-03-03 Thread RichardHo [何明忠] via groups . io
Hi Tinh/Rebecca/Michael, Does other issue in UsbNetworkPkg PATCH V4? May I add you to reviewer’s list in commit message? Thanks, Richard From: Richard Ho (何明忠) Sent: 2023年2月21日 11:02 AM To: Tinh Nguyen OS ; devel@edk2.groups.io Cc: Tony Lo (羅金松) ; Felix Polyudov ; Srini Narayana ; Harikrishna D

[edk2-devel] [PATCH 0/6] Fix issues in CpuPageTableLib

2023-03-03 Thread duntan
1.UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition 2.UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue 3.UefiCpuPkg/CpuPageTebleLib: Check input Mask in PageTableMap 4.UefiCpuPkg/CpuPageTableLib: Add manual TestCase to check input Mask 5.UefiCpuPkg/CpuPageTableLib: Modify RandomTe

[edk2-devel] [PATCH 1/6] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition

2023-03-03 Thread duntan
Remove unneeded 'if' condition in CpuPageTableLib code. The deleted code is in the code branch for present non-leaf parent entry. So the check for (ParentPagingEntry->Pnle.Bits.Present == 0) won't is always FALSE. Signed-off-by: Dun Tan Cc: Dandan Bi Cc: Liming Gao Cc: Ray Ni --- UefiCpuPkg/L

Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition

2023-03-03 Thread duntan
Sorry for adding wrong reviewers. Will resend the patch set. Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of duntan Sent: Friday, March 3, 2023 5:55 PM To: devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Ni, Ray Subject: [edk2-devel] [PATCH 1/6] UefiCpuPkg/C

[edk2-devel] [PATCH 0/6] Fix issues in CpuPageTableLib

2023-03-03 Thread duntan
1.UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition 2.UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue 3.UefiCpuPkg/CpuPageTebleLib: Check input Mask in PageTableMap 4.UefiCpuPkg/CpuPageTableLib: Add manual TestCase to check input Mask 5.UefiCpuPkg/CpuPageTableLib: Modify RandomTe

[edk2-devel] [PATCH 1/6] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition

2023-03-03 Thread duntan
Remove unneeded 'if' condition in CpuPageTableLib code. The deleted code is in the code branch for present non-leaf parent entry. So the check for (ParentPagingEntry->Pnle.Bits.Present == 0) won't is always FALSE. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffman

[edk2-devel] [PATCH 2/6] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

2023-03-03 Thread duntan
Fix the non-1:1 mapping issue in PageTableMap () of CpuPageTableLib Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-)

[edk2-devel] [PATCH 3/6] UefiCpuPkg/CpuPageTebleLib: Check input Mask in PageTableMap

2023-03-03 Thread duntan
When creating new page table or mapping not-present range in existing page table, we need to make sure all the non-reserved fields of input Mask are not 0. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap

[edk2-devel] [PATCH 4/6] UefiCpuPkg/CpuPageTableLib: Add manual TestCase to check input Mask

2023-03-03 Thread duntan
Add manual test case to check input Mask. When creating new page table or mapping not-present range in existing page table, all the non-reserved fields of Mask should not be 0. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/CpuPageTab

[edk2-devel] [PATCH 5/6] UefiCpuPkg/CpuPageTableLib: Modify RandomTest to check Mask

2023-03-03 Thread duntan
Modify RandomTest to check invalid input. When creating new page table or mapping not-present range in existing page table, if any non-reserved field of input Mask are 0, the return status of PageTableMap () should be RETURN_INVALID_PARAMETER. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc:

[edk2-devel] [PATCH 6/6] UefiCpuPkg/CpuPageTableLib: Enable non-1:1 mapping in random test

2023-03-03 Thread duntan
Enable non-1:1 mapping in random test. In previous test, non-1:1 test will fail due to the non-1:1 mapping issue in CpuPageTableLib and invalid Input Mask when creating new page table or mapping not-present range. Now these issue have been fixed. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni

Re: [edk2-devel] [PATCH v1 2/2] uefi-sct/SctPkg: Enable LoongArch64 building

2023-03-03 Thread G Edhaya Chandran
The patch is upstreamed through commit:  https://github.com/tianocore/edk2-test/commit/39f27f233aeab16f71fc8f5ed6b287eb9f884ec6 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100691): https://edk2.groups.io/g/devel/message/100691 Mute Thi

Re: [edk2-devel] [PATCH v1 1/2] uefi-sct/SctPkg: Add LoongArch64 platform support

2023-03-03 Thread G Edhaya Chandran
The patch is upstreamed through the commit:  https://github.com/tianocore/edk2-test/commit/09b7d056d43da01b3abe772946879e3ed5b5eebe -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100692): https://edk2.groups.io/g/devel/message/100692 Mute

[edk2-devel] [PATCH v2 1/1] SecurityPkg/DxeImageVerificationLib: Check result of GetEfiGlobalVariable2

2023-03-03 Thread Gerd Hoffmann
Call gRT->GetVariable() directly to read the SecureBoot variable. It is one byte in size so we can easily place it on the stack instead of having GetEfiGlobalVariable2() allocate it for us, which avoids a few possible error cases. Skip secure boot checks if (and only if): (a) the SecureBoot var

Re: [edk2-devel] [PATCH 0/5] MdePkg/Base.h: Introduce various alignment-related macros

2023-03-03 Thread Lendacky, Thomas via groups.io
On 3/3/23 00:51, Gerd Hoffmann wrote: Gerd Hoffmann (2): OvmfPkg: Rename IS_ALIGNED macros to avoid name collisions OvmfPkg: Consume new alignment-related macros Marvin Häuser (3): MdeModulePkg: Rename IS_ALIGNED macros to avoid name collisions MdePkg/Base.h: Introduce various alig

Re: [edk2-devel] [PATCH v1 0/1] Remove FP Init in UPL Entry

2023-03-03 Thread Dhaval Sharma
On Fri, Mar 3, 2023 at 6:05 AM Guo, Gua wrote: > What's the issue you encounter ? > I will add this context in the next patchset. But primarily I am enabling UPL for RiscV and during the process I found a few sequences which I believe are arch specific and showing up in the common boot path. Whil

Re: [edk2-devel] [edk2 0/3] v2 RISC-V SBI-backed SerialLib

2023-03-03 Thread Andrei Warkentin
Hi Sunil, Thanks for the feedback. I had run SetupGit, and CheckPatch doesn't find any CR/LF issues. Are you seeing this in the email or up on https://github.com/andreiw/edk2-rv-wip/tree/patchset-2? Is it possible this is getting mangled by the mail server? I do have "transferEncoding = 8bit

[edk2-devel] [edk2 0/3] v3 RISC-V SBI-backed SerialLib

2023-03-03 Thread Andrei Warkentin
Hello! Here are three patches that provide a SerialLib backed by SBI console. Both legacy and DBCN mechanisms are supported in various execution environments and have been tested with UART and HTIF consoles. This is also available at https://github.com/andreiw/edk2-rv-wip/tree/patchset-2 Compa

[edk2-devel] [edk2 1/3] MdePkg: BaseRiscVSbiLib: make more useful to consumers

2023-03-03 Thread Andrei Warkentin
Add a few more definitions and make SbiCall and TranslateError usable (not static) by library users. Cc: Daniel Schaefer Cc: Sunil V L Acked-by: Gerd Hoffmann Signed-off-by: Andrei Warkentin --- MdePkg/Include/Library/BaseRiscVSbiLib.h | 40 ++-- MdePkg/Library/BaseRis

[edk2-devel] [edk2 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec

2023-03-03 Thread Andrei Warkentin
If the SerialPortLib had any initialization needed, this would be skipped in the RiscVVirt Sec. Follow the example seen elsewhere (ArmVirtPkg PrePi). Seen with BaseSerialPortLibRiscVSbi not using DBCN in Sec, yet using DBCN elsewhere. Cc: Daniel Schaefer Cc: Sunil V L Signed-off-by: Andrei Wark

[edk2-devel] [edk2 2/3] [PATCH v3] MdePkg: add SBI-based SeriaPortLib for RISC-V

2023-03-03 Thread Andrei Warkentin
These are implementations of SerialPortLib using SBI console services. - SecPeiRiscVSerialPortLibSbi is appropriate for SEC/PEI (XIP) environments - PrePiDxeRiscVSerialPortLibSbi is appropriate for PrePI/DXE environments Tested with: - Qemu RiscVVirt (non-DBCN case, backed by UART) - TinyEMU + Ris