[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, December 5, 2022 #cal-reminder

2022-12-04 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, December 5, 2022 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1623297 ) *Description:* Tian

Re: [edk2-devel] [PATCH 1/4] MdeModulePkg/XhciDxe/XhciReg: Handle incorrect PSIV indices

2022-12-04 Thread Wu, Hao A
Hello, Could you help to send a V2 series of the patches? Also, a CI link with passed results will be appreciated. Best Regards, Hao Wu From: Sean Rhodes Sent: Saturday, December 3, 2022 12:38 AM To: devel@edk2.groups.io; Wu, Hao A Cc: Matt DeVillier ; Ni, Ray Subject: Re: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE

2022-12-04 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran > Sent: Friday, December 2, 2022 11:38 PM > To: Wu, Hao A ; devel@edk2.groups.io; Wang, Jian J > ; Gao, Liming ; Ni, Ray > > Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that > occur for bu

Re: [edk2-devel] [PATCH v1 1/2] UefiCpuPkg/Test: Move EfiMpServiceProtocol UT in a separate function

2022-12-04 Thread Zhiguang Liu
Reviewed-by: Zhiguang Liu < zhiguang@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96933): https://edk2.groups.io/g/devel/message/96933 Mute This Topic: https://groups.io/mt/95236455/21656 Group Owner: devel+ow...@edk2.gr

Re: [edk2-devel] [PATCH v1 2/2] UefiCpuPkg/Test: develop UEFI App and dynamic cmd for MP services UT

2022-12-04 Thread Zhiguang Liu
Reviewed-by: Zhiguang Liu < zhiguang@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96934): https://edk2.groups.io/g/devel/message/96934 Mute This Topic: https://groups.io/mt/95236454/21656 Group Owner: devel+ow...@edk2.gr

Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

2022-12-04 Thread Rebecca Cran
On 9/1/22 23:24, RichardHo [何明忠] via groups.io wrote: + DataLength = (UINTN)(Cpb->DataLen + (UINT32)Cpb->MediaheaderLen); + + while (1) { +if (Counter >= 3) { + StatCode = PXE_STATCODE_BUSY; + break; +} + +Status = Nic->UsbEth->UsbEthTransmit (Cdb, Nic->UsbEth, (VOID *)(U

Re: [edk2-devel] [PATCH v1 1/2] UefiCpuPkg/Test: Move EfiMpServiceProtocol UT in a separate function

2022-12-04 Thread duntan
Reviewed-by: Dun Tan -Original Message- From: devel@edk2.groups.io On Behalf Of Jason Lou Sent: Thursday, November 24, 2022 8:12 PM To: devel@edk2.groups.io Cc: Lou, Yun ; Ni, Ray ; Dong, Eric ; Laszlo Ersek ; Kumar, Rahul R Subject: [edk2-devel] [PATCH v1 1/2] UefiCpuPkg/Test: Move E

Re: [edk2-devel] [PATCH v1 2/2] UefiCpuPkg/Test: develop UEFI App and dynamic cmd for MP services UT

2022-12-04 Thread duntan
Reviewed-by: Dun Tan -Original Message- From: Lou, Yun Sent: Thursday, November 24, 2022 8:12 PM To: devel@edk2.groups.io Cc: Lou, Yun ; Ni, Ray ; Dong, Eric ; Laszlo Ersek ; Kumar, Rahul R ; Liu, Zhiguang ; Tan, Dun Subject: [PATCH v1 2/2] UefiCpuPkg/Test: develop UEFI App and dyna

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/PlatformCI: Expand Ovmf PlatformCI for Shell UnitTest

2022-12-04 Thread duntan
Hi all, Is there anything else I can do to speed up the review process for this patch set? Looking forward to your reply. Thanks, Dun -Original Message- From: Tan, Dun Sent: Monday, November 28, 2022 5:34 PM To: devel@edk2.groups.io; Tan, Dun Cc: Ard Biesheuvel ; Yao, Jiewen ; Justen,

Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI template for Shell UnitTest

2022-12-04 Thread duntan
Hi all, Is there anything else I can do to speed up the review process for this patch set? Looking forward to your reply. Thanks, Dun -Original Message- From: Tan, Dun Sent: Monday, November 28, 2022 5:34 PM To: devel@edk2.groups.io; Tan, Dun Cc: Sean Brogan ; Michael Kubacki ; Kinney,

Re: [edk2-devel] [PATCH] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation

2022-12-04 Thread Ni, Ray
Liming, We are running some code that requires MSR access (e.g.: MtrrLib) in EmulatorPkg. Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming via groups.io > Sent: Friday, December 2, 2022 5:48 PM > To: devel@edk2.groups.io; Liu, Zhiguang > Cc: Kinney

Re: [edk2-devel] [PATCH] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation

2022-12-04 Thread Zhiguang Liu
Hi Liming, Like ray said, we are trying to use some baselib function in EmulatorPkg, which is assembly code in normal BaseLib, and is mocked in UnitTestBaseLib, such as AsmWriteMsr64 and AsmCpuid. Thanks Zhiguang > -Original Message- > From: Ni, Ray > Sent: Monday, December 5, 2022 1:3

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

2022-12-04 Thread Prakash K via groups.io
Hi Gaoliming, Kindly let us the know the review status of the pull request. Thanks, Prakash K -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96942): https://edk2.groups.io/g/devel/message/96942 Mute This Topic: https://groups.io/mt/9524

[edk2-devel] [PATCH] EmulatorPkg/Win: Unload DLLs before reset

2022-12-04 Thread Ni, Ray
EmulatorPkg/Win calls LoadLibraryEx() when the corresponding DLL file is found for each PEIM or DXE driver. The module entry point is changed to point to the entry point from the DLL. This helps to notify Visual Studio that a new windows module is loaded and corresponding symbol parsing is performe

Re: [edk2-devel] [Patch 1/1] UnitTestFrameworkPkg: Library classes private to public

2022-12-04 Thread Zhiguang Liu
Hi Mike, Thanks for the patch. One comment is that UnitTestPersistenceLib depends on a struct definition UNIT_TEST_SAVE_HEADER, which is defined in private headers. Do you think it is ok to also move it into UnitTestPersistenceLib.h? Or what we really need from the struct in UnitTestPersistenceL

Re: [edk2-devel] [Patch 1/1] UnitTestFrameworkPkg: Library classes private to public

2022-12-04 Thread Zhiguang Liu
Another suggestion from Ray is to change the API adding a new parameter(size), so we can avoid using the UNIT_TEST_SAVE_HEADER struct. EFI_STATUS EFIAPI SaveUnitTestCache ( IN UNIT_TEST_FRAMEWORK_HANDLE FrameworkHandle, IN VOID *SaveData,