[edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes

2022-09-19 Thread Konstantin Aladyshev
The commit b807174fecacf4c9f8400cab4d6fb3f580284021 ("MdeModulePkg/GraphicsConsoleDxe: add modes") has added modes for the high display resolutions. Support these modes in the TerminalDxe as well, so it would be possible to select the text mode that would take all the available screen space. Signe

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-19 Thread Igor Mammedov
On Fri, 16 Sep 2022 15:45:38 -0400 "Jason Andryuk" wrote: CCing Stefan as he is probably the best person to talk about qemu impl. of TPM > Hi, > > I've noticed an issue with the TPM2 EventLog. OVMF exposes the TPM > Event Log via EFI and ACPI, but they have different addresses. The > EFI one

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-19 Thread Stefan Berger
On 9/19/22 05:17, Igor Mammedov wrote: On Fri, 16 Sep 2022 15:45:38 -0400 "Jason Andryuk" wrote: CCing Stefan as he is probably the best person to talk about qemu impl. of TPM Hi, I've noticed an issue with the TPM2 EventLog. OVMF exposes the TPM Event Log via EFI and ACPI, but they have

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-19 Thread Jason Andryuk
Hi, Stefan, On Mon, Sep 19, 2022 at 8:22 AM Stefan Berger wrote: > > > > On 9/19/22 05:17, Igor Mammedov wrote: > > On Fri, 16 Sep 2022 15:45:38 -0400 > > "Jason Andryuk" wrote: > > > > CCing Stefan as he is probably the best person to talk about qemu > > impl. of TPM > > > >> Hi, > >> > >> I've

Re: [edk2-devel] [PATCH] Maintainers.txt: Change Anthony's github id

2022-09-19 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Anthony PERARD > Sent: Friday, September 16, 2022 8:31 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; > Kinney, Michael D ; > Anthony PERARD > Subject: [PATCH] Maintainers.txt: Change Anthony's github id >

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-19 Thread Stefan Berger
On 9/19/22 12:55, Jason Andryuk wrote: Hi, Stefan, On Mon, Sep 19, 2022 at 8:22 AM Stefan Berger wrote: On 9/19/22 05:17, Igor Mammedov wrote: On Fri, 16 Sep 2022 15:45:38 -0400 "Jason Andryuk" wrote: CCing Stefan as he is probably the best person to talk about qemu impl. of TPM Hi,

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-19 Thread Jason Andryuk
On Mon, Sep 19, 2022 at 1:39 PM Stefan Berger wrote: > > > > On 9/19/22 12:55, Jason Andryuk wrote: > > Hi, Stefan, > > > > On Mon, Sep 19, 2022 at 8:22 AM Stefan Berger wrote: > >> > >> > >> > >> On 9/19/22 05:17, Igor Mammedov wrote: > >>> On Fri, 16 Sep 2022 15:45:38 -0400 > >>> "Jason Andryuk

Re: [edk2-devel] [PATCH v1 1/1] nasm_ext_dep.yaml: Remove leading zero in patch version

2022-09-19 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Friday, September 16, 2022 1:09 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Chen, Christine ; Sean > Brogan ; Kinney, Michael D > > Subject: [edk2

[edk2-devel] [PATCH v5 00/21] Add Raw algorithm support using Arm FW-TRNG interface

2022-09-19 Thread PierreGondois
From: Pierre Gondois Bugzilla: Bug 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) The Arm True Random Number Generator Firmware, Interface 1.0, specification defines an interface between an Operating System (OS) executing at EL1 and Firmware (FW) exposing a conditioned entropy source

[edk2-devel] [PATCH v5 01/21] ArmPkg: PCD to select conduit for monitor calls

2022-09-19 Thread PierreGondois
From: Sami Mujawar Define a PCD 'PcdMonitorConduitHvc' to select the conduit to use for monitor calls. PcdMonitorConduitHvc is defined as FALSE by default, meaning the SMC conduit is enabled as default. Adding PcdMonitorConduitHvc allows selection of HVC conduit to be used by virtual firmware im

[edk2-devel] [PATCH v5 02/21] ArmPkg/ArmMonitorLib: Definition for ArmMonitorLib library class

2022-09-19 Thread PierreGondois
From: Pierre Gondois The ArmMonitorLib provides an abstract interface to issue an HyperVisor Call (HVC) or System Monitor Call (SMC) depending on the default conduit. The PcdMonitorConduitHvc PCD allows to select the default conduit. The new library relies on the ArmHvcLib and ArmSmcLib librarie

[edk2-devel] [PATCH v5 03/21] ArmPkg/ArmMonitorLib: Add ArmMonitorLib

2022-09-19 Thread PierreGondois
From: Pierre Gondois The ArmMonitorLib provides an abstract interface to issue an HyperVisor Call (HVC) or System Monitor Call (SMC) depending on the default conduit. The PcdMonitorConduitHvc PCD allows to select the default conduit. Signed-off-by: Pierre Gondois --- ArmPkg/ArmPkg.dsc

[edk2-devel] [PATCH v5 04/21] ArmPkg/ArmHvcNullLib: Add NULL instance of ArmHvcLib

2022-09-19 Thread PierreGondois
From: Pierre Gondois Add a Null instance of ArmHvcLib in case of library dependencies. Signed-off-by: Pierre Gondois --- ArmPkg/ArmPkg.dsc | 1 + ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.c | 29 +++ .../Library/ArmHvcNullLib/ArmHvcNullLib.inf |

[edk2-devel] [PATCH v5 05/21] MdePkg/TrngLib: Definition for TRNG library class interface

2022-09-19 Thread PierreGondois
From: Sami Mujawar Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) The NIST Special Publications 800-90A, 800-90B and 800-90C provide recommendations for random number generation. The NIST 800-90C, Recommendation for Random Bit Generator (RBG) Constructions, defines the GetE

[edk2-devel] [PATCH v5 06/21] MdePkg/TrngLib: Add NULL instance of TRNG Library

2022-09-19 Thread PierreGondois
From: Sami Mujawar Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) The True Random Number Generator (TRNG) library defines an interface to access the entropy source on a platform. On platforms that do not have access to an entropy source, a NULL instance of the TRNG library

[edk2-devel] [PATCH v5 07/21] ArmPkg: Add FID definitions for Firmware TRNG

2022-09-19 Thread PierreGondois
From: Sami Mujawar Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) The Arm True Random Number Generator Firmware, Interface 1.0, Platform Design Document (https://developer.arm.com/documentation/den0098/latest/) defines an interface between an Operating System (OS) executing

[edk2-devel] [PATCH v5 08/21] ArmPkg/TrngLib: Add Arm Firmware TRNG library

2022-09-19 Thread PierreGondois
From: Sami Mujawar Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) The Arm True Random Number Generator Firmware, Interface 1.0, Platform Design Document (https://developer.arm.com/documentation/den0098/latest/) defines an interface between an Operating System (OS) executing

[edk2-devel] [PATCH v5 09/21] MdePkg/BaseRngLib: Rename ArmReadIdIsar0() to ArmGetFeatRng()

2022-09-19 Thread PierreGondois
From: Pierre Gondois The MdePkg must be self contained and not have external dependencies. ArmReadIdIsar0() is defined in MdePkg/Library/BaseRngLib and is limited to the scope of this library. The same function will be required to check the FEAT_AES and FEAT_RNG extensions in other libraries. As

[edk2-devel] [PATCH v5 10/21] ArmPkg/ArmLib: Add ArmReadIdIsar0() helper

2022-09-19 Thread PierreGondois
From: Pierre Gondois Add a ArmReadIdIsar0() helper function to access the AArch64 ID_ISAR0_EL1 register. Signed-off-by: Pierre Gondois --- ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 12 +++- ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 7 ++- 2 files changed, 17 insertio

[edk2-devel] [PATCH v5 11/21] ArmPkg/ArmLib: Add ArmHasRngExt()

2022-09-19 Thread PierreGondois
From: Pierre Gondois Add a ArmHasRngExt() to check for the FEAT_RNG extension. Also add a mask for the RNDR bits. Signed-off-by: Pierre Gondois --- ArmPkg/Include/Library/ArmLib.h| 12 +++- ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 15 ++- ArmPkg/Library/ArmL

[edk2-devel] [PATCH v5 12/21] SecurityPkg/RngDxe: Rename RdRandGenerateEntropy to generic name

2022-09-19 Thread PierreGondois
From: Sami Mujawar Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) Rename RdRandGenerateEntropy() to GenerateEntropy() to provide a common interface to generate entropy on other architectures. GenerateEntropy() is intended to generate high quality entropy. Also move the def

[edk2-devel] [PATCH v5 13/21] SecurityPkg/RngDxe: Replace Pcd with Sp80090Ctr256Guid

2022-09-19 Thread PierreGondois
From: Pierre Gondois gEfiRngAlgorithmSp80090Ctr256Guid was used as the default algorithm in RngGetRNG(). The commit below set the default algorithm to PcdCpuRngSupportedAlgorithm, which is a zero GUID by default. As the Pcd value is not defined for any platform in the edk2-platfoms repository, a

[edk2-devel] [PATCH v5 14/21] SecurityPkg/RngDxe: Remove ArchGetSupportedRngAlgorithms()

2022-09-19 Thread PierreGondois
From: Pierre Gondois RngGetInfo() is one of the 2 functions of the EFI_RNG_PROTOCOL. RngGetInfo() is currently a mere wrapper around ArchGetSupportedRngAlgorithms() which is implemented differently depending on the architecture used. RngGetInfo() does nothing more than calling ArchGetSupportedRn

[edk2-devel] [PATCH v5 15/21] SecurityPkg/RngDxe: Documentation/include/parameter cleanup

2022-09-19 Thread PierreGondois
From: Pierre Gondois This patch: -Update RngGetBytes() documentation to align the function definition and declaration. -Improve input parameter checking. Even though 'This' it is not used, the parameter should always point to the current EFI_RNG_PROTOCOL. -Removes TimerLib inclusion as unused.

[edk2-devel] [PATCH v5 16/21] SecurityPkg/RngDxe: Check before advertising Cpu Rng algo

2022-09-19 Thread PierreGondois
From: Pierre Gondois RngGetBytes() relies on the RngLib. The RngLib might use the RNDR instruction if the FEAT_RNG feature is present. RngGetInfo and RngGetRNG both must check that RngGetBytes() is working before advertising/using it. To do so, allocate an array storing the available algorithms.

[edk2-devel] [PATCH v5 17/21] SecurityPkg/RngDxe: Add AArch64 RawAlgorithm support through TrngLib

2022-09-19 Thread PierreGondois
From: Sami Mujawar Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) RawAlgorithm is used to provide access to entropy that is suitable for cryptographic applications. Therefore, add RawAlgorithm support that provides access to entropy using the TrngLib. Also remove unused Ue

[edk2-devel] [PATCH v5 18/21] SecurityPkg/RngDxe: Add debug warning for NULL PcdCpuRngSupportedAlgorithm

2022-09-19 Thread PierreGondois
From: Pierre Gondois PcdCpuRngSupportedAlgorithm should allow to identify the the algorithm used by the RNDR CPU instruction to generate a random number. Add a debug warning if the Pcd is not set. Signed-off-by: Pierre Gondois --- .../RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 10 +++

[edk2-devel] [PATCH v5 19/21] SecurityPkg/RngDxe: Rename AArch64/RngDxe.c

2022-09-19 Thread PierreGondois
From: Pierre Gondois To re-use the AArch64/RngDxe.c for an Arm implementation, rename AArch64/RngDxe.c to ArmRngDxe.c. Signed-off-by: Pierre Gondois --- .../RngDxe/{AArch64/RngDxe.c => ArmRngDxe.c}| 0 SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf | 2 +-

[edk2-devel] [PATCH v5 20/21] SecurityPkg/RngDxe: Add Arm support of RngDxe

2022-09-19 Thread PierreGondois
From: Pierre Gondois Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) Add RngDxe support for Arm. This implementation uses the TrngLib to support the RawAlgorithm and doens't support the RNDR instruction. To re-use the RngGetRNG(), RngGetInfo() and FreeAvailableAlgorithms()

[edk2-devel] [PATCH v5 21/21] ArmVirtPkg: Kvmtool: Add RNG support using FW-TRNG interface

2022-09-19 Thread PierreGondois
From: Sami Mujawar Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668) The EFI_RNG_PROTOCOL published by RngDxe has been updated to implement the EFI_RNG_ALGORITHM_RAW using the Arm FW-TRNG interface to provide access to entropy. Therefore, enable EFI_RNG_PROTOCOL for the Kvmto

Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes

2022-09-19 Thread Michael D Kinney
This looks like a reasonable update to support platforms that have both graphical consoles and serial consoles. Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Konstantin > Aladyshev > Sent: Monday, September 19, 2022 1:57 AM > To: devel@e

[edk2-devel] [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile

2022-09-19 Thread Rebecca Cran
When checking if $PYTHON_COMMAND exists, curly braces should be used instead of parentheses. Also, "1" causes an error on FreeBSD: it's likely supposed to be 2>&1 like other scripts. Signed-off-by: Rebecca Cran --- BaseTools/Tests/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[edk2-devel] [PATCH v4 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

2022-09-19 Thread Jeff Brasen via groups.io
Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 60 ++--- DynamicTablesP

[edk2-devel] [PATCH v4 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

2022-09-19 Thread Jeff Brasen via groups.io
_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/

[edk2-devel] [PATCH v4 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

2022-09-19 Thread Jeff Brasen via groups.io
Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 133 +- 1 file changed, 127 insertions(+), 6 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTo

[edk2-devel] [PATCH v4 0/3] DynamicTablesPkg: _CPC support

2022-09-19 Thread Jeff Brasen via groups.io
Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. v3 - Min

[edk2-devel] Event: Tools, CI, Code base construction meeting series - 09/19/2022 #cal-reminder

2022-09-19 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* 09/19/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610028 ) *Description:* TianoCore communit

Re: [edk2-devel] How to guard CAR's stack overflow

2022-09-19 Thread Brian J. Johnson
You could also try modifying the Ia32 segment descriptors to mark the stack segment as an "expand down" type with a limit set just below the low end of the stack area.  That should generate a stack-fault exception if the stack overflows, and wouldn't require building page tables.  See sections

[edk2-devel] Now: Tools, CI, Code base construction meeting series - 09/19/2022 #cal-notice

2022-09-19 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* 09/19/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610028 ) *Description:* TianoCore community, Micros

Re: [edk2-devel] [PATCH] FIX MinPlatformPkg PCIE Base Addess avoid thunking operation.

2022-09-19 Thread Isaac Oram
Ali, I don't understand what "thunking the address" means. The old code was typecasting the address which could truncate it. In my experience, when people say thunk, they refer to a processor environment switch, eg from 64b to 32b. Other uses should probably be avoided or at least clearly de

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-19 Thread Min Xu
On September 19, 2022 2:59 PM, Ard Biesheuvel wrote: > On Mon, 19 Sept 2022 at 04:13, Xu, Min M wrote: > > > > On September 18, 2022 8:52 PM, Ard Biesheuvel wrote: > > > Hello Min Xu, > > > > > > On Sat, 17 Sept 2022 at 04:53, Xu, Min M wrote: > > > > > > > > Hi, Ard > > > > > > > > I am checking

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-19 Thread Jiading Zhang
Hello, I test for several times and find that if add the following line, the KB and MassStorage will work, InputContext->EP[0].EPType = ED_CONTROL_BIDIR; I don't know if the issue is brought in by the different of xHCI controllers or else. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive a

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 09/20/2022 #cal-reminder

2022-09-19 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 09/20/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed77

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-19 Thread Wu, Hao A
Thanks for the information. Yes, I think the “EPType” field should be initialized properly for the Evaluate Context command to work. The spec mentions in 6.2.3 Endpoint Context that: * Note: Unless otherwise stated: As Input, all fields of the Endpoint Context shall be initialized to the appropr

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-19 Thread Wu, Hao A
Sorry, missed one change, “EPState” field should be cleared to 0 for input context: INPUT_CONTEXT_64*InputContext; DEVICE_CONTEXT_64 *OutputContext; EFI_PHYSICAL_ADDRESSPhyAddr; ASSERT (Xhc->UsbDevContext[SlotId].SlotId != 0); // // 4.6.7 Evaluate Conte

[edk2-devel] Logical operator function in shell environment

2022-09-19 Thread Tiger Liu(BJ-RD)
Hi, Experts: I am writing a shell script. I have a few questions about shell script syntax. For examples: 1. Could I save register content (which is read with mm command) to a local variable? Take an example: Reading register 0x80's content with mm command, and I want to save its content to

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-19 Thread Jiading Zhang
I update XhcEvaluateContext64 according your suggesting and test in my platform, the KB and mass storage both can work! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93981): https://edk2.groups.io/g/devel/message/93981 Mute This Topic:

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-19 Thread Wu, Hao A
Thanks. Could you help to: 1) File a Bugzilla to track this issue at https://bugzilla.tianocore.org/enter_bug.cgi?product=EDK2; 2) Send a new version of the patch for code changes (please update XhcEvaluateContext function accordingly as well). Best Regards, Hao Wu From: devel@edk2.groups.io