Reviewed-by: James Lu
Thanks,
James
-Original Message-
From: Guo, Gua
Sent: Friday, September 2, 2022 8:13 AM
To: Sravanthi, K KavyaX ; devel@edk2.groups.io
Cc: Dong, Guo ; Ni, Ray ; Rhodes, Sean
; Lu, James
Subject: RE: [PATCH v6 2/2] UefiPayloadPkg: Allow DxeMain.inf to consume th
Richard:
ReadMe introduces the module behavior. But, it doesn't provide the code
design. So, I want to confirm whether NetworkCommon driver support PXE.
Thanks
Liming
> -邮件原件-
> 发件人: RichardHo [何明忠]
> 发送时间: 2022年9月1日 11:47
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Andrew Fish' ; '
Aladyshev:
Thanks for your sharing. Your UEFI lessons provide the basic information of
Edk2. They are useful for new edk2 developer.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Konstantin
> Aladyshev
> 发送时间: 2022年8月31日 15:29
> 收件人: gaoliming
> 抄送: devel@edk2.groups.io; Feng,
Hi Liming,
See the Binding.jpg that is NetworkCommon driver boot flow.
Below is NetworkCommon driver to do
#1 Install UNDI protocol
#2 Respond normal Cdb flag or attribute in UNDI API
#3 Provide device API hook if the device has specific command or setting.
Ex: UndiGetState routine in PxeFuncito
On Sat, Aug 27, 2022 at 02:02:00AM +0200, Théo wrote:
> From: Théo Jehl
>
> QemuOpenBoardPkg adds a MinPlatform port to Qemu x86_64
> It can boots UEFI Linux and Windows, and works on PIIX4 and Q35
> This board port provides a simple starting place for investigating edk2 and
> MinPlatform Arch.
>
There currently isn't a way to differentiate the different
levels of DEBUG output: DEBUG_ERROR, DEBUG_WARN, DEBUG_INFO
etc.
To improve this, wrap DEBUG_ERROR and DEBUG_WARN level
messages in ANSI color code escape sequences. DEBUG_ERROR
messages will be displayed in red text, and DEBUG_WARN
in yel
Changes in v3:
Renamed the FeatureFlag to PcdDebugAnsiSeqSupport.
Rebecca Cran (1):
MdePkg: Use ANSI colors to indicate debug message severity
MdePkg/MdePkg.dec| 6 +
MdePkg/MdePkg.dsc| 2 +
Md
There's no bhyve specific PlatformSecureLib any more. Use the default
one of OvmfPkg which works too.
Signed-off-by: Corvin Köhne
CC: Ard Biesheuvel
CC: Jiewen Yao
CC: Jordan Justen
CC: Gerd Hoffmann
CC: Rebecca Cran
CC: Peter Grehan
CC: devel@edk2.groups.io
---
OvmfPkg/Bhyve/BhyveX64.dsc
Hi @Dong, Guo
I've created the PR, could you help me add push label when you're available. I
think we're better to check in the solution.
https://github.com/tianocore/edk2/pull/3269
-Original Message-
From: Lu, James
Sent: Thursday, September 1, 2022 3:09 PM
To: Liu, KasimX ; devel@ed
>
> That is a rather short description for a patch of this size. It
> probably makes sense to break that down into smaller pieces and make a
> patch series out of it because you can describe the specific pieces much
> better then.
I was thinking about breaking down the main patch into smaller on
Thanks for the patch, Michael.
Reviewed-by: Maciej Rabeda
On 25 sie 2022 05:48, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
Removes Status argument that is not needed from DEBUG macros.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Michael Kubacki
---
Netw
Thanks for the patch!
Reviewed-by: Maciej Rabeda
On 23 sie 2022 18:00, PierreGondois wrote:
From: Pierre Gondois
In an effort to clean the documentation of the above
package, remove duplicated words.
Cc: Maciej Rabeda
Signed-off-by: Pierre Gondois
---
NetworkPkg/DnsDxe/ComponentName.c
Hi,
> > That is a rather short description for a patch of this size. It
> > probably makes sense to break that down into smaller pieces and make a
> > patch series out of it because you can describe the specific pieces much
> > better then.
> I was thinking about breaking down the main patch i
On Fri, Sep 2, 2022 at 11:02 AM Gerd Hoffmann wrote:
> On Sat, Aug 27, 2022 at 02:02:00AM +0200, Théo wrote:
> > From: Théo Jehl
> >
> > QemuOpenBoardPkg adds a MinPlatform port to Qemu x86_64
> > It can boots UEFI Linux and Windows, and works on PIIX4 and Q35
> > This board port provides a simp
>
> S3Feature.dsc
> - remove commented out code
Regarding the SmmAccess library definition, which is the safer default?
There is a build failure for the package if nothing is defined, but a
platform should be required to define its correct library. Currently,
that's the SMRAMC instance for platfo
I've pushed this patch to a branch at
https://github.com/bcran/edk2/tree/usb-net .
--
Rebecca Cran
On 9/1/22 23:24, RichardHo [何明忠] via groups.io wrote:
UsbNetworkPkg provides network functions for USB ACM, USB NCM,
and USB RNDIS network device.
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc:
From: Michael Kubacki
After noticing a few occurrences of DEBUG macros with a mismatched
number of arguments, I wrote a script to automatically detect this.
This patch series is the result of matches found by the script.
In some cases it is not obvious what was originally intended so I
have att
From: Michael Kubacki
These debug messages are repeated in both NorFlashBlockIoReadBlocks()
and NorFlashBlockIoWriteBlocks():
"NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x"
"bytes (%d kB), BufferPtr @ 0x%08x)\n"
Although this requires 5 arguments, only 4 are provided. T
From: Michael Kubacki
This debug macro should take one argument based on the number of
print specifiers defined. However, two arguments are given.
It looks like the code may have been refactored such that the
second argument was moved to a new print and this argument was
not removed. In any case
From: Michael Kubacki
Updates debug macros in the package that have an imbalanced number
of print specifiers to arguments. These changes try to preserve
what was likely intended by the author. In cases information was
missing due to the bug, the specifier may be removed since it was
not previousl
From: Michael Kubacki
The debug macro argument in this change is removed since it does
have a corresponding print specifier in the debug message string.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Michael Kubacki
Reviewed-by: Abner Chang
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverD
From: Michael Kubacki
The debug macro modified in this change was missing a print specifier
for a debug message argument given.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Michael Kubacki
Reviewed-by: Jiewen Yao
---
SecurityPkg/Library/SmmTcg2PhysicalPresen
From: Michael Kubacki
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Michael Kubacki
Reviewed-by: Sami Mujawar
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/Acpi
From: Michael Kubacki
Removes Status argument that is not needed from DEBUG macros.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Michael Kubacki
Reviewed-by: Maciej Rabeda
---
NetworkPkg/TcpDxe/SockInterface.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions
From: Michael Kubacki
The DEBUG macro updated in this patch previously contained 11 print
specifiers in the debug string but passeed 13 arguments. This change
attempts to update the macro to the author's intention so the number
of specifiers match the number of arguments.
Cc: Ard Biesheuvel
Cc:
Hello OvmfPkg & FatPkg maintainers,
This series only needs a Reviewed-by from these packages. It should take
less than a couple minutes of your time.
Thanks,
Michael
On 9/2/2022 6:21 PM, Michael Kubacki wrote:
From: Michael Kubacki
After noticing a few occurrences of DEBUG macros with a mi
I updated V3 to repeat BufferSizeInBytes.
Regards,
Michael
On 8/25/2022 6:15 AM, Leif Lindholm wrote:
On Wed, Aug 24, 2022 at 23:48:17 -0400, Michael Kubacki wrote:
From: Michael Kubacki
These debug messages are repeated in both NorFlashBlockIoReadBlocks()
and NorFlashBlockIoWriteBlocks():
This helps resolve most of my concern but opens up a few logistical
complexities.
Compression Point in Boot Flow
--
The original patch placed compression in the SaveMemoryConfig DXE
driver. This proposal would move compression to PEI.
Specifically, it would need to
From: "brbar...@microsoft.com"
Remove Bret Barkelew from:
- .azurepipelines
- .mergify
- .pytool
- UnitTestFrameworkPkg
Add Michael Kubacki to:
- .azurepipelines
- .pytool
Signed-off-by: Bret Barkelew
Cc: Sean Brogan
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Michael Kubacki
---
Maintainers.
29 matches
Mail list logo
