[edk2-devel] [PATCH edk2-platforms 1/1] Silicon/SynQuacer/PlatformDxe: set ACPI as default hardware description

2022-08-19 Thread Masahisa Kojima
Since ACPI is well supported on SynQuacer platform, set ACPI as default hardware description. Only changing the "DEFAULT" flags from ACPIPREF_DT to ACPIPREF_ACPI does not work as expected, this commit also replaces the value of ACPIPREF_DT and ACPIPREF_ACPI. Signed-off-by: Masahisa Kojima --- S

Re: [edk2-devel] [PATCH 1/2] CloudHv/arm: add PeiMemInfoLib

2022-08-19 Thread Jianyong Wu
Thanks Sami. I will fix them all and send the v2 later. From: Sami Mujawar Sent: Thursday, August 18, 2022 7:41 PM To: Jianyong Wu ; devel@edk2.groups.io Cc: Ard Biesheuvel ; Justin He ; nd Subject: Re: [edk2-devel] [PATCH 1/2] CloudHv/arm: add PeiMemInfoLib Hi Jianyong, Please find my respon

Re: [edk2-devel] [PATCH V4 3/3] RedfishPkg: Redfish functions for REST requests are not fully spec complied

2022-08-19 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang Thanks! > -Original Message- > From: Igor Kulchytskyy > Sent: Friday, August 19, 2022 3:41 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nickle.w...@hpe.com; Igor > Kulchytskyy ; Chang, Abner > Subject: [PATCH V4 3/3] Red

[edk2-devel] [PATCH v2 0/2] CloudHv/arm: Add specific mem info lib

2022-08-19 Thread Jianyong Wu
Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the memory layout for cloud hypervisor is changed, it needs a new meminfo lib. Signed-off-by: Jianyong Wu Jianyong Wu (2): CloudHv/arm: add PeiMemInfoLib CloudHv/arm: switch PeiMemLib to its own ArmVirtPkg/ArmVirtCloudHv.dsc

[edk2-devel] [PATCH v2 1/2] CloudHv/arm: add PeiMemInfoLib

2022-08-19 Thread Jianyong Wu
Memory layout in CLoud Hypervisor for arm is changed and is different with Qemu, thus we should build its own PeiMemInfoLib. The main change in the memory layout is that normal ram may not contiguous under 4G. The top 64M under 4G is reserved for 32bit device. What this patch does: 1. get all of t

[edk2-devel] [PATCH 2/2] CloudHv/arm: switch PeiMemLib to its own

2022-08-19 Thread Jianyong Wu
As Cloud Hypervisor has its own PeiMemLib, change it in dsc file accordingly. Signed-off-by: Jianyong Wu Reviewed-by: Sami Mujawar --- ArmVirtPkg/ArmVirtCloudHv.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.dsc

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/SynQuacer/PlatformDxe: set ACPI as default hardware description

2022-08-19 Thread Ard Biesheuvel
On Fri, 19 Aug 2022 at 09:00, Masahisa Kojima wrote: > > Since ACPI is well supported on SynQuacer platform, set ACPI as > default hardware description. > > Only changing the "DEFAULT" flags from ACPIPREF_DT to ACPIPREF_ACPI > does not work as expected, this commit also replaces the value > of ACP

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

2022-08-19 Thread Rohit Mathew
Hi Swatisri, Thanks for the patch. Please find my comments inline marked [Rohit] - > -Original Message- > From: devel@edk2.groups.io On Behalf Of Name > via groups.io > Sent: 16 August 2022 21:18 > To: devel@edk2.groups.io; Sami Mujawar ; > Alexei Fedorov ; michael.d.kin...@intel.com; >

Re: [edk2-devel] [PATCH 2/2] Dynamic Tbl Mgr: MPAM: MPAM Generator and supporting files

2022-08-19 Thread Rohit Mathew
Hi Swatisri, Thanks for the patch. Please find my comments inline marked [Rohit] - > -Original Message- > From: devel@edk2.groups.io On Behalf Of Name > via groups.io > Sent: 16 August 2022 21:18 > To: devel@edk2.groups.io; Sami Mujawar ; > Alexei Fedorov ; michael.d.kin...@intel.com; >

Re: [edk2-devel] [PATCH] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

2022-08-19 Thread Boeuf, Sebastien
On Mon, 2022-08-15 at 15:49 +0200, Gerd Hoffmann wrote: > On Thu, Aug 11, 2022 at 02:40:57PM +0200, Boeuf, Sebastien wrote: > > From: Sebastien Boeuf > > > > Both ACPI shutdown and ACPI PM timer devices has been moved to > > different > > port addresses in the latest version of Cloud Hypervisor.

[edk2-devel] [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

2022-08-19 Thread Boeuf, Sebastien
From: Sebastien Boeuf Both ACPI shutdown and ACPI PM timer devices has been moved to different port addresses in the latest version of Cloud Hypervisor. These changes need to be reflected on the OVMF firmware. Acked-by: Gerd Hoffmann Signed-off-by: Sebastien Boeuf --- OvmfPkg/Include/Industry

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName

2022-08-19 Thread Sunny Wang
Looks good. Reviewed-by: Sunny Wang -Original Message- From: Dimitrije Pavlov Sent: 17 August 2022 15:35 To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Jiewen Yao ; Liming Gao ; Sunny Wang ; Jeff Booher-Kaeding ; Samer El-Haj-Mahmoud Subject: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check

Re: [edk2-devel] [PATCH v3] DynamicTablesPkg: Add support to build _DSD

2022-08-19 Thread PierreGondois
Thanks for the v3! Reviewed-by: Pierre Gondois On 8/17/22 18:39, Jeff Brasen wrote: Add APIs needed to build _DSD with different UUIDs. This is per ACPI specification 6.4 s6.2.5. Adds support for building data packages with format Package {"Name", Integer} Signed-off-by: Jeff Brasen --- ..

[edk2-devel] Problems building some Arm platforms (__stack_chk_guard/__stack_chk_fail, _GLOBAL_OFFSET_TABLE_)

2022-08-19 Thread Rebecca Cran
I have an armplatbld.sh script that goes through and tries to build as many of the Arm (AARCH64 and ARM) platforms in edk2-platforms as possible. I'm think this used to work for these, but I'm getting some errors now. I'm using edk2-platforms 46686eeb7e78efe603badd86f13777d9fb070fb8 and edk2 e

Re: [edk2-devel] Problems building some Arm platforms (__stack_chk_guard/__stack_chk_fail, _GLOBAL_OFFSET_TABLE_)

2022-08-19 Thread Rebecca Cran
I got an error emailing Masami Hiramatsu , who's listed as a reviewer for Socionext platforms and silicon: apparently they no longer work at Linaro. -- Rebecca Cran On 8/19/22 17:35, Rebecca Cran wrote: I have an armplatbld.sh script that goes through and tries to build as many of the Ar

Re: [edk2-devel] Problems building some Arm platforms (__stack_chk_guard/__stack_chk_fail, _GLOBAL_OFFSET_TABLE_)

2022-08-19 Thread Rebecca Cran
./Features/Ext4Pkg/Ext4Pkg.dsc is also failing - with errors about __stack_chk_guard and __stack_chk_fail. And I get an error from Andy Hayes' email: "Your message couldn't be delivered to the recipient because you don't have permission to send to it." -- Rebecca Cran On 8/19/22 17:35, Re

Re: [edk2-devel] Problems building some Arm platforms (__stack_chk_guard/__stack_chk_fail, _GLOBAL_OFFSET_TABLE_)

2022-08-19 Thread Pedro Falcato
Hi Rebecca, What EDK2 toolchain are you using? And how is your toolchain configured (or where did you get it from?)? It seems that it's trying to use the stack protector automatically... Thanks, Pedro On Sat, 20 Aug 2022, 00:40 Rebecca Cran, wrote: > ./Features/Ext4Pkg/Ext4Pkg.dsc is also fai

Re: [edk2-devel] Problems building some Arm platforms (__stack_chk_guard/__stack_chk_fail, _GLOBAL_OFFSET_TABLE_)

2022-08-19 Thread Rebecca Cran
I'm using gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1) on Ubuntu 20.04.4, from the Ubuntu repo. I'm building it with: export PACKAGES_PATH=$PWD/edk2:$PWD/edk2-platforms:$PWD/edk2-non-osi export WORKSPACE=$PWD export GCC5_AARCH64_PREFIX=aarch64-linux-gnu- . ./edk2/edksetup.sh build -p ./F

Re: [edk2-devel] Problems building some Arm platforms (__stack_chk_guard/__stack_chk_fail, _GLOBAL_OFFSET_TABLE_)

2022-08-19 Thread Pedro Falcato
I see the issue: We're not passing -fno-stack-protector to AARCH64 GCC toolchains (although arguably we should just enable support for it...). Can you try hacking up your tools_def to add -fno-stack-protector to GCC_AARCH64_CC_FLAGS? It should fix your build issues. On Sat, Aug 20, 2022 at 2:51 AM

Re: [edk2-devel] Problems building some Arm platforms (__stack_chk_guard/__stack_chk_fail, _GLOBAL_OFFSET_TABLE_)

2022-08-19 Thread Rebecca Cran
Other platform such as Platform/Qemu/SbsaQemu/SbsaQemu.dsc have:   # Add support for GCC stack protector   NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf -- Rebecca Cran On 8/19/22 20:34, Pedro Falcato wrote: I see the issue: We're not passing -fno-stack-protector to AARCH64 GC