+cc: Ard Biesheuvel, Leif Lindholm, Gerd Hoffmann
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jianyong
> Wu via groups.io
> Sent: Friday, July 29, 2022 3:22 PM
> To: devel@edk2.groups.io; Sami Mujawar
> Cc: ard.biesheu...@linaro.org; Justin He ; Jianyong
> Wu
> Subjec
+cc: Ard Biesheuvel, Leif Lindholm, Gerd Hoffmann
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jianyong
> Wu via groups.io
> Sent: Friday, July 29, 2022 3:22 PM
> To: devel@edk2.groups.io; Sami Mujawar
> Cc: ard.biesheu...@linaro.org; Justin He ; Jianyong
> Wu
> Subjec
Hi Ray,
Sure, I will complete all these below.
Thank you.
Jack
-Original Message-
From: Ni, Ray
Sent: Friday, August 5, 2022 2:43 PM
To: Lin, JackX ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Dong, Eric ;
Yao, Jiewen ; Chaganty, Rangasai V
; Kuo, Donald ; Kumar,
Chandana C ; Palakshar
BIOS should not reordering cpu processor_uid
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Dong Eric
Cc: Jiewen Yao
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Donald Kuo
Cc: Chandana C Kumar
Cc: Palakshareddy, Lavanya C
Cc: JackX Lin
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlat
Hi Michael,
Please find the link for the pull request with the review tags updated
at https://github.com/tianocore/edk2/pull/3183
Regards,
Sami Mujawar
On 05/08/2022 04:08 pm, Michael Kubacki wrote:
Hi Sami,
I see you created a PR that is marked as draft with these changes:
https://github.
Hi Michael,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 04/08/2022 05:09 am, Michael Kubacki wrote:
For the series: Reviewed-by: Michael Kubacki
The patch formatting seems a little strange:
1. The patches don't have "Cc" lines.
[SAMI] I have not been following
Hi Jianyong,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 29/07/2022 08:21 am, Jianyong Wu wrote:
Memory layout in CLoud Hypervisor for arm is changed and is different
with Qemu, thus we should build its own PeiMemInfoLib.
The main change i
Hi Jianyong,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 29/07/2022 08:21 am, Jianyong Wu wrote:
As Cloud Hypervisor has its own PeiMemLib, change it in dsc file
accordingly.
Signed-off-by: Jianyong Wu
---
ArmVirtPkg/ArmVir
Hi Kun,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 31/07/2022 06:37 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
This change added an extra step to allow check for installed ACPI tables.
For FADT, MADT, GT
Hi Kun,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 31/07/2022 06:37 am, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
Certain OSes will complain if the ECAM config space is not reserve
Hi Kun,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 31/07/2022 06:37 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
This change added a switch case handling for PCI_SS_CONFIG during SSDT
generation
Hi DynamicTablePkg maintainers,
Just a gentle ping on this patch series. If there is no further
feedback, can we merge
them into the mainline? Otherwise, any feedback is appreciated.
Regards,
Kun
On 8/3/2022 9:57 AM, Kun Qin wrote:
Hi DynamicTablePkg maintainers,
Do you have any further fee
Hi Kun,
I have just tried testing your patch with Kvmtool guest firmware and
think this patch may need some modifications.
Also, the patch 4/6 may need some adjustment, which I will reply back on
that patch separately.
Regards,
Sami Mujawar
On 08/08/2022 02:22 pm, Sami Mujawar wrote:
Hi
Hi Kun,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 08/08/2022 02:05 pm, Sami Mujawar wrote:
Hi Kun,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 31/07/2022 06:37 am, Kun Qin wrote:
REF: https://bugzilla.tian
Hi Kun,
I have just replied to your patch series. I think patches 4 & 5 may need some
adjustment.
Can you look into those, please?
Regards,
Sami Mujawar
On 08/08/2022, 16:34, "Kun Qin" wrote:
Hi DynamicTablePkg maintainers,
Just a gentle ping on this patch series. If there is no f
From: Shengfengx Xue
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4014
if Configured Memory Speed is 65,535 MT/s or greater,
and the actual speed is stored in the Extended Configured Memory Speed
field. but current Smbiosview have no this logic.
Signed-off-by: Shengfengx Xue
---
.../Uef
SerDesProtocolMap is a UINT64, but BIT0 is an unadorned int. Shifting
BIT0 left by more than 31 bits is undefined behaviour. This would cause
SerDesProtocolMap to be filled with incorrect values when using Serdes
protocols numbered 32 and above, such as the SGMII protocols.
This fixes a hang at bo
Hi,
I would like to propose to add Alert standard format support which is based
on ASF2.0 specification(DSP0136).
REF:https://www.dmtf.org/sites/default/files/standards/documents/DSP0136.pdf
Could you suggest which package is suitable for this feature?
Since I'm not sure which package to include
---
ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
index c3927ca35b..2d7e7d0bb4 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c
+
Reviewed-by: Marvin Häuser
> On 7. Aug 2022, at 01:39, Pedro Falcato wrote:
>
> Check its alignment and value for possible bad values.
>
> Cc: Marvin Häuser
> Signed-off-by: Pedro Falcato
> ---
> Features/Ext4Pkg/Ext4Dxe/Superblock.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --
Pushed as 436a8612ae..ea2a520c83
-Original Message-
From: devel@edk2.groups.io On Behalf Of Oram, Isaac W
Sent: Friday, August 5, 2022 1:30 PM
To: mikub...@linux.microsoft.com; devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Gao, Liming ; Dong,
Eric
Subject: Re: [edk2-d
Pushed as ea2a520c83..60053f3077
-Original Message-
From: devel@edk2.groups.io On Behalf Of Oram, Isaac W
Sent: Friday, August 5, 2022 1:40 PM
To: mikub...@linux.microsoft.com; devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Gao, Liming ; Dong,
Eric
Subject: Re: [edk2-d
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Benjamin Doron
Sent: Monday, July 25, 2022 10:12 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Oram, Isaac W
; Desimone, Nathaniel L
; Sinha, Ankit ; Gao,
Liming ; Dong, Eric
Subject: [edk2-de
Pushed as edc718521e..d85e4251ce
-Original Message-
From: devel@edk2.groups.io On Behalf Of Oram, Isaac W
Sent: Monday, August 8, 2022 12:22 PM
To: devel@edk2.groups.io; benjamin.doro...@gmail.com
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
; Sinha, Ankit ; Gao,
Liming ; Dong, Eric
Hi Sami,
Thanks for the deep dive on those patches. I will work on the patches
and reply on those threads.
Regards,
Kun
On 8/8/2022 8:44 AM, Sami Mujawar wrote:
Hi Kun,
I have just replied to your patch series. I think patches 4 & 5 may need some
adjustment.
Can you look into those, pleas
Add mapping for all enabled and disabled threads in MADT
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Eric Dong
Signed-off-by: Ankit Sinha
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 49
+++-
1 file changed, 28 insertions(+), 21 deletions(-)
diff --git a/Platf
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
08/08/2022
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1608785 )
*Description:*
TianoCore communit
Reviewed-by: Isaac Oram
-Original Message-
From: Sinha, Ankit
Sent: Monday, August 8, 2022 2:05 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Desimone, Nathaniel L
; Dong, Eric
Subject: [edk2-devel][edk2-platforms][PATCH V3 1/1] MinPlatformPkg/AcpiTables:
Add additional thread mapp
Pushed as d85e4251ce..306c2d1cef
-Original Message-
From: devel@edk2.groups.io On Behalf Of Oram, Isaac W
Sent: Monday, August 8, 2022 3:41 PM
To: Sinha, Ankit ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Dong, Eric
Subject: Re: [edk2-devel][edk2-platforms][PATCH V3 1/1]
MinPlatf
Responses inline.
On 8/8/2022 6:35 AM, Sami Mujawar wrote:
Hi Michael,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 04/08/2022 05:09 am, Michael Kubacki wrote:
For the series: Reviewed-by: Michael Kubacki
The patch formatting seems a little strange:
1. The pat
Benjamin,
Can you update the readme with descriptions of the modules and their
functionality?
Can you comment the PcdUseVersion1 declaration in the DEC file?
If you can think of a more descriptive name than "version 1", that would be
better.
Note that convention (maybe requirement) is to prefac
*Tools, CI, Code base construction meeting series*
*When:*
08/08/2022
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1608785 )
*Description:*
TianoCore community,
Micros
Hi Sami,
Thank you for taking time testing this change!
I have a question about one comment you have for this specific patch
inline (marked with [KQ]).
Could you please provide more details?
I also responded to your other comments, please let me know if the
proposed change makes
sense to yo
The patch set is to hide the exception implementation details,
so that caller don't need to know anything about IDT when separate stack
for it. However, this patch set changes a library API, so I have to
change multiple packages inside one patch. Otherwise, I can make sure
every single commit can
Hide the Exception implementation details in CpuExcetionHandlerLib and
caller only need to provide buffer
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Leif Lindholm
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J Wang
Cc: Ard Biesheuvel
Reviewed-by: Sami Mujawar
Signed-off-by: Zhiguang Liu
---
Since the API InitializeSeparateExceptionStacks is simplified and does't
use the struct CPU_EXCEPTION_INIT_DATA, CPU_EXCEPTION_INIT_DATA become
a inner implementation of CpuExcetionHandlerLib.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Leif Lindholm
Cc: Dandan Bi
Cc: Liming Gao
Cc: Jian J
CPU_EXCEPTION_INIT_DATA is now an internal implementation of
CpuExceptionHandlerLib. Union can be removed since Ia32 and X64 have the
same definition. Also, two fields (Revision and InitDefaultHandlers)are
useless, can be removed.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Zhiguang
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
08/09/2022
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed77
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Zhiguang Liu
> Sent: Tuesday, August 9, 2022 9:26 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Dong, Eric
> ; Ni, Ray ; Kumar, Rahul R
> ; Leif Lindholm ; Bi,
> Dandan ; Gao, Liming ;
> Wang, Jian
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Monday, July 18, 2022 9:18 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH 00/10] UefiCpuPkg: Create CpuPageTableLib for
manipulating X86 paging structs
Ray Ni (10):
UefiCpuPkg: C
Hi Sean,
How about directly setting the PCD in the build command line instead of adding
a MACRO?
Prefer not adding new MACRO if we could avoid it.
Thanks,
Guo
-Original Message-
From: Sean Rhodes
Sent: Friday, August 5, 2022 12:53 AM
To: devel@edk2.groups.io
Cc: Rhodes, Sean ; Dong, G
Reviewed-by: Guo Dong
-Original Message-
From: Liu, KasimX
Sent: Thursday, June 23, 2022 8:44 PM
To: devel@edk2.groups.io
Cc: Liu, KasimX ; Dong, Guo ; Ni, Ray
; Lu, James ; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Backward support with python 3.6
From: KasimX Liu
REF: ttps://bu
Parse Type 0 or Local APIC structure.
Also parse the Local APIC Flags as bitfields.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Abdul Lateef Attar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 74
++--
1 file changed, 67 insertions(+), 7 deletions(
Parse Type 0 or Local APIC structure.
Also parse the Local APIC Flags as bitfields.
Cc: Ray Ni
Cc: Zhichao Gao
Abdul Lateef Attar (1):
ShellPkg: Adds Local APIC parser to AcpiView
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 74
++--
1 file chang
44 matches
Mail list logo
