Currently, "push byte %[Vector]" causes nasm warning when Vector is larger
than 0x7F. This is because push accepts a signed value, and byte means
signed int8. Maximum signed int8 is 0x7F.
When Vector is larger the 0x7F, for example, when Vector is 255, byte 255
turns to -1, and causes the warning "
Hello edk2-devel list,
Laszlo Ersek in his email to edk2-devel related to
"CPU count limitation in CpuMpPei BIST processing"
pointed out coding style violation related to local variable
and function name overlap.
This patch addresses mentioned issue.
This is the version 2. Comparing to v1 new
Local variable name overlaped with function name.
Variable name has been updated to remove name duplication.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Paweł Poławski
---
UefiCpuPkg/CpuMpPei/CpuBist.c | 40 ++--
1 file changed, 20 insertions(+), 20 deletions(-)
Bugzilla: 3458 - Add support IORT Rev E.d specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping Table, Platform Design Document, Revision E.d,
Feb 2022 (https://developer.arm.com/documentation/den0049/)
introduces the following updates, coll
Some field names in the IORT table parser were longer than the
OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of
the output print alignment. Therefore, abbreviate the field names.
Signed-off-by: Sami Mujawar
Reviewed-by: Zhichao Gao
Reviewed-by: Pierre Gondois
---
Notes:
v4:
Bugzilla: 3458 - Add support IORT Rev E.d specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping Table, Platform Design Document, Revision E.d,
Feb 2022 (https://developer.arm.com/documentation/den0049/)
introduces the following updates, collectively
Bugzilla: 3458 - Add support IORT Rev E.d specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping Table, Platform Design Document, Revision E.d,
Feb 2022 (https://developer.arm.com/documentation/den0049/)
introduces the following updates, collectively
Bugzilla: 3458 - Add support IORT Rev E.d specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping Table, Platform Design Document, Revision E.d,
Feb 2022 (https://developer.arm.com/documentation/den0049/)
introduces the following updates, collectively
The IORT table generator is setting up a reference to ID array for
nodes even when the ID Mapping count is zero. This is not an issue as an
OS would only access the ID Reference if the ID mapping count is not zero.
However, it would be good to set the reference to ID array to zero when
the ID Mapp
Add error handling when the IdMappingCount is not zero and the
IdMappingToken is NULL.
Signed-off-by: Sami Mujawar
---
Notes:
v4:
- No changes since v3. Resending with v4 series. [SAMI]
v3:
- New patch in this series. Moves error handling code for [SAMI]
The IORT generator is populating the reference field for Context and
PMU interrupts even if their count is zero.
Update the IORT generator to set the references only if the interrupt
count is not 0. Also add checks to ensure a valid reference token has
been provided.
Signed-off-by: Sami Mujawar
Bugzilla: 3458 - Add support IORT Rev E.d specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping Table, Platform Design Document, Revision E.d,
Feb 2022 (https://developer.arm.com/documentation/den0049/)
introduces the following updates, collectively
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_
The patch series fixes the build break in Ampere/Jade and
Pythium/FT2000-4 due to missing VariableFlashInfoLib dependency
and also updates the IORT revision macro.
The IORT Rev E.d specification updates the IORT table revision
to 5. Following this the IORT table revision macro
EFI_ACPI_IO_REMAPPI
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.
Signed-off-by: Sami Mujawar
---
Si
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Add an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This allows the variable
driver to build successfully as it has a dependency on this
library class.
Signed-off-by: Sami Mujawar
---
Si
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_
The CM_STD_OBJ_ACPI_TABLE_INFO.AcpiTableRevision can be used to specify
the major revision number of the ACPI table that the generator must use.
Although most ACPI tables only have a major revision number, the FADT
table additionally has a minor revision number.
The FADT generator currently defaul
Please update HOOKAFTER_STUB_SIZE to 18.
> -Original Message-
> From: Liu, Zhiguang
> Sent: Wednesday, July 6, 2022 3:31 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Dong, Eric ;
> Ni, Ray ; Kumar,
> Rahul1 ; De, Debkumar ; Han,
> Harry ; West,
> Catharine
> Subject: [PATCH] Uef
Currently, "push byte %[Vector]" causes nasm warning when Vector is larger
than 0x7F. This is because push accepts a signed value, and byte means
signed int8. Maximum signed int8 is 0x7F.
When Vector is larger the 0x7F, for example, when Vector is 255, byte 255
turns to -1, and causes the warning "
Reviewed-by: Lean Sheng Tan< sheng@9elements.com >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91112): https://edk2.groups.io/g/devel/message/91112
Mute This Topic: https://groups.io/mt/92181074/21656
Group Owner: devel+ow...@edk2.
Invoke the constructor in the SEC phase to call into initialization
functions associated with libraries linked with this particular module.
For instance, PrePeiCore's CEntryPoint function calls DebugLib library's
print API before the library is initialized. This change is essential
to initialize u
On 06/07/2022 11:39, Sami Mujawar wrote:
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REV0.
Therefore, up
On 06/07/2022 14:42, Rohit Mathew wrote:
Invoke the constructor in the SEC phase to call into initialization
functions associated with libraries linked with this particular module.
For instance, PrePeiCore's CEntryPoint function calls DebugLib library's
print API before the library is initiali
Hello Sami,
The only configuration manager not using ACPI 6.4 tables is at:
Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c
I think the minor version of its FADT table needs to be updated along with
this patch. Otherwise:
Reviewed-by:
Regards,
Pierre
On 7/6
Hi Thomas,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 06/07/2022 03:18 pm, Thomas Abraham wrote:
On 06/07/2022 11:39, Sami Mujawar wrote:
The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been update
Hi Pierre,
On 06/07/2022 04:03 pm, Pierre Gondois wrote:
Hello Sami,
The only configuration manager not using ACPI 6.4 tables is at:
Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c
I think the minor version of its FADT table needs to be updated along
with
Hi Sami,
On 06/07/2022 16:15, Sami Mujawar wrote:
Hi Thomas,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 06/07/2022 03:18 pm, Thomas Abraham wrote:
On 06/07/2022 11:39, Sami Mujawar wrote:
The IORT Specification E.d updates the IORT table revision to 5. To
refl
On Wed, Jul 6, 2022 at 02:57 AM, Sami Mujawar wrote:
>
> -#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0
> +#define EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0
> +#define EFI_ACPI_IO_REMAPPING_TABLE_REV5 0x5
Based on discussion at
https://edk2.groups.io/g/devel/topic/patch_edk2_platforms_v2/92203690
Hi Jiewen,
Yes, the "https://github.com/kuqin12/edk2/tree/secure_boot_enhance_v3";
is the branch I generate these patch series. And they have not been
changed after sending v3 patches.
I confirm that:
1. the latest update 256220d82191effae32d91897ab0f65a4fa0641b is
identical to the one I sub
Hi Pedro,
This is an interesting feature.
It is backwards compatible since you are adding a format specifier to the
PrintLib class.
There is a 2nd lib instance that needs to be updated, and that is
DxePrintLibPrint2Protocol in MdeModulePkg.
I think using ANSI C %z specifier syntax assumes tha
On Wed, Jul 6, 2022 at 7:22 PM Kinney, Michael D
wrote:
> Hi Pedro,
>
> This is an interesting feature.
>
> It is backwards compatible since you are adding a format specifier to the
> PrintLib class.
>
> There is a 2nd lib instance that needs to be updated, and that is
> DxePrintLibPrint2Protocol
Merged https://github.com/tianocore/edk2/pull/3050
From: Kun Qin
Sent: Thursday, July 7, 2022 1:44 AM
To: devel@edk2.groups.io; Yao, Jiewen
Cc: Wang, Jian J ; Xu, Min M ; Sean
Brogan ; Ard Biesheuvel ;
Justen, Jordan L ; Gerd Hoffmann
; Rebecca Cran ; Peter Grehan
; Boeuf, Sebastien ; Andrew
Thank you so much for the help, Jiewen!
On 7/6/2022 6:09 PM, Yao, Jiewen wrote:
Merged https://github.com/tianocore/edk2/pull/3050
*From:* Kun Qin
*Sent:* Thursday, July 7, 2022 1:44 AM
*To:* devel@edk2.groups.io; Yao, Jiewen
*Cc:* Wang, Jian J ; Xu, Min M
; Sean Brogan ; Ard
Biesheuvel ;
Mateusz:
To be compatible, I suggest to add one new UefiDevicePathLibPeim.inf for
PEIM module. It will be same to UefiDevicePathLibStandaloneMm.inf except for
module type and base name.
The source file rename is the compatible change. It can be made.
Thanks
Liming
> -邮件原件-
> 发件人:
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Robert Kowalewski
> 发送时间: 2022年7月6日 21:48
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jenny
> Huang ; Sheng Wei
> 主题: [PATCH] MdePkg/include: Update DMAR definitions to Intel VT-d spec
> ver4.0
>
> Updated D
Sami:
I suggest to keep EFI_ACPI_IO_REMAPPING_TABLE_REVISION. Its value can be
EFI_ACPI_IO_REMAPPING_TABLE_REV5, because the structure has been updated, such
as EFI_ACPI_6_0_IO_REMAPPING_RC_NODE.
Compared to the previous version, EFI_ACPI_6_0_IO_REMAPPING_RC_NODE struct is
larger. Does t
Can we always enable CRYPTO_ENABLE?
If yes, can we remove the macro?
> -Original Message-
> From: Hsieh, PaytonX
> Sent: Thursday, July 7, 2022 10:35 AM
> To: devel@edk2.groups.io
> Cc: Hsieh, PaytonX ; Dong, Guo ;
> Ni, Ray ; Lu,
> James ; Guo, Gua
> Subject: [PATCH] UefiPayloadPkg: Ad
On Wed, Jul 6, 2022 at 11:57 AM Sami Mujawar wrote:
>
> Bugzilla: 3458 - Add support IORT Rev E.d specification updates
> (https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
>
> The IO Remapping Table, Platform Design Document, Revision E.d,
> Feb 2022 (https://developer.arm.com/docume
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974
CcProbeLib once was designed to probe the Confidential Computing guest
type by checking the PcdOvmfWorkArea. But this memory is allocated with
either EfiACPIMemoryNVS or EfiBootServicesData. It cannot be accessed
after ExitBootService. Please
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974
CcProbeLib once was designed to probe the Confidential Computing guest
type by checking the PcdOvmfWorkArea. But this memory is allocated with
either EfiACPIMemoryNVS or EfiBootServicesData. It cannot be accessed
after ExitBo
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974
SecPeiCcProbeLib is designed to probe the Confidential Computing guest
type in SEC/PEI phase. The CC guest type was set by each CC guest at
the beginning of boot up and saved in PcdOvmfWorkArea.
Cc: Erdem Aktas
Cc: James Bo
49 matches
Mail list logo
