[edk2-devel] [PATCH 1/3] UefiPayloadPkg: Simplify code logic

A little overdesign about VisitAllPciInstances function, since there are two call back functions. Simplify the code logic by combining the two call back functions. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Zhiguang Liu --- .../PlatformBootManager

[edk2-devel] [PATCH 0/3] UefiPayloadPkg: Enhance the logic to add ConIn and ConOut

Fix the bug that in some platform, there is no serial output or graphics output. Code passed open CI, and pleae check in https://github.com/tianocore/edk2/pull/2864 Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Zhiguang Liu Zhiguang Liu (3): UefiP

[edk2-devel] [PATCH 2/3] UefiPayloadPkg: Add Serial IO device path according to related protocol

Current code follow some rules to check if the PCI device connected to a serial port device, but some platform or hardware doesn't follow such rule. By locating gEfiSerialIoProtocolGuid protocol, we can find the related device path. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: S

[edk2-devel] [PATCH 3/3] UefiPayloadPkg: Connect all root bridge in PlatformBootManagerBeforeConsole

Some ConIn or ConOut device may not in the first root bridge, so connect all root bridge before detect ConIn and ConOut device. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Zhiguang Liu --- .../PlatformBootManagerLib.inf| 1 + .../

[edk2-devel] [PATCH V4 0/5] CryptoPkg/openssl: Enable EC conditionally.

Recommend from Gerd: (2) Keep the EC config option, but update process_files.pl to automatically add the PcdEcEnabled config option handling to the files it generates. This patch set does (2). When remove 'no-ec' from openssl configure list, will automatically remove 'OPENSSL_NO_EC', 'OPENSS

[edk2-devel] [PATCH V4 1/5] CryptoPkg: Rename PCD about openssl EC configuration

PcdOpensslXXXEnabled is a more appropriate choice. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/CryptoPkg.dec | 2 +- .../Library/BaseCryptLib/BaseCryptLib.inf | 2 +- .../Library/BaseCryptLib/PeiCryptLib.inf

[edk2-devel] [PATCH V4 2/5] CryptoPkg: Separate auto-generated openssl config and edk2 openssl config

Move auto-generated openssl config to openssl/opensslconf_generated, And openssl/opensslconf.h will contain both edk2 conditional openssl feature and openssl/opensslconf_generated. Will make two part more clear. New conditional feture code in opensslconf.h will look like: /* Autogenerated condit

[edk2-devel] [PATCH V4 3/5] CryptoPkg: Update process_files.pl to automatically add PCD config option

Recommend from Gerd: (2) Keep the EC config option, but update process_files.pl to automatically add the PcdEcEnabled config option handling to the files it generates. When remove 'no-ec' from openssl configure list, will automatically remove 'OPENSSL_NO_EC', 'OPENSSL_NO_ECDH', 'OPENSSL_NO_ECD

[edk2-devel] [PATCH V4 4/5] CryptoPkg/openssl: update generated files

Run process_files.pl with the current openssl submodule version. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Gerd Hoffmann --- CryptoPkg/Library/Include/crypto/dso_conf.h | 7 +- .../Library/Include/openssl/opensslconf.h | 17 ++ .../Inclu

[edk2-devel] [PATCH V4 5/5] CryptoPkg/openssl: disable codestyle checks for generated files

Files generated by process_files.pl from openssl sources should not be checked for edk2 code style. Signed-off-by: Gerd Hoffmann Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/CryptoPkg.ci.yaml | 14 +- 1 file changed, 13 insert

Re: [edk2-devel] [PATCH 1/3] UefiPayloadPkg: Simplify code logic

> > +DetectAndPreparePlatformPciDevicePath ( > >IN EFI_HANDLE Handle, > >IN VOID*Instance, > >IN VOID*Context Is "Context" needed? Can you please remove it? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (

Re: [edk2-devel] [PATCH V4 0/5] CryptoPkg/openssl: Enable EC conditionally.

Series reviewed-by: Jiewen Yao > -Original Message- > From: Li, Yi1 > Sent: Tuesday, May 10, 2022 3:19 PM > To: devel@edk2.groups.io > Cc: Li, Yi1 ; Yao, Jiewen ; Wang, Jian > J ; Lu, Xiaoyu1 ; Jiang, Guomin > ; Gerd Hoffmann > Subject: [PATCH V4 0/5] CryptoPkg/openssl: Enable EC condit

[edk2-devel] [PATCH edk2-platforms 1/1] Silicon/SynQuacer/Fip006Dxe: Support 4-bytes address for erase and write

From: Kazuhiko Sakamoto Support 4-bytes address for erase and write, so that we can access whole region of SPI-NOR Flash(64MiB) implemented on the Developerbox. This commit also fixes the wrong macro name. SPINOR_OP_SE and SPINOR_OP_SE_4B is the commoand for 64KB block erase, it must be SPINOR_O

[edk2-devel] "FceFmmt2022" branch on edk2-staging

Hello, The "FceFmmt2022" branch was created on edk2-staging repository. https://github.com/tianocore/edk2-staging/tree/FceFmmt2022. This branch is based on the edk2 SHA-1: 0e31124877cc8bc0140a03ad3196f0d58b2fd966 and it's for resolving the conflict issues when downstream user cherry-pick the Fm

Re: [edk2-devel] [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image

On Mon, May 09, 2022 at 12:44:58PM +, Xu, Min M wrote: > Gerd & Tom > What are your comments about this patch-set? > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 > > > > Above BZ reports an issue that commit 88da06ca triggers ASSERT in some > > scenario. This patch-set is to fi

Re: [edk2-devel] [PATCH 0/5] CryptoPkg/openssl: enable EC unconditionally.

On Mon, May 09, 2022 at 09:41:02AM -0400, James Bottomley wrote: > On Mon, 2022-05-09 at 12:03 +, Yao, Jiewen wrote: > > It is possible to switch to other crypt lib. > > > > For example, the *mbedtls* version POC can be found at > > https://github.com/jyao1/edk2/tree/DeviceSecurity/CryptoMbed

Re: [edk2-devel] [PATCH V2 2/5] CryptoPkg: Separate auto-generated openssl config and edk2 openssl config

On Tue, May 10, 2022 at 12:40:13PM +0800, Yi Li wrote: > Move auto-generated openssl config to opensslconf_generated.h, > And opensslconf.h will contain both edk2 conditional openssl > feature and opensslconf_generated.h. > Will make two part more clear. > New conditional feture code in opensslco

Re: [edk2-devel] [PATCH 0/5] CryptoPkg/openssl: enable EC unconditionally.

> I'm wondering where the crypto algorithm selection in > CryptoPkg/CryptoPkg.dsc comes from though, specifically for > MIN_DXE_MIN_SMM. Why is the crypto feature selection identical > for DXE and SMM? Specifically why TLS is enabled for SMM? [Jiewen] So far, I don't know if any SMM feature requ

Re: [edk2-devel] [PATCH V2 2/5] CryptoPkg: Separate auto-generated openssl config and edk2 openssl config

Just for convenience. There are too many places need to configure, so I think putting all the configuration options close together, all in process_file.pl, will be more clear to user ;) Thank you, Yi -Original Message- From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann Sent: Tuesd

[edk2-devel] [PATCH 1/4] OvmfPkg: CloudHv: Fix FW_BASE_ADDRESS

From: Sebastien Boeuf The FW_BASE_ADDRESS value provided by OvmfPkgDefines.fdf.inc is incorrect for the CloudHv target. We know the generated firmware contains a PVH ELF header, meaning it will be loaded according to the address provided through this header. And since we know this address isn't g

[edk2-devel] [PATCH 0/4] OvmfPkg: CloudHv: Reduce PIO and MMIO accesses

From: Sebastien Boeuf The goal of this series is to reduce the amount of inappropriate PIO and MMIO accesses generated by the firmware when running on Cloud Hypervisor. For MMIO accesses, it is about providing the right base address where the firmware will be loaded by the VMM in order to avoid

[edk2-devel] [PATCH 3/4] OvmfPkg: CloudHv: Rely on QemuFwCfgLibNull implementation

From: Sebastien Boeuf Since Cloud Hypervisor doesn't support the fw_cfg mechanism, it's more appropriate to rely on QemuFwCfgLibNull implementation of QemuFwCfgLib since it provides a null implementation that will not issue any PIO accesses to ports 0x510 and 0x511. Signed-off-by: Sebastien Boeu

[edk2-devel] [PATCH 4/4] OvmfPkg: Don't access A20 gate register on Cloud Hypervisor

From: Sebastien Boeuf Since Cloud Hypervisor doesn't emulate an A20 gate register on I/O port 0x92, it's better to avoid accessing it when the platform is identified as Cloud Hypervisor. Signed-off-by: Sebastien Boeuf --- OvmfPkg/Library/PlatformInitLib/Platform.c | 4 +++- 1 file changed, 3 i

[edk2-devel] [PATCH 2/4] OvmfPkg: Check for QemuFwCfg availability before accessing it

From: Sebastien Boeuf There are few places in the codebase assuming QemuFwCfg will be present and supported, which can cause some issues when trying to rely on the QemuFwCfgLibNull implementation of QemuFwCfgLib. Signed-off-by: Sebastien Boeuf --- OvmfPkg/Library/PlatformInitLib/Platform.c

[edk2-devel] EDKII CI is broken

Hi Seam/Mike The EDKII CI is broken. All CI fail on PlatformCI_OvmfPkg_Windows_VS2019_PR . For example: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=50537&view=logs&j=47cf355a-6eb4-51a8-46a8-ff4028bfcac0&t=f601237e-b16c-5795-7d4b-f60359758ac0&l=98 Could someone help to take a l

Re: [edk2-devel] [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image

On 5/9/22 18:37, Xu, Min M wrote: On May 10, 2022 1:30 AM, Tom Lendacky wrote: On 5/9/22 07:44, Xu, Min M wrote: Gerd & Tom What are your comments about this patch-set? Hi Min, This appears to resolve the issue. I was able to boot a 64 vCPU guest in legacy, SEV, SEV-ES and SEV-SNP modes wit

Re: [edk2-devel] [PATCH 0/5] CryptoPkg/openssl: enable EC unconditionally.

On Tue, 2022-05-10 at 12:40 +0200, Gerd Hoffmann wrote: > On Mon, May 09, 2022 at 09:41:02AM -0400, James Bottomley wrote: > > On Mon, 2022-05-09 at 12:03 +, Yao, Jiewen wrote: > > > It is possible to switch to other crypt lib. > > > > > > For example, the *mbedtls* version POC can be found at

Re: [edk2-devel] [PATCH 0/4] Refactor MpInitLib

On 5/9/22 18:16, Ni, Ray wrote: https://github.com/niruiyu/edk2/tree/refactormp

Re: 回复: [edk2-devel] [PATCH v5 0/8] Add Variable Flash Info HOB

What's the plan for next steps? The v5 PR has been up for two weeks with no changes. Are we going to try to define a long-term pattern for how to include new library classes in core packages or merge the patch series? Thanks, Michael On 5/5/2022 9:52 PM, Michael Kubacki wrote: I still believ

Re: [edk2-devel] [PATCH 0/4] Refactor MpInitLib

On 5/10/22 09:44, Tom Lendacky wrote: On 5/9/22 18:16, Ni, Ray wrote: https://github.com/niruiyu/edk2/tree/refactormp

Re: [edk2-devel] [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image

On 5/9/22 18:37, Xu, Min M wrote: On May 10, 2022 1:30 AM, Tom Lendacky wrote: On 5/9/22 07:44, Xu, Min M wrote: Gerd & Tom What are your comments about this patch-set? Hi Min, This appears to resolve the issue. I was able to boot a 64 vCPU guest in legacy, SEV, SEV-ES and SEV-SNP modes

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Add support for VariableFlashInfoLib

Another reminder to review this patch. Thanks, Michael On 4/29/2022 4:08 PM, Michael Kubacki wrote: Please help review this patch when possible. Thanks, Michael On 4/22/2022 10:02 AM, Michael Kubacki wrote: Reminder to review this patch. On 4/18/2022 7:43 PM, Michael Kubacki wrote: From:

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

Another reminder to look at this patch. Thanks, Michael On 4/29/2022 4:07 PM, Michael Kubacki wrote: Another reminder to merge this series. Chasel has added his review and that is in this branch: https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1

Re: [edk2-devel] [PATCH V7 36/37] UefiCpuPkg: Setting initial-count register as the last step

On 2/28/22 01:21, Min Xu via groups.io wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 Per SDM, changing the mode of APIC timer (from one-shot to periodic or vice versa) by writing to the timer LVT entry does not start the timer. To start the timer, it is necessary to write to the

Re: [edk2-devel] [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image

On May 10, 2022 5:27 PM, Gerd Hoffmann wrote: > On Mon, May 09, 2022 at 12:44:58PM +, Xu, Min M wrote: > > Gerd & Tom > > What are your comments about this patch-set? > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 > > > > > > Above BZ reports an issue that commit 88da06ca tri

Re: [edk2-devel] [PATCH 1/3] UefiPayloadPkg: Simplify code logic

Hi Ray, The function DetectAndPreparePlatformPciDevicePath is the second parameter of VisitAllInstancesOfProtocol. It follows the below type: typedef EFI_STATUS (EFIAPI *PROTOCOL_INSTANCE_CALLBACK)( IN EFI_HANDLEHandle, IN VOID *Instance, IN VOID *

Re: [edk2-devel] [PATCH V7 36/37] UefiCpuPkg: Setting initial-count register as the last step

On May 11, 2022 4:30 AM, Tom Lendacky wrote: > On 2/28/22 01:21, Min Xu via groups.io wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 > > > > Per SDM, changing the mode of APIC timer (from one-shot to periodic or > > vice versa) by writing to the timer LVT entry does not start th

[edk2-devel] [edk2:PATCH] MdePkg/Acpi62: Add type 7 NFIT Platform Capabilities Structure support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3915 This commit adds a definition type 7 Platform Capabilities Structure for NFIT Table Structure Types. The type has been added since ACPI Specification Version 6.2A. Signed-off-by: Miki Shindo Cc: Michael D Kinney Cc: Liming Gao Cc: Zhigu