Re: [edk2-devel] [PATCH 1/1] MdePkg: Add WPA3 related TLS configure macro

2022-05-06 Thread yi1 li
Hi Jiewen, 1) {0x13, *} is defined in TLS1.3 Due to TlsLib in edk2 is not fully support TLS1.3, I think I need to remove 1.3 cipher suite to avoid confusion. 2) 3) Although it is not absolutely required, I highly recommend to add specific value to TLS_HASH_ALGO, to align with definition

Re: [edk2-devel] [PATCH v3 05/10] MdePkg/CompilerIntrinsicsLib: copy over intrinsics from edk2-libc repo

2022-05-06 Thread Gerd Hoffmann
On Thu, May 05, 2022 at 01:10:12PM +0100, Leif Lindholm wrote: > On Thu, May 05, 2022 at 12:23:18 +0200, Gerd Hoffmann wrote: > > On Thu, May 05, 2022 at 10:50:27AM +0100, Leif Lindholm wrote: > > > ...I think these files should also be given the SPDX treatment, and > > > while doing that have the

Re: [edk2-devel] [PATCH v2] MdeModulePkg/XhciDxe: Add access xHCI Extended Capabilities Pointer

2022-05-06 Thread Wu, Hao A
Please refer to the inline comments below: > -Original Message- > From: Chiu, Ian > Sent: Monday, April 25, 2022 9:45 PM > To: devel@edk2.groups.io > Cc: Chiu, Ian ; Huang, Jenny ; > Shih, More ; Wu, Hao A ; Ni, Ray > > Subject: [PATCH v2] MdeModulePkg/XhciDxe: Add access xHCI Extended

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg: Add README for TDVF

2022-05-06 Thread Yao, Jiewen
Merged https://github.com/tianocore/edk2/pull/2858 > -Original Message- > From: Xu, Min M > Sent: Wednesday, May 4, 2022 8:14 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Brijesh Singh ; > Aktas, Erdem ; Gerd Hoffmann > ; James Bottomley ; Yao, Jiewen > ; Tom Lendacky > Subject: [PATC

[edk2-devel] [PATCH] UefiPayloadPkg: Fix the build failure

2022-05-06 Thread duntan
Add double quotes to LlvmObjcopyPath. Blank space in LlvmObjcopyPath will cause build failure. This build failure is introduced by 2306555bf908 ( "UefiPayloadPkg: Fix IA32 entry build failure"). Signed-off-by: Dun Tan Cc: Ray Ni Cc: Guo Dong Cc: Benjamin You Cc: Sean Rhodes --- UefiPayloadPk

[edk2-devel] TianoCore Community Meeting 20220505 APAC/NAMO

2022-05-06 Thread Demeter, Miki
**Highlights:** - Coverity update from Felix - GSOC – 7 Prospects going through ranking and rating Should know near the end of May. # Meeting Minutes: 1) **Event Updates (_5 minutes]** - **No Event Updates ** 2) [**Stable Tag Updates (_5 minutes_)** - Soft Freeze - 2022-05-9 - Hard freeze - 2

[edk2-devel] [PATCH] MdeModulePkg/PCD: Pcd initialize DXE have assert

2022-05-06 Thread guo . guo
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3917 When PlatformPkg.dsc has multiple SKU IDs but didn't exist delta PCD, System will hang on BuildPcdDxeDataBase. Ideally, if didn't exist delta PCD by different SKU ID, UpdatePcdDatabase () shouldn't return EFI_NOT_FOUND. Sig

[edk2-devel][edk2-platforms][PATCH V2 0/1] Add PlatformPayloadPkg

2022-05-06 Thread Guo Dong
From: Guo Dong changes from patch V1: a) Change package name from PayloadPlatformPkg to PlatformPayloadPkg b) Put PlatformPayloadPkg to Features/Intel instead of Platform/Intel c) Reuse DSC/FDF files from MinPlatforms d) Following Features orgnaizaion updated AdvancedFeaturePkg DSC/FDF e) Updated

Re: [edk2-devel] [PATCH 4/6] OvmfPkg/Sec: Install MpInitLibDepLib PPIs in SecMain.c

2022-05-06 Thread Min Xu
On May 6, 2022 1:04 PM, Ni Ray wrote: > > > > -EFI_PEI_PPI_DESCRIPTOR mPrivateDispatchTable[] = { > > +EFI_PEI_PPI_DESCRIPTOR mPrivateDispatchTableMp[] = { > >{ > > (EFI_PEI_PPI_DESCRIPTOR_PPI | > > EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST), > > EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST should

Re: [edk2-devel] [PATCH 6/6] OvmfPkg: Enable 2 different CpuMpPei and CpuDxe drivers

2022-05-06 Thread Min Xu
On May 6, 2022 1:07 PM, Ni Ray wrote: > > > > +DEFINE MP_CPU_DXE_GUID = 2d73044a-1df3-415d-b054-17fe05765c3c > Can you remove the above GUID definition? > > > +DEFINE MP_CPU_PEI_GUID = 3dd59561-e4ea-4846-b7c5-c7b74a061190 > Can you remove the above GUID definition? > > > +DEFINE UP_CPU_PEI_GUID

[edk2-devel] [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image

2022-05-06 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 Above BZ reports an issue that commit 88da06ca triggers ASSERT in some scenario. This patch-set is to fix this issue. As commit 88da06ca describes TDVF BSP and APs are simplied and it can simply use MpInitLibUp instead of MpInitLib. To achie

[edk2-devel] [PATCH V2 2/6] OvmfPkg: Add MpInitLibDepLib related PPI/Protocol definitions

2022-05-06 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 MpInitLibDepLib is a set of libraries which depend on PPI/Protocol. This patch defines the related PPI/Protocols in OvmfPkg. Cc: Eric Dong Cc: Ray Ni Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky

[edk2-devel] [PATCH V2 1/6] UefiCpuPkg: Revert "UefiCpuPkg: Enable Tdx support in MpInitLib"

2022-05-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 This reverts commit 88da06ca763eb6514565c1867a801a427c1f3447. This commit triggers the ASSERT in Non-Td guest. Cc: Eric Dong Cc: Ray Ni Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lenda

[edk2-devel] [PATCH V2 4/6] OvmfPkg/Sec: Install MpInitLibDepLib PPIs in SecMain.c

2022-05-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 Td guest should use MpInitLibUp, other guest use the MpInitLib. So in SecMain.c different PPI is installed according to the working guest type. Cc: Eric Dong Cc: Ray Ni Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottoml

[edk2-devel] [PATCH V2 3/6] OvmfPkg: Add MpInitLibDepLib

2022-05-06 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 There are 4 MpInitLibDepLib: - PeiMpInitLibMpDepLib: MpInitLib multi-processor dependency - PeiMpInitLibUpDepLib: MpInitLib unique-processor dependency - DxeMpInitLibMpDepLib: MpInitLib multi-processor dependency - DxeMpInitLibUp

[edk2-devel] [PATCH V2 5/6] OvmfPkg/TdxDxe: Install MpInitLibDepLib protocols

2022-05-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 In Td guest CpuDxe driver uses the MpInitLibUp, the other guest type use the MpInitLib. So we install different Protocols according to the current working guest type. Cc: Eric Dong Cc: Ray Ni Cc: Brijesh Singh Cc: Erdem A

[edk2-devel] [PATCH V2 6/6] OvmfPkg: Enable 2 different CpuMpPei and CpuDxe drivers

2022-05-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 In OvmfPkgX64 we enable 2 different CpuMpPei and CpuDxe drivers. The difference between the drivers is the MpInitLib or MpInitLibUp. This is acomplished by adding a MpInitLibDepLib. In IntelTdxX64 we enable 2 versions of Cpu

[edk2-devel] [PATCH v2] PcAtChipsetPkg: Change the flow of PcRtcInit()

2022-05-06 Thread Zhuoran Chao
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3913 The original flow of PcRtcInit() is like: 1. Guarantee atomic accesses to the RTC time registers and read out the value. 2. Program RTC register B. (adopt 12h mode or 24h mode. Current bios code sets RTC to 24h mode by default). 3. Then

[edk2-devel] [Patch V2] UefiPayloadPkg: Fix the UPL build failure

2022-05-06 Thread duntan
Add double quotes to LlvmObjcopyPath. Blank space in LlvmObjcopyPath will cause build failure. This build failure is introduced by 2306555bf908 ( "UefiPayloadPkg: Fix IA32 entry build failure"). Signed-off-by: Dun Tan Cc: Ray Ni Cc: Guo Dong Cc: Benjamin You Cc: Sean Rhodes --- UefiPayloadPk

Re: [edk2-devel] [PATCH V2 1/6] UefiCpuPkg: Revert "UefiCpuPkg: Enable Tdx support in MpInitLib"

2022-05-06 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Xu, Min M > Sent: Saturday, May 7, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Dong, Eric ; Ni, Ray > ; Brijesh Singh > ; Aktas, Erdem ; James > Bottomley ; Yao, Jiewen > ; Tom Lendacky ; Gerd Hoffmann > > Subject: [PATCH

Re: [edk2-devel] [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image

2022-05-06 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Xu, Min M > Sent: Saturday, May 7, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Dong, Eric ; Ni, Ray > ; Brijesh Singh > ; Aktas, Erdem ; James > Bottomley ; Yao, Jiewen > ; Tom Lendacky ; Gerd Hoffmann > > Subject: [PATCH

Re: [edk2-devel] [PATCH v2] PcAtChipsetPkg: Change the flow of PcRtcInit()

2022-05-06 Thread Ni, Ray
> - if ((Time->Hour & 0x80) != 0) { > -IsPM = TRUE; > - } else { > -IsPM = FALSE; > + // Check 24-hour format situation > + if (RegisterB.Bits.Mil == 1) { > +if (RegisterB.Bits.Dm == 0) { > + if (Time->Hour > 0x23) { > +return EFI_INVALID_PARAMETER; > + } > +}