Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-06 Thread Corvin Köhne
Any comments from bhyve folks on that? Best regards Corvin Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 -Original Message- From: Corvin Köhne Sent: Tuesday, March 29, 2022 12:14

Re: [edk2-devel] [PATCH edk2 v3 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2022-04-06 Thread Sami Mujawar
Hi Ming, I am not sure if this is an issue at my end, but I cannot apply this patch series, can you check, please? Also, is it possible to share these patches on a Github branch. Regards, Sami Mujawar On 30/03/2022, 10:37, "Ming Huang" wrote: Hi, Any comment about this series?

Re: [edk2-devel] [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on UefiCpuLib.

2022-04-06 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Wednesday, April 6, 2022 11:42 AM To: Pu, Yu ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star Subject: RE: [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on UefiCpuLib. Thanks

Re: [edk2-devel] [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib

2022-04-06 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Wednesday, April 6, 2022 11:42 AM To: Pu, Yu ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star Subject: RE: [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib Thanks Yu! Rev

[edk2-devel] [PATCH] UefiPayloadPkg: Fix bug that Elf loader doesn't relocate in some case

2022-04-06 Thread Zhiguang Liu
Current implementation of the Elf loader reuses the same memory range if the desired memory range is covered by [file base, file base + file size]. However, there is a potentil bug, for example: If the first segment is located at 0x1000, and the desired address is 0x2000. While the second segment i

Re: [edk2-devel][PATCH v2 2/8] IntelFsp2Pkg: Add FSPx_ARCH2_UPD support for X64

2022-04-06 Thread Chiu, Chasel
Hi Ted, Please see my comments inline below. Thanks, Chasel > -Original Message- > From: Kuo, Ted > Sent: Monday, April 4, 2022 2:23 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S, > Ashraf Ali > Subject: [edk2-devel][PATCH v2 2/8] IntelFs

Re: [edk2-devel][PATCH v2 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

2022-04-06 Thread Chiu, Chasel
Hi Ted, Please see my comments inline below. Thanks, Chasel > -Original Message- > From: Kuo, Ted > Sent: Monday, April 4, 2022 2:23 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S, > Ashraf Ali > Subject: [edk2-devel][PATCH v2 1/8] Inte

Re: [edk2-devel][PATCH v2 2/8] IntelFsp2Pkg: Add FSPx_ARCH2_UPD support for X64

2022-04-06 Thread Chiu, Chasel
One more comments. Thanks, Chasel > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, April 6, 2022 10:40 PM > To: Kuo, Ted ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star > ; S, Ashraf Ali > Subject: RE: [edk2-devel][PATCH v2 2/8] IntelFsp2Pkg: Add > FSPx_ARCH

Re: [edk2-devel][PATCH v2 8/8] IntelFsp2WrapperPkg: SecFspWrapperPlatformSecLibSample support for X64

2022-04-06 Thread Chiu, Chasel
HI Ted, Please see my comments below inline. Thanks, Chasel > -Original Message- > From: Kuo, Ted > Sent: Monday, April 4, 2022 2:23 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S, > Ashraf Ali > Subject: [edk2-devel][PATCH v2 8/8] IntelF

[edk2-devel] [PATCH v1 0/3] Add Variable Flash Info HOB

2022-04-06 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm, VariableStandaloneMm, etc. (and their dependent protocol/library stack), typically acquire UEFI variable store flash information with PCDs declared in

[edk2-devel] [PATCH v1 1/3] MdeModulePkg: Add Variable Flash Info HOB

2022-04-06 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds a new GUID that is used to identify a HOB that passes variable flash information to UEFI variable drivers in HOB consumption phases such as DXE, Traditional MM, and Standalone MM. This information was previously

[edk2-devel] [PATCH v1 2/3] MdeModulePkg/Variable: Consume Variable Info HOB

2022-04-06 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Updates VariableRuntimeDxe, VariableSmm, and VariableStandaloneMm to acquire variable flash information from the Variable Flash Information HOB. If the HOB is not present, the drivers will continue to directly read fl

[edk2-devel] [PATCH v1 3/3] MdeModulePkg/FaultTolerantWrite: Consume Variable Info HOB

2022-04-06 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds support to the UEFI variable fault tolerant write (FTW) drivers to receive FTW base and size information dynamically via the Variable Flash Information HOB. This supplements support added earlier for the variable

[edk2-devel][PATCH v3 2/8] IntelFsp2Pkg: Add FSPx_ARCH2_UPD support for X64

2022-04-06 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 1.Added FSPx_ARCH2_UPD structures which support both IA32 and X64. 2.Added FSPx_UPD_COMMON_FSP24 structures. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo --- IntelFsp2Pkg/FspSecCore/Ia32/FspApi

[edk2-devel][PATCH v3 3/8] IntelFsp2Pkg: Update FSP_GLOBAL_DATA and FSP_PLAT_DATA for X64

2022-04-06 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 Updated FSP_GLOBAL_DATA and FSP_PLAT_DATA structures to support both IA32 and X64. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo --- IntelFsp2Pkg/FspSecCore/SecFsp.c | 2 +- IntelFsp2Pkg/In

[edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

2022-04-06 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 1.Added EFIAPI to FspNotifyPhasePeimEntryPoint. 2.Changed AsmReadEsp to AsmReadStackPointer. 3.Changed the type of the return value of AsmReadStackPointer from UINT32 to UINTN. 4.Changed the type of TemporaryMemoryBase, PermenentMemoryBase

[edk2-devel][PATCH v3 0/8] Support PEI 64bit in IntelFsp2Pkg and IntelFsp2WrapperPkg

2022-04-06 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 Currently PEI drivers/libraries only support 32bit in IntelFsp2Pkg and IntelFsp2WrapperPkg. The patches below are needed to support these drivers/libraries in 64bit. V2 changes: 1.Change FSPM_UPD_COMMON2 to FSPM_UPD_COMMON_FSP24 in FspApiEnt

[edk2-devel][PATCH v3 5/8] IntelFsp2Pkg: SecFspSecPlatformLibNull support for X64

2022-04-06 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 1.Added SecFspSecPlatformLibNull support for X64. 2.Added X64 support to IntelFsp2Pkg.dsc. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo --- IntelFsp2Pkg/IntelFsp2Pkg.dsc |

[edk2-devel][PATCH v3 6/8] IntelFsp2WrapperPkg: Adopt FSPM_UPD_COMMON_FSP24 for X64

2022-04-06 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 Adopt FSPM_UPD_COMMON_FSP24 in FspmWrapperPeim to support X64. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo --- .../FspmWrapperPeim/FspmWrapperPeim.c | 25 ++ 1

[edk2-devel][PATCH v3 4/8] IntelFsp2Pkg: FspSecCore support for X64

2022-04-06 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 1.Added FspSecCore support for X64. 2.Bumped FSP header revision to 7 to indicate FSP 64bit is supported. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo --- IntelFsp2Pkg/FspSecCore/Fsp22SecCoreS.

[edk2-devel][PATCH v3 7/8] IntelFsp2WrapperPkg: BaseFspWrapperApiLib support for X64

2022-04-06 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 Add Execute64BitCode to execute 64bit code from long mode directly in PEI 64bit. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo --- .../BaseFspWrapperApiLib/FspWrapperApiLib.c| 42 +++

[edk2-devel][PATCH v3 8/8] IntelFsp2WrapperPkg: SecFspWrapperPlatformSecLibSample support for X64

2022-04-06 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 1.Added SecFspWrapperPlatformSecLibSample support for X64. 2.Adopted FSPT_ARCH2_UPD in SecFspWrapperPlatformSecLibSample. 3.Moved Fsp.h up one level to be shared across IA32 and X64. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashr

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-06 Thread Rebecca Cran
I seem to remember seeing previous feedback that Bhyve developers strongly preferred the BhyveFwCtl mechanism. I've been out of the loop though (busy with $dayjob) so I don't know if things have changed. Hopefully other people can provide feedback. -- Rebecca Cran On 4/6/22 01:00, Corvin Köhn

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-06 Thread Rebecca Cran
[re-posting from my personal email account, since my mail to freebsd-virtualization got rejected] I seem to remember seeing previous feedback that Bhyve developers strongly preferred the BhyveFwCtl mechanism. I've been out of the loop though (busy with $dayjob) so I don't know if things have c

[edk2-devel] edk2-libc Python Build issue

2022-04-06 Thread M.T.
Hello I am trying to build the Python environment for UEFI as per Py368ReadMe.txt. I am doing this on Ubuntu 20.04.4 LTS with GCC5 for X64, all instructions seem to be meant for windows and MSFT. I was able to build everything else and verify that it works, so I don't see why this should be an iss

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-06 Thread Peter Grehan
[re-posting from my personal email account, since my mail to > freebsd-virtualization got rejected]> > I seem to remember seeing previous feedback that Bhyve developers > strongly preferred the BhyveFwCtl mechanism. I've been out of the loop > though (busy with $dayjob) so I don't know if thing

Re: [edk2-devel] [edk2-platforms PATCH 0/8] Marvell Pp2Dxe fixes

2022-04-06 Thread Marcin Wojtas
Hi, pon., 14 mar 2022 o 16:38 Marcin Wojtas napisał(a): > > Hi, > > ES ACS v1.0 test suite (https://github.com/ARM-software/arm-systemready) > unveiled a number of issues in Pp2Dxe SNP callbacks. > This patchset fixes all of them and allow for > successful SCT tests run. > > For convenience, the

Re: [edk2-devel] [edk2-platforms PATCH] Marvell/SolidRun: Rework Readme.md files

2022-04-06 Thread Marcin Wojtas
Hi, pon., 14 mar 2022 o 18:17 Sunny Wang napisał(a): > > Looks good. Thanks much, Marcin. > > This will be helpful as http://wiki.macchiatobin.net/tiki-index.php has been > not accessible for quite a while. > > Reviewed-by: Sunny Wang > Do you have any feedback about the patch? Best regards,

Re: [edk2-devel] Applying for GSoC 2022: Add Rust Support to EDK II

2022-04-06 Thread Pedro Falcato
Hi Ayush! I had a decent look at your proposal, and I have some questions (note that you can always re-submit proposals until April 19th): 1) How are you planning to reconcile the cargo build system with EDK2's build system? 2) If you go ahead with cargo, will the new Rust code require a lot of

Re: [edk2-devel] [PATCH v2 0/3] BaseTools: Add support for gdb and lldb

2022-04-06 Thread Rebecca Cran
Could I have some more reviews on this please? I'd like to get this into the tree soon. -- Rebecca Cran On 3/21/22 14:20, Rebecca Cran wrote: This patch set adds debugging support for gdb and lldb. It also adds generic debugging classes that use a file like object to make it easy to import int

Re: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

2022-04-06 Thread Ni, Ray
> -; UINT32 > +; UINTN > ; EFIAPI > -; AsmReadEsp ( > +; AsmReadStackPointer ( > ; VOID > ; ); > > ;-- > -global ASM_PFX(AsmReadEsp) > -ASM_PFX(AsmReadEsp): > +global ASM_PFX(AsmReadStackPointer) > +ASM_PFX(AsmRead

Re: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

2022-04-06 Thread Andrew Fish via groups.io
> On Apr 6, 2022, at 4:57 PM, Ni, Ray wrote: > >> -; UINT32 >> +; UINTN >> ; EFIAPI >> -; AsmReadEsp ( >> +; AsmReadStackPointer ( >> ; VOID >> ; ); >> ;-- >> -global ASM_PFX(AsmReadEsp) >> -ASM_PFX(AsmReadEsp): >>

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix bug that Elf loader doesn't relocate in some case

2022-04-06 Thread Ni, Ray
> -Original Message- > From: Liu, Zhiguang > Sent: Wednesday, April 6, 2022 9:52 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice > ; You, Benjamin > ; Rhodes, Sean > Subject: [PATCH] UefiPayloadPkg: Fix bug that Elf loader doesn't relocate in > some case > > Cu

Re: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

2022-04-06 Thread Ni, Ray
> >> -; UINT32 > >> +; UINTN > >> ; EFIAPI > >> -; AsmReadEsp ( > >> +; AsmReadStackPointer ( > >> ; VOID > >> ; ); > >> ;-- > >> -global ASM_PFX(AsmReadEsp) > >> -ASM_PFX(AsmReadEsp): > >> +global ASM_PFX(AsmReadStackP

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC

2022-04-06 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, March 22, 2022 6:28 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libr

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Fix mis-parsed HSTI structures

2022-04-06 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, March 22, 2022 6:11 PM To: devel@edk2.groups.io Cc: Bret Barkelew ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/T

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC

2022-04-06 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/edf5edf -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, March 22, 2022 6:28 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/TestPointCheckLib: Fix mis-parsed HSTI structures

2022-04-06 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/170f455 -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, March 22, 2022 6:11 PM To: devel@edk2.groups.io Cc: Bret Barkelew ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-pl

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix bug that Elf loader doesn't relocate in some case

2022-04-06 Thread Zhiguang Liu
Sorry, it is a typo. the example should be The first segment is located at 0x1000, and the desired address is 0x2000. The second segment is located at 0x2000, and the desired address is 0x1000. The current ELF loader may copy first segment to 0x2000, which will erase the second segment. Thanks Z

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 03/33] NetworkPkg: Add LOONGARCH64 architecture for EDK2 CI.

2022-04-06 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:52 PM > To: devel@edk2.groups.io > Cc: Maciej Rabeda ; Jiaxin Wu > ; Siyuan Fu > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 03/33] > NetworkPk

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 04/33] NetworkPkg/HttpBootDxe: Add LOONGARCH64 architecture for EDK2 CI.

2022-04-06 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:52 PM > To: devel@edk2.groups.io > Cc: Maciej Rabeda ; Jiaxin Wu > ; Siyuan Fu > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 04/33] > NetworkPk

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 00/33] Add a new architecture called LoongArch in EDK II

2022-04-06 Thread Abner Chang
Hi Li, I found there is no 9/33 of the RESEND patch. Is that I miss it? Regards, Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:51 PM > To: devel@edk2.groups.io > Cc: Ray Ni ; Liming Gao ; > Michael D Kinney ; Guomin Jian

Re: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

2022-04-06 Thread Kuo, Ted
Hi Ray, Please see my inline comment. Thanks, Ted -Original Message- From: Ni, Ray Sent: Thursday, April 7, 2022 7:58 AM To: devel@edk2.groups.io; Kuo, Ted Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star ; S, Ashraf Ali Subject: RE: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X6

Re: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

2022-04-06 Thread Kuo, Ted
Hi Andrew, Please see my inline comment. Thanks, Ted -Original Message- From: Andrew Fish Sent: Thursday, April 7, 2022 8:06 AM To: devel@edk2.groups.io; Ni, Ray Cc: Kuo, Ted ; Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star ; S, Ashraf Ali Subject: Re: [edk2-devel][PATCH v3 1/8]

[edk2-devel] Add PrmPkg to Bugzilla

2022-04-06 Thread Michael Kubacki
Hi Mike, Can you please add PrmPkg as a package to the edk2 product on Bugzilla? Thanks, Michael -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88496): https://edk2.groups.io/g/devel/message/88496 Mute This Topic: https://groups.io/mt/

Re: [edk2-devel] [PATCH-V2] Fix Setup numeric default value incorrect issue

2022-04-06 Thread Chen Lin Z
@Gao, Liming, Any comment about patch V2 ? we need to this patch to fix our issues, Pls help review it. Thanks, Lin -Original Message- From: Chen, Lin Z Sent: Friday, April 1, 2022 2:09 PM To: Wang, Jian J ; Gao, Liming ; Bi, Dandan ; Dong, Eric ; devel@edk2.groups.io Cc: Li, Zhua

Re: [edk2-devel] Add PrmPkg to Bugzilla

2022-04-06 Thread Michael D Kinney
Done. Mike > -Original Message- > From: Michael Kubacki > Sent: Wednesday, April 6, 2022 6:31 PM > To: Kinney, Michael D ; devel@edk2.groups.io > Subject: Add PrmPkg to Bugzilla > > Hi Mike, > > Can you please add PrmPkg as a package to the edk2 product on Bugzilla? > > Thanks, > Mich

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 05/33] CryptoPkg: Add LOONGARCH64 architecture for EDK2 CI.

2022-04-06 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Jiewen Yao ; Jian J Wang > ; Xiaoyu Lu ; Guomin Jiang > > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 06/33] MdePkg/Include: Add LOONGARCH related definitions EDK2 CI.

2022-04-06 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 06/33] > MdePkg/Include: Add LOON

Re: [edk2-devel] [PATCH v1 0/3] Add Variable Flash Info HOB

2022-04-06 Thread Wu, Hao A
Sorry for a question: GetVariableFlashInfo() seems being defined multiple times across modules, do you see value in abstracting it as a library API? Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Thursday, April 7, 2022 12:2

Re: [edk2-devel] [PATCH v1 2/3] MdeModulePkg/Variable: Consume Variable Info HOB

2022-04-06 Thread Wu, Hao A
One inline comment below: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Thursday, April 7, 2022 12:27 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Liming > Subject: [edk2-devel] [PATCH v1 2/3] MdeModulePkg/Variable: Con

Re: [edk2-devel] [PATCH v1 3/3] MdeModulePkg/FaultTolerantWrite: Consume Variable Info HOB

2022-04-06 Thread Wu, Hao A
Two minor inline comments: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Thursday, April 7, 2022 12:27 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Liming > Subject: [edk2-devel] [PATCH v1 3/3] MdeModulePkg/FaultToleran

[edk2-devel] 回复: [PATCH v2 0/3] BaseTools: Add support for gdb and lldb

2022-04-06 Thread gaoliming
Acked-by: Liming Gao > -邮件原件- > 发件人: Rebecca Cran > 发送时间: 2022年4月7日 6:34 > 收件人: devel@edk2.groups.io; Leif Lindholm ; > Michael D Kinney ; Hao A Wu > ; Bob Feng ; Liming Gao > ; Yuwei Chen > 抄送: Andrew Fish > 主题: Re: [PATCH v2 0/3] BaseTools: Add support for gdb and lldb > > Could I h

[edk2-devel] 回复: [PATCH-V2] Fix Setup numeric default value incorrect issue

2022-04-06 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Chen Lin Z > 发送时间: 2022年4月1日 14:09 > 收件人: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; > dandan...@intel.com; eric.d...@intel.com; devel@edk2.groups.io > 抄送: zhuangzhi...@intel.com; di.zh...@intel.com; Chen Lin Z > > 主题: [PATCH-V2] Fix Setup n

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-06 Thread Corvin Köhne
Hi Peter and Rebecca, thanks for your feedback. This patch is backward compatible. It checks if QemuFwCfg is available and if QemuFwCfg is missing it falls back to BhyveFwCtl. So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the commit message? Thanks Corvin Beckhoff Automation