WorkSpaceAddress and SpareAreaAddress point into MMIO, which isn't
always aligned. Remove the check for block alignment to avoid
false assertions.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Sean Rhodes
Change-Id: Ia1c1f44b6a0e7f32cac0d7806e74d729e5d83a6d
---
.../Universal/Faul
Hi Ray,
The reason why we use PeiDxeDebugLibReportStatusCode instead of
BaseDebugLibSerialPort is that
Base Debug library is based on Serial Port library, and it can only send debug
messages to serial port device, while SerialPort supports to print debug msg in
other places.
Thanks
Yuanhao
--
Reviewed-by: Jiewen Yao
Is this a standalone patch? Or one of a series patch?
I think it should be later. But, please enlighten me.
> -Original Message-
> From: Li, Zhihao
> Sent: Tuesday, March 29, 2022 2:38 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Justen,
Thanks for the explanation.
Reviewed-by: Ray Ni
> -Original Message-
> From: Xie, Yuanhao
> Sent: Friday, April 1, 2022 5:56 PM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Dong, Guo ; Ma, Maurice ; You,
> Benjamin ;
> Rhodes, Sean ; Liu, Zhiguang
> Subject: RE: [PATCH] UefiPayloadPkg: C
Reviewed-by: Lean Sheng Tan
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88324): https://edk2.groups.io/g/devel/message/88324
Mute This Topic: https://groups.io/mt/89991252/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: htt
RISC-V port will follow this implementation.
Acked-by: Abner Chang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yu Pu
> Sent: Tuesday, March 29, 2022 2:37 PM
> To: devel@edk2.groups.io
> Cc: Yu Pu
> Subject: [edk2-devel] [PATCH v1 00/15] Merge UefiCpuLib to CpuLib
>
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Yu Pu
---
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 +
IntelFsp2Pkg/FspSecCore/SecMain.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3394
Today lots of duplicated code call CPUID and calculates the address mask.
Adding an API named GetPhysicalAddressBits in UefiCpuLib can solve this
problem, but at the same time cause MdeModulePkg depend on UefiCpuPkg
which does not meet the
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Yu Pu
---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 1 +
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 1 +
2 files changed, 2 insertions(+)
diff --git a/IntelFsp2
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Yu Pu
---
OvmfPkg/Sec/SecMain.c | 1 +
OvmfPkg/Sec/SecMain.inf | 1 +
2 files changed, 2 insertions(+)
diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c
inde
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Yu Pu
---
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 1 +
UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 1 +
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
Signed-off-by: Yu Pu
---
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h| 1 +
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 1 +
UefiPayloadPkg/UefiPayload
Step 1 to merge UefiCpuLib to CpuLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Yu Pu
---
MdePkg/MdeLibs.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc
index 3c70daf87a0c..322575090239 100644
--- a/MdePkg/M
Since this is a new package, I am waiting for a steward to approve.
Please let me know if you have any questions.
Thanks,
Michael
On 3/22/2022 12:19 PM, Michael Kubacki wrote:
From: Michael Kubacki
This patch series adds a new package called PrmPkg. An RFC was sent
to the edk2 mailing list o
Thanks for the review.
Can you please merge this soon if there are no concerns?
On 3/23/2022 2:14 AM, Chiu, Chasel wrote:
Reviewed-by: Chasel Chiu
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Wednesday, March 23, 2022 9:11 AM
To: devel@edk2.groups.io
Cc: Bret Barkel
Thanks for the review.
Can you please merge this soon if there are no concerns?
On 3/23/2022 2:15 AM, Chiu, Chasel wrote:
Reviewed-by: Chasel Chiu
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Wednesday, March 23, 2022 9:28 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel
Could someone review these, and if they look good push them please?
Thanks.
Rebecca Cran
On 3/19/22 14:13, Rebecca Cran wrote:
I noticed Linux reports a firmware bug with the current Juno ACPI
tables. These patches fix it by reserving the ECAM area with a RES0
device, while also converting A
Hi Rebecca,
I will do this shortly.
Regards,
Sami Mujawar
On 01/04/2022, 15:51, "Rebecca Cran" wrote:
Could someone review these, and if they look good push them please?
Thanks.
Rebecca Cran
On 3/19/22 14:13, Rebecca Cran wrote:
> I noticed Linux reports a firmware b
Acked-by: Michael D Kinney
> -Original Message-
> From: Michael Kubacki
> Sent: Friday, April 1, 2022 7:11 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Kinney, Michael D
> ; Leif Lindholm
> Subject: Re: [edk2-devel] [PATCH v1 00/41] Add PrmPkg
>
> Since this is a new package, I a
I made it one series since the OvmfPkg patches are dependent on the
.pytool changes.
Let me know if you see a substantial advantage to split it up.
Regards,
Michael
On 3/22/2022 12:14 PM, Michael D Kinney wrote:
Hi Michael,
Should this be broken up into 2 series? One for pytool change and o
That is borrowed from a pattern used in other plugins. Example:
https://github.com/tianocore/edk2/blob/master/.pytool/Plugin/SpellCheck/SpellCheck.py#L160-#L161
I don't mind updating the plugins to do something different if that is
desired, but perhaps that should be a separate change.
Regards
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
This patch series:
1. Updates ignore handling in UncrustifyCheck including adding
a new CI plugin configuration option to ignore files in a package.
2. Reverts Un
From: Michael Kubacki
Currently, UncrustifyCheck._get_git_ignored_paths() is documented to
return a list of absolute file paths but it currently returns a list
of relative file paths.
This change updates the function to return a list of absolute file
paths. The result is later compared to the li
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880
Currently UncrustifyCheck.py provides the following exclusion
options:
1. Override the type of files UncrustifyCheck operates against by
default (.c and .h files). Using the "IgnoreStandardPaths"
configuration option.
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
The following files:
OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h
OvmfPkg/QemuVideoDxe/VbeShim.h
Are auto generated by the following generators:
OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.sh
OvmfPkg/QemuVideoDxe/VbeShim.sh
The
Hi Mike,
Sorry I missed this message earlier.I made the change as I understood it
in v2.
https://edk2.groups.io/g/devel/message/88342
Thanks,
Michael
On 3/22/2022 12:12 PM, Michael D Kinney wrote:
Hi Michael,
I meant to ask. Is there a reason you are not normalizing the
file paths os.path
Reviewed - by : Sean Brogan
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88347): https://edk2.groups.io/g/devel/message/88347
Mute This Topic: https://groups.io/mt/90183062/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: htt
for all reviewed-by jiewen@intel.com
thank you!
Yao, Jiewen
> 在 2022年4月2日，上午12:23，mikub...@linux.microsoft.com 写道：
>
> From: Michael Kubacki
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
>
> This patch series:
> 1.
Can you explain how this filename is used? Perhaps add a comment in this
series.
If this pattern is used in several places, then I agree that can be cleaned up
in a different patch series.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael Kubacki
> Sent: F
Hi Rebecca,
Apologies for the delay.
Pushed as e18e208e7105..1e5be97660c6
Regards,
Sami Mujawar
On 01/04/2022, 15:51, "Rebecca Cran" wrote:
Could someone review these, and if they look good push them please?
Thanks.
Rebecca Cran
On 3/19/22 14:13, Rebecca Cran wrote:
Yes, some patches in other Pkg.
Patch in UefiCpuPkg have been merged.
It provide a mode allow cpu which in SMM mode work without waiting for
other APs enter SMM mode.
And define a new service that can be used by SMI handler to optionally wait
for other APs to complete SMM rendezvous.
Pa
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
Pipelines are currently building against VS2019 and use the
"windows-latest" VM image in Azure Pipelines. The "windows-latest"
image recently moved its toolchain to VS2022, so VS2019 is no
longer found.
To immediately
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
The YAML file previously specified "windows-latest" which recently
moved to VS2022. To continue using VS2019 (at least in the short
term), the VM image needs to be explicitly set to "windows-2019".
Cc: Sean Brogan
Cc
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
The YAML file previously specified "windows-latest" which recently
moved to VS2022. To continue using VS2019 (at least in the short
term), the VM image needs to be explicitly set to "windows-2019".
Cc: Andrew Fish
Cc
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
The YAML file previously specified "windows-latest" which recently
moved to VS2022. To continue using VS2019 (at least in the short
term), the VM image needs to be explicitly set to "windows-2019".
Cc: Ard Biesheuvel
Given this is all CI related and the CI is down. I will offer my reviewed by
for the series.
Reviewed - by : Sean Brogan
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88356): https://edk2.groups.io/g/devel/message/88356
Mute This Topi
In regard to the "nofile.txt"
That parameter is used for reporting which file specified the ignore list.
This was a feature of the gitignore parser that was integrated but that
"report" is never used. Thus, in the additional api I added where I enabled
the ignore content in a parameter rather
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
This patch series:
1. Updates ignore handling in UncrustifyCheck including adding
a new CI plugin configuration option to ignore files in a package.
2. Reverts Un
From: Michael Kubacki
Currently, UncrustifyCheck._get_git_ignored_paths() is documented to
return a list of absolute file paths but it currently returns a list
of relative file paths.
This change updates the function to return a list of absolute file
paths. The result is later compared to the li
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880
Currently UncrustifyCheck.py provides the following exclusion
options:
1. Override the type of files UncrustifyCheck operates against by
default (.c and .h files). Using the "IgnoreStandardPaths"
configuration option.
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
The following files:
OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h
OvmfPkg/QemuVideoDxe/VbeShim.h
Are auto generated by the following generators:
OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.sh
OvmfPkg/QemuVideoDxe/VbeShim.sh
The
Series Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Friday, April 1, 2022 10:12 AM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Bret Barkelew
> ; Kinney, Michael D
> ; Gao, Liming ; Andrew
> Fish ; Ni, Ray
> ; Chang, Abner ; Wa
Series Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Friday, April 1, 2022 2:58 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Sean Brogan
> ; Bret Barkelew ; Ard
> Biesheuvel ; Yao,
> Jiewen ; Justen, Jordan
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3891
Pipelines are currently building against VS2019 and use the
"windows-latest" VM image in Azure Pipelines. The "windows-latest"
image recently moved its toolchain
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3891
Changes the Python version used in pipelines to 3.8.x (3.8.12) to
workaround an issue discovered after 3.9.10 that causes
stuart_update to fail on a web_dependency (e.g. GCC ARM compilers).
The Python version should b
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
The YAML file previously specified "windows-latest" which recently
moved to VS2022. To continue using VS2019 (at least in the short
term), the VM image needs to be explicitly set to "windows-2019".
Cc: Sean Brogan
Cc
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
The YAML file previously specified "windows-latest" which recently
moved to VS2022. To continue using VS2019 (at least in the short
term), the VM image needs to be explicitly set to "windows-2019".
Cc: Andrew Fish
Cc
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3890
The YAML file previously specified "windows-latest" which recently
moved to VS2022. To continue using VS2019 (at least in the short
term), the VM image needs to be explicitly set to "windows-2019".
Cc: Ard Biesheuvel
From: Michael Kubacki
Updates to the latest release 11.2-2022.02. The previous download
page (10.3-2021.07) has been marked deprecated.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Cc: Michael D Kinney
Cc: Sean Brogan
Signed-off-by: Michael Kubacki
Reviewed-by: Sean Brogan
---
BaseTools/Bi
Just confirming my RB for the entire series.
I appreciate the work here to identify a number of odd issues with CI, external
tools, python patch versions, etc.
Reviewed-by: Sean Brogan
For others, we will continue looking into python issue for tar files/ext_dep as
well as prepare the VS2022 ch
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3889
Currently the HTTP DNS Retry Interval is 2 second and no retry attempt.
If DNS response can't arrive in 2 second, the DNS request is failed,
and then HTTP boot is failed.
In order to resolve this issue, Add PCDs to support RetryCount
and Ret
Hi Liming,
Have tried this option, still not works.
Thanks,
Christine (Yuwei)
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> gaoliming
> Sent: Thursday, March 31, 2022 1:33 PM
> To: Chen, Christine ; devel@edk2.groups.io; 'Gerd
> Hoffmann' ; Kinney, Michael D
> ; 'Sea
52 matches
Mail list logo
