Re: [edk2-devel] [PATCH V12 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-30 Thread Ni, Ray
Reviewed-by: Ray Ni https://edk2.groups.io/g/devel/message/88255 Mute This Topic: https://groups.io/mt/90121206/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [Patch V2 1/2] UefiPayloadPkg: Add a new DebugPrintErrorLevelLib instance

2022-03-30 Thread Yuanhao Xie
It consumes the HOB defined in UefiPayloadPkg/Include/Guid/DebugPrintErrorLevel.h, and allow bootloader to config DebugPrintErrorLevel. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Yuanhao Xie --- UefiPayloadPkg/Include/Guid/DebugPrintErrorLevel.h

[edk2-devel] [Patch V2 2/2] UefiPayloadPkg: Consume the new added DebugPrintErrorLevelLib instance

2022-03-30 Thread Yuanhao Xie
Change the DebugPrintErrorLevelLib instance in UefiPayloadPkg.dsc to allow bootloader to config DebugPrintErrorLevel. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Yuanhao Xie --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +- 1 file changed, 1 insertion

Re: [edk2-devel] [PATCH v1 0/2] Fix StandaloneMmPkg HOB issue

2022-03-30 Thread Ming Huang
Hi, Any comment about this series? 在 2/9/22 8:25 PM, Ming Huang 写道: > Fix two issues in StandaloneMmPkg HOB. > > Ming Huang (2): > StandaloneMmPkg/Hob: Assert or return NULL for create hob failed > StandaloneMmPkg: Fix HOB space and heap space conflicted issue > > StandaloneMmPkg/Core/Stan

Re: [edk2-devel] [PATCH edk2 v3 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2022-03-30 Thread Ming Huang
Hi, Any comment about this series? 在 12/31/21 7:06 PM, Ming Huang 写道: > There are two scene communicate with StandaloneMm(MM): > 1 edk2 -> TF-A -> MM, communicate MM use non-secure buffer which > specify by EFI_SECURE_PARTITION_BOOT_INFO.SpNsCommBufBase; > 2 RAS scene: fiq -> TF-A -> MM, use se

[edk2-devel] [edk2-platforms][PATCH v1 0/2] MinPlatformPkg: Check MemoryTypeInfo Fixes

2022-03-30 Thread Michael Kubacki
From: Michael Kubacki This patch series addresses two issues in TestPointCheckLib/DxeCheckMemoryTypeInformation.c: 1. The MemoryTypeInformation HOB is modified when the HOB data is being dumped. Test point code should not modify HOB data contents in DXE and this can impact subsequent HOB

[edk2-devel] [edk2-platforms][PATCH v1 1/2] MinPlatformPkg/TestPointCheckLib: Prevent MemTypeInfo HOB modification

2022-03-30 Thread Michael Kubacki
From: Michael Kubacki The function DumpMemoryTypeInfoSummary() is written to dump data from the memory type information HOB. However, it actually modifies the HOB data. This can be logic later in boot dependent on the HOB value. This change removes modification of the HOB data. Cc: Chasel Chiu

[edk2-devel] [edk2-platforms][PATCH v1 2/2] MinPlatformPkg/TestPointCheckLib: Remove unused variable

2022-03-30 Thread Michael Kubacki
From: Michael Kubacki The variable VariableMemoryTypeInformation is set but never used. This change removes the variable. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck

Re: [edk2-devel] [Patch V2 1/2] UefiPayloadPkg: Add a new DebugPrintErrorLevelLib instance

2022-03-30 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: devel@edk2.groups.io On Behalf Of Yuanhao Xie Sent: Wednesday, March 30, 2022 5:17 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Maurice Ma ; You, Benjamin ; Rhodes, Sean Subject: [edk2-devel] [Patch V2 1/2] UefiPayloadPkg: Add a ne

Re: [edk2-devel] [Patch V2 2/2] UefiPayloadPkg: Consume the new added DebugPrintErrorLevelLib instance

2022-03-30 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Xie, Yuanhao Sent: Wednesday, March 30, 2022 5:17 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Maurice Ma ; You, Benjamin ; Rhodes, Sean Subject: [Patch V2 2/2] UefiPayloadPkg: Consume the new added DebugPrintErrorLevelLib instan

[edk2-devel] [PATCH 2/2] OvmfPkg: Fix PciHostBridgeLibScan

2022-03-30 Thread Sean Rhodes
From: Patrick Rudolph Don't assume a 64bit register always holds an address greater than 4GB. Check the value in the register and decide which Aperature it should be assigned to. The same code caused an issue on real hardware. It's unclear if this is an issue here as well, as it's intended to ru

[edk2-devel] [PATCH 1/2] UefiPayloadPkg: Fix PciHostBridgeLib

2022-03-30 Thread Sean Rhodes
From: Lean Sheng Tan Don't assume a 64bit register always holds an address greater than 4GB. Check the value in the register and decide which Aperature it should be assigned to. Fixes assertion "ASSERT [PciHostBridgeDxe] Bridge->MemAbove4G.Base >= 0x0001ULL". Tested with coreboot as

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Fix PciHostBridgeLib

2022-03-30 Thread Sean Rhodes
Reviewed-by Sean Rhodes On Wed, 30 Mar 2022 at 19:29, Sean Rhodes wrote: > From: Lean Sheng Tan > > Don't assume a 64bit register always holds an address greater than 4GB. > Check the value in the register and decide which Aperature it should be > assigned to. > > Fixes assertion > "ASSERT [Pc

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation

2022-03-30 Thread Brijesh Singh via groups.io
On 3/30/22 01:04, Dov Murik wrote: On 30/03/2022 8:20, Gerd Hoffmann wrote: Hi, Check if that page is defined; if it is, skip it in the metadata list. In such case, VMM should fill the page with the hashes content, or explicitly update it as a zero page (if kernel hashes are not used).

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation

2022-03-30 Thread Dov Murik
On 30/03/2022 22:27, Brijesh Singh wrote: > > > On 3/30/22 01:04, Dov Murik wrote: >> >> >> On 30/03/2022 8:20, Gerd Hoffmann wrote: >>>    Hi, >>> Check if that page is defined; if it is, skip it in the metadata list. In such case, VMM should fill the page with the hashes content, o

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation

2022-03-30 Thread Brijesh Singh via groups.io
On 3/30/22 14:31, Dov Murik wrote: On 30/03/2022 22:27, Brijesh Singh wrote: On 3/30/22 01:04, Dov Murik wrote: On 30/03/2022 8:20, Gerd Hoffmann wrote:    Hi, Check if that page is defined; if it is, skip it in the metadata list. In such case, VMM should fill the page with the has

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation

2022-03-30 Thread Dov Murik
On 30/03/2022 22:35, Brijesh Singh wrote: > > > On 3/30/22 14:31, Dov Murik wrote: >> >> >> On 30/03/2022 22:27, Brijesh Singh wrote: >>> >>> >>> On 3/30/22 01:04, Dov Murik wrote: On 30/03/2022 8:20, Gerd Hoffmann wrote: >     Hi, > >> Check if that page is defined;

Re: [edk2-devel] [GSoC 2022] How to begin contributing?

2022-03-30 Thread Marvin Häuser
Hey Tejesh, Sorry your mail doesn't get much activity. I think parsing-related things are most important: - String functions in BaseLib: https://github.com/tianocore/edk2/blob/55637a2894babca97945eeca1da0d431f74f8627/MdePkg/Library/BaseLib/String.c - DevicePathLib: https://github.com/tiano

[edk2-devel] Does anyone know why the measured boot log seems to be recording the hash of PEIFV wrongly?

2022-03-30 Thread James Bottomley
When I do a measured boot of OVMF, I get a load of records including the two EV_EFI_PLATFORM_FIRMWARE_BLOB events, which, according to the code in Tcg2Pei.c are supposed to be measuring PEIFV and DXEFV from the uncompressed MEMFD. However, when I compare the hashes against the build artifacts, the

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Fix PciHostBridgeLib

2022-03-30 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Sean Rhodes Sent: Wednesday, March 30, 2022 11:29 AM To: devel@edk2.groups.io Cc: Tan, Lean Sheng ; Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Rhodes, Sean ; Patrick Rudolph Subject: [PATCH 1/2] UefiPayloadPkg: Fix PciHostBri

Re: [edk2-devel] [Patch V2 1/2] UefiPayloadPkg: Add a new DebugPrintErrorLevelLib instance

2022-03-30 Thread Guo Dong
This patch has both UNIVERSAL_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL and UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL. Please double check this patch if it could pass build. Thanks, Guo -Original Message- From: Xie, Yuanhao Sent: Wednesday, March 30, 2022 2:17 AM To: devel@edk2.groups.io Cc: Dong,

[edk2-devel] [Patch V3 2/2] UefiPayloadPkg: Consume the new added DebugPrintErrorLevelLib instance

2022-03-30 Thread Yuanhao Xie
Change the DebugPrintErrorLevelLib instance in UefiPayloadPkg.dsc to allow bootloader to config DebugPrintErrorLevel. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Yuanhao Xie --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +- 1 file changed, 1 insertion

[edk2-devel] [Patch V3 1/2] UefiPayloadPkg: Add a new DebugPrintErrorLevelLib instance

2022-03-30 Thread Yuanhao Xie
It consumes the HOB defined in UefiPayloadPkg/Include/Guid/DebugPrintErrorLevel.h, and allow bootloader to config DebugPrintErrorLevel. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Yuanhao Xie --- UefiPayloadPkg/Include/Guid/DebugPrintErrorLevel.h

Re: [edk2-devel] [PATCH v2 1/1] Basetools: fix gcc workaround

2022-03-30 Thread Yuwei Chen
Hi Hoffmann, I received some reports that some platforms are using gcc5.4. With this patch, these platform builds are still broken. Would you like to revert the original commits? Thanks, Christine (Yuwei) > -Original Message- > From: Gerd Hoffmann > Sent: Tuesday, March 29, 2022 4:38 P

回复: [edk2-devel] [PATCH v1 00/15] Merge UefiCpuLib to CpuLib

2022-03-30 Thread gaoliming
The change in MdePkg is good to me. Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yu Pu > 发送时间: 2022年3月29日 14:37 > 收件人: devel@edk2.groups.io > 抄送: Yu Pu > 主题: [edk2-devel] [PATCH v1 00/15] Merge UefiCpuLib to CpuLib > > REF:https://bugzilla.tianocore.org/show_bug.cgi

回复: [edk2-devel] [PATCH v1 00/41] Add PrmPkg

2022-03-30 Thread gaoliming
Acked-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sinha, Ankit > 发送时间: 2022年3月30日 0:29 > 收件人: devel@edk2.groups.io; mikub...@linux.microsoft.com > 抄送: Andrew Fish ; Gao, Kang ; > Kinney, Michael D ; Kubacki, Michael > ; Leif Lindholm ; You, > Benjamin ; Liu, Yun Y ; > Desimone

Re: [edk2-devel] [PATCH v2 1/1] Basetools: fix gcc workaround

2022-03-30 Thread Yuwei Chen
Since the gcc12 has the incompatible change from GCC5.4, I'd also suggest we could create a new TOOL CHAIN for gcc12. The error reports I collected show in gcc5.4 , "-Wno-error=stringop-overflow" is an unrecognized command line option which is available in gcc12. Thanks, Christine (Yuwei) >

Re: [edk2-devel] [PATCH V12 00/47] Enable Intel TDX in OvmfPkg (Config-A)

2022-03-30 Thread Yao, Jiewen
Thanks Min Series: Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Wednesday, March 30, 2022 7:46 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Brijesh Singh ; > Dong, Eric ; Aktas, Erdem ; > Wu, Hao A ; Wang, Jian J ; > James Bottomley ; Yao, Jiewen ; > Gao, Lim

[edk2-devel] [GSoC 2022] Introducing myself & seeking for project ideas

2022-03-30 Thread Théo Jehl
Hello, I’m Théo, a French 1st year master’s student, specialized in embedded systems engineering. I’m interested in joining EDK II development as part of the Google Summer of Code program. I’ve learnt operating system structures in uni, I know how to write C/C++ and I started learning x86 ASM. I

回复: [edk2-devel] [PATCH v2 1/1] Basetools: fix gcc workaround

2022-03-30 Thread gaoliming
Christine: Can you try the option -Wno-unknown-warning to see whether it disables the warning about an unrecognized command line option? Thanks Liming > -邮件原件- > 发件人: Chen, Christine > 发送时间: 2022年3月31日 10:47 > 收件人: devel@edk2.groups.io; Chen, Christine ; > Gerd Hoffmann ; Kinney, Michae

Re: [edk2-devel] [Patch V3 1/2] UefiPayloadPkg: Add a new DebugPrintErrorLevelLib instance

2022-03-30 Thread Ni, Ray
+} UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL; + +#pragma pack() + +#define UNIVERSAL_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION 1 Please change above macro to UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Repl

Re: [edk2-devel] [PATCH 2/3] UefiPayloadPkg: Fix build on IA32

2022-03-30 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Wednesday, March 30, 2022 4:32 AM To: devel@edk2.groups.io Cc: Rhodes, Sean Subject: [edk2-devel] [PATCH 2/3] UefiPayloadPkg: Fix build on IA32 Signed-off-by: Sean Rhodes --- UefiPayloadP

Re: [edk2-devel] [PATCH 3/3] UefiPayloadPkg: Add --quiet argument to Universal Payload build script

2022-03-30 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Wednesday, March 30, 2022 4:32 AM To: devel@edk2.groups.io Cc: Rhodes, Sean Subject: [edk2-devel] [PATCH 3/3] UefiPayloadPkg: Add --quiet argument to Universal Payload build script Signed-

Re: [edk2-devel] [PATCH 2/2] OvmfPkg: Fix PciHostBridgeLibScan

2022-03-30 Thread Ard Biesheuvel
On Wed, 30 Mar 2022 at 20:29, Sean Rhodes wrote: > > From: Patrick Rudolph > > Don't assume a 64bit register always holds an address greater than 4GB. > Check the value in the register and decide which Aperature it should be > assigned to. > > The same code caused an issue on real hardware. It's