Re: [edk2-devel] [PATCH] [PATCH v1] MdeModulePkg: Add bRefClkFreq card attribute programming support

2022-03-07 Thread Wu, Hao A
A general level question: Is it possible that for a system with multiple UFS Host Controllers (HCs), each HC will have different bRefClkFreq values? If so, my thought is that a new protocol service might be needed to get the bRefClkFreq value from each UFS HC: typedef EFI_STATUS (EFIAPI *EDKII_U

[edk2-devel] [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error Status Block

2022-03-07 Thread Wu, Hao A
Starting from ACPI Specification Version 5.1 Errata B, the term 'Correctable' is no longer being used as an error severity of the reported error in Chapter 18 APEI. This commit adds a new macro to reflect this and also keeps the origin definition (but add comments to make it deprecated) for compat

Re: [edk2-devel] [PATCH] [PATCH v1] MdeModulePkg: Add bRefClkFreq card attribute programming support

2022-03-07 Thread Bandaru, Purna Chandra Rao
Thank you Wu, Hao. 1) Even in multiple UFS host controllers it will have single REF_CLK. 2) responded in line. Thanks ~Purna -Original Message- From: Wu, Hao A Sent: Monday, March 7, 2022 1:39 PM To: devel@edk2.groups.io; Bandaru, Purna Chandra Rao Cc: Albecki, Mateusz Subject:

[edk2-devel] [PATCH] [PATCH v2] MdeModulePkg: Add bRefClkFreq card attribute programming support

2022-03-07 Thread Bandaru, Purna Chandra Rao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3851 When the UFS card comes out of Manufacturer, bRefClkFreq attribute is set to 1h on the UFS card as per the "MDV” (Manufacturer Default Value) specified by the spec JESD220*. However, depends on the UFS host system environment, it need to be

Re: [edk2-devel] [PATCH 1/4] NetworkPkg/HttpDxe: Decofigure Tcp4 before reconfiguring

2022-03-07 Thread Gerd Hoffmann
On Fri, Mar 04, 2022 at 02:34:28PM +0100, Oliver Steffen wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 > > Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or > HTTP_STATE_TCP_CLOSED and de-configure the Tcp4 instance before > configuring it again. > > Sign

Re: [edk2-devel] [PATCH 2/4] NetworkPkg/HttpDxe: Add ConnectionClose flag fo HTTP_PROTOCOL

2022-03-07 Thread Gerd Hoffmann
Hi, > - if ((HttpInstance->RemotePort == RemotePort) && > > + if ((HttpInstance->ConnectionClose == FALSE) && > > + (HttpInstance->RemotePort == RemotePort) && Adding a check for the port makes sense, but that change should also be mentioned in the commit message (or splitt

Re: [edk2-devel] [PATCH 3/4] NetworkPkg/HttpDxe: Detect 'Connection: close' header

2022-03-07 Thread Gerd Hoffmann
On Fri, Mar 04, 2022 at 02:34:30PM +0100, Oliver Steffen wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 > > Force connecton close before the next request if > the server sends the 'Connection: close' header. > > Signed-off-by: Oliver Steffen > --- > NetworkPkg/HttpDxe/HttpImp

Re: [edk2-devel] [PATCH 4/4] NetworkPkg/HttpDxe: Detect non-HTTP/1.1 servers

2022-03-07 Thread Gerd Hoffmann
On Fri, Mar 04, 2022 at 02:34:31PM +0100, Oliver Steffen wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 > > Force connecton close before the next request if > the server does not identify as version 1.1. > > Signed-off-by: Oliver Steffen > --- > NetworkPkg/HttpDxe/HttpImpl.c

[edk2-devel][PATCH] UefiCpuPkg: Support FFS3 GUID in SearchForBfvBase.asm

2022-03-07 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3862 The new algorithm searches BFV address with FFS3 GUID first. If not found, it will search BFV address with FFS2 GUID. Cc: Ray Ni Cc: Debkumar De Cc: Harry Han Cc: Catharine West Signed-off-by: Ted Kuo --- .../Vtf0/Bin/IA32/ResetVector.i

[edk2-devel] [PATCH v3 1/1] .pytool: Update to newest pytools

2022-03-07 Thread Kenneth Lautner
From: Ken Lautner Update to the newest pytools and resolves the API change for GetAbsolutePathOnThisSytemFromEdk2RelativePath Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Kenneth Lautner Reviewed-by: Sean Brogan --- .azurepipelines/Ubuntu-PatchChec

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-03-07 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Sean Rhodes Sent: Saturday, March 5, 2022 3:15 AM To: devel@edk2.groups.io Cc: Rhodes, Sean ; Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable Provide a build option

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-03-07 Thread Guo Dong
It was merged @https://github.com/tianocore/edk2/pull/2596 https://github.com/tianocore/edk2/commit/af74efe494c5920c7992b543fada1af2b186bd8c Thanks, Guo -Original Message- From: devel@edk2.groups.io On Behalf Of Guo Dong Sent: Monday, March 7, 2022 1:23 PM To: Rhodes, Sean ; devel@edk2

Re: [edk2-devel] [PATCH] BlSupportSmm: fix definition of SetSmrr()

2022-03-07 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Wednesday, February 23, 2022 3:55 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Rhodes, Sean ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Matt DeVillier Subject: [edk2-devel] [PATCH] BlSupp

[edk2-devel] 回复: [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error Status Block

2022-03-07 Thread gaoliming
Hao: Can you let me know why you update Acpi64.h only? Thanks Liming > -邮件原件- > 发件人: Hao A Wu > 发送时间: 2022年3月7日 16:35 > 收件人: devel@edk2.groups.io > 抄送: Hao A Wu ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu > 主题: [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error

[edk2-devel] 回复: [PATCH v3 1/1] MdePkg/Include: Smbios Specification 3.5.0 changes

2022-03-07 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: abdullateef.at...@amd.com 代表 > Abdul Lateef Attar > 发送时间: 2022年2月24日 23:50 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu > 主题: [PATCH v3 1/1] MdePkg/Include: Smbios Specification 3.5.0 changes > > Adds following

Re: [edk2-devel] [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error Status Block

2022-03-07 Thread Wu, Hao A
Hello Liming, My take is that the consumers of the ACPI header file will always use the latest version. Is my understanding correct? Or should I update all the header files relating to the affected versions (5.1~6.4) of the ACPI spec? Best Regards, Hao Wu > -Original Message- > From: g

Re: [edk2-devel] [edk2-platforms][PATCH V1 00/15] Platform: Add Loongson support

2022-03-07 Thread xianglai
ping for reply. I submitted the code to edk2-platform to support loongson platform.But I haven't heard back,Is there something wrong with me? edk2 related code has been submitted by lic...@loongson.cn. You can also view the code through the Loongson community. The edk2 code in Loongson commu

Re: [edk2-devel] [PATCH] MdePkg/Acpi64: Update Error Severity type for Generic Error Status Block

2022-03-07 Thread Ni, Ray
The Acpixx.h are not like Pcixx.h. There are duplications among them (using different structure/macro prefix with version embedded). I suggest we either update all of them, or we refactor the Acpixx.h to remove the duplications through "typedef" or "define". The easier way for this small change

[edk2-devel] question about iSCSI remote boot

2022-03-07 Thread Tiger Liu(BJ-RD)
Hello, I used I210 network card to do a remote boot os with iscsi method. I210 network card's oprom include a legacy ISCSI remote boot option ROM image. I want to use NetworkPkg\IScsiDxe drivers. So, if I use NetworkPkg\IScsiDxe driver, so I don't need load I210's legacy ISCSI option ROM image?

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 03/08/2022 #cal-reminder

2022-03-07 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

[edk2-devel] [PATCH 00/14] Introduce PlatformInitLib in OvmfPkg

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 There are 3 variants of PlatformPei in OvmfPkg: - OvmfPkg/PlatformPei - OvmfPkg/Bhyve/PlatformPei - OvmfPkg/XenPlatformPei A lot of common code can be shared in above PlatformPeis. Further more, with the upstreaming of TDVF (Pei-less boot

[edk2-devel] [PATCH 01/14] OvmfPkg: Create initial version of PlatformInitLib

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 There are 3 variants of PlatformPei in OvmfPkg: - OvmfPkg/PlatformPei - OvmfPkg/XenPlatformPei - OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf These PlatformPeis can share many common codes, such as Cmos / Hob / Memory / Platform related funct

[edk2-devel] [PATCH 02/14] OvmfPkg/PlatformInitLib: Add hob functions

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 In this patch of PlatformInitLib, below hob functions are introduced: - PlatformAddIoMemoryBaseSizeHob - PlatformAddIoMemoryRangeHob - PlatformAddMemoryBaseSizeHob - PlatformAddMemoryRangeHob - PlatformAddReservedMemoryBaseSizeHob They

[edk2-devel] [PATCH 03/14] OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 The intention of PlatformInitLib is to extract the common function used in OvmfPkg/PlatformPei. This lib will be used not only in PEI phase but also in SEC phase. SEC phase cannot use global variables between different functions. So PlatformI

[edk2-devel] [PATCH 04/14] OvmfPkg/PlatformPei: Refactor MiscInitialization

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 In MiscInitialization Microvm looks a little weird. Other platforms call PcdSet16S to set the PcdOvmfHostBridgePciDevId with the value same as PlatformInfoHob->HostBridgeDevId. But Microvm doesn't follow this way. In switch-case 0x is Mic

[edk2-devel] [PATCH 05/14] OvmfPkg/PlatformPei: Refactor MiscInitialization for CloudHV

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 Refactor MiscInitialization for CloudHV to set PCD as other platforms do. Because in the following patch we will split the functions which set PCDs into two, one for PlatformInitLib, one for PlatformPei. Cc: Ard Biesheuvel Cc: Jordan Justen

[edk2-devel] [PATCH 06/14] OvmfPkg/PlatformPei: Refactor AddressWidthInitialization

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 >From this patch we start to restruct the functions which set PCDs into two, one for PlatformInitLib, one for PlatformPei. AddressWidthInitialization is the first one. It is splitted into two: - PlatformAddressWidthInitialization is for Pla

[edk2-devel] [PATCH 07/14] OvmfPkg/PlatformPei: Refactor MaxCpuCountInitialization

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 MaxCpuCountInitialization is splitted into two: - PlatformMaxCpuCountInitialization is for PlatformInitLib - MaxCpuCountInitialization is for PlatformPei. It calls PlatformMaxCpuCountInitialization then sets PCDs. Cc: Ard Biesheuvel Cc

[edk2-devel] [PATCH 08/14] OvmfPkg/PlatformPei: Refactor QemuUc32BaseInitialization

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 Rename QemuUc32BaseInitialization to PlatformQemuUc32BaseInitialization. This function is for PlatformInitLib. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky

[edk2-devel] [PATCH 09/14] OvmfPkg/PlatformPei: Refactor InitializeRamRegions

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 InitializeRamRegions is refactored into 3 calls: - PlatformQemuInitializeRam - SevInitializeRam - PlatformQemuInitializeRamForS3 SevInitializeRam is not in PlatformInitLib. Because in the first stage PlatformInitLib only support the basic

[edk2-devel] [PATCH 10/14] OvmfPkg/PlatformPei: Refactor MemMapInitialization

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 MemMapInitialization is split into 2 functions: - PlatformMemMapInitialization is for PlatformInfoLib - MemMapInitialization calls PlatformMemMapInitialization and then sets PCDs. It is for PlatformPei. Cc: Ard Biesheuvel Cc: Jordan Ju

[edk2-devel] [PATCH 11/14] OvmfPkg/PlatformPei: Refactor NoexecDxeInitialization

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 NoexecDxeInitialization is split into 2 functions: - PlatformNoexecDxeInitialization is for PlatformInitLib - NoexecDxeInitialization calls PlatformNoexecDxeInitialization and then sets PCD. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Br

[edk2-devel] [PATCH 12/14] OvmfPkg/PlatformPei: Refactor MiscInitialization

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 MiscInitialization is split into 2 functions: - PlatformMiscInitialization is for PlatformInitLib. - MiscInitialization calls PlatformMiscInitialization and then sets PCD. It is for PlatformPei. Cc: Ard Biesheuvel Cc: Jordan Justen Cc

[edk2-devel] [PATCH 13/14] OvmfPkg/PlatformInitLib: Create MemDetect.c

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 Move functions in PlatformPei\MemDetect.c to PlatformInitLib\MemDetect.c. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Cc: Sebastien Boeu

[edk2-devel] [PATCH 14/14] OvmfPkg/PlatformInitLib: Move functions to Platform.c

2022-03-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 Move functions in PlatformPei/Platform.c to PlatformInitLib/Platform.c. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Cc: Sebastien Boeuf

Re: [edk2-devel] [PATCH V7 19/37] OvmfPkg/PlatformInitLib: Add memory functions

2022-03-07 Thread Min Xu
On March 2, 2022 2:57 PM, Gerd Hoffmann wrote: > Hi, > > > > Hmm. Unlike patches 17+18 which are pure code motion (except the > > > function renaming but that doesn't change the workflow) this patch > > > mixes code changes and code moving which makes it hard to review. > > > > > > It should be

Re: [edk2-devel] [PATCH] [PATCH v2] MdeModulePkg: Add bRefClkFreq card attribute programming support

2022-03-07 Thread Wu, Hao A
Minor inline comments below on coding style from the uncrustify tool: > -Original Message- > From: Bandaru, Purna Chandra Rao > Sent: Monday, March 7, 2022 7:47 PM > To: devel@edk2.groups.io > Cc: Bandaru, Purna Chandra Rao ; > Wu, Hao A ; Albecki, Mateusz > ; Gao, Liming ; > L

[edk2-devel] [PATCH v2] MdePkg/AcpiXX.h: Update Error Severity type for Generic Error Status Block

2022-03-07 Thread Wu, Hao A
Starting from ACPI Specification Version 5.1 Errata B, the term 'Correctable' is no longer being used as an error severity of the reported error in Chapter 18 APEI. This commit will a) For Acpi40.h & Acpi50.h Add new macro EFI_ACPI_X_X_ERROR_SEVERITY_RECOVERABLE, since both the terms 'Correctable'

[edk2-devel] [PATCH 0/2] BaseTools:Add the FeatureFlagExpression usage to the InfBuildData

2022-03-07 Thread yi1 li
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1446 FeatureFlagExpression Support in LibraryClasses/Guids/Ppi/Protocols/ Source section of INF file. The Pcd value in the expression is from INF or DEC When a FeatureFlagExpression is present,if the expression evaluates to TRUE,then the entry is

[edk2-devel] [PATCH 1/2] BaseTools:Add the FeatureFlagExpression usage to the InfBuildData

2022-03-07 Thread yi1 li
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1446 FeatureFlagExpression Support in LibraryClasses/Guids/Ppi/Protocols section of INF file. The Pcd value in the expression is from INF or DEC When a FeatureFlagExpression is present,if the expression evaluates to TRUE,then the entry is valid. I

[edk2-devel] [PATCH 2/2] BaseTools:Add the FeatureFlagExpression usage to the Source Section

2022-03-07 Thread yi1 li
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1446 FeatureFlagExpression Support in Source section of INF file. The Pcd value in the expression is from INF or DEC. When a FeatureFlagExpression is present,if the expression evaluates to TRUE,then the entry is valid. If the expression evaluates