Re: [edk2-devel] [PATCH v2 14/17] Silicon/Ampere: Update ArmPlatformLib to work with changed ARM_CORE_INFO

2022-01-30 Thread Ard Biesheuvel
On Sun, 19 Dec 2021 at 04:36, Nhi Pham wrote: > > Hi Rebecca, > > Leif is merging the rest of Altra port to the edk2-platforms which has > SRAT ACPI table consuming the CPU Core Info table. Therefore, we will > need to fix the SRAT too. I would defer the fix until the Altra port is > fully merged.

Re: [edk2-devel] [PATCH v3 1/4] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct

2022-01-30 Thread Ard Biesheuvel
Hello Rebecca, On Thu, 16 Dec 2021 at 04:46, Rebecca Cran wrote: > > Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in > favor of a new Mpidr field. Update code in > ArmPlatformPkg/PrePeiCore/MainMPCore and ArmPlatformPkg/PrePi/MainMPCore.c > to use the new field and call n

Re: [edk2-devel] [PATCH v2 00/17] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2

2022-01-30 Thread Ard Biesheuvel
On Thu, 16 Dec 2021 at 23:08, Rebecca Cran wrote: > > Changes from v1: > > Fixed Platform/SoftIron, Platform/RaspberryPi, Silicon/AMD, > Silicon/Ampere, Silicon/Phytium, Silicon/Hisilicon. > > Patches 1/17 through 8/17 are the same as v1. > > > > The following platforms are already broken

Re: [edk2-devel] [PATCH 2/2] CryptoPkg: Add BigNum NullLib

2022-01-30 Thread yi1 li
Hi Jiewen With build cmd 'build -p .\Edk2\CryptoPkg\CryptoPkg.dsc -t VS2019 -a X64 -D CRYPTO_SERVICES=ALL': CryptDxe.efi will be 813,504 bytes without CryptBn; will be 815,040 bytes with CryptBnNull; will be 815,360 bytes with CryptBn; This patch has little effect on binary size since the dependen

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning

2022-01-30 Thread Rebecca Cran
I'm still seeing this error when building using XCode 13.2.1, so I guess this patch hasn't been committed yet. -- Rebecca Cran On 12/13/21 12:38 PM, Brijesh Singh via groups.io wrote: The XCODE5 reported the below warning OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uniniti

Re: [edk2-devel] [PATCH v3 1/4] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct

2022-01-30 Thread Ard Biesheuvel
On Sun, 30 Jan 2022 at 11:44, Ard Biesheuvel wrote: > > Hello Rebecca, > > On Thu, 16 Dec 2021 at 04:46, Rebecca Cran wrote: > > > > Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in > > favor of a new Mpidr field. Update code in > > ArmPlatformPkg/PrePeiCore/MainMPCore and

Re: [edk2-devel] [PATCH 2/2] CryptoPkg: Add BigNum NullLib

2022-01-30 Thread Yao, Jiewen
Hi Then I don’t understand why we need this feature. Please submit a bugzilla to describe the problem statement. (Not the solution) Also please provide the size difference in pei and smm before and after your patch. Not only the crypto bin but also the individual driver using crypto lib, such a