Hi Liming, Hi Michael,
May I know when will the review process finished and code will be merged ?
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming
Sent: Wednesday, December 15, 2021 1:41 PM
To: devel@edk2.groups.io; Liu, Zhiguang ; Chu, Maggie
Cc: Kinney, Michael
Hi Khasim,
Everything looks good to me:
Reviewed-by: Pierre Gondois
Regards,
Pierre
On 12/22/21 2:14 AM, Khasim Mohammed via groups.io wrote:
> The patch removes PciExpressLib implementation for N1Sdp as:
>
> a) The PciSegmentLib implementation for N1Sdp makes MmioRead() calls
> instead
Hi Khasim,
Everything looks good to me:
Reviewed-by: Pierre Gondois
Regards,
Pierre
On 12/22/21 2:14 AM, Khasim Mohammed via groups.io wrote:
> This patch enables CCIX root complex support by updating
> the root complex node info in PciHostBridge library.
>
> Signed-off-by: Khasim Syed Mohamme
Hi Khasim,
Everything looks good to me:
Reviewed-by: Pierre Gondois
Regards,
Pierre
On 12/22/21 2:14 AM, Khasim Mohammed via groups.io wrote:
> PCD entries are updated to remove the hardcoded assignments and to
> add support for multiple PCI root ports.
>
> Signed-off-by: Khasim Syed Mohammed
Hi Khasim,
Everything looks good to me:
Reviewed-by: Pierre Gondois
Regards,
Pierre
On 12/22/21 2:14 AM, Khasim Mohammed via groups.io wrote:
> The BasePCISegment Library in MdePkg doesn't allow configuring
> multiple segments required for PCIe and CCIX root port
> enumeration. Therefore, a cu
Patch pushed:
https://github.com/tianocore/edk2/commit/9ec2cc1f3138ef9314314df29fc6ce0aa5e120b9
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
> Sent: Tuesday, December 21, 2021 8:40 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimo
Hello all,
In one out of ~5 attempts at pushing a PR to master, I get a failure
at the following step
"Install QEMU and Set QEMU on path"
of the PlatformCI_OvmfPkg_Windows_VS2019_PR target.
Is there any way we can remediate this? Or at least classify some
failures as temporary, so it doesn't lo
*** BLURB HERE ***
VincentX Ke (3):
MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem
MdeModulePkg: Refactoring UFS DME request and fix timing problem
MdeModulePkg: Put off UFS HCS.DP checking to fix timing problem
.../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 23 +-
MdeMo
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3714
Replace with UFS_UNIT_DESC to fix response timeout problem.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
.../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 23 +--
1 file changed, 11 i
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3775
Refactoring UFS DME request function and retry up to 5 times.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 310 +++-
1 file changed, 17
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3776
Put off UFS HCS.DP (Device Attached) checking
until UfsDeviceDetection() to fix timing problem.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 47 +++
Hi All,
Kindly review the attached changes to display SMBIOS Type38 fields in
smbiosview command in formatted manner for Bug 3755.
Below is the Bug link:
https://bugzilla.tianocore.org/show_bug.cgi?id=3755
Thanks,
Prakash K
-The information contained in this message may be confidential and propr
Fix typo of "DstBufAlocated" in DxeCore.
Signed-off-by: Charles Zhang
---
MdeModulePkg/Core/Dxe/Image/Image.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c
b/MdeModulePkg/Core/Dxe/Image/Image.c
index 68bde5c15c..5bdf96b52c 100644
-
Hey Ming,
Please check
https://edk2.groups.io/g/devel/message/84973?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2CMarvin%2C20%2C2%2C0%2C86334815
While a few comments were cosmetical, there is an invalid memory access
outlined too, which persists in this patch.
For the future, th
Hi Ard,
Can you point me at some PRs that have this in their log?
Thanks,
Mike
> -Original Message-
> From: Ard Biesheuvel
> Sent: Wednesday, December 22, 2021 1:43 AM
> To: edk2-devel-groups-io
> Cc: Leif Lindholm ; Kinney, Michael D
> ; Sean Brogan ;
> Bret Barkelew ; Kubacki, Mich
Hi Michael,
I was curious when I read this email this morning and I found a log:
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=36430&view=logs&j=417cab99-ad63-55d7-94dd-9898cfdbbe0e&t=5e8e03ff-365b-5151-1b77-4c25d18d4964
It looks like Chocolatey is taking way too long to download/
Hi Pedro,
Thanks for the link to the log. I agree that log shows the choco install is
very slow and timeout out after 45 minutes.
choco does support a flag to specify a larger timeout (--execution-timeout).
We can try increasing a bit higher as a temp workaround.
If choco is going to be this
I do find it weird that Chocolatey is taking 45 minutes to install Qemu. Is
this normal? I've never used Chocolatey but I've used plenty of package
managers and none have ever taken this long to install something.
Maybe it's Azure CI's problem?
Anyway, is it not possible to cross-build qemu, as d
Reviewed-by: Rebecca Cran
On 12/17/21 2:34 PM, Ard Biesheuvel wrote:
Remove the obsolete ARM_PROCESSOR_TABLE definition, and all the pieces
that are related to it.
Cc: Rebecca Cran
Cc: Leif Lindholm
Cc: Sami Mujawar
Ard Biesheuvel (2):
ArmPkg/MpInitLib: avoid ARM_PROCESSOR_TABLE
Arm
I agree that building QEMU from sources is another option.
We could also consider adding QEMU to the nuget feed we use for other tools, so
we avoid the current server’s perf issues.
Mike
From: Pedro Falcato
Sent: Wednesday, December 22, 2021 1:19 PM
To: edk2-devel-groups-io ; Kinney, Michael D
Create PR https://github.com/tianocore/edk2/pull/2346 for this patch.
Thanks
Liming
发件人: Pedro Falcato
发送时间: 2021年12月21日 1:02
收件人: edk2-devel-groups-io ; r...@burtonini.com
抄送: Bob Feng ; Liming Gao ;
Yuwei Chen
主题: Re: [edk2-devel] [PATCH] BaseTools/Brotli: update to latest brotli submo
Prakash:
Can you use git send-email command to send git patch to this mail list?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Prakash K via
groups.io
发送时间: 2021年12月22日 14:40
收件人: devel@edk2.groups.io
抄送: Vasudevan Sambandan ; Sundaresan S
; Gayathri Thunuguntla
主题: [edk2-devel] Regarding
Reviewed-by: Peter Grehan
The Ssdt.asl file isn't used, so delete it.
Signed-off-by: Rebecca Cran
---
OvmfPkg/Bhyve/AcpiTables/Ssdt.asl | 15 ---
1 file changed, 15 deletions(-)
diff --git a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
b/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
deleted file mo
Create PR https://github.com/tianocore/edk2/pull/2348 for this patch.
Thanks
Liming
> -邮件原件-
> 发件人: Chu, Maggie
> 发送时间: 2021年12月22日 16:35
> 收件人: devel@edk2.groups.io; Gao, Liming ;
> Liu, Zhiguang
> 抄送: Kinney, Michael D
> 主题: RE: [edk2-devel] [PATCH] MdePkg: Add registers of boot part
Pushed via:
PR - https://github.com/tianocore/edk2/pull/2347
Commit -
https://github.com/tianocore/edk2/commit/ae8272ef787d80950803c521a13a308651bdc62e
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Tuesday, December 21, 2021 4:24
*** BLURB HERE ***
VincentX Ke (3):
MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem
MdeModulePkg: Refactoring UFS DME request and fix timing problem
MdeModulePkg: Put off UFS HCS.DP checking to fix timing problem
.../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 23 +-
MdeMo
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3714
Replace with UFS_UNIT_DESC to fix response timeout problem.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
.../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 23 +--
1 file changed, 11 i
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3775
Refactoring UFS DME request function and retry up to 5 times.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 312 +++-
1 file changed, 17
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3776
Put off UFS HCS.DP (Device Attached) checking
until UfsDeviceDetection() to fix timing problem.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 47 +++
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Monday, December 20, 2021 4:40 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star ; Ni, Ray
; S, Ashraf Ali
Subject: [PATCH] IntelFsp2WrapperPkg : Remove EFIAPI from local functions.
Inline comment below:
> -Original Message-
> From: Ke, VincentX
> Sent: Thursday, December 23, 2021 12:19 PM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Wu, Hao A
> ; Ni, Ray ; Chiu, Ian
> ; Chu, Maggie
> Subject: [PATCH v6 2/3] MdeModulePkg: Refactoring UFS DME request and
> fix ti
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Ke, VincentX
> Sent: Thursday, December 23, 2021 12:19 PM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Wu, Hao A
> ; Ni, Ray ; Chiu, Ian
> ; Chu, Maggie
> Subject: [PATCH v6 1/3] MdeModulePkg: Replace with UFS_U
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> VincentX Ke
> Sent: Thursday, December 23, 2021 12:19 PM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Wu, Hao A
> ; Ni, Ray ; Chiu, Ian
> ; Chu, Maggie
> Subject: [edk2-devel]
*** BLURB HERE ***
VincentX Ke (3):
MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem
MdeModulePkg: Refactoring UFS DME request and fix timing problem
MdeModulePkg: Put off UFS HCS.DP checking to fix timing problem
.../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 23 +-
MdeMo
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3714
Replace with UFS_UNIT_DESC to fix response timeout problem.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
.../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 23 +--
1 file changed, 11 i
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3776
Put off UFS HCS.DP (Device Attached) checking
until UfsDeviceDetection() to fix timing problem.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 47 +++
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3775
Refactoring UFS DME request function and retry up to 5 times.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Ian Chiu
Cc: Maggie Chu
Signed-off-by: VincentX Ke
---
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 326 +++-
1 file changed, 18
37 matches
Mail list logo
