Re: [edk2-devel] [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved

2021-11-19 Thread Gerd Hoffmann
Hi, >BuildMemoryAllocationHob ( > PcdGet32 (PcdSevLaunchSecretBase), > ALIGN_VALUE (PcdGet32 (PcdSevLaunchSecretSize), EFI_PAGE_SIZE), > -EfiBootServicesData > +EfiReservedMemoryType > ); Acked-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)

2021-11-19 Thread Gerd Hoffmann
On Thu, Nov 18, 2021 at 09:46:21PM +0100, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > and those are consumed by the following PrintLib instance: > > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrin

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-19 Thread Gerd Hoffmann
Hi, > Comment on config-B. > > I'm sure I've asked this before: Why skip the PEI phase? So far > > I have not seen any convincing argument for it. > > Skipping PEI phase is valid architecture design. Sure. > Second, the confidential computing changes the threat model > completely. One of

Re: [edk2-devel] [PATCH] MdePkg: DebugLib: Compilation fix for clang-13.

2021-11-19 Thread Michael D Kinney
Hi Mikhail, For RELEASE GCC5 toolchains in tools_def.txt, I see this warning is disabled. Likely for the same reason. RELEASE_GCC5_IA32_CC_FLAGS = DEF(GCC5_IA32_CC_FLAGS) -flto -Os -Wno-unused-but-set-variable -Wno-unused-const-variable RELEASE_GCC5_X64_CC_FLAGS= DEF(GCC5_X64_CC_

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-19 Thread Yao, Jiewen
> -Original Message- > From: Gerd Hoffmann > Sent: Friday, November 19, 2021 11:12 PM > To: Yao, Jiewen > Cc: Xu, Min M ; devel@edk2.groups.io; Ard Biesheuvel > ; Justen, Jordan L ; > Brijesh Singh ; Erdem Aktas > ; James Bottomley ; Tom > Lendacky > Subject: Re: [PATCH V3 15/29] Ovmf