On November 3, 2021 2:57 PM, Gerd Hoffmann wrote:
> > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/DxeIplTdVmcall.nasm
> > @@ -0,0 +1,146 @@
> > +;--
> > +;*
> > +;* Copyright (c) 2020 - 2021, Intel Corporation. All rights reserv
On Wed, Nov 03, 2021 at 12:57:37PM +, Xu, Min M wrote:
> On November 3, 2021 2:09 PM, Gerd Hoffmann wrote:
> > > +++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm
> > > @@ -0,0 +1,120 @@
> > > +;
> > > +--
> > > +
Hi,
> [SAMI] Apologies, I missed this in my previous review. I think the behaviour
> if both the TCG2 and CC measurement protocols are installed
> would be inconsistent between DxeTpmMeasurementLib and
> DxeTpm2MeasureBootLib. The main difference being in the later, the
> TCG2 protocol takes pre
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/AmdSev/AmdSevX64.dsc | 47
OvmfPkg/AmdSev/AmdSevX64.fdf | 15
2 files changed, 62 deletions(-)
diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
index 5ee54451169b..d54ef2916536 1006
On Wed, Nov 03, 2021 at 15:59:54 -0700, Michael D Kinney wrote:
> Update builds_rules.template to add $(SLINK) to the GCC
> steps for processing HII resources to produce a static
> library instead of an object file. This improves linker
> compatibility and specifically fixes a link failure seen
>
In order to support secure boot with authenticated type variable store
and non secure boot with normal type variable store, add one flag to
switch them.
User can append '-D VPD_AUTHENTICATED_VARIABLE_STORE' to build command
to enable authenticated type varaible store.
Also, user can add 'VPD_AUTH
On Tue, Nov 02, 2021 at 13:17:34 -0700, brbar...@microsoft.com wrote:
> From: Bret Barkelew
>
> Drop switch from the custom "StandaloneMmMmuLib" class to the
> more generic "ArmMmuLib" class and add the missing functions
> to fulfill that interface.
>
> REF: https://bugzilla.tianocore.org/show_b
On Tue, Nov 02, 2021 at 13:17:37 -0700, brbar...@microsoft.com wrote:
> From: Bret Barkelew
>
> TODO: Might keep the name of the .inf. Pending discussion.
Seems a yes on that.
If so:
Reviewed-by: Leif Lindholm
> This aligns better with Mu's philosophy around dependency structuring
> and is on
On Tue, Nov 02, 2021 at 13:17:39 -0700, brbar...@microsoft.com wrote:
> From: Bret Barkelew
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Sean Brogan
> Signed-off-by: Bret Barkelew
For the moving out part:
Reviewed-by: Leif Lin
On November 4, 2021 1:51 PM, Gao, Liming wrote:
> Min:
> I have one minor comment. gEfiCcFinalEventsTableGuid may be placed into
> [Guids] section instead of [Protocols] section.
>
Hi, Liming
I follow the definition of gEfiTcg2ProtocolGuid and
gEfiTcg2FinalEventsTableGuid. See
https://github.c
On Tue, Nov 02, 2021 at 13:17:43 -0700, brbar...@microsoft.com wrote:
> From: Sean Brogan
>
> The previously Arm-specific "ArmMmuLib" has been generalized
> as "MmuLib". The Arm implementation of this lib can still use
> the existing library logic to back it.
>
> As such, this implementation is
On Tue, Nov 02, 2021 at 15:07:14 -0700, Nate DeSimone wrote:
> To help keep edk2-platforms healthy, I would like to
> offer to maintain SimicsOpenBoardPkg, SimicsX58SktPkg,
> and SimicsIch10Pkg. The current maintainer for those
> packages has changed jobs and is no longer active in
> the community.
On November 4, 2021 4:21 PM, Gerd Hoffmann wrote:
> Hi,
>
> > [SAMI] Apologies, I missed this in my previous review. I think the
> > behaviour if both the TCG2 and CC measurement protocols are installed
> > would be inconsistent between DxeTpmMeasurementLib and
> > DxeTpm2MeasureBootLib. The mai
Thanks the detail explanation.
I think it makes sense to make "NewTpmActivePcrBanks = TpmActivePcrBanks &
PcdTpm2HashMask (hardware config) & PcdTcg2HashAlgorithmBitmap (software
config)"
Reviewed-by: Jiewen Yao
From: Gonzalez Del Cueto, Rodrigo
Sent: Saturday, October 30, 2021 8:26 AM
To:
Reviewed-by: Jiewen Yao
From: Gonzalez Del Cueto, Rodrigo
Sent: Saturday, October 30, 2021 5:34 AM
To: Yao, Jiewen ; devel@edk2.groups.io
Cc: Wang, Jian J
Subject: Re: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command
completion.
Hi Jiewen,
I have tested the proposed CRB protocol
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:Asia/Shanghai
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai
X-LIC-LOCAT
On November 4, 2021 9:35 PM, Xu Min wrote:
> On November 4, 2021 4:21 PM, Gerd Hoffmann wrote:
> > Hi,
> >
> > > [SAMI] Apologies, I missed this in my previous review. I think the
> > > behaviour if both the TCG2 and CC measurement protocols are
> > > installed would be inconsistent between DxeTp
Hey
It has been a while since the patch is sent, any feedback from UefiCpuPkg
maintainer?
> -Original Message-
> From: Brijesh Singh
> Sent: Monday, October 25, 2021 7:46 AM
> To: devel@edk2.groups.io
> Cc: brijesh.si...@amd.com; James Bottomley ; Xu, Min M
> ; Yao, Jiewen ; Tom Lendac
CI fail: https://github.com/tianocore/edk2/pull/2172
Please fix it, run CI by yourself before send the next version.
Thank you
Yao Jiewen
From: devel@edk2.groups.io On Behalf Of Yao, Jiewen
Sent: Thursday, November 4, 2021 9:40 PM
To: Gonzalez Del Cueto, Rodrigo ;
devel@edk2.groups.io
Cc: Wang
*TianoCore edk2-test Bug Triage Meeting*
*When:*
11/04/2021
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/93809865843?pwd=dU1hSzk4NHM2RGhaRDRyWWZxUzY5dz09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...@arm.com?subject=Re:%20Eve
CI failed: https://github.com/tianocore/edk2/pull/2173
Would you please try CI by yourself?
From: devel@edk2.groups.io On Behalf Of Yao, Jiewen
Sent: Thursday, November 4, 2021 9:40 PM
To: Gonzalez Del Cueto, Rodrigo ;
devel@edk2.groups.io
Cc: Wang, Jian J
Subject: Re: [edk2-devel] [PATCH] Sec
Hi Min,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 04/11/2021 01:49 PM, Xu, Min M wrote:
On November 4, 2021 9:35 PM, Xu Min wrote:
On November 4, 2021 4:21 PM, Gerd Hoffmann wrote:
Hi,
[SAMI] Apologies, I missed this in my previous review. I think the
beha
I believe a platform should have only one RTS/RTR.
Only one of (virtual)TPM1.2, (virtual)TPM2.0 and CC MR exists. Then only one
TCG_SERVICE_PROTOCOL, TCG2_PROTOCOL, CC_MEASUREMENT_PROTOCOL is exposed.
In the case that, a vTPM is present to emulate the CC MR, then a TDVF should
only expose TCG2_
Hi, EDK2 community,
Just FYI, base on RedfishPkg which is the EDK2 Redfish foundation, we upstream
EDK2 Redfish Client implementation to edk2-staging repo.
In case you don’t know this project, below is the information regarding edk2
Redfish foundation,
https://github.com/tianocore/edk2/blob/m
[AMD Official Use Only]
Hi Min,
I am good with Gerd suggestion. Now that we have workarea containing the guest
type, I can sure summit a patch to simplify the checks greatly. I am waiting
for the UefiCpuPkg maintainers to ack our SNP series so that I can start
building/cleaning other stuff.
T
On 11/4/21 3:10 AM, Gerd Hoffmann wrote:
On Wed, Nov 03, 2021 at 12:57:37PM +, Xu, Min M wrote:
On November 3, 2021 2:09 PM, Gerd Hoffmann wrote:
+++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm
@@ -0,0 +1,120 @@
+;
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles
Thanks Gerd,
On 04/11/2021 11:21, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Dov Murik
Tested-by: Dov Murik
-Dov
> ---
> OvmfPkg/AmdSev/AmdSevX64.dsc | 47
> OvmfPkg/AmdSev/AmdSevX64.fdf | 15
> 2 files changed, 62
Hi Leif,
I will add NOOPT information to the commit message.
Unfortunately, this change caused a boot to shell failure for ArmVirtPkg QEMU.
TFTP dynamic shell command failed to find HII package.
https://github.com/tianocore/edk2/pull/2166
https://dev.azure.com/tianocore/edk2-c
Will address.
On Wed, Nov 3, 2021 at 11:24 PM Andrew Fish wrote:
>
>
> > On Nov 3, 2021, at 11:23 PM, gaoliming wrote:
> >
> > Lefi:
> >
> >> -邮件原件-
> >> 发件人: devel@edk2.groups.io 代表 Leif Lindholm
> >> 发送时间: 2021年11月2日 17:51
> >> 收件人: brbar...@microsoft.com
> >> 抄送: devel@edk2.groups.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3515
In V3: Cleaned up comments, debug prints and updated patch to use the
new debug ENUM definitions.
- Replaced EFI_D_INFO with DEBUG_INFO.
- Replaced EFI_D_VERBOSE with DEBUG_VERBOSE.
In V2: Add case to RegisterHashInterfaceLib logic
Regist
Hi Liming,
The Uefi spec Version 2.9 appears to have some inconsistencies regarding the
possibility of runtime processing of FMP capsules. The UpdateCapsule()
runtime service in Section 8.5.3 states that "the firmware may process the
capsule immediately", but in Section 23.3.1, where the FMP
On November 4, 2021 11:21 PM, Tom Lendacky wrote:
> On 11/4/21 3:10 AM, Gerd Hoffmann wrote:
> > On Wed, Nov 03, 2021 at 12:57:37PM +, Xu, Min M wrote:
> >> On November 3, 2021 2:09 PM, Gerd Hoffmann wrote:
> +++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm
> @@ -0,0 +1,120 @@
Reviewed-by: Prince Agyeman
Prince
-Original Message-
From: devel@edk2.groups.io On Behalf Of Desimone,
Nathaniel L
Sent: Tuesday, November 2, 2021 3:07 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Leif Lindholm
; Kinney, Michael D
Subject: [edk2-devel] [PATCH v1] Maintainers.tx
Hi, Sami
Please see my comments inline.
From: devel@edk2.groups.io On Behalf Of Sami Mujawar
Sent: Tuesday, November 2, 2021 5:43 PM
To: Xu, Min M ; devel@edk2.groups.io
Cc: Kinney, Michael D ; Liming Gao
; Liu, Zhiguang ; Yao, Jiewen
; Wang, Jian J ; Gerd Hoffmann
; nd
Subject: Re: [edk2-dev
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles
Hi, Sami
Please see my comments inline.
+**/
+EFI_STATUS
+EFIAPI
+CcMeasureAndLogData (
+ IN UINT32 PcrIndex,
+ IN UINT32 EventType,
+ IN VOID *EventLog,
+ IN UINT32 LogLen,
+ IN VOID *HashData,
+ IN UINT64
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles
Hi Leif,
I am dropping patch 7 from this series.
I am not able to get the ARM build failure resolved at this time.
The basic issue is that the GCC builds are using objcopy to create
and ELF image with an section named .hii with the HII data. However,
objcopy can not set the ELF fields for the A
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, November 2, 2021 5:38 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Justen, Jordan L ; Gerd
> Hoffmann ; Michael Kubacki
>
> Subject: [Patch V2 7/7] OvmfPkg: Reproduce builds a
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Leif Lindholm
> 发送时间: 2021年11月4日 20:18
> 收件人: brbar...@microsoft.com
> 抄送: devel@edk2.groups.io; Ard Biesheuvel ;
> Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Sean
> Brogan
> 主题: Re: [edk2-devel] [PATCH v2 07/16] Arm
Min:
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Min Xu
> 发送时间: 2021年11月4日 20:35
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn
> 抄送: Kinney, Michael D ; Liu, Zhiguang
> ; Yao, Jiewen ; Wang, Jian J
> ; Lu, Ken ; 'Sami Mujawar'
> ; 'Gerd Hoffmann'
> 主题: Re: [edk2-devel] 回复: [PATCH V4
Would you please confirm if you have run CI and got a PASS result?
> -Original Message-
> From: Gonzalez Del Cueto, Rodrigo
> Sent: Friday, November 5, 2021 2:07 AM
> To: devel@edk2.groups.io
> Cc: Gonzalez Del Cueto, Rodrigo ;
> Wang, Jian J ; Yao, Jiewen
> Subject: [PATCH] Reallocate
Bob:
I suggest to obviously describe that FMP protocol services may be available
in EFI runtime, and define the standard method to know whether FMP protocol
supports runtime attribute.
Because UEFI spec is required to be updated, the code enhancement in
DxeCapsuleLibFmp and FmpDevicePkg ca
Hi, all
We will enter into Soft Feature Freeze phase on 2021-11-08. In this phase,
the feature under review will not be allowed to be pushed. The feature
passed review can still be merged.
The patch review can continue without break in edk2 community. If the patch
is sent before Soft Feature
On November 5, 2021 1:20 PM, Gao Liming wrote:
> > On November 4, 2021 1:51 PM, Gao, Liming wrote:
> > > Min:
> > > I have one minor comment. gEfiCcFinalEventsTableGuid may be placed
> > into
> > > [Guids] section instead of [Protocols] section.
> > >
> > Hi, Liming
> > I follow the definition of
> > Can't you create something in MdePkg/Library/Baselib and then use it
> > everywhere it's needed?
> >
> Do you mean put the basic Tdx functions in MdePkg/Library/BaseLib? If that is
> the case, then I would add below basic Tdx functions in BaseLib:
> - TdIsEnabled ()
> - TdCall ()
> - TdVmC
On November 5, 2021 2:46 PM, Gerd Hoffmann wrote:
> > > Can't you create something in MdePkg/Library/Baselib and then use it
> > > everywhere it's needed?
> > >
> > Do you mean put the basic Tdx functions in MdePkg/Library/BaseLib? If that
> > is
> the case, then I would add below basic Tdx functi
49 matches
Mail list logo
