Re: [edk2-devel] [PATCH V3 23/29] UefiCpuPkg: Update AddressEncMask in CpuPageTable

Hi, > + gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask## > CONSUMES >AddressEncMask = PcdGet64 (PcdPteMemoryEncryptionAddressOrMask) & > PAGING_1G_ADDRESS_MASK_64; > + if (AddressEncMask == 0) { > +AddressEncMask = PcdGet64 (PcdTdxSharedBitMask) & > PAGING_1

Re: [edk2-devel] [PATCH V3 27/29] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library

On Mon, Nov 01, 2021 at 09:16:16PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Add Intel Tdx helper library. The library provides the routines to: > - set or clear Shared bit for a given memory region. > - query whether TDX is enabled. Hmm, patch 22 adds

Re: [edk2-devel] [PATCH V3 28/29] OvmfPkg/QemuFwCfgLib: Support Tdx in QemuFwCfgDxe

On Mon, Nov 01, 2021 at 09:16:17PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > In the previous QemuFwCfgDxe only SEV is supported. This commit > introduce TDX support in QemuFwCfgDxe. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Brijesh Singh > Cc: E

Re: [edk2-devel] [PATCH V3 29/29] OvmfPkg: Update IoMmuDxe to support TDX

Hi, > + if (CC_GUEST_IS_SEV (PcdGet64 (PcdConfidentialComputingGuestAttr))) { > +// > +// Clear the memory encryption mask on the plaintext buffer. > +// > +Status = MemEncryptSevClearPageEncMask ( > + 0, > + MapInfo->PlainTextAddress, > +

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

On 03/11/2021 8:07, Gerd Hoffmann wrote: > Hi, > Does SEV need and/or use SMM mode? Looking through AmdSevX64.dsc doesn't give a clear answer, on one hand there is a LibraryClasses.common.SMM_CORE section, but on the other hand it uses the non-SMM variable driver stack. >

Re: [edk2-devel] [PATCH V3 12/29] UefiCpuPkg: Define ConfidentialComputingGuestAttr

On November 2, 2021 10:36 PM, Gerd Hoffmann wrote: > Hi, > > > .../Include/ConfidentialComputingGuestAttr.h | 25 +++ > > MdePkg/MdePkg.dec | 4 +++ > > Subject doesn't match patch (UefiCpuPkg vs MdePkg). > It is SEV's patch and they're aware of it

[edk2-devel] [PATCH v3 0/7] OvmfPkg/PlatformCI: hook up AmdSev, Bhyve and Microvm

v3: - pick up Acked-by: - use __file__ to extend path v2: - hook up OvmfXen too. - add CI maintainers to Cc. Gerd Hoffmann (7): OvmfPkg/PlatformCI: factor out PlatformBuildLib.py OvmfPkg/PlatformCI: add QEMU_SKIP OvmfPkg/PlatformCI: add BhyveBuild.py OvmfPkg/PlatformCI: add MicrovmBuil

[edk2-devel] [PATCH v3 2/7] OvmfPkg/PlatformCI: add QEMU_SKIP

Skip the qemu boot test in case QEMU_SKIP is set to true. Acked-by: Jiewen Yao Acked-by: Ard Biesheuvel Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformCI/PlatformBuildLib.py | 5 + 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/

[edk2-devel] [PATCH v3 1/7] OvmfPkg/PlatformCI: factor out PlatformBuildLib.py

Move SettingsManager and PlatformBuilder classes to PlatformBuildLib.py file, keep only CommonPlatform class in PlatformBuild.py. Allows reusing these classes for other builds. Pure code motion, no functional change. Acked-by: Jiewen Yao Acked-by: Ard Biesheuvel Signed-off-by: Gerd Hoffmann -

[edk2-devel] [PATCH v3 3/7] OvmfPkg/PlatformCI: add BhyveBuild.py

Add build test for OvmfPkg/Bhyve. Acked-by: Jiewen Yao Acked-by: Ard Biesheuvel Signed-off-by: Gerd Hoffmann --- .../.azurepipelines/Ubuntu-GCC5.yml | 9 + OvmfPkg/PlatformCI/BhyveBuild.py | 37 +++ 2 files changed, 46 insertions(+) create mode 1006

[edk2-devel] [PATCH v3 5/7] OvmfPkg/PlatformCI: add AmdSevBuild.py

Add build test for OvmfPkg/AmdSev. Acked-by: Jiewen Yao Acked-by: Ard Biesheuvel Signed-off-by: Gerd Hoffmann --- .../.azurepipelines/Ubuntu-GCC5.yml | 10 + OvmfPkg/PlatformCI/AmdSevBuild.py | 37 +++ 2 files changed, 47 insertions(+) create mode 100

[edk2-devel] [PATCH v3 6/7] OvmfPkg/PlatformCI: dummy grub.efi for AmdSev

Building grub.efi for AmdSev is difficult because it depends on patches not yet merged to upstream grub. So shortcut the grub build by simply creating an empty grub.efi file. That allows to at least build-test the AmdSev variant. Acked-by: Jiewen Yao Acked-by: Ard Biesheuvel Signed-off-by: Ger

[edk2-devel] [PATCH v3 7/7] OvmfPkg/PlatformCI: add XenBuild.py

Add build test for OvmfXen. Signed-off-by: Gerd Hoffmann --- .../.azurepipelines/Ubuntu-GCC5.yml | 9 + OvmfPkg/PlatformCI/XenBuild.py| 37 +++ 2 files changed, 46 insertions(+) create mode 100644 OvmfPkg/PlatformCI/XenBuild.py diff --git a/OvmfPk

[edk2-devel] [PATCH v3 4/7] OvmfPkg/PlatformCI: add MicrovmBuild.py

Add build test for OvmfPkg/Microvm. Acked-by: Jiewen Yao Acked-by: Ard Biesheuvel Signed-off-by: Gerd Hoffmann --- .../.azurepipelines/Ubuntu-GCC5.yml | 10 + OvmfPkg/PlatformCI/MicrovmBuild.py| 37 +++ 2 files changed, 47 insertions(+) create mode 10

Re: [edk2-devel] [edk2-platforms][PATCH v4 02/31] AmpereAltraPkg: Add FlashLib library instance

On 26/10/2021 18:25, Leif Lindholm wrote: On Fri, Oct 22, 2021 at 13:17:40 +0700, Nhi Pham wrote: From: Vu Nguyen Provides functions to access the NVRAM, NVRAM2 and FailSafe region on the Flash over MM communication. Cc: Thang Nguyen Cc: Chuong Tran Cc: Phong Vo Cc: Leif Lindholm Cc: Mich

Re: [edk2-devel] [edk2-platforms][PATCH v4 01/31] Ampere: Initial support for Ampere Altra processor and Mt. Jade platform

On 26/10/2021 18:14, Leif Lindholm wrote: On Fri, Oct 22, 2021 at 13:17:39 +0700, Nhi Pham wrote: From: Vu Nguyen This commit adds the support for Ampere’s Altra processor-based Mt. Jade platform that provides up to 160 processor cores in a dual socket configuration. The essential modules are

Re: [edk2-devel] [edk2-platforms][PATCH v4 03/31] AmpereAltraPkg: Add FailSafe and WDT support

On 26/10/2021 19:15, Leif Lindholm wrote: Hi Nhi, On Fri, Oct 22, 2021 at 13:17:41 +0700, Nhi Pham wrote: The FailSafeDxe is a driver for the FailSafe feature which reverts the system's configuration to known good values if the system fails to boot up multiple times. Also, this driver implement

Re: [edk2-devel] [edk2-platforms][PATCH v4 12/31] AmpereAltraPkg: Add Ac01PcieLib library instance

Hi Leif, Thanks a lot for reviewing. I will address all your comments and review carefully through this module as well. Best regards, Nhi On 26/10/2021 19:45, Leif Lindholm wrote: On Fri, Oct 22, 2021 at 13:17:50 +0700, Nhi Pham wrote: From: Vu Nguyen Provides essential functions to initia

Re: [edk2-devel] [edk2-platforms][PATCH v4 13/31] JadePkg: Add BoardPcieLib library instance

On 26/10/2021 19:46, Leif Lindholm wrote: On Fri, Oct 22, 2021 at 13:17:51 +0700, Nhi Pham wrote: From: Vu Nguyen Provide Mt. Jade specific segment number for each Root Complex and function to handle the PCIe PERST. Cc: Thang Nguyen Cc: Chuong Tran Cc: Phong Vo Cc: Leif Lindholm Cc: Micha

Re: [edk2-devel] [edk2-platforms][PATCH v4 16/31] AmpereAltraPkg: Add PciSegmentLib library instance

Thanks, Leif. Will fix all of them. Best regards, Nhi On 26/10/2021 19:53, Leif Lindholm wrote: On Fri, Oct 22, 2021 at 13:17:54 +0700, Nhi Pham wrote: From: Vu Nguyen Provides functions to handle the PCIe configuration requests. The target Root Complex is selected based on the segment numbe

Re: [edk2-devel] [edk2-platforms][PATCH v4 31/31] AmpereAltraPkg: Add configuration screen for Watchdog timer

On 26/10/2021 20:03, Leif Lindholm wrote: On Fri, Oct 22, 2021 at 13:18:09 +0700, Nhi Pham wrote: From: Vu Nguyen There are secure and non-secure watchdog timers supported in the Mt. Jade system. They are used to monitor the system booting like system firmware, UEFI, and OS. The system will be

Re: [edk2-devel] [edk2-platforms][PATCH v4 00/31] Add new Ampere Mt. Jade platform

Thanks, Leif. I really appreciate your reviewing. I will fix and send the v5 soon. Best regards, Nhi On 26/10/2021 20:08, Leif Lindholm wrote: Hi Nhi, I have finished review of this revision. I did spot a couple of large-ish things (enums and watchdog) that I had not noticed in previous revis

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

Hi Rebecca, Apologies, I missed reviewing this patch. Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 20/09/2021 04:47 PM, Rebecca Cran via groups.io wrote: Add a new MpServicesTest application under MdeModulePkg/Application that exercises the EFI_MP_SERVICES_PROTOCOL.

Re: [EXTERNAL] [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

On Tue, Nov 02, 2021 at 16:34:15 -0700, Andrew Fish via groups.io wrote: > > No objections to this for any of my use-cases, but I'd like for one of > > the BaseTools maintainers to comment on whether this breaks anything > > with regards to EDK_TOOLS_PATH, or if we can finally get rid of that > > a

Re: [edk2-devel] [Patch 1/6] DynamicTablesPkg: Add missing BaseStackCheckLib instance

Hi Mike, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 03/11/2021 03:05 AM, Michael D Kinney wrote: Fix ARM and AARCH64 build issues by adding the BaseStackCheckLib instance. Cc: Sami Mujawar Cc: Alexei Fedorov Cc: Ard Bieshe

Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

On November 3, 2021 2:09 PM, Gerd Hoffmann wrote: > > +++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm > > @@ -0,0 +1,120 @@ > > +; > > +-- > > +;* > > +;* Copyright (c) 2020 - 2021, Intel Corporation. All rights > >

Re: [edk2-devel] [PATCH V3 20/29] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation

On November 3, 2021 2:51 PM, Gerd Hoffmann wrote: > > +/** > > + Check if it is Tdx guest > > + > > + @retvalTRUE It is Tdx guest > > + @retvalFALSE It is not Tdx guest > > +**/ > > +BOOLEAN > > +QemuFwCfgIsTdxGuest ( > > QemuFwCfgIsCC() > > > + return (CcWorkAreaHeader != NULL &&

Re: [edk2-devel] [PATCH V3 20/29] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation

On November 3, 2021 2:51 PM, Gerd Hoffmann wrote: > > +/** > > + Check if it is Tdx guest > > + > > + @retvalTRUE It is Tdx guest > > + @retvalFALSE It is not Tdx guest > > +**/ > > +BOOLEAN > > +QemuFwCfgIsTdxGuest ( > > QemuFwCfgIsCC() > > > + return (CcWorkAreaHeader != NULL &&

Re: [edk2-devel] [Patch 5/6] UefiCpuPkg/MtrrLib/UnitTest: Fix 32-bit GCC build issues

On 11/3/21 04:05, Michael D Kinney wrote: > When using UT_ASSERT_EQUAL() on a pointer value, it must be > cast to UINTN. This follows the samples provided with the > UnitTestFrameworkPkg. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Signed-off-by: Michael D Kinney > --- > UefiCpuPkg/Li

Re: [edk2-devel] [Patch 6/6] MdeModulePkg/Variable/RuntimeDxeUnitTest: Fix 32-bit GCC builds

On 11/3/21 04:05, Michael D Kinney wrote: > When using will_return() on a pointer value, it must be > cast to UINTN to be compatible with 32-bit GCC builds. > This uses the same approach in samples provided in the > UnitTestFramworkPkg when passing pointer values to > UT_ASSERT_EQUAL(). > > Cc: Ha

Re: [edk2-devel] [PATCH v3 2/7] OvmfPkg/PlatformCI: add QEMU_SKIP

On 11/3/21 10:11, Gerd Hoffmann wrote: > Skip the qemu boot test in case QEMU_SKIP is set to true. > > Acked-by: Jiewen Yao > Acked-by: Ard Biesheuvel > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/PlatformCI/PlatformBuildLib.py | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Philip

Re: [edk2-devel] [PATCH v3 4/7] OvmfPkg/PlatformCI: add MicrovmBuild.py

On 11/3/21 10:11, Gerd Hoffmann wrote: > Add build test for OvmfPkg/Microvm. > > Acked-by: Jiewen Yao > Acked-by: Ard Biesheuvel > Signed-off-by: Gerd Hoffmann > --- > .../.azurepipelines/Ubuntu-GCC5.yml | 10 + > OvmfPkg/PlatformCI/MicrovmBuild.py| 37 +++

Re: [edk2-devel] [PATCH v3 5/7] OvmfPkg/PlatformCI: add AmdSevBuild.py

On 11/3/21 10:11, Gerd Hoffmann wrote: > Add build test for OvmfPkg/AmdSev. > > Acked-by: Jiewen Yao > Acked-by: Ard Biesheuvel > Signed-off-by: Gerd Hoffmann > --- > .../.azurepipelines/Ubuntu-GCC5.yml | 10 + > OvmfPkg/PlatformCI/AmdSevBuild.py | 37

[edk2-devel] [PATCH v1 0/3] IntelSiliconPkg: Remove v1 PCH SPI PPI and Protocol

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3717 V2 of the PCH SPI PPI and PCH SPI Protocol were recently added to IntelSiliconPkg. This change removes the v1 definitions. V2 is intended to better support multiple silicon generations which aligns with the goals of I

[edk2-devel] [PATCH v1 1/3] CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Remove unneeded SPI header

From: Michael Kubacki This contents of the header file are not referenced in this source file. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Michael Kubacki --- Platform/Intel/CometlakeOpenBoardPkg/Policy/Libra

[edk2-devel] [PATCH v1 2/3] WhiskeylakeOpenBoardPkg/PeiPolicyUpdateLib: Remove unneeded SPI header

From: Michael Kubacki This contents of the header file are not referenced in this source file. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Michael Kubacki --- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/PeiPchPolicyUpdate.c | 1 - Platform/Intel/Whiskey

[edk2-devel] [PATCH v1 3/3] IntelSiliconPkg: Remove SPI v1 PPI and Protocol definitions

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3717 V2 of the PCH SPI PPI and PCH SPI Protocol were recently added to IntelSiliconPkg. This change removes the v1 definitions. V2 is intended to better support multiple silicon generations which aligns with the goals of I

[edk2-devel] [PATCH v2 1/5] OvmfPkg/Microvm/fdt: add device tree support

Add fdt parser from EmbeddedPkg (FdtLib and FdtClientDxe) to MicrovmX64. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3689 Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 6 ++ OvmfPkg/Microvm/MicrovmX64.fdf | 2 ++ 2 files changed, 8 insertions(+) diff --git a/Ovmf

[edk2-devel] [PATCH v2 3/5] OvmfPkg/Microvm/fdt: add empty fdt

FdtClient is unhappy without a device tree, so add an empty fdt which we can use in case etc/fdt is not present in fw_cfg. On ARM machines a device tree is mandatory for hardware detection, thats why FdtClient fails hard. On microvm the device tree is only used to detect virtio-mmio devices (this

[edk2-devel] [PATCH v2 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support

Add virtio-mmio support (VirtioMmioDeviceLib and VirtioFdtDxe). With this patch added and a new enough qemu version (6.2+) edk2 will detect virtio-mmio devices, so it is possible to boot from storage (virtio-blk, virtio-scsi) or network (virtio-net). https://bugzilla.tianocore.org/show_bug.cgi?id

[edk2-devel] [PATCH v2 2/5] OvmfPkg/Microvm/fdt: load fdt from fw_cfg

Needed for hardware detection: virtio-mmio devices for now, later also pcie root bridge. Depends on patched qemu which actually provides an fdt: https://gitlab.com/kraxel/qemu/-/commits/sirius/microvm-device-tree https://bugzilla.tianocore.org/show_bug.cgi?id=3689 Signed-off-by: Gerd Hoffmann --

[edk2-devel] [PATCH v2 0/5] [RfC] OvmfPkg/Microvm: second batch of microvm patches

Adds support for virtio-mmio devices to microvm. While being at it also add the README, the patch somehow disappeared from the first batch. v2: - qemu changes needed for this are merged and will be in the 6.2 release (dec 2021). - more verbose commit messages. Gerd Hoffmann (5): OvmfPkg/M

[edk2-devel] [PATCH v2 5/5] OvmfPkg/Microvm: add README

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/README | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 OvmfPkg/Microvm/README diff --git a/OvmfPkg/Microvm/README

[edk2-devel] [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3662 Two DEBUG macros in XhciDxe/XhciSched.c are missing the argument that should be passed for the print specifier. In addition, this change updates the print level to "DEBUG_ERROR" and prints the status as well. Cc: Jia

Re: [EXTERNAL] [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

I’d prefer to use EDK_TOOLS_PATH. Because of PACKAGES_PATH, the relative path does not depend on the WORKSPACE, the WORKSPACE can be set to anywhere. So we can’t assume the BaseTools is under WORKSPACE. But EDK_TOOLS_PATH always points to edk2/BaseTools. This patch does not break any of the use

[edk2-devel] [PATCH v2 1/7] MdePkg: Add missing Cache ID (in)valid define

Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Add Cache ID valid/invalid defines to Acpi64.h which were not initially added when the CacheIdValid field was added to EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE_FLAGS. Signed-off-by: Chris Jones --- MdePkg/Include/IndustryStandard/Acp

[edk2-devel] [PATCH v2 0/7] Support ACPI 6.4 PPTT changes

Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) This patch series updates the Acpiview PPTT parser and DynamicTablesPkg PPTT generator to support ACPI 6.4. This consists of two main changes: - The addition of the 'Cache ID' field. - The removal of the PPTT ID (type 2) struct

[edk2-devel] [PATCH v2 2/7] MdePkg: Remove PPTT ID type structure

Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) The ACPI 6.3A specification deprecated the PPTT ID type structure (type 2) therefore remove it from Acpi64.h. Mantis ID: 2072 (https://mantis.uefi.org/mantis/view.php?id=2072) Signed-off-by: Chris Jones --- MdePkg/Include/Ind

[edk2-devel] [PATCH v2 4/7] ShellPkg: Add Cache ID to PPTT parser

Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser with the Cache ID field and relevant validations as defined in tables 5.140 and 5.141 of the ACPI 6.4 specification. Signed-off-by: Chris Jones --- Notes: v2: - Fixed a bug where 'CacheF

[edk2-devel] [PATCH v2 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4

Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser to use Acpi64.h. As part of the changes, remove support for parsing PPTT type 2 ID structure. Signed-off-by: Chris Jones --- Notes: v2: - Changed PPTT ID error message to say "removed" i

[edk2-devel] [PATCH v2 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator with the CacheId field as defined in table 5.140 of the ACPI 6.4 specification. Also add validations to ensure that the cache id generated is unique. Signed-off-by: Chris Jones --- Notes: v2:

[edk2-devel] [PATCH v2 5/7] DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator

Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) ACPI 6.3A deprecated PPTT ID (type 2) structure which was subsequently removed in ACPI 6.4. Therefore remove support for generating PPTT ID structures. Signed-off-by: Chris Jones --- DynamicTablesPkg/Include/ArmNameSpaceObject

[edk2-devel] [PATCH v2 6/7] DynamicTablesPkg: Update PPTT generator to ACPI 6.4

Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator to use Acpi64.h. Signed-off-by: Chris Jones --- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --g

Re: [edk2-devel] RFC: Static Analysis in edk2 CI

Hi Felix, I think this is a great idea to add this to edk2 CI. I recommend we focus initially on a full scan once a week to get started. If we see lots of escapes, we can evaluate how to enable the scan on a submitted PR. What do you need with from the community to move this proposal forward?

Re: [EXTERNAL] [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

Sounds good. Will update in v3. - Bret From: Feng, Bob C Sent: Wednesday, November 3, 2021 8:35:33 AM To: Andrew Fish ; edk2-devel-groups-io ; Bret Barkelew Cc: Lindholm, Leif ; brbar...@microsoft.com ; Ard Biesheuvel ; Liming Gao ; Chen, Yuwei ; Sean Brogan

Re: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes

Thank you for the review, Liming. Since uploading the original patch series I noticed some issues myself and have sent a v2 for the patch series (https://edk2.groups.io/g/devel/message/83272). I have not made any MdePkg changes, so I assume your review carries over to the new series? Thanks,

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

Thanks. I have a couple of comments, but will otherwise send out a v2 patch later today. On 11/3/21 4:54 AM, Sami Mujawar wrote: On 20/09/2021 04:47 PM, Rebecca Cran via groups.io wrote: + + for (Index = 0; Index < NumCpus; Index++) { +Status = Mp->GetProcessorInfo (Mp, Index, &CpuInfo);

Re: [edk2-devel] [PATCH v1 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4

Hi Jeremy, While we have had some discussions internally, I thought I would share these with the rest of the list for those interested. No, this patch series does not break either build or runtime compatibility. If anyone tries to build an old table with PPTT ID type (type 2) structures then Ac

Re: [edk2-devel] [PATCH v1 0/3] IntelSiliconPkg: Remove v1 PCH SPI PPI and Protocol

For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, November 3, 2021 7:45 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepi

Re: [edk2-devel] [PATCH v1 0/3] IntelSiliconPkg: Remove v1 PCH SPI PPI and Protocol

For the series, Reviewed-by: Sai Chaganty -Original Message- From: mikub...@linux.microsoft.com Sent: Wednesday, November 03, 2021 7:45 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V ; Kethi Reddy, Deepika ; Esakkithevar, Kathappan ; Ni,

Re: [edk2-devel] [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64

Reviewed-by: Maciej Rabeda Mike, Who is going to do the PR? Thanks, Maciej On 03-Nov-21 04:05, Michael D Kinney wrote: Fix NetworkPkg build breaks for ARM and RISCV64 by adding RngLib mapping. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel S

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Changed commit title to: "NetworkPkg/HttpDxe: Enable wildcard host name matching for HTTP+TLS." Patch merged. PR: https://github.com/tianocore/edk2/pull/2168 Commit: https://github.com/tianocore/edk2/commit/6f9e83f757ed7c5c78d071f475b2e72d899c2aef On 02-Nov-21 20:54, Maciej Rabeda wrote: Hi

Re: [edk2-devel] [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64

I will do the PR for the series once all the reviews are complete. Thanks, Mike > -Original Message- > From: Rabeda, Maciej > Sent: Wednesday, November 3, 2021 2:25 PM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Wu, Jiaxin ; Fu, Siyuan ; Ard > Biesheuvel ; Chang, > Abner ; Sch

[edk2-devel] [PATCH] StdLib/LibC: add strnlen function wrapper

From: mateusz-mowka This patch adds strnlen function wrapper that internally calls AsciiStrnLenS, which is defined in BaseLib. Cc: Caleb Reister Cc: Rebecca Cran Cc: Michael D Kinney Signed-off-by: Mateusz Mówka --- StdLib/Include/string.h | 11 +++ StdLib/LibC/String/Misc.c | 12

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hi Jiewen, Thanks for checking. One of the issue is, ecc change required additional vsinstrincs to be included. If not, IA32 build will fail with __allmul undefined. So I have to include below in OVMFPKGIA32.dsc from Project Mu [LibraryClasses.IA32] NULL|MdePkg/Library/VsIntrinsicLib/VsIntrinsi

Re: [edk2-devel] [PATCH V2] MdeModulePkg/PciBusDxe: Enumerator to check for RCiEP before looking for RP

Hi, Any update on this topic? Damian From: Bassa, Damian Sent: Monday, September 20, 2021 6:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Wu, Hao A ; Kolakowski, Jacek Subject: [PATCH V2] MdeModulePkg/PciBusDxe: Enumerator to check for RCiEP before looking for RP Before trying to access parent

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Thanks a lot Maciej for merging the PR. Thanks, Vineel On Wed, Nov 3, 2021 at 2:29 PM Rabeda, Maciej wrote: > Changed commit title to: "NetworkPkg/HttpDxe: Enable wildcard host name > matching for HTTP+TLS." > > Patch merged. > PR: https://github.com/tianocore/edk2/pull/2168 > Commit: > > http

[edk2-devel] Patch for Bug 3704

Patch for Bug 3704 - OvmfPkgX64 RELEASE build fails with clang-13.   -- Михаил Кричанов   -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83294): https://edk2.groups.io/g/devel/message/83294 Mute This Topic: https://groups.io/mt/86803252

[edk2-devel] Patch for Bug 3715

  Patch for Bug 3715 - Some tools fail to compile for NOOPT with clang-13. -- Михаил Кричанов   -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83295): https://edk2.groups.io/g/devel/message/83295 Mute This Topic: https://groups.io/mt/86

[edk2-devel] [Patch V2 4/7] SignedCapsulePkg/SignedCapsulePkg.dsc: Add RngLib mapping

Fix build breaks for all architectures by adding RngLib mapping. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Michael D Kinney Reviewed-by: Daniel Schaefer --- SignedCapsulePkg/SignedCapsulePkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff -

[edk2-devel] [Patch V2 5/7] UefiCpuPkg/MtrrLib/UnitTest: Fix 32-bit GCC build issues

When using UT_ASSERT_EQUAL() on a pointer value, it must be cast to UINTN. This follows the samples provided with the UnitTestFrameworkPkg. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Michael D Kinney Reviewed-by: Philippe Mathieu-Daude --- UefiCpuPkg/Library/MtrrLib/UnitTest/Mt

[edk2-devel] [Patch V2 2/7] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64

Fix NetworkPkg build breaks for ARM and RISCV64 by adding RngLib mapping. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Michael D Kinney Reviewed-by: Daniel Schaefer Reviewed-by: Maciej Rabeda --- NetworkPkg/NetworkPkg

[edk2-devel] [Patch V2 6/7] MdeModulePkg/Variable/RuntimeDxeUnitTest: Fix 32-bit GCC builds

When using will_return() on a pointer value, it must be cast to UINTN to be compatible with 32-bit GCC builds. This uses the same approach in samples provided in the UnitTestFramworkPkg when passing pointer values to UT_ASSERT_EQUAL(). Cc: Hao A Wu Cc: Liming Gao Cc: Bret Barkelew Signed-off-by

[edk2-devel] [Patch V2 1/7] DynamicTablesPkg: Add missing BaseStackCheckLib instance

Fix ARM and AARCH64 build issues by adding the BaseStackCheckLib instance. Cc: Sami Mujawar Cc: Alexei Fedorov Cc: Ard Biesheuvel Signed-off-by: Michael D Kinney Reviewed-by: Sami Mujawar --- DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[edk2-devel] [Patch V2 7/7] BaseTools/Conf: Fix Linux GCC ARM build issues with HII

Update builds_rules.template to add $(SLINK) to the GCC steps for processing HII resources to produce a static library instead of an object file. This improves linker compatibility and specifically fixes a link failure seen on Linux GCC ARM builds of the MdeModulePkg due to mismatched ABI types be

[edk2-devel] [Patch V2 3/7] SecurityPkg/SecurityPkg.dsc: Add missing RngLib for ARM and RISCV64

Fix SecurityPkg build breaks for ARM and RISCV64 by adding RngLib mapping. Cc: Jiewen Yao Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Michael D Kinney Acked-by: Jiewen Yao Reviewed-by: Daniel Schaefer --- SecurityPkg/SecurityPkg.dsc | 9 -

[edk2-devel] [Patch V2 0/7] Fix package build issues

New in V2 - * Update build_rules.template to fix Linux GCC ARM build issue with HII resource sections. This patch series fixes a number of diffent package build issues. These were discovered when evaluating the source format changes from uncrustify and there where valid package builds

Re: [edk2-devel] [EXTERNAL] [Patch V2 6/7] MdeModulePkg/Variable/RuntimeDxeUnitTest: Fix 32-bit GCC builds

Reviewed-by: Bret Barkelew - Bret From: Michael D Kinney Sent: Wednesday, November 3, 2021 4:00 PM To: devel@edk2.groups.io Cc: Hao A Wu; Liming Gao; Bret Barkelew

Re: [edk2-devel] [Patch V2 2/7] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64

Reviewed-by: Abner Chang From: Michael D Kinney Sent: Thursday, November 4, 2021 6:59 AM To: devel@edk2.groups.io Cc: Maciej Rabeda ; Jiaxin Wu ; Siyuan Fu ; Ard Biesheuvel ; Chang, Abner (HPS SW/FW Technologist) ; Schaefer, Daniel (ROM Janitor) Subject: [Pat

Re: [edk2-devel] [Patch V2 3/7] SecurityPkg/SecurityPkg.dsc: Add missing RngLib for ARM and RISCV64

Acked-by: Abner Chang From: Michael D Kinney Sent: Thursday, November 4, 2021 6:59 AM To: devel@edk2.groups.io Cc: Jiewen Yao ; Jian J Wang ; Ard Biesheuvel ; Chang, Abner (HPS SW/FW Technologist) ; Schaefer, Daniel (ROM Janitor) ; Jiewen Yao Subject: [Patch

Re: [edk2-devel] [Patch V2 4/7] SignedCapsulePkg/SignedCapsulePkg.dsc: Add RngLib mapping

Acked-by: Abner Chang From: Michael D Kinney Sent: Thursday, November 4, 2021 6:59 AM To: devel@edk2.groups.io Cc: Jian J Wang ; Ard Biesheuvel ; Chang, Abner (HPS SW/FW Technologist) ; Schaefer, Daniel (ROM Janitor) Subject: [Patch V2 4/7] SignedCapsulePkg/Si

Re: [edk2-devel] [Patch V2 2/7] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64

Change my review tag to Acked-by. Acked-by: Abner Chang From: devel@edk2.groups.io on behalf of Abner Chang Sent: Thursday, November 4, 2021 8:20 AM To: Michael D Kinney ; devel@edk2.groups.io Cc: Maciej Rabeda ; Jiaxin Wu ; Siyuan Fu ; Ard Biesheuvel ; Sc

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments

> -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, November 3, 2021 11:16 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Liming Gao > ; Wu, Hao A ; Ni, Ray > > Subject: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG > arguments > > From: Michael Ku

Re: [edk2-devel] [Patch V2 6/7] MdeModulePkg/Variable/RuntimeDxeUnitTest: Fix 32-bit GCC builds

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Thursday, November 4, 2021 7:00 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Liming Gao > ; Bret Barkelew ; > Philippe Mathieu-Daude > Subject: [edk2-devel] [Patch V2 6/7] > MdeModulePkg/Variable/

Re: [edk2-devel] [Patch V2 5/7] UefiCpuPkg/MtrrLib/UnitTest: Fix 32-bit GCC build issues

Reviewed-by: Ray Ni -Original Message- From: Kinney, Michael D Sent: Thursday, November 4, 2021 7:00 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul1 ; Philippe Mathieu-Daude Subject: [Patch V2 5/7] UefiCpuPkg/MtrrLib/UnitTest: Fix 32-bit GCC build issues When usi

回复: [edk2-devel] [Patch V2 0/7] Reproduce builds across source format changes

Mike: I understand your point. This change is just for the binary comparison in NOOPT builds with all DEBUG and ASSERT macros enabled. I have no other comments. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2021年11月2日 15:11 > 收件人: gaoliming ; devel@

回复: [edk2-devel] 回复: [Patch V2 1/7] MdePkg/Include: Enhance DebugLib to support reproduce builds

Mike: OK. So, this change is to pass ECC. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Kinney, Michael D > 发送时间: 2021年11月2日 15:05 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Kinney, Michael > D > 抄送: Liu, Zhiguang ; 'Michael Kubacki' > > 主题: RE: [edk2-devel] 回复:

Re: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting.

Abdul: The following are the testing result using FWTS 21.08.00: spcr: SPCR Serial Port Console Redirection Table test. Test 1 of 3: SPCR Serial Port Console Redirection Table test. Serial Interface: 16550 compatible

[edk2-devel] 回复: [PATCH V4 1/3] MdePkg: Introduce CcMeasurementProtocol for CC Guest firmware

Min: I have one minor comment. gEfiCcFinalEventsTableGuid may be placed into [Guids] section instead of [Protocols] section. Thanks Liming > -邮件原件- > 发件人: Min Xu > 发送时间: 2021年11月2日 10:51 > 收件人: devel@edk2.groups.io > 抄送: Min Xu ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Jiewen

回复: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Always do S.M.A.R.T. check if device support

Hao: Thanks for your comment. I will update the commit log. Thanks Liming > -邮件原件- > 发件人: Wu, Hao A > 发送时间: 2021年11月2日 11:17 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: Ni, Ray > 主题: RE: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Always do > S.M.A.R.T. check

[edk2-devel] 回复: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments

Reviewed-by: Liming Gao > -邮件原件- > 发件人: mikub...@linux.microsoft.com > 发送时间: 2021年11月3日 23:16 > 收件人: devel@edk2.groups.io > 抄送: Jian J Wang ; Liming Gao > ; Hao A Wu ; Ray Ni > > 主题: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG > arguments > > From: Michael Kubacki > > RE

回复: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes

Sure. Liming. 发件人: Christopher Jones 发送时间: 2021年11月4日 0:20 收件人: gaoliming ; devel@edk2.groups.io 抄送: michael.d.kin...@intel.com; zhiguang@intel.com; ray...@intel.com; zhichao@intel.com; Alexei Fedorov ; Sami Mujawar ; nd 主题: Re: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT chan

回复: [edk2-devel] [Patch V2 7/7] BaseTools/Conf: Fix Linux GCC ARM build issues with HII

Mike: > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2021年11月4日 7:00 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng ; Liming Gao > ; Yuwei Chen ; Leif > Lindholm ; Ard Biesheuvel > 主题: [edk2-devel] [Patch V2 7/7] BaseTools/Conf: Fix Linux GCC ARM build > issues with HII

回复: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

Lefi: > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Leif Lindholm > 发送时间: 2021年11月2日 17:51 > 收件人: brbar...@microsoft.com > 抄送: devel@edk2.groups.io; Ard Biesheuvel ; > Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Sami > Mujawar ; Jiewen Yao ; > Supreeth Venkatesh ; Maciej Rabeda > ; Jiaxin

Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

> On Nov 3, 2021, at 11:23 PM, gaoliming wrote: > > Lefi: > >> -邮件原件- >> 发件人: devel@edk2.groups.io 代表 Leif Lindholm >> 发送时间: 2021年11月2日 17:51 >> 收件人: brbar...@microsoft.com >> 抄送: devel@edk2.groups.io; Ard Biesheuvel ; >> Michael D Kinney ; Liming Gao >> ; Zhiguang Liu ; Sami >> Muj

Re: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting.

[Public] Code changes looks good. Is fwts passing now? I think FWTS has wrong test case. It expects Global system interrupt number to be zero for APIC interrupt type, which is wrong. In my opinion it should check for Global system interrupt number for zero in case of PC-AT interrupt type. Than

[edk2-devel] [RFC] Application Process for https://bugzilla.tianocore.org/

Hi, all A change has been made in the account creation policy for the TianoCore Bugzilla server, new user needs to be approved by Admin. If you want to register the account in https://bugzilla.tianocore.org/, please follow below steps. 1. Join https://edk2.groups.io/g/devel, and subscrib