RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
XenTimerDxe is a local Apic timer driver and it has nothing to do
with Xen. So rename it to LocalApicTimerDxe.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
XenTimerDxe is a local Apic timer driver and it has nothing to do
with Xen. So rename it to LocalApicTimerDxe.
After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=FALSE.
Otherwise 8254 timer is used.
Patch #1:
Rename XenTimer
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
Discussion in https://bugzilla.tianocore.org/show_bug.cgi?id=1496 shows
that 8254TimerDxe was not written for OVMF. It was moved over from
PcAtChipsetPkg to OvmfPkg in 2019. Probably because OVMF was the only
user left.
Most likely the reas
If S.M.A.R.T. has been enabled, it can be checked.
Signed-off-by: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
---
.../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
b/Md
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Add macros CC_GUEST_IS_TDX/CC_GUEST_IS_SEV to check SEV/TDX guest.
Cc: Michael Roth
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Eric Dong
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: E
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
In TDVF BSP and APs are simplified. BSP is the vCPU-0, while the others
are treated as APs.
So MP intialization is rather simple. The processor info is retrieved by
TDCALL, ApWorker is not supported, BSP is always the working processor,
whi
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
In TDX BSP and APs goes to the same entry point in SecEntry.nasm.
BSP initialize the temporary stack and then jumps to SecMain, just as
legacy Ovmf does.
APs spin in a modified mailbox loop using initial mailbox structure.
Its structure de
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
In Tdx BSP may issues commands to APs for some task, for example, to
accept pages paralelly. BSP also need to wait until all the APs have
done the task. TdxMailboxLib wraps these common funtions for BSP.
Cc: Ard Biesheuvel
Cc: Jordan Juste
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
EFI_RESOURCE_ATTRIBUTE_ENCRYPTED is Physical memory encrypted attribute.
It indicates the memory uses platform encrpytion capabilities for
protection. If this bit is clear, the memory does not use platform
encryption protection.
Cc: Ard Bie
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
IntelTdx.h defines the defitions used by TDX in OvmfPkg:
- Mailbox related defitions,such as the data structure, command code,
AP relocation defitions.
- EFI_HOB_PLATFORM_INFO describes the TDX platform information
Cc: Ard Biesheuvel
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
When host VMM create the Td guest, the system memory informations are
stored in TdHob, which is a memory region described in Tdx metadata.
The system memory region in TdHob should be accepted before it can be
accessed. So the major task of t
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
If TDX is enabled then we do not support DMA operation in PEI phase.
This is mainly because DMA in TDX guest requires using bounce buffer
(which need to allocate dynamic memory and allocating a PAGE size'd
buffer can be challenge in PEI phas
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
In TDX IA32_ERER is RO to host VMM. It could not be changed.
PcdIa32EferChangeAllowed is added in MdeModulePkg.dec and it is
to be set to FALSE in Tdx guest.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Botto
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Qemu allows a ROM device to set to ROMD mode (default) or MMIO mode.
When it is in ROMD mode, the device is mapped to guest memory and
satisfies read access directly.
In EDK2 Option ROM is treated as MMIO region. So Tdx guest access
Option
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
MMIO region in Tdx guest is set with PcdTdxSharedBitMask when
creating 1:1 identity page table. In SEV guest the page table
entries is set with PcdPteMemoryEncryptionAddressOrMask when
creating 1:1 identity table.
So the AddressEncMask in G
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Intel TDX has its own requirement in InitializePlatform (PlatformPei).
1. Publish the ram region
Host VMM pass the memory region to TDVF in TD Hob. These memory
are accepted by TDVF before they're available for access. TDVF
publish the
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
In TDX the guest firmware is designed to publish a multiprocessor-wakeup
structure to let the guest-bootstrap processor wake up guest-application
processors with a mailbox. The mailbox is memory that the guest firmware
can reserve so each gu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
TdxDxe driver is dispatched early in DXE, due to being list in APRIORI.
This module is responsible for below features:
- Sets max logical cpus based on TDINFO
- Sets PCI PCDs based on resource hobs
Besides above features, TdxDxe driver wi
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Add Intel Tdx helper library. The library provides the routines to:
- set or clear Shared bit for a given memory region.
- query whether TDX is enabled.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
In the previous QemuFwCfgDxe only SEV is supported. This commit
introduce TDX support in QemuFwCfgDxe.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Ger
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
The IOMMU protocol driver provides capabilities to set a DMA access
attribute and methods to allocate, free, map and unmap the DMA memory
for the PCI Bus devices.
The current IoMmuDxe driver supports DMA operations inside SEV guest.
To supp
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
TdxLib is created with functions to perform the related Tdx operation.
This includes functions for:
- TdCall : Cause a VM exit to the Intel TDX module.
- TdVmCall: It helps invoke services from the host VMM to pass/
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
The base VmgExitLib library provides a default limited interface to
handle #VE exception. To provide full support, the OVMF version of
VmgExitLib is extended to provide full support of #VE handler.
PcdIgnoreVeHalt is created in OvmfPkg.dec
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
VmgExitLib performs the necessary processing to handle a #VC exception.
VmgExitLibNull is a NULL instance of VmgExitLib which provides a
default limited interface. In this commit VmgExitLibNull is extended to
handle a #VE exception with a de
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3249
Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology
that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory
Encryption (MKTME) with a new kind of virutal machines guest called a
Trust Domain (TD). A T
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Add base support to handle #VE exceptions. Update the common exception
handlers to invoke the VmTdExitHandleVe () function of the VmgExitLib
library when a #VE is encountered. A non-zero return code will propagate
to the targeted exception h
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Previously IoFifo functions are in X64/IoFifoSev.nasm which supports
both SEV guest and Legacy guest. IoLibFifo.c is introduced to support
SEV/TDX/Legacy guest in one binary. It checks the guest type in runtime
and call corresponding functio
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
This commit supports IoRead/IoWrite for SEV/TDX/Legacy guest in one
binary. It checks the guest type in runtime and then call corresponding
functions.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Brijesh Singh
Cc: Erdem Akta
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
TDVF access MMIO with TDG.VP.VMCALL to invoke VMM provided emulation
functions. If the access to MMIO fails, it fall backs to the direct
access.
BaseIoLibIntrinsic.inf is the IoLib used by other packages. It will
not support I/O in Td guest
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Intel TDX architecture does not prescribe a specific software convention
to perform I/O from the guest TD. Guest TD providers have many choices to
provide I/O to the guest. The common I/O models are emulated devices,
para-virtualized devices
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Tdx.h includes the Intel Trust Domain Extension definitions.
Detailed information can be found in below document:
https://software.intel.com/content/dam/develop/external/us/en/
documents/tdx-module-1eas-v0.85.039.pdf
Cc: Michael D Kinney
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
TdxLib is included in BaseXApicX2ApicLib. To prevent any build
breakage, update the UefiPayloadPkg.dsc to include the TdxLib
library.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Signed-off-
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
MSR is accessed in BaseXApicX2ApicLib. In TDX some MSRs are accessed
directly from/to CPU. Some should be accessed via explicit requests
from the host VMM using TDCALL(TDG.VP.VMCALL). This is done by the
help of TdxLib.
Please refer to [TDX
From: "Brijesh Singh via groups.io"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
While initializing APs, the MpInitLib may need to know whether the
guest is running with active AMD SEV or Intel TDX memory encryption.
Add a new ConfidentialComputingGuestAttr PCD that can be used to qu
Hi Min,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On Tue, Oct 26, 2021 at 10:19 PM, Min Xu wrote:
>
>
>>
>>> + if (TdProtocol != NULL) {
>>> + TdEvent = CreateTdEventFromTcg2Event (TdProtocol, Tcg2Event,
>>
>> EventSize);
>>
>>> + if (TdEvent == NULL) {
>>> + got
Hi Jiewen,
I agree using CC as in (EFI_CC_MEASUREMENT_PROTOCOL) would be much clearer.
Regards,
Sami Mujawar
On 29/10/2021, 01:17, "Yao, Jiewen" wrote:
I am OK to use EFI_CC_MEASUREMENT_PROTOCOL to replace
EFI_TEE_MEASUREMENT_PROTOCOL. (much better than COCO)
Samy
What do you t
Great. It seems we are all aligned.
> -Original Message-
> From: Sami Mujawar
> Sent: Monday, November 1, 2021 9:55 PM
> To: Yao, Jiewen ; Tom Lendacky
> ; Brijesh Singh ;
> kra...@redhat.com; Xu, Min M
> Cc: devel@edk2.groups.io; Erdem Aktas ; James
> Bottomley ; Dong, Eric ; Ni, Ray
>
Hi,
Any comments about this series?
On 10/15/21 5:06 PM, Ming Huang wrote:
> Fix issues in StandaloneMmPkg for supporting communicate from
> TF-A with secure buffer.
>
> Ming Huang (3):
> StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field
> StandaloneMmPkg: Replace DEBUG_INFO with DE
Reviewed-by: Guo Dong
-Original Message-
From: Xu, Min M
Sent: Monday, November 1, 2021 6:16 AM
To: devel@edk2.groups.io
Cc: Xu, Min M ; Dong, Guo ; Ni, Ray
; Ma, Maurice ; You, Benjamin
; Yao, Jiewen ; Gerd Hoffmann
Subject: [PATCH V3 10/29] UefiPayloadPkg: PreparePrepare UefiPay
Minor comment on the subject "PreparePrepare UefiPayloadPkg to use TdxLib".
Duplicated "Prepare" ?
Otherwise, looks good to me.
Reviewed-by: Maurice Ma
> -Original Message-
> From: Xu, Min M
> Sent: Monday, November 1, 2021 6:16
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Dong, G
Hi JP,
The updates to these 2 ReadMe.txt files is not complete and do not match the
updated to AppPkg/ReadMe.txt.
There is an additional paragraph with Python 2.x references.
Mike
> -Original Message-
> From: Jayaprakash, N
> Sent: Saturday, October 30, 2021 6:53 AM
> To: devel@edk2
On Thu, Oct 28, 2021 at 09:53:34 +0900, Masami Hiramatsu wrote:
> Hi Leif,
>
> Thank you for your reply!
>
> 2021年10月27日(水) 20:21 Leif Lindholm :
> >
> > Hi Masami,
> >
> > Apologies for delay.
> >
> > Thank you, this set looks good.
> > However, you cannot make legal statements on behalf of Saka
Hi Shashi,
The build fails after applying this patch.
Please resubmit after you have fixed *and* tested it.
/
Leif
On Wed, Oct 27, 2021 at 21:07:56 -0400, Shashi Mallela wrote:
> Setting the Always-on Capability bit in GTDT table for
> system PE timers in sbsa platform.This is also required
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3687
If a C structure parsed by the VFR compiler contains an unnamed
field, then mFieldName is left uninitialized, which generates
random data in the VFR compiler output file.
If the FieldName is NULL, then initialize pNewField->mFieldName
to a
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 6 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
SecurityPkg/Include/Library/TcgStorageCoreLib.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
This change is required to help verify that source code formatting
changes such as the use of uncrustify and line ending corrections
do not have any functional differences. Source format changes may
add or remove line endings that change the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
.../Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-
.../Smbios/SmbiosMiscDxe/Ty
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
* Add DEBUG_LINE_NUMBER define to DebugLib.h that is
by default mapped to __LINE__. A build can pre-define
DEBUG_LINE_NUMBER to use a fixed value.
* Add DEBUG_EXPRESSION_STRING(Expression) macrso to
DebugLib.h that is by default mappe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c| 2 +-
MdeModulePkg/Library/UefiBootManagerLib/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
NetworkPkg/Include/Library/NetLib.h | 8
NetworkPkg/Library/DxeNetLib/DxeNe
Hi Mike,
I didn’t notice this.
Will send an updated patch.
Sorry for the inconvenience.
Regards,
JP
-Original Message-
From: Kinney, Michael D
Sent: 01 November 2021 21:59
To: Jayaprakash, N ; devel@edk2.groups.io; Kinney,
Michael D
Cc: Rebecca Cran
Subject: RE: [edk2-libc Patch v
On Mon, Nov 01, 2021 at 18:54:57 +0100, Marcin Juszkiewicz wrote:
> From: Shashi Mallela
>
> Setting the Always-on Capability bit in GTDT table for
> system PE timers in sbsa platform.This is also required
> for ACS sbsa level 3 test compliancy.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc:
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83017): https://edk2.groups.io/g/devel/message/83017
Mute This Topic: https://groups.io/mt/86748823/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3589
This commit is to remove references to the py 2.7.2 UEFI port
in all documents from edk2-libc repo. This python interpreter
is no more supported on UEFI shell due to availability of
py 3.6.8 on UEFI.
Cc: Rebecca Cran
Cc: Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3589
This commit is to remove the document references to py 2.7.10
UEFI port. Py2.7.10 is no more supported as it has reached EOL
starting from 1st Jan 2020. You may use the version py 3.6.8
available for uefi shell from edk2-libc.
Cc: Rebecca C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3589
This commit is to update remaining references to py 2.7.10 in
StdLib/Readme.txt and StdLibPrivateInternalFiles/ReadMe.txt
documents to py3.6.8.
Cc: Rebecca Cran
Cc: Michael D Kinney
Signed-off-by: Jayaprakash N
---
StdLib/ReadMe.txt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3589
This commit is to update references to py 2.7.10 in
StdLib/Readme.txt and StdLibPrivateInternalFiles/ReadMe.txt
documents to py3.6.8.
Cc: Rebecca Cran
Cc: Michael D Kinney
Signed-off-by: Jayaprakash N
---
StdLib/ReadMe.txt
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83022): https://edk2.groups.io/g/devel/message/83022
Mute This Topic: https://groups.io/mt/86748855/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/
Hi Mike,
Submitted the updated PR.
Regards,
JP
-Original Message-
From: Jayaprakash, N
Sent: 02 November 2021 00:01
To: Kinney, Michael D ; devel@edk2.groups.io
Cc: Rebecca Cran
Subject: RE: [edk2-libc Patch v3 5/5] AppPkg/Applications/Python: to update
readme files in edk2-libc
Hi M
On Mon, Nov 01, 2021 at 11:29:37 -0700, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
>
> * Add DEBUG_LINE_NUMBER define to DebugLib.h that is
> by default mapped to __LINE__. A build can pre-define
> DEBUG_LINE_NUMBER to use a fixed value.
> * Add DEBUG_E
On Mon, Nov 01, 2021 at 11:29:38 -0700, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
>
> Use DEBUG_LINE_NUMBER instead of __LINE__.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Michael Kubacki
> Signed-off-by: Michael D Kinney
Reviewed-by: Leif Lindh
From: Shashi Mallela
Setting the Always-on Capability bit in GTDT table for
system PE timers in sbsa platform.This is also required
for ACS sbsa level 3 test compliancy.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Graeme Gregory
Signed-off-by: Shashi Mallela
[fixed compilation error]
Signed-o
For the series:
Tested-by: Michael Kubacki
On 11/1/2021 2:29 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
This change is required to help verify that source code formatting
changes such as the use of uncrustify and line ending corrections
do not have an
Series Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jayaprakash, N
> Sent: Monday, November 1, 2021 11:35 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Kinney, Michael D
> ; Jayaprakash, N
>
> Subject: [edk2-libc Patch V4 6/6] AppPkg/Applications/Python: to fix read
This series of patch commits moves a number of modules and libraries around in
order
to better un-silo the Arm-specific code. Unnecessary abstractions were removed,
some
duplicate code was abstracted, and generally things were cleaned up so that
common
code (e.g. MdePkg, MdeModulePkg, Standalone
From: Bret Barkelew
Not sure what all module types this HAS been validated against, but it
doesn't work with STANDALONE_MM or STANDALONE_MM_CORE.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
A
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 37
ArmPkg/Library/StandaloneMmMmuLib/ArmMmu
From: Bret Barkelew
StandaloneMmMmuLib has been turned into an implementation of the
ArmMmuLib class.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
Stand
From: Bret Barkelew
This extra interface is redundant and unnecessary. Dropping it is
more EDK2-ish.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
ArmPkg/ArmPkg.dec |
From: Bret Barkelew
This aligns better with Mu's philosophy around dependency structuring
and is one of the steps to enable Basecore to have zero CI dependencies
on other Mu repos.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3649
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Michael D Kinn
From: Bret Barkelew
This aligns better with Mu's philosophy around dependency structuring
and is one of the steps to enable Basecore to have zero CI dependencies
on other Mu repos.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3650
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Bob Feng
Cc:
From: Bret Barkelew
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
{ArmPkg => MdePkg}/Include/AsmMacroIoLib.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/ArmPkg/Include/AsmMa
From: Bret Barkelew
There are a number of Arm-specific accesses that are abstracted
behind this. It may need to be refactored to work better across
architectures.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Sean Brogan
Si
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
Cc: Liming Gao
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
MdeModulePkg/Core/DxeIplPeim/Arm/DxeLoadFunc.c | 4 ++--
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/AArch64/StandaloneMmPeCoffExtra
From: Sean Brogan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
ArmPkg/Library/MmuLib/MmuLib.c | 120
ArmPkg/ArmPkg.dsc| 1 +
ArmPkg/Library/MmuL
From: Bret Barkelew
This aligns better with Mu's philosophy around dependency structuring
and is one of the steps to enable Basecore to have zero CI dependencies
on other Mu repos.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
From: Bret Barkelew
Drop X64 references. Update GUID.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
ArmPkg/Library/StandaloneMmCoreEntryPoint/X64/StandaloneMmCoreEntryPoint.c |
71
From: Bret Barkelew
This aligns better with Mu's philosophy around dependency structuring
and is one of the steps to enable Basecore to have zero CI dependencies
on other Mu repos.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
ArmPkg/ArmPkg.dsc | 8
1 file changed, 8 insertions(+)
diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index 4741a9
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sean Brogan
Signed-off-by: Bret Barkelew
---
ArmPlatformPkg/ArmPlatformPkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ArmPlatformPkg/ArmPlatf
Reviewed-by: Isaac Oram
Please note subject/title and message body indicate PurleyOpenBoardPkg, but
actual file is located in WhitleyOpenBoardPkg.
I don't see any content difference and think it would be better to modify INF
to include IntelSiliconPkg/IntelSiliconPkg.dec.
I can do this in the
Reviewed-by: Isaac Oram
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Thursday, October 28, 2021 1:43 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Desimone, Nathaniel L
; Chiu, Chasel
Subject: [PATCH v6 26/52] WhitleyOpenBoardPkg: UseIntelSiliconPkg
SpiFvbServiceSmm
Thanks for pointing that out. This was a mistake in copying/pasting
patch subject lines and your plan to extend WhitleyOpenBoardPkg to use
IntelSiliconPkg sounds good.
If the package names in the commit message can be corrected before
pushing that would be great.
Thanks,
Michael
On 11/1/202
Series Reviewed-by: Isaac Oram
These PCD already exist:
gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress|0xFF80|UINT32|0x1001
gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize|0x0080|UINT32|0x1002
gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0xFFE6|UINT32|0
Thanks for looking at the series. I would also like to see the PCDs get
consolidated if possible.
Regards,
Michael
On 11/1/2021 4:43 PM, Oram, Isaac W wrote:
Series Reviewed-by: Isaac Oram
These PCD already exist:
gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress|0xFF80|UINT32|0
Quick PS: I CC'd the edk2-platforms stewards on the patch because there's
no co-maintainer, and from what I gathered, that's what I'm supposed to do.
If I'm mistaken, please let me know.
Thanks,
Pedro
On Fri, Oct 29, 2021 at 2:04 AM Pedro Falcato via groups.io wrote:
> Uninitialized extents are
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
* Add DEBUG_LINE_NUMBER define to DebugLib.h that is
by default mapped to __LINE__. A build can define
DEBUG_LINE_NUMBER to use a fixed value.
* Add DEBUG_EXPRESSION_STRING(Expression) macros to
DebugLib.h that is by default mapped to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
* Use DEBUG_LINE_NUMBER instead of __LINE__.
* Use DEBUG_EXPRESSION_STRING instead of #Expression.
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
MdePkg/Include/Library/UnitTestLib.h | 46 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c| 2 +-
MdeModulePkg/Library/UefiBootManagerLib/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
.../Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-
.../Smbios/SmbiosMiscDxe/Ty
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
NetworkPkg/Include/Library/NetLib.h | 8
NetworkPkg/Library/DxeNetLib/DxeNe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
New in V2
* Split MdePkg DebugLib class enhancements out into its own commit
* Address ECC failures
* Align macro continuation marks in same column
This change is required to help verify that source code formatting
changes such
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 6 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
Use DEBUG_LINE_NUMBER instead of __LINE__.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Michael Kubacki
Signed-off-by: Michael D Kinney
---
.../Include/Library/TcgStorageCoreLib.h | 26 +--
1 file changed, 13 insertions(+),
To reduce the amount of template code, introduce SMC helper
functions. Update ArmSmcPsciResetSystemLib and Universal/Smbios to use
them.
Changes from v1 to v2:
Added a patch to update code to use the new functions.
Rebecca Cran (2):
ArmPkg: Add SMC helper functions
ArmPkg: Update SMC calls t
Add functions ArmCallSmc0/1/2/3 to do SMC calls with 0, 1, 2 or 3
arguments.
The functions return up to 3 values.
Signed-off-by: Rebecca Cran
---
ArmPkg/Include/Library/ArmSmcLib.h | 73
ArmPkg/Library/ArmSmcLib/ArmSmc.c| 122
ArmPkg/Libra
New SMC helper functions have been added to reduce the amount of
template code. Update ArmSmcPsciResetSystemLib and
Smbios/ProcessorSubClassDxe to use them.
Signed-off-by: Rebecca Cran
---
ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c | 10
++-
ArmPkg/Universal/Smb
On Monday, November 1, 2021 11:59 PM, Ma, Maurice wrote:
> Minor comment on the subject "PreparePrepare UefiPayloadPkg to use TdxLib".
> Duplicated "Prepare" ?
Thanks much for the reminder. It will be fixed in the next version.
> Otherwise, looks good to me.
>
> Reviewed-by: Maurice Ma
>
Thanks
1 - 100 of 129 matches
Mail list logo
