[edk2-devel] [PATCH v3 1/3] MdeModulePkg/UniversalPayload: Add definition for extra info in payload

2021-06-16 Thread Ni, Ray
The payload is in ELF format per the universal payload spec. UNIVERSAL_PAYLOAD_INFO_HEADER is stored in the ELF payload as a separate section named ".upld_info". Extra data needed by payload is stored in sections whose name starts with ".upld.". Signed-off-by: Ray Ni Cc: Maurice Ma Cc: Guo Dong

[edk2-devel] [PATCH v3 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

2021-06-16 Thread Ni, Ray
Per universal payload spec, the payload is in ELF format. The patch adds a payload loader that supports to load ELF image. The location of extra data sections whose names start with "upld." is stored in UNIVERSAL_PAYLOAD_EXTRA_DATA HOB. Signed-off-by: Maurice Ma Signed-off-by: Ray Ni Cc: Mauric

[edk2-devel] [PATCH v3 3/3] PeiCore: Remove assertion when failing to load PE image

2021-06-16 Thread Ni, Ray
EFI_PEI_LOAD_FILE_PPI is invoked by DxeIpl for loading DxeCore. It's possible that the instance produced by PeiCore fails to load but other instances of EFI_PEI_LOAD_FILE_PPI can load. Signed-off-by: Ray Ni Cc: Jian J Wang Acked-by: Hao A Wu Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/Core

Re: [edk2-devel] [PATCH v3 0/3] Add PayloadLoaderPeim which can load ELF payload

2021-06-16 Thread Ni, Ray
Since the V3 did a very straightforward change which is to change PLD_ to UNIVERSAL_PAYLOAD_. I will carry all the Reviewed-by/Acked-by from V2 and merge directly. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, June 16, 2021 2:59 PM > To: devel@e

Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

2021-06-16 Thread Marvin Häuser
Good day, May I ask about two small things? 1) Was there any rationale as to e.g. code compatibility with choosing UINT64 for the data length? I understand that this is the maximum of the two as of currently, but I wonder whether a message length that exceeds the UINT32 range (4 GB!) can poss

[edk2-devel] [PATCH 1/2] Maintainers.txt: Add Reviewers for Universal Payload definitions

2021-06-16 Thread Ni, Ray
Signed-off-by: Ray Ni Cc: Hao A Wu --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index a359919fef..264b47edd9 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -227,6 +227,11 @@ W: https://github.com/tianocore/tianocore.github

[edk2-devel] [PATCH 2/2] Maintainers.txt: Add reviewers for ACPI and SMBIOS modules

2021-06-16 Thread Ni, Ray
Per discussion with MdeModulePkg package maintainer, add Zhiguang as one of the reviewers for ACPI and SMBIOS modules. Signed-off-by: Ray Ni Cc: Hao A Wu --- Maintainers.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 264b47edd9..2622cd51a3 1006

[edk2-devel] [PATCH 0/2] Add reviewers for MdeModulePkg

2021-06-16 Thread Ni, Ray
Ray Ni (2): Maintainers.txt: Add Reviewers for Universal Payload definitions Maintainers.txt: Add reviewers for ACPI and SMBIOS modules Maintainers.txt | 7 +++ 1 file changed, 7 insertions(+) -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent

[edk2-devel] [patch v2 1/1] BaseTools GenFw: Keep read only alloc section as text when convert ELF

2021-06-16 Thread gaoliming
From: gaoliming This is the fix of the regression issue at c6b872c6. Based on ELF spec, readonly alloc section is .rodata section. It is used. This fix is to add back original check logic for ELF section. Now, the readonly alloc section and execute alloc section are regarded as .text. Signed-off

Re: [edk2-devel] [PATCH 1/2] Maintainers.txt: Add Reviewers for Universal Payload definitions

2021-06-16 Thread Wu, Hao A
> -Original Message- > From: Ni, Ray > Sent: Wednesday, June 16, 2021 3:15 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A > Subject: [PATCH 1/2] Maintainers.txt: Add Reviewers for Universal Payload > definitions > > Signed-off-by: Ray Ni > Cc: Hao A Wu > --- > Maintainers.txt | 5 +

Re: [edk2-devel] [PATCH 2/2] Maintainers.txt: Add reviewers for ACPI and SMBIOS modules

2021-06-16 Thread Wu, Hao A
-Original Message- > From: Ni, Ray > Sent: Wednesday, June 16, 2021 3:15 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A > Subject: [PATCH 2/2] Maintainers.txt: Add reviewers for ACPI and SMBIOS > modules > > Per discussion with MdeModulePkg package maintainer, add > Zhiguang as one of th

Re: [edk2-devel] [patch v2 1/1] BaseTools GenFw: Keep read only alloc section as text when convert ELF

2021-06-16 Thread Bob Feng
Created a PR. https://github.com/tianocore/edk2/pull/1724 -Original Message- From: Liming Gao Sent: Wednesday, June 16, 2021 3:58 PM To: devel@edk2.groups.io Cc: gaoliming ; Feng, Bob C ; Ni, Ray Subject: [patch v2 1/1] BaseTools GenFw: Keep read only alloc section as text when conver

Re: [edk2-devel] [RESEND PATCH v2] BaseTools: Add support for RISCV GOT/PLT relocations

2021-06-16 Thread Pete Batard
Sunil, Daniel, thanks for the patch. I confirm that this addresses the 0x13 and 0x14 relocation issues that I was seeing. However, this patch appears to introduces new R_RISCV_PCREL_LO12_S relocation errors that I was not seeing previously, so I still can't manage to get a successful compila

[edk2-devel] reg: Static Code Analyzer Issues

2021-06-16 Thread Sivaraman Nainar
Hello Maciej: This is regarding the Code analyzer issue reported on the PxeBcDhcp4CallBack() and PxeBcDhcp6CallBack() functions of UEFIPXEBC Driver. In both the functions the allowed event are Dhcp4RcvdOffer, Dhcp4SelectOffer, Dhcp4SendDiscover, Dhcp4RcvdAck. If any other event comes as input i

Re: [edk2-devel] [patch v2 1/1] BaseTools GenFw: Keep read only alloc section as text when convert ELF

2021-06-16 Thread Bob Feng
Create a new PR. https://github.com/tianocore/edk2/pull/1725 -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Wednesday, June 16, 2021 6:53 PM To: Liming Gao ; devel@edk2.groups.io Cc: Ni, Ray Subject: Re: [edk2-devel] [patch v2 1/1] BaseTools GenFw: Keep read on

Re: [edk2-devel] [Patch] StandaloneMmPkg: Fixed communicating from TF-A failed issue

2021-06-16 Thread Ard Biesheuvel
On Wed, 16 Jun 2021 at 07:30, Omkar Kulkarni wrote: > > > On 6/10/21 6:44 AM, Ming Huang via groups.io wrote: > > On 6/9/21 3:10 PM, Ard Biesheuvel wrote: > > > On Tue, 8 Jun 2021 at 16:21, Ming Huang > > wrote: > > >> > > >> TF-A: TrustedFirmware-a > > >> SPM: Secure Partition Manager(MM) > > >>

Re: [edk2-devel] [edk2-non-osi][PATCH 1/1] Platform/RaspberryPi: Update TF-A to v2.5

2021-06-16 Thread Ard Biesheuvel
Acked-by: Ard Biesheuvel Pushed as 9c509e9b00cc..e1bb27fb825b Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76595): https://edk2.groups.io/g/devel/message/76595 Mute This Topic: https://groups.io/mt/83558386/21656 Group Owner:

Re: [edk2-devel] [edk2-platforms][PATCH v2 16/32] AmpereAltraPkg: Add PciHostBridge driver

2021-06-16 Thread Ard Biesheuvel
On Tue, 15 Jun 2021 at 17:54, Nhi Pham wrote: > > On 6/9/21 12:29, Ard Biesheuvel wrote: > > On Wed, 26 May 2021 at 12:12, Nhi Pham wrote: > >> From: Vu Nguyen > >> > >> The roles of this driver: > >> * Consume PcieCoreLib to initialize all enable PCIe controllers. > >> * Produce neccessary prot

Re: [edk2-devel] [PATCH v2 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmCache.h

2021-06-16 Thread Ard Biesheuvel
On Mon, 14 Jun 2021 at 20:57, Rebecca Cran wrote: > > Many of the cache definitions in ArmLibPrivate.h are being used outside > of ArmLib, in Universal/Smbios. Move them into ArmCache.h to make them > public, and remove the include of ArmLibPrivate.h from files in > Universal/Smbios. > > Signed-of

Re: [edk2-devel] [PATCH RESEND v1 0/2] ArmVirtPkg: Enable PCIe support for Kvmtool

2021-06-16 Thread Ard Biesheuvel
On Tue, 15 Jun 2021 at 17:21, wrote: > > From: Pierre Gondois > > PCIe support has been added to the Kvmtool virtual machine > manager. Therefore, add a PciHostBridgeUtilityLib and enable > PCIe support for Kvmtool firmware. > > The patches were re-send as the devel@edk2.groups.io was not include

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: Remove Xen remnants

2021-06-16 Thread Ard Biesheuvel
On Sat, 12 Jun 2021 at 23:08, Rebecca Cran wrote: > > Several Xen remnants were left over from adapting the Ovmf code for > Bhyve. Remove them. > > Signed-off-by: Rebecca Cran Hi Rebecca, This fails to apply. Is it perhaps conflicting with your TPM removal patch? > --- > OvmfPkg/Bhyve/AcpiPla

Re: [edk2-devel] [PATCH v2 1/4] StandaloneMmPkg: Core: Spelling error in comment

2021-06-16 Thread Ard Biesheuvel
On Mon, 14 Jun 2021 at 20:34, Kun Qin wrote: > > From: Sean Brogan > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 > > This change fixed a misspelling that was not caught by spell check. > > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Cc: Sea

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

2021-06-16 Thread Ard Biesheuvel
(+ Sean, Mike) On Sat, 12 Jun 2021 at 22:43, Rebecca Cran wrote: > > TPM support hasn't been tested and any lines in the .dsc and .fdf files > that appear to show support are bogus. Remove them. > > This fixes https://bugzilla.tianocore.org/show_bug.cgi?id=3354 . > > Signed-off-by: Rebecca Cran

[edk2-devel] [PATCH v1 1/1] MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy

2021-06-16 Thread Kenneth Lautner
From: Ken Lautner Changed BdsEntry.c to use Variable Policy instead of Variable Lock as Variable Lock will be Deprecated eventually Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Kenneth Lautner Fixed Library References Quick revert MdeModulePkg/BdsDxe: Fixed Libr

Re: [edk2-devel] [PATCH v1 2/8] MdePkg: IORT header update for IORT Rev E.b spec

2021-06-16 Thread Sami Mujawar
Hi All, I realised that setting EFI_ACPI_IO_REMAPPING_TABLE_REVISION to 3 (Rev 3) will break existing platforms as they would not be populating the Identifier field in the IORT nodes. This can result in the Identifier fileds being non-unique. I will send out a v2 patch series that sets EFI_

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

2021-06-16 Thread Sean
Ard, The PR you are trying to "push" has a mergify merge in it which is causing patchcheck to fail. https://github.com/tianocore/edk2/pull/1727/commits Mike, I think github has better features now around things like auto complete PR when "checks pass" and allow rebase merging and finally

Re: [edk2-devel] [PATCH v1 0/5] EDK2 Code First: PI Specification: Update EFI_MM_COMMUNICATE_HEADER

2021-06-16 Thread Kun Qin
Hi Marvin, Thanks for reaching out. Please see my comment inline. Regards, Kun On 06/16/2021 00:02, Marvin Häuser wrote: Good day, May I ask about two small things? 1) Was there any rationale as to e.g. code compatibility with choosing UINT64 for the data length? I understand that this is t

Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

2021-06-16 Thread Kun Qin
Hi pipeline maintainers, Could you please help reviewing this specific patch? Thanks to Ard, the other patches in this series are already reviewed and merged. Regards, Kun On 06/14/2021 11:34, Kun Qin via groups.io wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 Per update

Re: [edk2-devel] SIMPLE_TEXT_OUTPUT_PROTOCOL and Video Resolution

2021-06-16 Thread David F.
Also, I found if there are 2 GOP handles and you change the mode of one, the other one doesn't reflect the change (but still doesn't solve anything with the original question), are you supposed to set the mode on every handle to keep that part in sync? On Tue, Jun 15, 2021 at 11:33 PM David F. via

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

2021-06-16 Thread Ard Biesheuvel
On Wed, 16 Jun 2021 at 21:00, Sean Brogan wrote: > > Ard, > > The PR you are trying to "push" has a mergify merge in it which is > causing patchcheck to fail. > > https://github.com/tianocore/edk2/pull/1727/commits > Ah, I missed that. So the base of my branch was out of date, and the merge was d

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

2021-06-16 Thread Michael D Kinney
Hi Ard, I was not merged into edk2/master. PatchCheck failed due to the merge commit in the submitted PR. You will just need to resubmit the PR without the merge commit and rebased against latest edk2/master, and it will then be able to go through. Mike > -Original Message- > From: Ar

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy

2021-06-16 Thread Kenneth Lautner
This needs more editorial changes so disregard for now and I'll resend it when it's better. Sorry about that. On Wed, Jun 16, 2021 at 10:35 AM Kenneth Lautner via groups.io wrote: > From: Ken Lautner > > Changed BdsEntry.c to use Variable Policy instead of Variable Lock > as Variable Lock will

[edk2-devel] [PATCH v2 1/1] MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy

2021-06-16 Thread Kenneth Lautner
From: Ken Lautner Changed BdsEntry.c to use Variable Policy instead of Variable Lock as Variable Lock will be Deprecated eventually Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Liming Gao Signed-off-by: Kenneth Lautner Reviewed-by Liming Gao --- MdeModulePkg/Universal/Bds

Re: [edk2-devel] SIMPLE_TEXT_OUTPUT_PROTOCOL and Video Resolution

2021-06-16 Thread Andrew Fish via groups.io
> On Jun 16, 2021, at 2:45 PM, David F. wrote: > > Also, I found if there are 2 GOP handles and you change the mode of > one, the other one doesn't reflect the change (but still doesn't solve > anything with the original question), are you supposed to set the mode > on every handle to keep that

[edk2-devel] [edk2-platforms] [PATCH V1 0/2] Support for TiogaPass Platform and Override generic PciBus Driver with

2021-06-16 Thread manickavasakam karpagavinayagam
Add BoardTiogaPass packages to support TiogaPass Platform Enabled Network, ISCSI,IPMI, SMBIOS, Performance Measurement Remove AST2500 UEFI option ROM driver from PurleyOpenBoardPkg AST2500 UEFI option ROM move to edk2-non-osi ASpeedGopBinPkg Update copyright headers manickavasakam karpagavinaya

[edk2-devel] [edk2-platforms] [PATCH V1] PurleyOpenBoardPkg : Support for LINUX Boot

2021-06-16 Thread manickavasakam karpagavinayagam
Support for LINUX Boot To enable/disable feature, PcdLinuxBootEnable can be used 1. Follow directions on http://osresearch.net/Building/ to compile the heads kernel and initrd for qemu-system_x86_64 2. Copy the following built files (1) initrd.cpio.xz to LinuxBootPkg/LinuxBinaries/initr

[edk2-devel] [edk2-non-osi] [PATCH] ASpeed : ASpeedGopBinPkg : Add X64 ASpeedAst2500Gop UEFI Driver

2021-06-16 Thread manickavasakam karpagavinayagam
Add X64 ASpeedAst2500Gop UEFI Driver --- .../ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 .../ASpeedGopBinPkg/X64/ASpeedAst2500Gop.efi| Bin 0 -> 36928 bytes 2 files changed, 4 insertions(+) create mode 100644 Drivers/ASpeed/ASpeedGopBinPkg/X64/ASpeedAst2500Gop.efi diff --git a/Dr

Re: [EXTERNAL] RE: [edk2-devel] [edk2-platforms][PATCH 0/2] Support for TiogaPass Platform and Override generic PciBus Driver with

2021-06-16 Thread manickavasakam karpagavinayagam
Nate : Thank you for your review comments. Addressed all below comments and sent V1 patches and new patch for ASPEED 2500 GOP driver [edk2-platforms] [PATCH V1 0/2] Support for TiogaPass Platform and Override generic PciBus Driver with [edk2-platforms] [PATCH V1 1/2] PurleyOpenBoardPkg : Suppor

[edk2-devel] [edk2-platforms] [PATCH V1 1/2] PurleyOpenBoardPkg : Support for TiogaPass Platform

2021-06-16 Thread manickavasakam karpagavinayagam
Add BoardTiogaPass packages to support TiogaPass Platform Enabled Network, ISCSI,IPMI, SMBIOS, Performance Measurement Remove AST2500 UEFI option ROM driver from PurleyOpenBoardPkg AST2500 UEFI option ROM move to edk2-non-osi ASpeedGopBinPkg Update copyright headers manickavasakam karpagavinay

[edk2-devel] [edk2-platforms] [PATCH V1 0/2] Support for TiogaPass Platform and Override generic PciBus Driver with

2021-06-16 Thread manickavasakam karpagavinayagam
Add BoardTiogaPass packages to support TiogaPass Platform Enabled Network, ISCSI,IPMI, SMBIOS, Performance Measurement Remove AST2500 UEFI option ROM driver from PurleyOpenBoardPkg AST2500 UEFI option ROM move to edk2-non-osi ASpeedGopBinPkg Update copyright headers manickavasakam karpagavinayagam

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Improve bootloader memrange parsing

2021-06-16 Thread Ma, Maurice
Hi, Rudolph, Thank you for submitting the patch. In general the approach looks good to me. Here I have several minor comments on your patch as listed below: 1. For global variable in module, could we add "m" prefix ? EX: Change "TopOfLowerUsableDram" to "mTopOfLowerUsableDram" ? 2. Ple

[edk2-devel] FW: [edk2-platforms] [PATCH V1 0/2] Support for TiogaPass Platform and Override generic PciBus Driver with

2021-06-16 Thread Nate DeSimone
Hi Everyone, It seems like Manic is having issues sending his patch series to the mailing list. I will forward it to the list on Manic's behalf while he gets these issues sorted out with his email system. Thanks, Nate -Original Message- From: manickavasakam karpagavinayagam Sent: Wed

[edk2-devel] [edk2-platforms] [PATCH V1] PurleyOpenBoardPkg : Support for LINUX Boot

2021-06-16 Thread Nate DeSimone
From: Manickavasakam Karpagavinayagam Support for LINUX Boot To enable/disable feature, PcdLinuxBootEnable can be used 1. Follow directions on http://osresearch.net/Building/ to compile the heads kernel and initrd for qemu-system_x86_64 2. Copy the following built files (1) initrd.cpio

[edk2-devel] [edk2-non-osi] [PATCH] ASpeed : ASpeedGopBinPkg : Add X64 ASpeedAst2500Gop UEFI Driver

2021-06-16 Thread Nate DeSimone
From: manickavasakam karpagavinayagam Add X64 ASpeedAst2500Gop UEFI Driver Cc: Isaac Oram Cc: Felix Polyudov Cc: Harikrishna Doppalapudi Cc: Manish Jha Cc: Zachary Bobroff Cc: Manickavasakam Karpagavinayagam --- .../ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 .../ASpeedGopBinP

[edk2-devel] 回复: [PATCH v2 1/1] MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy

2021-06-16 Thread gaoliming
Ken: Thanks for your update. Please also update MdeModulePkg\Universal\BdsDxe\Bds.h to remove #include , because EDKII_VARIABLE_LOCK_PROTOCOL is not used any more. Thanks Liming > -邮件原件- > 发件人: kenlautn...@gmail.com > 发送时间: 2021年6月17日 6:45 > 收件人: devel@edk2.groups.io > 抄送: Jian J Wang

Re: [edk2-devel] [PATCH v2 0/6] Secure Boot default keys

2021-06-16 Thread Min Xu
On 06/14/2021 5:48 PM, Grzegorz Bernacki Wrote: > Hi Min M, > > Please find log from tests of OvmfX64 built with VS2019 at: > https://drive.google.com/file/d/18w7s6GxIz3aeId22xABMib7I3JX7G9X1/view?u > sp=sharing > Usually we summarize the test in a table which is posted in the mail thread, so th

回复: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow

2021-06-16 Thread gaoliming
Create PR https://github.com/tianocore/edk2/pull/1728 for it. This patch has been reviewed by Ray Ni. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sumana > Venur > 发送时间: 2021年6月12日 1:02 > 收件人: Ni, Ray ; Wu, Hao A > 抄送: devel@edk2.groups.io > 主题: Re: [edk2-devel] [PATCH] MdeMo

回复: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat

2021-06-16 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2021年6月13日 11:35 > 收件人: Bob Feng ; Liming Gao > ; Yuwei Chen > 抄送: Rebecca Cran ; devel@edk2.groups.io > 主题: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in > toolset.bat > > Split is now

回复: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat

2021-06-16 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2021年6月13日 11:56 > 收件人: Bob Feng ; Liming Gao > ; Yuwei Chen > 抄送: Rebecca Cran ; devel@edk2.groups.io > 主题: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and > "overwriting" in toolset.ba

回复: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check

2021-06-16 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2021年6月13日 11:43 > 收件人: Bob Feng ; Liming Gao > ; Yuwei Chen > 抄送: Rebecca Cran ; devel@edk2.groups.io > 主题: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat > after edk2basetools check

[edk2-devel] 回复: [RESEND PATCH v2] BaseTools: Add support for RISCV GOT/PLT relocations

2021-06-16 Thread gaoliming
Sunil: I add my comments below. Thanks Liming > -邮件原件- > 发件人: Sunil V L > 发送时间: 2021年6月11日 22:05 > 收件人: devel@edk2.groups.io > 抄送: Sunil V L ; Abner Chang > ; Daniel Schaefer ; Bob > Feng ; Liming Gao ; > Yuwei Chen ; Heinrich Schuchardt > > 主题: [RESEND PATCH v2] BaseTools: Add suppor

[edk2-devel] 回复: [PATCH v2 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters

2021-06-16 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Kun Qin > 发送时间: 2021年6月16日 0:54 > 收件人: devel@edk2.groups.io > 抄送: Sean Brogan ; Bret Barkelew > ; Michael D Kinney > ; Liming Gao ; > Bret Barkelew > 主题: [PATCH v2 1/1] Pytool: SpellCheck: Defer path expansion in cspell > parameters > > From: Sea

回复: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

2021-06-16 Thread gaoliming
Acked-by: Liming Gao > -邮件原件- > 发件人: Kun Qin > 发送时间: 2021年6月17日 5:08 > 收件人: devel@edk2.groups.io > 抄送: Sean Brogan ; Bret Barkelew > ; Michael D Kinney > ; Liming Gao ; > Ard Biesheuvel > 主题: Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce > Node dependency to use ver

回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes

2021-06-16 Thread gaoliming
Gopi: Could you let me know why changes below field name? MemoryArrayLocationCXLFlexbus10AddonCard ==> MemoryArrayLocationCXLAddonCard MemoryTechnologyIntelPersistentMemory ==> MemoryTechnologyIntelOptanePersistentMemory Thanks Liming 发件人: devel@edk2.groups.io 代表 Thotala, Gopi 发送时间:

回复: [edk2-devel] [PATCH v3 8/8] MdeModulePkg: Use SecureBootVariableLib in PlatformVarCleanupLib.

2021-06-16 Thread gaoliming
Grzegorz: MdeModulePkg is generic base package. It should not depend on SecurityPkg. I agree CreateTimeBasedPayload() is the generic API. It can be shared in the different modules. I propose to add it into MdeModulePkg AuthVariableLib. Thanks Liming > -邮件原件- > 发件人: devel@edk2.group

[edk2-devel] 回复: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error

2021-06-16 Thread gaoliming
> -邮件原件- > 发件人: manickavasakam karpagavinayagam > 发送时间: 2021年6月12日 5:50 > 收件人: devel@edk2.groups.io > 抄送: isaac.w.o...@intel.com; nathaniel.l.desim...@intel.com; > fel...@ami.com; harikrish...@ami.com; mani...@ami.com; > zacha...@ami.com; manickavasak...@ami.com; > gaolim...@byosoft.com

[edk2-devel] 回复: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error

2021-06-16 Thread gaoliming
Manickavasakam: Please update this patch. It also includes 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch. The patch should only include the code changes in MdePkg. Thanks Liming > -邮件原件- > 发件人: gaoliming > 发送时间: 2021年6月17日 10:50 > 收件人: 'manickavasakam karpagavinay

回复: [edk2-devel] [edk2-platforms] [PATCH V1 0/2] Support for TiogaPass Platform and Override generic PciBus Driver with

2021-06-16 Thread gaoliming
Please follow https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format to update the commit message format. And, for the override PciBus module, can you give more detail why need to override PciBus? Is it possible to update Edk2 MdeModulePkg PciBus to meet the platform

Re: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat

2021-06-16 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: gaoliming Sent: Thursday, June 17, 2021 9:36 AM To: devel@edk2.groups.io; rebe...@bsdio.com; Feng, Bob C ; Chen, Christine Subject: 回复: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat Reviewed-by: Liming Gao

[edk2-devel] OvmfPkgIa32X64.dsc is broken: OvmfPkg/Sec/SecMain.inf NOT found in DSC file; Is it really a binary module?

2021-06-16 Thread Rebecca Cran
Is OvmfPkg/OvmfPkgIa32X64.dsc still supposed to work after the recent changes in OvmfPkg? I realized it's currently broken. bcran@photon:~/src/uefi/edk2> build -p OvmfPkg/OvmfPkgIa32X64.dsc -a X64 -t GCC5 -b RELEASE Build environment: Linux-5.12.9-1-default-x86_64-with-glibc2.2.5 Build start

Re: [edk2-devel] [RESEND PATCH v2] BaseTools: Add support for RISCV GOT/PLT relocations

2021-06-16 Thread Sunil V L
Hi Pete, Thank you very much!. On Wed, Jun 16, 2021 at 01:35:27PM +0100, Pete Batard wrote: > Sunil, Daniel, thanks for the patch. > > I confirm that this addresses the 0x13 and 0x14 relocation issues that I was > seeing. > > However, this patch appears to introduces new R_RISCV_PCREL_LO12_S >

Re: [edk2-devel] 回复: [RESEND PATCH v2] BaseTools: Add support for RISCV GOT/PLT relocations

2021-06-16 Thread Sunil V L
Hi Liming, Thank you very much for the review. On Thu, Jun 17, 2021 at 09:43:21AM +0800, gaoliming wrote: > Sunil: > I add my comments below. > > Thanks > Liming > > -邮件原件- > > 发件人: Sunil V L > > 发送时间: 2021年6月11日 22:05 > > 收件人: devel@edk2.groups.io > > 抄送: Sunil V L ; Abner Chang >

[edk2-devel] [PATCH v3] BaseTools GenFw: Add support for RISCV GOT/PLT relocations

2021-06-16 Thread Sunil V L
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3096 This patch adds support for R_RISCV_CALL_PLT and R_RISCV_GOT_HI20 relocations generated by PIE enabled compiler. This also needed changes to R_RISCV_32 and R_RISCV_64 relocations as explained in https://github.com/riscv/riscv-gnu-toolchain/i

[edk2-devel] Recommended VSCode Extensions and Settings

2021-06-16 Thread Nate DeSimone
Hi Everyone, I have compiled a list of recommended extensions and settings for using Visual Studio Code to develop EDK II code. I have posted them on the wiki: https://github.com/tianocore/tianocore.github.io/wiki/Nate's-Recommended-VSCode-Extensions-and-Settings Feel free to add to the list if