[edk2-devel] Question about Smm code / StandaloneMmPkg

Dear All: I have a few questions about Smm code and StandaloneMmPkg. Take X86 Arch cpu as example: 1. Smm infrastructure code is implemented in MdeModulePkg\Core\PiSmmCore But it's a traditional smm mode, used launched in UEFI DXE Phase. A_Tour_Beyond_BIOS_Launching_Standalone_SMM_Drivers_in_P

Re: [edk2-devel] [RFC PATCH 00/14] Firmware Support for Fast Live Migration for AMD SEV

Hi Tobin, as mentioned in the reply to the QEMU patches posted by Tobin, I think the firmware helper approach is very good, but there are some disadvantages in the idea of auxiliary vCPUs. These are especially true in the VMM, where it's much nicer to have a separate VM that goes through a spec

[edk2-devel] Updated Event: TianoCore Design Meeting - APAC/NAMO - Friday, 5 March 2021 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCATION:Asia/Shanghai BEGIN:STANDARD TZNAME:CST TZOFFSETFROM:+

[edk2-devel] TianoCore Community Meeting - EMEA / NAMO - Thu, 03/04/2021 9:00am-10:00am #cal-reminder

*Reminder:* TianoCore Community Meeting - EMEA / NAMO *When:* Thursday, 4 March 2021, 9:00am to 10:00am, (GMT-08:00) America/Los Angeles *Where:* https://intel.webex.com/intel/j.php?MTID=m75ff00aa6638139bdae36ef591d290cc View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1083702 )

[edk2-devel] TianoCore Community Meeting - EMEA / NAMO - Thu, 03/04/2021 9:00am-10:00am #cal-reminder

*Reminder:* TianoCore Community Meeting - EMEA / NAMO *When:* Thursday, 4 March 2021, 9:00am to 10:00am, (GMT-08:00) America/Los Angeles *Where:* https://intel.webex.com/intel/j.php?MTID=m75ff00aa6638139bdae36ef591d290cc View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1083702 )

[edk2-devel] generating the test matrix for local CI runs

(Sigh, my address book pulled one over me -- resending to the correct list address now. Please ignore the previous posting that you may have gotten "in private".) Hi All, while I can run specific CI tests locally, using the commands listed at: https://github.com/tianocore/edk2/tree/master/.pytoo

Re: [edk2-devel] [RFC PATCH 00/14] Firmware Support for Fast Live Migration for AMD SEV

On 03/03/21 19:25, Tobin Feldman-Fitzthum wrote: >> Laszlo wrote: >> I'm quite uncomfortable with an attempt to hide a CPU from the OS via >> ACPI. The OS has other ways to learn (for example, a boot loader could >> use the MP services itself, stash the information, and hand it to the OS >> kernel

Re: [edk2-devel] generating the test matrix for local CI runs

On 3/4/21 10:04 AM, Laszlo Ersek wrote: (Sigh, my address book pulled one over me -- resending to the correct list address now. Please ignore the previous posting that you may have gotten "in private".) Hi All, while I can run specific CI tests locally, using the commands listed at: https://gi

Re: [EXTERNAL] Re: [edk2-devel] generating the test matrix for local CI runs

*An* answer is: - There’s a DevOps virtual environment that you can run that will pretend to be a build agent. I played with it years ago, but that was before the CI tooling (and it was years ago) so I don’t know how the capabilities compare. My real answer is: - If you run the three commands --

Re: [EXTERNAL] Re: [edk2-devel] generating the test matrix for local CI runs

Thinking further, it will skip some tests if you haven’t installed the prerequisites (e.g. spell check). We could potentially add a single script to install the prerequisites, but then there are the prereqs for the prereqs (e.g. Node). To more clearly address your question, the “tests” that a G

Re: [EXTERNAL] Re: [edk2-devel] generating the test matrix for local CI runs

Digging in even further, it looks like you’re asking about tests across test pipelines, including some of the platform pipelines. I don’t believe there’s a cohesive way to do that, as some of them require platform-specific parameters (such as the --FlashRom parameter for OvmfPkg). Can you share

Re: [EXTERNAL] Re: [edk2-devel] generating the test matrix for local CI runs

On 03/04/21 19:20, Bret Barkelew wrote: > Thinking further, it will skip some tests if you haven’t installed the > prerequisites (e.g. spell check). We could potentially add a single script to > install the prerequisites, but then there are the prereqs for the prereqs > (e.g. Node). > > To more

[edk2-devel] [PATCH v5 0/7] Add MmUnblockMemoryLib Interface and Usages

This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/72343 The module changes are validated on two different physical platforms and QEMU based Q35 plastform. Standalone and traditional MM are both tested to be functional on these systems. v5 patches main

[edk2-devel] [PATCH v5 1/7] MdePkg: MmUnblockMemoryLib: Added definition and null instance

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3168 This interface provides an abstration layer to allow MM modules to access requested areas that are outside of MMRAM. On MM model that blocks all non-MMRAM accesses, areas requested through this API will be mapped or unblocked for accessibili

[edk2-devel] [PATCH v5 2/7] OvmfPkg: resolve MmUnblockMemoryLib (mainly for VariableSmmRuntimeDxe)

This change added NULL MmUnblockMemoryLib instance in dsc files of OvmfPkg to pass CI build. When SMM_REQUIRE flag is set, the library interface is consumed by VariableSmmRuntimeDxe to better support variable runtime cache feature. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Signed-o

[edk2-devel] [PATCH v5 6/7] SecurityPkg: Tcg2Smm: Added support for Standalone Mm

https://bugzilla.tianocore.org/show_bug.cgi?id=3169 This change added Standalone MM instance of Tcg2. The notify function for Standalone MM instance is left empty. A dependency DXE driver with a Depex of gEfiMmCommunication2ProtocolGuid was created to indicate the readiness of Standalone MM Tcg2

[edk2-devel] [PATCH v5 4/7] SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst

This change replaced gSmst with gMmst to support broader compatibility under MM environment for Tcg2Smm driver. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin Reviewed-by: Jiewen Yao --- Notes: v5: - Previously reviewed, no change. v4: -

[edk2-devel] [PATCH v5 7/7] SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS region

This changes added usage of MmUnblockMemoryLib to explicitly request allocated NVS region to be accessible from MM environment. It will bring in compatibility with architectures that supports full memory blockage inside MM. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-of

[edk2-devel] [PATCH v5 5/7] SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 modules

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3169 This change separated the original Tcg2Smm module into 2 drivers: the SMM driver that registers callback for physical presence and memory clear; the Tcg2Acpi driver that patches and publishes ACPI table for runtime use. Tcg2Smm introduced a

[edk2-devel] [PATCH v5 3/7] MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface

This changes added usage of MmUnblockMemoryLib to explicitly request runtime cache regions(and its indicators) to be accessible from MM environment when PcdEnableVariableRuntimeCache is enabled. It will bring in compatibility with architectures that supports full memory blockage inside MM. Cc: Jia

Re: [EXTERNAL] Re: [edk2-devel] generating the test matrix for local CI runs

On 03/04/21 19:32, Bret Barkelew wrote: > Can you share the specific PR youre failing so that we can talk in > concrete terms? Sure. In January, I posted the following patch series: [edk2-devel] [PATCH 0/8] ShellPkg, ArmVirtPkg, OvmfPkg: shell usability improvements https://edk2.groups.

Re: [edk2-devel] [PATCH v5 1/7] MdePkg: MmUnblockMemoryLib: Added definition and null instance

On 03/04/21 19:58, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3168 > > This interface provides an abstration layer to allow MM modules to access > requested areas that are outside of MMRAM. On MM model that blocks all > non-MMRAM accesses, areas requested through this API

Re: [edk2-devel] [RFC PATCH 00/14] Firmware Support for Fast Live Migration for AMD SEV

On 03/04/21 10:21, Paolo Bonzini wrote: > Hi Tobin, > > as mentioned in the reply to the QEMU patches posted by Tobin, I > think the firmware helper approach is very good, but there are some > disadvantages in the idea of auxiliary vCPUs. These are especially > true in the VMM, where it's much nic

Re: [edk2-devel] Question about Smm code / StandaloneMmPkg

Adding Kun Qin; a comment below: On 03/04/21 09:34, Tiger Liu(BJ-RD) wrote: > Dear All: > I have a few questions about Smm code and StandaloneMmPkg. > > Take X86 Arch cpu as example: > 1. Smm infrastructure code is implemented in MdeModulePkg\Core\PiSmmCore >But it's a traditional smm mode, u

Re: [edk2-devel] [RFC PATCH 00/14] Firmware Support for Fast Live Migration for AMD SEV

On 03/04/21 21:45, Laszlo Ersek wrote: > On 03/04/21 10:21, Paolo Bonzini wrote: >> Hi Tobin, >> >> as mentioned in the reply to the QEMU patches posted by Tobin, I >> think the firmware helper approach is very good, but there are some >> disadvantages in the idea of auxiliary vCPUs. These are espe

Re: [edk2-devel] [edk2-platforms] [PATCH v1 0/9] IpmiFeaturePkg: Add IPMI transport drivers

Michael, Thanks for the feedback. I was torn between aligning with the proprietary version and cleaning it up. My concern is if we do too much cleanup, it will delay adoption. I did the minimum that we know is required for ECC tool to pass coding style tool and avoid EFI prefixes. I would

Re: [edk2-devel] [PATCH v5 1/7] MdePkg: MmUnblockMemoryLib: Added definition and null instance

Hi Mike/Liming/Zhiguang, Could you please review this patch and let me know if you have any feedback on this patch? Any input is appreciated. Regards, Kun From: Kun Qin Sent: Thursday, March 4, 2021 10:58 To: devel@edk2.groups.io Cc: Michae

[edk2-devel] TianoCore Design Meeting - APAC/NAMO - Fri, 03/05/2021 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Friday, 5 March 2021, 9:30am to 10:30am, (GMT+08:00) Asia/Shanghai *Where:* https://intel.webex.com/intel/j.php?MTID=me894224717bbf0af843f2ff7502c98cb View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=963104 ) *Organizer:* Ra

回复: [edk2-devel] [PATCH v1] MdePkg: Support standalone MM Driver Unload capability

That's OK. Reviewed-by: Liming Gao for this patch. > -邮件原件- > 发件人: Wu, Jiaxin > 发送时间: 2021年3月4日 11:22 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: Kinney, Michael D ; Liu, Zhiguang > ; Fu, Siyuan > 主题: RE: [edk2-devel] [PATCH v1] MdePkg: Support standalone MM Driver > Unload capabilit

[edk2-devel] TianoCore Design Meeting - APAC/NAMO - Fri, 03/05/2021 #cal-notice

"TianoCore Design Meeting - APAC/NAMO" When: Friday, 5 March 2021 9:30am to 10:30am (GMT+08:00) Asia/Shanghai Where: https://intel.webex.com/intel/j.php?MTID=me894224717bbf0af843f2ff7502c98cb Organizer: ray...@intel.com Description: ## TOPIC * FilterLib: Filter/Trace Port IO/

Re: [edk2-devel] TianoCore Design Meeting - APAC/NAMO - Fri, 03/05/2021 #cal-notice

Hi Dandan, Below is the information for you to update the table in your slide. IA32 X64 EBC ARM ARM64 AARCH64 RISCV64 CSR R/WNA NA NANA NA NA YES Thanks Abner From: devel@

Re: [edk2-devel] TianoCore Design Meeting - APAC/NAMO - Fri, 03/05/2021 #cal-notice

Thank you, Abner. Thanks, Dandan From: Chang, Abner (HPS SW/FW Technologist) Sent: Friday, March 5, 2021 10:11 AM To: devel@edk2.groups.io; Bi, Dandan Cc: Schaefer, Daniel Subject: RE: [edk2-devel] TianoCore Design Meeting - APAC/NAMO - Fri, 03/05/2021 #cal-notice Hi Dandan, Below is the in

Re: [edk2-devel] Question about Smm code / StandaloneMmPkg

Hi Tiger, Our team has been sending patches to the community to cover Standalone MM driver to support x86 arch recently by believing that Standalone MM is the direction we are moving to in the long term. From our experience so far, the Standalone MM core infrastructure is arch independent and

[edk2-devel] TianoCore Community Meeting - APAC/NAMO - Thu, 03/04/2021 7:30pm-8:30pm #cal-reminder

*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* Thursday, 4 March 2021, 7:30pm to 8:30pm, (GMT-08:00) America/Los Angeles *Where:* https://intel.webex.com/intel/j.php?MTID=m36627c5ee595f86f0257d9a52bb86044 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1083709 ) *Or

回复: [edk2-devel] [PATCH v5 1/7] MdePkg: MmUnblockMemoryLib: Added definition and null instance

Kun: I have one minor comment. Please see it. Thanks Liming 发件人: devel@edk2.groups.io 代表 Kun Qin 发送时间: 2021年3月5日 8:23 收件人: devel@edk2.groups.io; Michael D Kinney ; gaoliming ; Zhiguang Liu 抄送: Hao A Wu ; Jiewen Yao ; Laszlo Ersek 主题: Re: [edk2-devel] [PATCH v5 1/7] MdePkg: MmUnblockMemo

[edk2-devel] TianoCore Community Meeting - APAC/NAMO - Thu, 03/04/2021 7:30pm-8:30pm #cal-reminder

*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* Thursday, 4 March 2021, 7:30pm to 8:30pm, (GMT-08:00) America/Los Angeles *Where:* https://intel.webex.com/intel/j.php?MTID=m36627c5ee595f86f0257d9a52bb86044 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1083709 ) *Or

[edk2-devel] [PATCH 0/2] OvmfPkg/IntelGvtGopDxe: Add Intel GVT-g GOP.

This patch set add Intel GVT-g GOP DXE to OvmfPkg. Colin Xu (2): OvmfPkg/IntelGvtGopDxe: Intel GVT-g GOP Implementation. OvmfPkg/IntelGvtGopDxe: Enable GVT-g GOP in OvmfPkg DSC & DFD. OvmfPkg/IntelGvtGopDxe/Common.h | 45 + OvmfPkg/IntelGvtGopDxe/DebugHelper.h | 20 + Ovmf

[edk2-devel] [PATCH 2/2] OvmfPkg/IntelGvtGopDxe: Enable GVT-g GOP in OvmfPkg DSC & DFD.

Intel GVT-g is already enabled by default in upstream kernel. Signed-off-by: Colin Xu --- OvmfPkg/OvmfPkgX64.dsc | 4 OvmfPkg/OvmfPkgX64.fdf | 3 +++ 2 files changed, 7 insertions(+) diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index fabb8b2f29e4..971fd262151b 100644 --- a/

Re: [edk2-devel] [PATCH v5 1/7] MdePkg: MmUnblockMemoryLib: Added definition and null instance

Thanks, Liming. I will send the updated patches shortly. Regards, Kun From: gaoliming Sent: Thursday, March 4, 2021 19:15 To: devel@edk2.groups.io; ku...@outlook.com; 'Michael D Kinney'

[edk2-devel] [PATCH v6 1/7] MdePkg: MmUnblockMemoryLib: Added definition and null instance

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3168 This interface provides an abstration layer to allow MM modules to access requested areas that are outside of MMRAM. On MM model that blocks all non-MMRAM accesses, areas requested through this API will be mapped or unblocked for accessibili

[edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages

This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/72442 v6 patches mainly focus on feedback for reviewed commits in v5 patches, including: a. Adding "Reviewed-by" and "Acked-by" tags for applicable patch; b. Updating library class description for newly

[edk2-devel] [PATCH v6 2/7] OvmfPkg: resolve MmUnblockMemoryLib (mainly for VariableSmmRuntimeDxe)

This change added NULL MmUnblockMemoryLib instance in dsc files of OvmfPkg to pass CI build. When SMM_REQUIRE flag is set, the library interface is consumed by VariableSmmRuntimeDxe to better support variable runtime cache feature. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Signed-o

[edk2-devel] [PATCH v6 3/7] MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface

This changes added usage of MmUnblockMemoryLib to explicitly request runtime cache regions(and its indicators) to be accessible from MM environment when PcdEnableVariableRuntimeCache is enabled. It will bring in compatibility with architectures that supports full memory blockage inside MM. Cc: Jia

[edk2-devel] [PATCH v6 4/7] SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst

This change replaced gSmst with gMmst to support broader compatibility under MM environment for Tcg2Smm driver. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin Reviewed-by: Jiewen Yao --- Notes: v6: - Previously reviewed, no change. v5: -

[edk2-devel] [PATCH v6 7/7] SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS region

This changes added usage of MmUnblockMemoryLib to explicitly request allocated NVS region to be accessible from MM environment. It will bring in compatibility with architectures that supports full memory blockage inside MM. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-of

[edk2-devel] [PATCH v6 6/7] SecurityPkg: Tcg2Smm: Added support for Standalone Mm

https://bugzilla.tianocore.org/show_bug.cgi?id=3169 This change added Standalone MM instance of Tcg2. The notify function for Standalone MM instance is left empty. A dependency DXE driver with a Depex of gEfiMmCommunication2ProtocolGuid was created to indicate the readiness of Standalone MM Tcg2

[edk2-devel] [PATCH v6 5/7] SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 modules

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3169 This change separated the original Tcg2Smm module into 2 drivers: the SMM driver that registers callback for physical presence and memory clear; the Tcg2Acpi driver that patches and publishes ACPI table for runtime use. Tcg2Smm introduced a

Re: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages

Hi, Thanks to all the reviewers helping through this patch series. Each individual patch has received reviewed-by tag in this v6 version. It has also just passed all CI build tests here: Unblock mem v6 by kuqin12 · Pull Request #1473 · tianocore/edk2 (github.com)

Re: [edk2-devel] [PATCH 0/2] OvmfPkg/IntelGvtGopDxe: Add Intel GVT-g GOP.

Will fix transferEncoding and re-send. -- Best Regards, Colin Xu On Fri, 5 Mar 2021, Colin Xu wrote: This patch set add Intel GVT-g GOP DXE to OvmfPkg. Colin Xu (2): OvmfPkg/IntelGvtGopDxe: Intel GVT-g GOP Implementation. OvmfPkg/IntelGvtGopDxe: Enable GVT-g GOP in OvmfPkg DSC & DFD. OvmfP

[edk2-devel] [PATCH v2 0/2] OvmfPkg/IntelGvtGopDxe: Add Intel GVT-g GOP.

This patch set add Intel GVT-g GOP DXE to OvmfPkg. V2: Program PIPESRC to match active H/V. Colin Xu (2): OvmfPkg/IntelGvtGopDxe: Intel GVT-g GOP Implementation. OvmfPkg/IntelGvtGopDxe: Enable GVT-g GOP in OvmfPkg DSC & DFD. OvmfPkg/IntelGvtGopDxe/Common.h | 45 + OvmfPkg/IntelG

[edk2-devel] [PATCH v2 2/2] OvmfPkg/IntelGvtGopDxe: Enable GVT-g GOP in OvmfPkg DSC & DFD.

Intel GVT-g is already enabled by default in upstream kernel. V2: Refresh. Signed-off-by: Colin Xu --- OvmfPkg/OvmfPkgX64.dsc | 4 OvmfPkg/OvmfPkgX64.fdf | 3 +++ 2 files changed, 7 insertions(+) diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index fabb8b2f29e4..971fd262151b