Re: [edk2-devel] [PATCH v2] EmulatorPkg: Enable support for Secure Boot

2020-09-21 Thread Wadhawan, Divneil R
Hi Liming, Here’s the bz: https://bugzilla.tianocore.org/show_bug.cgi?id=2979 Regards, Divneil From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Monday, September 21, 2020 6:19 AM To: devel@edk2.groups.io; Wadhawan, Divneil R ; Ni, Ray Cc: 'Andrew Fish' ; Justen, Jordan L ; Kinney, Mich

Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

2020-09-21 Thread Marcello Sylvester Bauer
Dear Laszlo, I'm really sorry for violating the development process. Reading the email thread that follows made me realize that I have to work on my submission work follow before creating more patch series. I'm looking forward to seeing this process moving completely to GitHub. No empty descripti

Re: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROMs

2020-09-21 Thread Marcello Sylvester Bauer
hi Ray, > I guess it is because the PciIoDevice->AllOpRomProcessed is set which causes GetPciRom() is skipped. exactly. Therefore we need this for the gPciPlatformProtocol implementation to work. I will add this information as a code comment. > In your UefiPayloadPkg change, you have an assumpti

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correct EFI_BLOCK_IO_PROTOCOL_REVISION3 value

2020-09-21 Thread Michael Kubacki
I found the issue while manually reviewing some protocol structures against the UEFI spec. I'm going to leave that question to the MdePkg and UEFI Specification maintainers as changing the specification may have an impact on other implementations that needs to be considered. My only preference

Re: [edk2-devel] [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4

2020-09-21 Thread Andrei Warkentin
Hi folks, No objection at all. IIRC the original pin selection was driven by an article I read about using OpenOCD with Pi 3. A From: Pete Batard Sent: Tuesday, September 15, 2020 7:26 AM To: Jeff Booher-Kaeding ; devel@edk2.groups.io Cc: Ard Biesheuvel ; Leif

回复: [edk2-devel] [PATCH v1 1/1] MdePkg: Correct EFI_BLOCK_IO_PROTOCOL_REVISION3 value

2020-09-21 Thread gaoliming
Michael and Ray: So far, I don't see the big impact with this change. I search Edk2/Edk2Platform code base. I only find MdeModulePkg ScsiDiskDxe installs BlkIo with revision 3, and PartitionDxe checks BlkIo revision. They are in the same package, and are used together. So, there is no impact f

回复: [edk2-devel] [PATCH v1 1/1] Tools/FitGen: Fix microcode alignment support

2020-09-21 Thread gaoliming
Aaron: This change is good. But, I would like to know whether there is the specific alignment requirement for microcode. Or, any alignment value is allowed, such as 0xFF? Thanks Liming > -邮件原件- > 发件人: Li, Aaron > 发送时间: 2020年9月21日 13:23 > 收件人: Feng, Bob C ; Liming Gao > > 抄送: devel@edk2

[edk2-devel] [PATCH v2 1/1] Tools/FitGen: Fix microcode alignment support

2020-09-21 Thread Aaron Li
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2971 v2: Add check for basic 16-byte alignment. This patch is to fix a issue that "-A" option would only support 2^n Byte alignment of microcode. Signed-off-by: Aaron Li Cc: Bob Feng Cc: Liming Gao --- Silicon/Intel/Tools/FitGen/FitGen.c | 8

Re: [edk2-devel] [PATCH v1 1/1] Tools/FitGen: Fix microcode alignment support

2020-09-21 Thread Aaron Li
Hi Liming, Checked in SDM, there is a requirement: The microcode update data must start at a 16-byte aligned linear address. Such as 0xFF should not be supported. I re-sent a v2 patch and added this requirement check. Please help review again. Thanks. Best, Aaron > -Original Message- >

Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

2020-09-21 Thread Bret Barkelew via groups.io
24 hours before Andrew Fish, Jordan Justen, and Ray Ni are enrolled in CatFacts. You’ll learn things you never knew! (That’s the definition of learning.) - Bret From: Bret Barkelew via groups.io Sent: Thursday, September 17, 2020 11:55 PM To: devel@ed

Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg/host: fix overflow in Mult

2020-09-21 Thread wenyi,xie via groups.io
Hi all, Please review this patch when you're free, thanks. Regards Wenyi On 2020/9/1 18:58, Wenyi Xie wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2947 > > When calculating memory regions and store the information in the > gSystemMemory in file WinHost.c, the code below will caus

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 09/22/2020 6:30pm-7:30pm #cal-reminder

2020-09-21 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 22 September 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://meetingsamer34.webex.com/meetingsamer34/j.php?MTID=m623b1dceab0c6dc62d56b2508fa50f39 View Event ( https://edk2.groups.io/g/devel/viewevent?event

回复: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 09/22/2020 6:30pm-7:30pm #cal-reminder

2020-09-21 Thread gaoliming
Hi, all The following BZs will be discussed this week. Welcome the reporter joins the meeting and shares the detail. And, this week will use webex. The meeting information can be found in https://edk2.groups.io/g/devel/viewevent?repeatid=14221

回复: [edk2-devel] [PATCH v2 1/1] Tools/FitGen: Fix microcode alignment support

2020-09-21 Thread gaoliming
Aaron: Thanks for your update. This version is good to me. Reviewed-by: Liming Gao If no more comment, I will merge this patch tomorrow. Thanks Liming > -邮件原件- > 发件人: bounce+27952+65422+4905953+8761...@groups.io > 代表 Aaron Li > 发送时间: 2020年9月22日 10:29 > 收件人: devel@edk2.groups.io > 抄

Re: [edk2-devel] [PATCH v12 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-09-21 Thread Laszlo Ersek
On 09/17/20 18:55, Vladimir Olovyannikov wrote: > Laszlo, what is the outcome? Were you able to run these tests locally? > Is there any step-by-step instruction I can follow? - See my comments at: - https://edk2.groups.io/g/devel/message/64428 - https://edk2.groups.io/g/devel/message/64528

Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

2020-09-21 Thread Laszlo Ersek
Hi Marcello, On 09/21/20 11:57, Marcello Sylvester Bauer wrote: > Dear Laszlo, > > I'm really sorry for violating the development process. my criticism was targeted solely at edk2 maintainers, not at contributors. As far as I'm aware, you did nothing wrong. I kept you CC'd because it's bad netiq