Re: [edk2-devel] Adding bhyve to the Continuous Integration system

On 08/09/20 21:18, Rebecca Cran wrote: > Now that bhyve is in edk2, I'd like to add CI support for it. Good idea, IMO. > I have a FreeBSD machine that has the Azure Agent installed: would it > be possible to add it to https://dev.azure.com/tianocore/edk2-ci/ ? I don't know, unfortunately. > Als

[edk2-devel] [Patch] BaseTools: Enable Module Scope Structure Pcd

This patch is to enable the Module scoped Structure Pcd usage. User can set structure pcd field value in module scope. For example, under the [components] section of a dsc file, user can override some field value for a specific module. Package/Module.inf{ gUefiTokenSpaceGuid.Structu

Re: [edk2-devel] [Wiki][Patch] Add EDK II Code First Process Wiki Page

On 08/08/20 03:03, Michael D Kinney wrote: > Based on the following RFC: > > https://edk2.groups.io/g/rfc/message/258 > > Additional updates: > * Add examples of all specifications currently maintained by > the UEFI Forums. > * Added specification change template using a CC-BY-4.0 license.

Re: [edk2-devel] [Wiki][Patch V2] Add EDK II Code First Process Wiki Page

On 08/08/20 03:04, Michael D Kinney wrote: > Based on the following RFC: > > https://edk2.groups.io/g/rfc/message/258 > > Additional updates: > * Add examples of all specifications currently maintained by > the UEFI Forums. > * Added specification change template using a CC-BY-4.0 license.

[edk2-devel] question about PCI bridge's bus range window configure's save and restore

Hi, Experts: I have a question about PCI Bridge’s config space’s save and restore. Pci bus driver configured PCI Bridges’ secondary bus number register and subordinate bus number register. So, if system resumes from S3(Suspend to ram) state, who is responsible for restoring PCI Bridges’ seconda

Re: [edk2-devel] Partition issue with Linux Distribution iso image

On 08/10/20 05:04, Gao, Zhichao wrote: > Andrew, > > Thanks for your info. I didn’t aware the partition driver is part of the UEFI > spec. And the order is mismatch between the code implementation and spec > description. > The order now is GPT > MBR > UDF( ISO 9660). I would send a patch to corr

Re: [edk2-devel] [edk2-test][PATCH v1 1/3] uefi-sct/SctPkg: Fix build with latest EDK2

Reviewed-by: G Edhaya Chandran > -Original Message- > From: Samer El-Haj-Mahmoud > Sent: 24 July 2020 07:59 > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Eric Jin > ; Irene Park ; Heinrich Schuchardt > > Subject: [edk2-test][PATCH v1 1/3] uefi-sct/SctPkg: Fix build with latest ED

Re: [edk2-devel] [PATCH v13 00/46] SEV-ES guest support

On 8/9/20 9:41 PM, Gao, Liming wrote: > > > -Original Message- > From: Laszlo Ersek > Sent: 2020年8月6日 23:39 > To: Tom Lendacky ; devel@edk2.groups.io > Cc: Brijesh Singh ; Ard Biesheuvel > ; Dong, Eric ; Justen, Jordan L > ; Gao, Liming ; Kinney, > Michael D ; Ni, Ray ; Andrew > Fis

[edk2-devel] [PATCH 1/1] Platform/Intel: Add VmgExitLib to required DSC files

From: Tom Lendacky Any DSC file that uses the UefiCpuPkg MpInitLib or CpuExeptionHandlerLib libraries, now requires the VmgExitLib library. Update the DSC files to include the VmgExitLib NULL library implementation. Signed-off-by: Tom Lendacky --- Platform/Intel/MinPlatformPkg/Include/Dsc/Core

答复: [edk2-devel] question about PCI bridge's bus range window configure's save and restore

It’s done by BIOS pei s3 resume code. Restored register value saved while BIOS normal POST BY BootScriptExecutor. You can refer gEfiPeiS3Resume2Ppi usage Thanks 发件人: devel@edk2.groups.io [mailto:devel@edk2.groups.io] 代表 Tiger Liu(BJ-RD) 发送时间: 2020年8月10日 17:32 收件人: devel@edk2.groups.io 主题:

Re: [edk2-devel] [Wiki][Patch V2] Add EDK II Code First Process Wiki Page

Mike, Looks like a good start. Acked-by: Andrew Fish Thanks, Andrew Fish > On Aug 10, 2020, at 2:17 AM, Laszlo Ersek wrote: > > On 08/08/20 03:04, Michael D Kinney wrote: >> Based on the following RFC: >> >>https://edk2.groups.io/g/rfc/message/258 >> >> Additional updates: >> * Add ex

Re: [edk2-devel] [Wiki][Patch V2] Add EDK II Code First Process Wiki Page

Mike, Looks good as a starting point! Acked-by: Samer El-Haj-Mahmoud I do have a few questions on this sentence: "Specification text changes are held within the affected source repository, using the GitHub flavor of markdown, in a file (or split across several files) with .md suffix." - Fo

Re: [edk2-devel] [Wiki][Patch V2] Add EDK II Code First Process Wiki Page

> On Aug 10, 2020, at 11:36 AM, Samer El-Haj-Mahmoud > wrote: > > Mike, > > Looks good as a starting point! > > Acked-by: Samer El-Haj-Mahmoud > > > > I do have a few questions on this sentence: "Specification text changes are > held within the affec

Re: [edk2-devel] [PATCH v14 07/46] MdePkg/BaseLib: Add support for the VMGEXIT instruction

Hi Tom, On 08/07/20 21:38, Lendacky, Thomas wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > VMGEXIT is a new instruction used for Hypervisor/Guest communication when > running as an SEV-ES guest. A VMGEXIT will cause an automatic exit (AE) > to occur,

Re: [edk2-devel] [PATCH v14 45/46] UefiCpuPkg/MpInitLib: Prepare SEV-ES guest APs for OS use

On 08/07/20 23:53, Lendacky, Thomas wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Before UEFI transfers control to the OS, it must park the AP. This is > done using the AsmRelocateApLoop function to transition into 32-bit > non-paging mode. For an SE

Re: [edk2-devel] [PATCH v14 07/46] MdePkg/BaseLib: Add support for the VMGEXIT instruction

On 8/10/20 1:47 PM, Laszlo Ersek wrote: > Hi Tom, Hi Laszlo, > > On 08/07/20 21:38, Lendacky, Thomas wrote: >> From: Tom Lendacky >> >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40am

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

On 08/07/20 21:38, Lendacky, Thomas wrote: > From: Tom Lendacky > > This patch series provides support for running EDK2/OVMF under SEV-ES. > > Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the > SEV support to protect the guest register state from the hypervisor. See > "A

[edk2-devel] [PATCH v2 3/6] FmpDevicePkg/FmpDxe: Add check image path Last Attempt Status capability

From: Michael Kubacki CheckTheImage() is used to provide the CheckImage() implementation for the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance produced by FmpDxe in addition to being called internally in the SetImage() path. Since CheckTheImage() plays a major role in determining the validity of a g

[edk2-devel] [PATCH v2 6/6] FmpDevicePkg/FmpDeviceLib: Add Last Attempt Status to Check/Set API

From: Michael Kubacki Provides the ability for a given FMP device library instance to return a Last Attempt Status code during FmpDeviceCheckImage() and FmpDeviceSetImage(). Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki --- FmpDevicePkg/Fmp

[edk2-devel] [PATCH v2 1/6] MdePkg/SystemResourceTable.h: Add vendor range values

From: Michael Kubacki Adds the following macros to define the unsuccessful vendor range min and max (defined in UEFI Specification 2.8): 1. LAST_ATTEMPT_STATUS_ERROR_UNSUCCESSFUL_VENDOR_RANGE_MIN 2. LAST_ATTEMPT_STATUS_ERROR_UNSUCCESSFUL_VENDOR_RANGE_MAX Cc: Liming Gao Cc: Michael D Kinney

[edk2-devel] [PATCH v2 5/6] FmpDevicePkg: Add Last Attempt Status support to dependency libs

From: Michael Kubacki The FMP dependency libraries are leveraged during firmware update to check for dependencies required to update the image. This change adds granular Last Attempt Status code support to these services so failures can be more easily observed during the firmware update process

[edk2-devel] [PATCH v2 0/6] Extend Last Attempt Status Usage

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2802 This patch series adds more granularity to Last Attempt Status codes reported during FMP check image and set image operations that greatly improve precision of the status codes. The vendor range (0x1000 - 0x4000) was

[edk2-devel] [PATCH v2 4/6] FmpDevicePkg/FmpDxe: Improve set image path Last Attempt Status granularity

From: Michael Kubacki Increases the level of granularity for Last Attempt Status codes returned from SetTheImage() in FmpDxe. This allows better identification of the error that occurred in the set image operation using Last Attempt Status codes. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin

[edk2-devel] [PATCH v2 2/6] FmpDevicePkg: Add LastAttemptStatus.h

From: Michael Kubacki Introduces a header file to contain Last Attempt Status codes that define granular FmpDevicePkg usage of the UEFI Specification defined vendor range. The vendor range is described in UEFI Specification 2.8A section 23.4. With this change, FmpDevicePkg currently defines thre

Re: 答复: [edk2-devel] question about PCI bridge's bus range window configure's save and restore

On 08/10/20 13:54, Ric Wang (王晓) wrote: > It’s done by BIOS pei s3 resume code. Restored register value saved while > BIOS normal POST BY BootScriptExecutor. You can refer gEfiPeiS3Resume2Ppi > usage That doesn't seem right. The S3 boot script is composed by platform drivers in the firmware

Re: [edk2-devel] [PATCH 1/1] Platform/Intel: Add VmgExitLib to required DSC files

Reviewed-by: Liming Gao -Original Message- From: Tom Lendacky Sent: 2020年8月10日 21:22 To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Dong, Eric ; Gao, Liming ; Kinney, Michael D ; Agyeman, Prince ; Qian, Yi ; Steele, Kelly ; Sun, Zailiang ; Laszlo Ersek ; Brijes

Re: [edk2-devel] [PATCH 1/1] Platform/Intel: Add VmgExitLib to required DSC files

Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Liming > Sent: Tuesday, August 11, 2020 8:02 AM > To: Tom Lendacky ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Dong, Eric ; > Kinney, Michael D ; Agyeman, Prince > ; Qian, Yi ; Steele, Kelly > ; Sun, Za

Re: [edk2-devel] [PATCH v2 9/9] SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY

Qi: I run ECC plugin (https://edk2.groups.io/g/devel/message/63271) for this patch set. It reports below issues. Can you help update the patches to fix them? EFI coding style error *Error code: 3002 *Non-Boolean comparisons should use a compare operator (==, !=, >, < >=, <=) *file: D:\All

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

+Jeremy, I review the patch and think it is reasonable, but I want to know some more detail information 1. Can you provide the detail debug log about USB? 2. The symptom always can be seen or have fail rate? Best Regards Guomin From: devel@edk2.groups.io On Behalf Of Guomin Jiang Sent: T

Re: [edk2-devel] [PATCH v2 2/6] FmpDevicePkg: Add LastAttemptStatus.h

My feedback: #1: Why is LastAttemptStatus.h in PrivateInclude? Seems like something you would want to have as a public header. #2: If someone inserts a new enum value in the middle of LAST_ATTEMPT_STATUS_EXPANDED_ERROR_LIST it will make it difficult to decode error codes in the future. Either

Re: [edk2-devel] [PATCH v2 9/9] SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY

Hi, Liming Thanks for your comments! Is there any wiki of how to run ECC plugin? BRs Qi Zhang > -Original Message- > From: Gao, Liming > Sent: Tuesday, August 11, 2020 8:19 AM > To: devel@edk2.groups.io; Zhang, Qi1 > Cc: Yao, Jiewen ; Wang, Jian J > ; Kumar, Rahul1 > Subject: RE: [edk

Re: [edk2-devel] TianoCore Community Meeting Minutes - August

Soumya: I add my comments. Thanks Liming From: devel@edk2.groups.io On Behalf Of Soumya Guptha Sent: 2020年8月7日 11:42 To: annou...@edk2.groups.io; devel@edk2.groups.io Subject: [edk2-devel] TianoCore Community Meeting Minutes - August TianoCore Community Meeting Minutes August 6, 2020 Event

Re: [edk2-devel] [PATCH v14 00/46] SEV-ES guest support

Tom: I run ECC plugin (https://edk2.groups.io/g/devel/message/63271) in my local machine. It reports below issues. Can you help update the patches to fix them? I use the standalone EccCheck from https://github.com/shenglei10/edk2/tree/ecc_script. EFI coding style error *Error code: 8005

Re: [edk2-devel] [PATCH v2 9/9] SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY

Qi: EccPlugin will be enabled in open CI. Then, ECC result can be checked in open CI result. Now, I use the standalone EccCheck.py from https://github.com/shenglei10/edk2/tree/ecc_script to check the patch set. Thanks Liming -Original Message- From: Zhang, Qi1 Sent: 2020年8月11日 8:54

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 08/11/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 11 August 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816386 ) *Organizer:* Brian Richardson brian.ri

Re: [edk2-devel] question about PCI bridge's bus range window configure's save and restore

Hi, Ric: Thanks for your reply. I think maybe some standard PCI config space registers, such as BAR registers, its content is restored by OS during S3 resume procedure. Such as: PCI bus driver scans PCI bus and assigns every PCI device’s resource requirements, and sets these BAR registers. But

Re: [edk2-devel] [PATCH v2 0/9] Need add a FSP binary measurement

Hi Qi Thanks for the update. 1) Since this is a new feature, a platform may already measure FSP binary in some ways, I recommend we change the default policy to: gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x. 2) We should not check FSP_MEASURE_FSP in IntelFsp2WrappePkg, bec

Re: 答复: [edk2-devel] question about PCI bridge's bus range window configure's save and restore

When resuming from S3, UEFI skips the memory initialization and PCIe enumeration, just brings memory out of self-refresh state and jumps to the resuming point in memory. OS doesn't re-enumerate, either. The interesting question is if I plug or unplug a PCIe device when system in S3 state, then

Re: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 08/11/2020 6:30pm-7:30pm #cal-reminder

Below issues are submitted recently. They will be reviewed in this week meeting. Welcome the reporter join the meeting to introduce the more background and detail. 2886 EDK2 Code unassig...@tianocore.org UNCO --- EmbeddedPkg PrePiHobLib SetBoo

[edk2-devel] [PATCH v4 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

From: Matthew Carlson Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Matthew Carlson --- MdePkg/Library/BaseRngLibDxe/RngDxeLib.c | 200 MdePkg/Library/BaseRngLibDxe/BaseRngLibDxe.inf | 38 MdePkg/MdePkg.dsc |

[edk2-devel] [PATCH v4 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhi

[edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib

From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Matthew Carlson (5): MdePkg: TimerRngLib: Added RngLib that uses TimerLib MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe OvmfPkg: Add RngLib based on TimerLib

[edk2-devel] [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

From: Matthew Carlson Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Signed-off-by: Matthew Carlson --- OvmfPkg/OvmfPkgIa32.dsc| 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 1 + OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/OvmfXen.dsc| 1 + 4 files

[edk2-devel] [PATCH v4 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

From: Matthew Carlson Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to OpenSSL and TlsLib. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Matthew Carlson --- Crypto

[edk2-devel] [PATCH v4 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

From: Matthew Carlson Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Matthew Carlson --- ArmVirtPkg/ArmVirt.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index cf44fc73890b..ddfcd0cf9eee 100644 --- a/

[edk2-devel] [edk2-wiki][PATCH v2] Update the Boot Guard TOCTOU wiki page.

The Boot Guard TOCTOU have been migrated into edk2/master. Update the document to meet the change. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Liming Gao Reviewed-by: Jian J Wang --- Boot-Guard-TOCTOU-Vulnerability-Mitigation.md | 28 ++- 1 file changed, 8 insertions(+), 2

[edk2-devel] [PATCH 3/3] MdeModulePkg/PartitionDxe: Fix the incorrect LBA size in child hander

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843 PartitionInstallChildHandle's parameters Start and End is counted by the BlockSize, but in the implementation it uses the parent device's BlockSize to calculate the new Start, End and LastBlock. It would cause the driver report incorrect blo

[edk2-devel] [PATCH 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 Refer to UEFI spec 2.8, Section 13.3.2, a block device should be scanned as below order: 1. GPT 2. ISO 9660 (El Torito) (UDF should aslo be here) 3. MBR 4. no partition found Note: UDF is using the same boot method as CD, so put it in the sa

[edk2-devel] [PATCH 0/3] MdeModulePkg/PartitionDxe: Make the parition driver match the spec

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843 Refer to the UEFI spec 2.8, Section 13.3.2: A block device should be scanned as below order: 1. GPT 2. ISO 9660 (El Torito) (UDF should aslo be here) 4. MBR 5. no partition found But

[edk2-devel] [PATCH 2/3] MdeModulePkg/PartitionDxe: Remove the check for special MBR

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 Follow the spec definition, the ISO 9660 (and UDF) would be checked before the MBR. So it is not required to skip such MBR talbe that contian the entire block device. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Gary Lin Cc: Andrew Fish