[edk2-devel] [edk2-platforms:PATCH v3] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support

2020-04-06 Thread Miki Shindo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2536 This commit adds DxeAslUpdateLib library support in IntelSiliconPkg, which allows AML to be updated in DXE. Signed-off-by: Miki Shindo Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Prince Agyeman Cc: Ray Ni Acked-by: Chasel C

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: Fix uninitialized variable in RunAxf

2020-04-06 Thread Ard Biesheuvel
On Fri, 3 Apr 2020 at 18:05, Sami Mujawar wrote: > > RunAxf is a shell command used for running an Axf > file. The ShellDynCmdRunAxfHandler() loads an ELF > file or one processed by the Flashloader. It > calls the appropriate loaders to load the file > in memory and to obtain the entry point addre

Re: [edk2-devel] [PATCH v2 15/28] Silicon/NXP: Move RAM retrieval from SocLib

2020-04-06 Thread Pankaj Bansal
> -Original Message- > From: Leif Lindholm > Sent: Wednesday, April 1, 2020 6:13 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Jon Nettleton > Subject: Re: [PATCH v2 15/28] Sil

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-04-06 Thread Ard Biesheuvel
On 4/5/20 8:39 AM, Sean via groups.io wrote: Platform and Core CI patches are ready for review.  I have 14 commits here. https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages This adds support for "Platform CI" for ArmVirtPkg, OvmfPkg, and EmulatorPkg. Each readm

Re: [edk2-devel] [PATCH v2 16/28] Platform/NXP/LS1043aRdbPkg: Add Clock retrieval APIs

2020-04-06 Thread Pankaj Bansal
> -Original Message- > From: Leif Lindholm > Sent: Wednesday, April 1, 2020 6:17 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Jon Nettleton > Subject: Re: [PATCH v2 16/28] Pla

Re: [edk2-devel] [PATCH v2 18/28] Silicon/NXP: Add Chassis2 Package

2020-04-06 Thread Pankaj Bansal
> -Original Message- > From: Leif Lindholm > Sent: Wednesday, April 1, 2020 7:48 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Jon Nettleton > Subject: Re: [PATCH v2 18/28] Sil

Re: [edk2-devel] [PATCH v2 01/28] Silicon/NXP: Add I2c lib

2020-04-06 Thread Leif Lindholm
On Mon, Apr 06, 2020 at 06:14:38 +, Pankaj Bansal (OSS) wrote: > > > > -Original Message- > > From: Leif Lindholm > > Sent: Tuesday, March 31, 2020 5:21 PM > > To: Pankaj Bansal (OSS) > > Cc: Meenakshi Aggarwal ; Michael D Kinney > > ; devel@edk2.groups.io; Varun Sethi > > ; Samer E

Re: [edk2-devel] [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib

2020-04-06 Thread Leif Lindholm
On Mon, Apr 06, 2020 at 06:33:40 +, Pankaj Bansal (OSS) wrote: > > > > -Original Message- > > From: Leif Lindholm > > Sent: Wednesday, April 1, 2020 3:23 PM > > To: Pankaj Bansal (OSS) > > Cc: Meenakshi Aggarwal ; Michael D Kinney > > ; devel@edk2.groups.io; Varun Sethi > > ; Samer

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

2020-04-06 Thread Ard Biesheuvel
On Fri, 3 Apr 2020 at 04:22, Bi, Dandan wrote: > > For the functionality, it is the same with before for platforms which set > PcdPropertiesTableEnable to false by default. > Reviewed-by: Dandan Bi for patch [PATCH 2/4] [PATCH > 3/4] [PATCH 4/4]. > > > If anyone still has the use case of enabli

Re: [edk2-devel] [PATCH v2 15/28] Silicon/NXP: Move RAM retrieval from SocLib

2020-04-06 Thread Leif Lindholm
On Mon, Apr 06, 2020 at 10:08:43 +, Pankaj Bansal (OSS) wrote: > > > > + > > > + FdBase = (UINTN)FixedPcdGet64 (PcdFdBaseAddress); > > > + FdTop = FdBase + (UINTN)FixedPcdGet32 (PcdFdSize); > > > + > > > + // Declare memory regios to system > > > >regions > > OK >

Re: [edk2-devel] [PATCH v2 18/28] Silicon/NXP: Add Chassis2 Package

2020-04-06 Thread Leif Lindholm
On Mon, Apr 06, 2020 at 11:07:45 +, Pankaj Bansal (OSS) wrote: > > > > -Original Message- > > From: Leif Lindholm > > Sent: Wednesday, April 1, 2020 7:48 PM > > To: Pankaj Bansal (OSS) > > Cc: Meenakshi Aggarwal ; Michael D Kinney > > ; devel@edk2.groups.io; Varun Sethi > > ; Samer

Re: [edk2-devel] [PATCH 1/1] ArmPkg: rename misleading local #define in CpuDxe

2020-04-06 Thread Ard Biesheuvel
On 4/3/20 1:48 PM, Leif Lindholm wrote: The local #define TT_ATTR_INDX_INVALID is used as a local error code in the AArch64 implementation, but is misleadingly named to match the definitions in ArmPkg/Include/Chipset/AArch64Mmu.h. Rename it INVALID_ENTRY to reduce confusion and improve readabili

Re: [edk2-devel] [PATCH 1/1] ArmPkg: rename misleading local #define in CpuDxe

2020-04-06 Thread Leif Lindholm
On Mon, Apr 06, 2020 at 13:55:44 +0200, Ard Biesheuvel wrote: > On 4/3/20 1:48 PM, Leif Lindholm wrote: > > The local #define TT_ATTR_INDX_INVALID is used as a local error code > > in the AArch64 implementation, but is misleadingly named to match the > > definitions in ArmPkg/Include/Chipset/AArch6

Re: [edk2-devel] [PATCH edk2-platforms 1/1] DeveloperBox: implement measured boot

2020-04-06 Thread Leif Lindholm
On Wed, Mar 04, 2020 at 08:25:43 +0100, Ard Biesheuvel wrote: > Enable the various components, library class resolutions and PCD defaults > to enable measured boot based on a version 2 TPM. The TPM is exposed as > having a memory mapped TIS frame, which is accomplished using the SPI > command seque

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W.

2020-04-06 Thread Leif Lindholm
Hi Gaurav, Haojian, Tien Hock - can you help review/test this change? Best Regards, Leif On Fri, Apr 03, 2020 at 14:54:07 +0530, Gaurav Jain wrote: > Moved BlockCount calculation below BufferSize Validation checks. > First Ensure Buffersize is Not Zero and multiple of Media BlockSize. > then ca

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W.

2020-04-06 Thread Ard Biesheuvel
On 4/6/20 4:08 PM, Leif Lindholm wrote: Hi Gaurav, Haojian, Tien Hock - can you help review/test this change? Best Regards, Leif On Fri, Apr 03, 2020 at 14:54:07 +0530, Gaurav Jain wrote: Moved BlockCount calculation below BufferSize Validation checks. First Ensure Buffersize is Not Zero and

Re: [edk2-devel] [PATCH edk2-platforms 1/1] DeveloperBox: implement measured boot

2020-04-06 Thread Ard Biesheuvel
On 4/6/20 3:58 PM, Leif Lindholm wrote: On Wed, Mar 04, 2020 at 08:25:43 +0100, Ard Biesheuvel wrote: Enable the various components, library class resolutions and PCD defaults to enable measured boot based on a version 2 TPM. The TPM is exposed as having a memory mapped TIS frame, which is accom

Re: [edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

2020-04-06 Thread Pankaj Bansal
> -Original Message- > From: Leif Lindholm > Sent: Wednesday, April 1, 2020 8:23 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Jon Nettleton > Subject: Re: [PATCH v2 21/28] Sli

Re: [edk2-devel] [PATCH v2 23/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Use Allocate pool

2020-04-06 Thread Pankaj Bansal
> -Original Message- > From: Leif Lindholm > Sent: Wednesday, April 1, 2020 11:34 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Jon Nettleton > Subject: Re: [PATCH v2 23/28] NX

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Checkout command is broken

2020-04-06 Thread Bjorge, Erik C
Thanks for fixing my mistake. Reviewed-by: Erik Bjorge -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Friday, April 3, 2020 4:27 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Phil

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 0/3] EdkRepo: Command completion in bash/zsh

2020-04-06 Thread Ashley E Desimone
For the series: Reviewed-by: Ashley DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Friday, April 3, 2020 4:49 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Philippe Mathieu-Daude Subject: [edk2-

[edk2-devel] [PATCH v1 0/2] SecurityPkg: Add PCD for SW SMI Command port

2020-04-06 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2416 The software SMI Command IO Port is currently used in SecurityPkg to support the Physical Presence Interface. The IO port is hardcoded as 0xB2 in Tpm.asl. This patch series adds a PCD to SecurityPkg with the default v

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Checkout command is broken

2020-04-06 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Friday, April 3, 2020 4:27 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Philippe Mathieu-Daude Subject

[edk2-devel] [PATCH v1 1/2] SecurityPkg: Add PCD for SW SMI Command port

2020-04-06 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2416 Adds a PCD to SecurityPkg used to specify the SW SMI Command port. This value may vary across platforms and is current hardcoded to 0xB2 in package code. Cc: Kun Qin Cc: Jian J Wang Cc: Jiewen Yao Cc: Chao Zhang S

[edk2-devel] [PATCH v1 2/2] SecurityPkg Tcg: Use SW SMI IO port PCD in Tpm.asl

2020-04-06 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2416 Replaces the hardcoded value of 0xB2 with a PCD for the SMI port access operation region. This allows platforms to customize the IO port value if necessary. Cc: Kun Qin Cc: Jian J Wang Cc: Jiewen Yao Cc: Chao Zhang

[edk2-devel] TianoCore Community Meeting Minutes - April

2020-04-06 Thread Soumya Guptha
TianoCore Community Meeting Minutes April 2, 2020 Events (Soumya Guptha): Spring 2020 UEFI PLUGFEST has been cancelled due to the Coronavirus. More details are published here - https://uefi.org/events/upcoming We are exploring to do a virtual meeting f

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add Support for macOS

2020-04-06 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Prince Agyeman Cc: Bret Barkelew Cc: Philippe Mathieu-Daude --- build-scripts/build_linux_installer.py| 2 + build-scripts/set_version_and_build_wheels.py | 10 +-- edkrepo/config/config_factory.py

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add Support for macOS

2020-04-06 Thread Bjorge, Erik C
Nate, To simplify some of the installer code should we just switch to local (user) installs in for Linux and Mac? I would like to move to this for Linux anyway. I can also submit a patch for this at some other time. The rest of the code looks good. Thanks, -Erik -Original Message- F

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add Support for macOS

2020-04-06 Thread Nate DeSimone
Hi Erik, I'm not planning on this being the only patch on this topic anyway. I still need to update documentation and stuff like that. You are welcome to take a look at what it would take to switch to user-based installs. For macOS, the only method I support is using pyenv. Thanks, Nate On 4

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add Support for macOS

2020-04-06 Thread Bjorge, Erik C
I will take a look at removing system wide installs on Linux and we can keep these change focused on Mac support. Thanks, -Erik Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Monday, April 6, 2020 2:43 PM To: Bjorge, Erik C ; devel@edk2.groups.io Cc: De

[edk2-devel] [edk2-staging/EdkRepo] [PATCH 2/2] EdkRepo: Update README.md

2020-04-06 Thread Nate DeSimone
- Added installation instructions for macOS - Updated recommended versions of Git and Python Signed-off-by: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Prince Agyeman Cc: Bret Barkelew Cc: Philippe Mathieu-Daude --- README.md | 81 +++---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH 0/2] Add documentation for EdkRepo on macOS

2020-04-06 Thread Nate DeSimone
This patch series add setup instructions and scripts for macOS and update the recommended versions for Git and Pyenv. Nate DeSimone (2): EdkRepo: Add setup_git_pyenv_mac.sh EdkRepo: Update README.md README.md | 81 +++- .../mac-scripts/setup_git_p

[edk2-devel] [edk2-staging/EdkRepo] [PATCH 1/2] EdkRepo: Add setup_git_pyenv_mac.sh

2020-04-06 Thread Nate DeSimone
Script to configure pyenv and git for use on macOS. Signed-off-by: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Prince Agyeman Cc: Bret Barkelew Cc: Philippe Mathieu-Daude --- .../mac-scripts/setup_git_pyenv_mac.sh| 118 ++ 1 file changed, 118 insertions(+) cre

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 04/08/2020 9:30am-10:30am #cal-reminder

2020-04-06 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Wednesday, 8 April 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/493235016 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=758251 ) *Organizer:* Brian Richardson brian.richard...@intel.com

Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment

2020-04-06 Thread Ni, Ray
Sean, PyTools is good. This patch is to support those platforms that haven’t adopted PyTools for their platform build. Thanks, Ray From: devel@edk2.groups.io On Behalf Of Sean via groups.io Sent: Thursday, April 2, 2020 11:59 PM To: Luo, Heng ; devel@edk2.groups.io Subject: Re: [edk2-devel] [P

Re: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add link flags for VS2019 tool chains.

2020-04-06 Thread Guomin Jiang
Hi Justen, Andrew, Ray, Could you help review the changes. Best Regards Guomin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jiang, > Guomin > Sent: Friday, March 20, 2020 1:26 PM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Andrew Fish > ; Ni, Ray > Subject: [e

Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment

2020-04-06 Thread Bob Feng
Hi Sean, That the Basetools works correctly depends on the PACAKGES_PATH is set correctly. I think this patch provides common function and provides assistance for the Basetools. Thanks, Bob From: Ni, Ray Sent: Tuesday, April 7, 2020 10:16 AM To: devel@edk2.groups.io; sean.bro...@microsoft.com;

Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment

2020-04-06 Thread Sean via groups.io
Bob and Ray, My point isn't that there is anything wrong with script.  This script is designed to work with edk2-platforms repo or other repos of similar layout.    This is a "platform" thing that is needed on some platforms (not edk2 core platforms).  To me this means it does't belong in edk2 r

[edk2-devel] [PATCH] .azurepiplines/pr-gate-steps.yml: Update python to 3.8.x for ci build

2020-04-06 Thread Zhang, Shenglei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2617 Update edk2 build and test ci to use Python 3.8.x Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .azurepipelines/templates/pr-gate-steps.yml | 2 +- 1 file changed, 1 insertion(+

[edk2-devel] [PATCH] pip-requirements.txt: Update extensions min version to 0.13.3

2020-04-06 Thread Zhang, Shenglei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2616 Pytool extensions are locked on 0.12.x but extensions has moved to 0.13.x. So update the pip-requirements.txt. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- pip-requirements.txt

[edk2-devel] [PATCH] BaseTools/WindowsVsToolChain.py: Update toolchain plugin

2020-04-06 Thread Zhang, Shenglei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2659 Allow WindowsVsToolChain Plugin to add libraries and headers of user defined ARCH for VS2017 and VS2019. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .../WindowsVsToolChain/WindowsVsToolChain.py | 73 ---