Re: [edk2-devel] [PATCH v2 3/6] UefiCpuPkg: Add definitions for EDKII microcode patch HOB

2019-12-25 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Wu, Hao A > Sent: Wednesday, December 25, 2019 3:58 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Dong, Eric ; Ni, > Ray ; Laszlo Ersek ; Zeng, Star > ; Fu, Siyuan ; Kinney, Michael > D > Subject: [PATCH v2 3/6] UefiCpuPkg: Add definiti

Re: [edk2-devel] [PATCH v2 5/6] UefiCpuPkg/MpInitLib: Relocate microcode patch fields in CPU_MP_DATA

2019-12-25 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Wu, Hao A > Sent: Wednesday, December 25, 2019 3:58 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Dong, Eric ; Ni, > Ray ; Laszlo Ersek ; Zeng, Star > ; Fu, Siyuan ; Kinney, Michael > D > Subject: [PATCH v2 5/6] UefiCpuPkg/MpInitLib: Re

Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Delete CPU_FEATURE_[BEFORE|AFTER]

2019-12-25 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Ray Ni [mailto:niru...@users.noreply.github.com] Sent: Tuesday, November 26, 2019 2:16 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Dong, Eric ; Zeng, Star Subject: [PATCH v2 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Delete CPU_FEATURE_[BEFOR

Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/RegisterCpuFeaturesLib: Rename [Before|After]FeatureBitMask

2019-12-25 Thread Zeng, Star
Minor comment added. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ray Ni > Sent: Tuesday, November 26, 2019 2:16 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Dong, Eric > Subject: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/RegisterCpuFeatures

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/CpuFeature: Introduce First to indicate 1st unit.

2019-12-25 Thread Zeng, Star
Some feedback added. > -Original Message- > From: Ray Ni [mailto:niru...@users.noreply.github.com] > Sent: Tuesday, November 26, 2019 2:16 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Dong, Eric ; Zeng, Star > ; Kinney, Michael D > Subject: [PATCH v2 3/3] UefiCpuPkg/CpuFeature: Introduce

[edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Relocate microcode patch fields in CPU_MP_DATA

2019-12-25 Thread Wu, Hao A
The below 2 microcode patch related fields in structure CPU_MP_DATA: UINT64 MicrocodePatchAddress; UINT64 MicrocodePatchRegionSize; They will be passed from PEI phase and be reused DXE phase. Previously, these 2 fields were placed after some fi

[edk2-devel] [PATCH v3 0/6] Microcode related optimizations

2019-12-25 Thread Wu, Hao A
Series is also available at: https://github.com/hwu25/edk2/tree/mpinitlib_opt_v3 V3 change: For patch 3, correct license information for newly added header file. V2 history: A. For patch 2, rename function parameters and variables to better reflect their usage; B. For patch 2, remove unneed

[edk2-devel] [PATCH v3 4/6] UefiCpuPkg/MpInitLib: Produce EDKII microcode patch HOB

2019-12-25 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2430 This commit will update the MpInitLib to: A. Collect the base address and size information after microcode patches being loaded into memory; B. Collect the detected microcode patch for each processor within system; C. Based on the collect

[edk2-devel] [PATCH v3 2/6] UefiCpuPkg/MpInitLib: Reduce the size when loading microcode patches

2019-12-25 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2429 This commit will attempt to reduce the copy size when loading the microcode patches data from flash into memory. Such optimization is done by a pre-process of the microcode patch headers (on flash). A microcode patch will be loaded into memo

[edk2-devel] [PATCH v3 1/6] UefiCpuPkg/MpInitLib: Collect processors' CPUID & Platform ID info

2019-12-25 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2429 This commit will collect the CPUID and Platform ID information for each processor within system. They will be stored in the CPU_AP_DATA structure. These information will be used in the next commit to decide whether a microcode patch will be

[edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: Remove redundant microcode fields in CPU_MP_DATA

2019-12-25 Thread Wu, Hao A
Previous commits have introduced below fields in structure CPU_AP_DATA: UINT32 ProcessorSignature; UINT8 PlatformId; UINT64 MicrocodeEntryAddr; which store the information of: A. CPUID B. Platform ID C. Detected micro

[edk2-devel] [PATCH v3 3/6] UefiCpuPkg: Add definitions for EDKII microcode patch HOB

2019-12-25 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2430 This commit will add the definitions for EDKII microcode patch HOB. The intention of adding this HOB is to provide a scheme to store the below information: A. The base address and size of the microcode patches that are being loaded (from

[edk2-devel] [Patch V4] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

2019-12-25 Thread Ethan Tsao
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318 Move ConfigBlockLib.h and ConfigBlock.h to InstelSiliconPkg and remove all other ConfigBlockLib.h and ConfigBlock.h Signed-off-by: Ethan Tsao Cc: Ray Ni Cc: Rangasai V Chaganty --- Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg

Re: [edk2-devel] [PATCH v7] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

2019-12-25 Thread Ashish Singhal
Hi Ray, Following up on this. Are we waiting on more suggestions or clarifications? Thanks Ashish Get Outlook for iOS From: Ni, Ray Sent: Monday, December 23, 2019 10:41:50 PM To: Wang, Sunny (HPS SW) ; devel@edk2.groups.io ; Ashish Singh

[edk2-devel] [Patch V5] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

2019-12-25 Thread Ethan Tsao
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318 Move ConfigBlockLib.h and ConfigBlock.h to InstelSiliconPkg and remove all other ConfigBlockLib.h and ConfigBlock.h Signed-off-by: Ethan Tsao Cc: Ray Ni Cc: Rangasai V Chaganty --- Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg

[edk2-devel] [PATCH] BaseTools:Reconfig reset environment value set by edksetup script

2019-12-25 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1985 Reconfig option should not only update build config files. This option should reset environment value set by edksetup script, such as EDK_TOOLS_PATH/PYTHONPATH. If so, this option will be valuable for the user to switch the different WORKSPACE

[edk2-devel][edk2-platforms][PATCH] IntelSiliconPkg/Feature/SmmAccess/*: Fix incorrect Docygen comment

2019-12-25 Thread Marc W Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2436 Cc: Michael Kubacki Cc: Sai Chaganty Cc: Liming Gao Cc: Shenglei Zhang Signed-off-by: Marc Chen --- .../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 19 --- .../Feature/SmmAccess/SmmAccessDxe/SmmAccessDriver.c |