About DbgDevInfoHeaderParser and DbgDevInfoParser.
This patch would parse same DbgDevInfo twice, one for getting length, the other
for dumping structure info.
How about the following?
Add one parameter for DumpDbgDeviceInfo
STATIC
VOID
EFIAPI
DumpDbgDeviceInfo (
IN UINT8* Ptr,
OUT UINT32* L
One confusion below:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Thursday, August 1, 2019 4:44 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao ; sami.muja...@arm.com;
> matteo.carl...@arm
This patch adds "Threat model for EDK II" as the appendix section
of "EDK II secure coding guide" document.
The threat model discussed here is a general guide and serves as the baseline of
the EDK II firmware. For each specific feature in EDK II firmware, there might
be
additional feature-ba
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525
The patch is to merge multiple FMP instances into single ESRT entry
when they have the same GUID.
The policy to LastAttemptStatus/LastAttemptVersion of ESRT entry is:
If all the LastAttemptStatus are LAST_ATTEMPT_STATUS_SUCCESS, then
LastAt
Hi Laszlo,
Thank you for the suggestion. Will set them in git.
Best Regards
Eric
-Original Message-
From: Laszlo Ersek
Sent: Thursday, August 1, 2019 5:03 AM
To: Jin, Eric
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple
controllers
On
Hao,
Thank you for the suggestion. I have sent the patch v2 out and merge series to
one patch.
Let's wait one day to follow the possible comments from stewards. Thanks.
Best Regards
Eric
-Original Message-
From: Wu, Hao A
Sent: Monday, August 5, 2019 2:20 PM
To: devel@edk2.groups.io;
Hi Zhichao,
The reason why processing of the Debug Device Information Structure is split
into:
1. loading the header
2. dumping the entire structure
Is because we want to let the users control how much of the structure is
dumped. This is important for backward compatibility of the acpiview tool
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Monday, August 05, 2019 1:55 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei ; Yao, Jiewen
> ; Wang, Jian J ; Zhang,
> Chao B
> Subject:
Reviewed-by: Ray Ni
> -Original Message-
> From: Dong, Eric
> Sent: Monday, August 5, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: [Patch v2 0/2] UefiCpuPkg: Remove debug message.
>
> This debug message may be called by BSP and APs. It may caused ASSER
Hi Tien Hock,
I have already given my reviewed-by to v5 of this patch.
So can you please resubmit the changes since then as a separate patch?
But I am still waiting for a response from Mike to
https://edk2.groups.io/g/devel/message/44042
before I am able to push the platform support.
Best Regard
Hi Leif,
OK noted, I'll submit a new patch on top of the commit.
I'll also try to ping Micheal.
Thanks
Tien Hock
> -Original Message-
> From: Leif Lindholm
> Sent: Monday, August 5, 2019 5:26 PM
> To: Loh, Tien Hock ; Kinney, Michael D
>
> Cc: devel@edk2.groups.io; thlo...@gmail.com; A
Hi Zhichao,
Please see my response inline.
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via
Groups.Io
Sent: 05 August 2019 08:23 AM
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Carsey, Jaben ; Ni, Ray ; Sami
Mujawar ; Matteo Carlini ;
On Sat, Aug 03, 2019 at 04:03:04AM +0200, Laszlo Ersek via Groups.Io wrote:
> On 08/01/19 21:16, Roman Kagan wrote:
> This is a serious bug. Thank you for reporting and analyzing it. Can you
> file it in the TianoCore Bugzilla too, please?
https://bugzilla.tianocore.org/show_bug.cgi?id=2053
> I w
For this patch series.
Tested-by: Sami Mujawar
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael D Kinney
via Groups.Io
Sent: 03 August 2019 02:47 AM
To: devel@edk2.groups.io
Cc: Jaben Carsey ; Ray Ni ; Zhichao
Gao ;
Hi Marcin,
On Thu, Jul 11, 2019 at 09:45:00AM +0100, Leif Lindholm wrote:
> > > > On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote:
> > > > > Ensure that in case of SlowMode or 3.3V operation,
> > > > > also the HS400 capability will be disabled in the
> > > > > SdMmc driver.
> > > >
This looks good.
Helps address some of the concerns brought up in evaluating secure coding
guidelines for alternate feature implementations, too.
Reviewed-by: Vincent Zimmer
-Original Message-
From: Yao, Jiewen
Sent: Monday, August 5, 2019 12:48 AM
To: devel@edk2.groups.io
Cc: Zimmer
Reviewed-by: Jaben Carsey
Thanks
-Jaben
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Sami Mujawar
> Sent: Monday, August 05, 2019 3:48 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao
> Su
Laszlo,
The context of this change is only to the PatchCheck.py tool.
and how that tool uses git show.
I agree with the summary of very flexible capabilities in git
to help developers review different types of files. All of
those settings that were added to support UNI files in UTF-16
file form
Reviewed-by: Ray Ni
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, August 2, 2019 11:23 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Justen, Jordan L
> ; Andrew Fish ; Ni, Ray
>
> Subject: [Patch 0/4] EmulatorPkg: Fix XCODE5 and VS2015 build failures
>
> https://bug
Reviewed-by: Ray Ni
> -Original Message-
> From: Rusocki, Krzysztof
> Sent: Tuesday, August 6, 2019 5:58 AM
> To: devel@edk2.groups.io
> Cc: Nikodem, Damian ; Dong, Eric
> ; Ni, Ray ; Wang, Jian J
> ; Laszlo Ersek ; Rusocki,
> Krzysztof
> Subject: UefiCpuPkg/PiSmmCpuDxeSmm: don't free pa
Reviewed-by: Jian J Wang
> -Original Message-
> From: Rusocki, Krzysztof
> Sent: Tuesday, August 06, 2019 5:58 AM
> To: devel@edk2.groups.io
> Cc: Nikodem, Damian ; Dong, Eric
> ; Ni, Ray ; Wang, Jian J
> ; Laszlo Ersek ; Rusocki,
> Krzysztof
> Subject: UefiCpuPkg/PiSmmCpuDxeSmm: don
Reviewed-by: Jian J Wang
> -Original Message-
> From: West, Gary
> Sent: Wednesday, July 31, 2019 5:54 AM
> To: devel@edk2.groups.io
> Cc: West, Gary ; West, Gary ;
> Wang, Jian J ; Ye, Ting
> Subject: [PATCH v2 1/1] CryptoPkg/BaseCryptLib: Wrap OpenSSL HKDF
> algorithm
>
> REF: http
The description of parameter Version is missing in comments.
So add the description.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.../BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h | 1 +
1 file changed, 1 insertion(+)
diff --git
a/MdePkg/Library/BaseUe
The description of parameter CapFileName is missing in comments.
So add the description.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Library/DxeCapsu
> -Original Message-
> From: Jin, Eric
> Sent: Monday, August 05, 2019 4:03 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan; Bret Barkelew; Wang, Jian J; Wu, Hao A; Kinney, Michael D
> Subject: [PATCH v2] MdeModulePkg/EsrtFmpDxe: Enhance ESRT to support
> multiple controllers
>
> REF: http
Hao Wu,
I agree that patches should be cleaned up for
submission to edk2 repo. The work in edk2-staging
may contain bug fixes and design changes in the
patch history that can be consolidated to a smaller
patch set. Also, all feedback to a patch set from
edk2-staging must be addressed just lik
OK, I got it. Now I have no comment of this patch. I think the description of
'Length' should be 'the whole length of the GT block include GT Block Timer
Structure' or '20+("GT Block Timer Offset" - 20) + n * 40, where n ...' in the
ACPI spec.
Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -O
27 matches
Mail list logo
