[edk2-devel] [PATCH V2] BaseTools:Add the Judgment Method of "--exclude"

2019-06-28 Thread Fan, ZhijuX
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1944 --exclude cannot be used under certain circumstances 1.The value of the parameter USES an absolute path 2.The value of Exclude parameters is based on the value of the Path parameter Neither of these approaches currently works This patch is

[edk2-devel] [Patch 1/1] BaseTools: Singleton the object to handle build conf file

2019-06-28 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The build config files are target.txt, build rule, tooldef During a build, the config is not changed, so the object to handle them need to be singleton. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGen.py

Re: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch files

2019-06-28 Thread Liming Gao
Push @d31666211873086c058285f4a4f1933bc3c3428c..6759212fa69d5d266c2854ea6de44bfd3f7e370b >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Friday, June 28, 2019 9:12 AM >To: Bi, Dandan ; Feng, Bob C ; >devel@edk2.groups.io >Subje

Re: [edk2-devel] [edk2-platofrms] [patch v2] Platform/PurleyOpenBoardPkg: Remove --nt32 flag of edkseup

2019-06-28 Thread Liming Gao
Push @e7fc97a3f9045c35a077ab0151c696aeba722417 >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Friday, June 28, 2019 10:57 AM >To: devel@edk2.groups.io; Bi, Dandan >Cc: Lu, Shifei A ; Zhou, Bowen >; Oram, Isaac W >Subject: Re:

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

2019-06-28 Thread Yao, Jiewen
Hi Would you please share the info on what test has been done for this 5 level paging? Such as stack paging enable/disable, SMM profile, etc. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, > Ray > Sent: Friday, June

Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-28 Thread Wu, Hao A
Hello Marcin, Do you mean by only reverting as below: - SdMmcCmdBlk.CommandArgument = (AccessMode & 0xF) | ((CommandSystem & 0xF) << 4) | \ -((DriverStrength & 0xF) << 8) | ((PowerLimit & 0xF) << 12) | \ + SdMmcCmdBlk.CommandArgument = (AccessMode & 0xF) | ((Pow

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

2019-06-28 Thread Ni, Ray
Jiewen, I tested the above 2^48 memory address access in SMM environment to ensure no GP fault. The code is internally used for a while and this patch is to upstream the code to edk2 repo. Thanks, Ray > -Original Message- > From: Yao, Jiewen > Sent: Friday, June 28, 2019 3:18 PM > To:

[edk2-devel] [Patch 1/1] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-06-28 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The WorkspaceAutoGen.__InitWorker function is too long, it's hard to read and understand. This patch is to separate the __InitWorker into multiple small ones. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/Auto

Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-28 Thread Marcin Wojtas
Hi Hao, pt., 28 cze 2019 o 09:23 Wu, Hao A napisał(a): > Hello Marcin, > > > > Do you mean by only reverting as below: > > - SdMmcCmdBlk.CommandArgument = (AccessMode & 0xF) | ((CommandSystem & > 0xF) << 4) | \ > > -((DriverStrength & 0xF) << 8) | (( > PowerLimi

Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-28 Thread Fan, ZhijuX
Hi: You're right, but at least we won't have to worry about this until “python3.10” · And we're comparing directory names, "Python 3.6.6" doesn't appear in the Python version we found · We find python applications using “whereis python” “/usr/bin/python3.6” “/usr/local/bin/py

Re: [edk2-devel] [edk2-platform patch V6] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-28 Thread Liming Gao
Zhiju: This version is good to me. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Fan, ZhijuX >Sent: Friday, June 28, 2019 2:59 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >; Ard Biesheuvel ; Leif >Lindholm ; Kinney, Michael D > >Subject: [edk2-platfor

Re: [edk2-devel] [edk2-platform patch V6] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-28 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, June 28, 2019 2:59 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Ard Biesheuvel ; Leif Lindholm ; Kinney, Michael D Subject: [edk2-platform patch V6] Platform/Intel:Add UniTool into edk2-platforms/

Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3

2019-06-28 Thread Liming Gao
The change is good. Reviewed-by: Liming Gao I suggest you run this script in Linux and double confirm. >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >rebe...@bluestop.org >Sent: Thursday, June 27, 2019 9:05 PM >To: Gao, Liming ; devel@edk2.gr

Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-28 Thread Albecki, Mateusz
Hi, Do you use override driver with this SD controller(if yes and it is open source could you provide the link)? There is one change introduced in this patch that might require changes in the override driver. We have added enumeration for SdMmcSdDs and SdMmcSdHs modes which were so far indicate

Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-28 Thread Wu, Hao A
Hello Marcin, I just realized that the series added 2 new bus modes (SdMmcSdDs and SdMmcSdHs) for 3.3V signaling SD card: Judging from your log: SdCardSetBusMode: Target bus mode: bus timing = 1, bus width = 4, clock freq[MHz] = 50, driver strength = 255 which “bus timing = 1” means SdMmcSdHs (

[edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters

2019-06-28 Thread Krzysztof Koch
The following patches modify the user interface to the Acpiview UEFI shell tool. These changes are aimed to simplify interaction with the tool as well as to remove redundant/non-functional command line parameters. Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_f

[edk2-devel] [PATCH v1 3/5] ShellPkg: acpiview: Allow disabling consistency checks (-q flag)

2019-06-28 Thread Krzysztof Koch
The current documentation for the acpiview UEFI shell tool states that the '-c' flag enables consistency checks on ACPI table data. However, these checks are enabled anyway by default. This patch keeps ACPI table validation as a default option, but it makes it possible to turn ACPI table validatio

[edk2-devel] [PATCH v1 2/5] ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting

2019-06-28 Thread Krzysztof Koch
Move printing double newline character ('\n\n') from the beginning of ACPI table checksum validation message to the end of the raw binary data dump. This way acpiview table dump looks similar regardless of whether Table Checksum is validated or not. Signed-off-by: Krzysztof Koch --- Changes can

Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-28 Thread Marcin Wojtas
Hi Mateusz, pt., 28 cze 2019 o 10:12 Albecki, Mateusz napisał(a): > Hi, > > > > Do you use override driver with this SD controller(if yes and it is open > source could you provide the link)? > [MW] Of course it's open source https://github.com/tianocore/edk2-platforms/tree/master/Silicon/Marv

[edk2-devel] [PATCH v1 1/5] ShellPkg: acpiview: Remove '/?' from valid command line flags

2019-06-28 Thread Krzysztof Koch
Acpiview currently allows displaying help info by specifying both -? and /? flags. This patch removes /? from valid command line flags that can be passed to the acpiview tool, as this flag is not used for such purpose in other UEFI shell commands. Signed-off-by: Krzysztof Koch --- Changes can be

[edk2-devel] [PATCH v1 4/5] ShellPkg: acpiview: Remove '-v' flag from allowed command line args

2019-06-28 Thread Krzysztof Koch
According to the acpiview documentation, the -v flag enables verbose output and it is set on default. Moreover, the acpiview UEFI shell tool dumps the same output with and without this flag set. Therefore this patch removes the superfluous -v flag from allowed command line parameters. Signed-off

[edk2-devel] [PATCH v1 5/5] ShellPkg: acpiview: Make '-h' option not require a parameter

2019-06-28 Thread Krzysztof Koch
Make the -h command line option a binary flag. Now, colour highlighting is enabled whenever this flag is set (stateless), instead of being dependent on previous acpiview command invocations. By removing the parameter required with the -h flag the command line parsing logic becomes simpler. Signed

[edk2-devel] [PATCH v1 2/4] ShellPkg: acpiview: Make DBG2 output consistent with other tables

2019-06-28 Thread Krzysztof Koch
Print an extra newline character at the end DBG2 table parsing in order to make the output resemble the one for other ACPI table parsers. With this change, there is now a blank line between the DBG2 table dump and the 'Table Statistics' section. Signed-off-by: Krzysztof Koch --- Changes can be

[edk2-devel] [PATCH v1 0/4] Fix a number of small issues in acpiview

2019-06-28 Thread Krzysztof Koch
The following patches introduce a number of unrelated changes which fix a number of minor issues in the Acpiview UEFI shell tool. Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_fixes_v1 Krzysztof Koch (4): ShellPkg: acpiview: Improve PPTT table field validatio

[edk2-devel] [PATCH v1 1/4] ShellPkg: acpiview: Improve PPTT table field validation

2019-06-28 Thread Krzysztof Koch
Add Cache Structure (Type 1) 'Number of sets' and 'Associativity' field validation in the acpiview Processor Properties Topology Table (PPTT) parser. Replace literal values with precompiler macros for existing Cache Structure validation functions. Signed-off-by: Krzysztof Koch --- Changes can b

[edk2-devel] [PATCH v1 4/4] ShellPkg: acpiview: Remove duplicate indentation in IORT parser

2019-06-28 Thread Krzysztof Koch
Remove redundant whitespace characters at the beginning of the strings describing IORT table field names. When dumping ACPI table contents, the indentation level for printing field names is controled using the 'Indent' argument to the 'ParseAcpi' function. In the IORT acpiview parser, both 'Indent

[edk2-devel] [PATCH v1 3/4] ShellPkg: acpiview: Remove redundant IORT node types enum

2019-06-28 Thread Krzysztof Koch
Replace the enum defining valid node types in the IORT table with macros from IoRemappingTable.h. Signed-off-by: Krzysztof Koch --- Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/commit/79650cd6f2552e849afcd89aa016f35774376408 Notes: v1: - Remove redundant enum defining

Re: [edk2-devel] [PATCH v1 4/4] ShellPkg: acpiview: Remove duplicate indentation in IORT parser

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43008): https://edk2.groups.io/g/devel/message/43008 Mute This Topic: https://groups.io/mt/32240403/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 3/4] ShellPkg: acpiview: Remove redundant IORT node types enum

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43009): https://edk2.groups.io/g/devel/message/43009 Mute This Topic: https://groups.io/mt/32240402/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 2/4] ShellPkg: acpiview: Make DBG2 output consistent with other tables

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43010): https://edk2.groups.io/g/devel/message/43010 Mute This Topic: https://groups.io/mt/32240396/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 1/4] ShellPkg: acpiview: Improve PPTT table field validation

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43011): https://edk2.groups.io/g/devel/message/43011 Mute This Topic: https://groups.io/mt/32240395/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 4/4] ShellPkg: acpiview: Remove duplicate indentation in IORT parser

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43012): https://edk2.groups.io/g/devel/message/43012 Mute This Topic: https://groups.io/mt/32240403/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 3/4] ShellPkg: acpiview: Remove redundant IORT node types enum

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43013): https://edk2.groups.io/g/devel/message/43013 Mute This Topic: https://groups.io/mt/32240402/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 2/4] ShellPkg: acpiview: Make DBG2 output consistent with other tables

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43014): https://edk2.groups.io/g/devel/message/43014 Mute This Topic: https://groups.io/mt/32240396/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 0/4] Fix a number of small issues in acpiview

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43015): https://edk2.groups.io/g/devel/message/43015 Mute This Topic: https://groups.io/mt/32240394/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 5/5] ShellPkg: acpiview: Make '-h' option not require a parameter

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43016): https://edk2.groups.io/g/devel/message/43016 Mute This Topic: https://groups.io/mt/32240040/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 4/5] ShellPkg: acpiview: Remove '-v' flag from allowed command line args

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43017): https://edk2.groups.io/g/devel/message/43017 Mute This Topic: https://groups.io/mt/32240039/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 3/5] ShellPkg: acpiview: Allow disabling consistency checks (-q flag)

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43018): https://edk2.groups.io/g/devel/message/43018 Mute This Topic: https://groups.io/mt/32240036/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 1/5] ShellPkg: acpiview: Remove '/?' from valid command line flags

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43020): https://edk2.groups.io/g/devel/message/43020 Mute This Topic: https://groups.io/mt/32240029/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 2/5] ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43019): https://edk2.groups.io/g/devel/message/43019 Mute This Topic: https://groups.io/mt/32240030/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters

2019-06-28 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43021): https://edk2.groups.io/g/devel/message/43021 Mute This Topic: https://groups.io/mt/32240028/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v3 4/4] OvmfPkg: don't assign PCI BARs above 4GiB when CSM enabled

2019-06-28 Thread Laszlo Ersek
On 06/27/19 21:16, David Woodhouse wrote: > On Thu, 2019-06-27 at 21:01 +0200, Laszlo Ersek wrote: >> >> To clarify -- this is by no means to say that *SeaBIOS* is a relic. I >> absolutely don't imply that. Users should use the firmware they need, >> especially in the virtual world, where choosing

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: Adjust the coding style in Base64Decode

2019-06-28 Thread Laszlo Ersek
On 06/28/19 05:57, Gao, Zhichao wrote: > Adjust the code style for better view. > > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > MdePkg/Library/BaseLib/String.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/MdePkg/Library/B

Re: [edk2-devel] [PATCH 0/3] MdePkg/BaseLib: Base64Decode: Make it follow its specification

2019-06-28 Thread Laszlo Ersek
On 06/28/19 05:57, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1891 > > Adjust the coding style. > Set DestinationSize before return. > Add addition decription for the RETURN_SUCCESS case. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Marvin Hauser > Cc: Laszlo

[edk2-devel] [off-topic] those crazy kids

2019-06-28 Thread Laszlo Ersek
Hi List, my indirect manager Karen Noel took the linked photo on her way to work. It made me laugh; with her permission, I'm sharing the photo, in the hope that it will make you guys laugh as well :) http://people.redhat.com/lersek/party-with-the-shell/IMG_20190627_120026.jpg (I hope this email

Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3

2019-06-28 Thread rebecca
On 6/28/19 2:04 AM, Liming Gao wrote: The change is good. Reviewed-by: Liming Gao I suggest you run this script in Linux and double confirm. I've tested it on openSUSE Tumbleweed 20190626 and verified it still works, by building OVMF. I tested both with and without PYTHON3_ENABLE=TRUE set

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

2019-06-28 Thread Laszlo Ersek
On 06/28/19 09:27, Ni, Ray wrote: > Jiewen, > I tested the above 2^48 memory address access in SMM environment to ensure no > GP fault. > > The code is internally used for a while and this patch is to upstream the > code to edk2 repo. I've tagged this for regression-testing (without 5 level pag

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

2019-06-28 Thread Laszlo Ersek
Ray, On 06/28/19 08:47, Ni, Ray wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1946 I think all three commit messages in the series should carry this BZ reference. I understand they are "prep work", but the preparation is being done for

Re: [edk2-devel] [PATCH] ArmVirtPkg: handle NETWORK_TLS_ENABLE in ArmVirtQemu*

2019-06-28 Thread Laszlo Ersek
On 06/28/19 06:48, Gary Lin wrote: > On Mon, Jun 24, 2019 at 09:13:36PM +0200, Laszlo Ersek wrote: >> Port the [LibraryClasses], [PcdsFixedAtBuild] and [Components] settings >> that are related to NETWORK_TLS_ENABLE from OvmfPkg to ArmVirtPkg. >> ArmVirtXen is not modified because it doesn't includ

Re: [edk2-devel] [PATCH] ArmVirtPkg: handle NETWORK_TLS_ENABLE in ArmVirtQemu*

2019-06-28 Thread Laszlo Ersek
On 06/24/19 21:13, Laszlo Ersek wrote: > Port the [LibraryClasses], [PcdsFixedAtBuild] and [Components] settings > that are related to NETWORK_TLS_ENABLE from OvmfPkg to ArmVirtPkg. > ArmVirtXen is not modified because it doesn't include the edk2 network > stack. > > (This change is now simpler th

[edk2-devel] [PATCH] OvmfPkg/XenBusDxe: Close XenIoProtocol openned by childs

2019-06-28 Thread Anthony PERARD
In XenBusDxe, the XenBusAddDevice() opens the gXenIoProtocolGuid on behalf of child controllers. It is never closed and prevent from uninstalling the protocol. Close it were we stop all the childs in XenBusDxe->Stop(). Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/XenBusDxe.c | 5 + 1

Re: [edk2-devel] [off-topic] those crazy kids

2019-06-28 Thread Brian Richardson
Very nice. Can I share this (with credit) on the @tianocore Twitter account? Thanks … br --- Brian Richardson -- Director of Firmware Ecosystem Engagements brian.richard...@intel.com -- @intel_brian Firmware Ecosystem & Business Development, Firmware Integration & Development (FID) https://softwa

[edk2-devel] [Patch] MdeModulePkg/PiSmmCore: Use unique structure signatures

2019-06-28 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1948 Update the data structure signatures in the PiSmmCore to be unique. Some of the signatures are the same as those used by the DxeCore. For example, the memory pool head and tail structures use the same signature in the PiSmmCore and DxeCore. This

Re: [edk2-devel] RFC for edk2-tools-library v2 previously known as RFC for Edk2-Library

2019-06-28 Thread Sean via Groups.Io
Final update on the RFC. The repo is up and populated and ready for contributions.   Please read the repository readme for details. https://github.com/tianocore/edk2-pytool-library An initial Pypi release has been made https://pypi.org/project/edk2-pytool-library/ And CI & pull request builds a

Re: [edk2-devel] [edk2-platforms][PATCH] ClevoOpenBoardPkg: Added OS boot support

2019-06-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Friday, June 14, 2019 1:01 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Wei, David Y ; Kubacki, Michael A ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-platforms][PATCH] ClevoOpenBoardPkg: Added OS boot

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: FSP Python scripts to support 3.x.

2019-06-28 Thread Nate DeSimone
Hi Chasel, In addition to Star's comment. Could you also please do the following for your python version check: if sys.version_info[0] < 3: Instead of: if sys.version_info < (3,0): With those changes... Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Monday

Re: [edk2-devel] [PATCH] MinPlatformPkg: FSP Python script to python 3.x.

2019-06-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Monday, June 24, 2019 7:36 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH] MinPlatformPkg: FSP Python script to python 3.x. https://bugzilla.tianocore.org/s

Re: [edk2-devel] RFC for Edk2-ToolEnv

2019-06-28 Thread Sean via Groups.Io
Wrapping up all comments on the RFC and requesting the RFC move to the implementation phase. Changes after community discussion: * GitHub repository will be called edk2-pytool-extensions * An additional comment will be added to the contribution process to make it clear that PRs will be squashed

Re: [edk2-devel] [Patch] MdeModulePkg/PiSmmCore: Use unique structure signatures

2019-06-28 Thread Yao, Jiewen
Good idea to catch the issue earlier. Reviewed-by: jiewen@intel.com > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Saturday, June 29, 2019 4:19 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Ni

Re: [edk2-devel] RFC for Edk2-ToolEnv

2019-06-28 Thread Michael D Kinney
Hi Sean, The edk2-pytool-extensions repo has been created. Thanks, Mike From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Sean via Groups.Io Sent: Friday, June 28, 2019 3:14 PM To: Sean ; devel@edk2.groups.io Subject: Re: [edk2-devel] RFC for Edk2-ToolEnv Wrapping up all c

Re: [edk2-devel] [Patch] MdeModulePkg/PiSmmCore: Use unique structure signatures

2019-06-28 Thread Zeng, Star
Good idea. Reviewed-by: Star Zeng . Thanks, Star > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Saturday, June 29, 2019 4:19 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Yao

Re: [edk2-devel] [RFC] EdkRepo - The Multi-Repository Tool for EDK II

2019-06-28 Thread Nate DeSimone
Hi All, The initial drop of EdkRepo has to edk2-staging has been completed! https://github.com/tianocore/edk2-staging/tree/EdkRepo For convenience, I have compiled binaries of the current state of EdkRepo and attached them to a personal fork of edk2-staging. By no means should these binaries b