Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py

2019-06-21 Thread Wang, Jian J
Hi David, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of David > Woodhouse > Sent: Friday, June 21, 2019 6:34 AM > To: devel@edk2.groups.io; ler...@redhat.com; Lu, XiaoyuX > > Cc: Wang, Jian J ; Ye, Ting ; > Richard Levitte > Subject: Re: [e

Re: [edk2-devel] [edk2-platform patch 1/2] Platform/Intel:Add GenBiosId into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Leif Lindholm
On Fri, Jun 21, 2019 at 01:58:17AM +, Fan, ZhijuX wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 > > GenBiosId is a tool to generate the BIOS ID binary file which uses > the data from the configuration file. > This tool can be run in both Py2 and Py3. > > This patch is going

Re: [edk2-devel] [edk2-platform patch 2/2] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Leif Lindholm
On Fri, Jun 21, 2019 at 01:58:57AM +, Fan, ZhijuX wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 > > UniTool is one python script to generate UQI (Universal Question > Identifier) unicode string for HII question PROMPT string. UQI > string can be used to identify each HII ques

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Fix CR/LF issue

2019-06-21 Thread Wang, Jian J
Pushed at 90e8f13d51278791e9534fc736a5319f9b4f9f0a Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang, > Jian J > Sent: Thursday, June 20, 2019 8:35 AM > To: Lu, XiaoyuX ; devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH v2 1/1] CryptoPkg/OpensslLib: disable autoload-config for OpenSSL

2019-06-21 Thread Wang, Jian J
Pushed at b86fbe1f980102eee3e55eed92ac91937aee638e Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Xiaoyu Lu > Sent: Thursday, June 20, 2019 1:55 PM > To: devel@edk2.groups.io; Laszlo Ersek ; Wang, Jian J > > Cc: Lu, XiaoyuX

Re: [edk2-devel] [edk2-platform patch 1/2] Platform/Intel:Add GenBiosId into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Fan, ZhijuX
Hi: Thank you for your comments. The output 1 was designed as a standard error. Function EdkLogger () sys.exit(1) "1" missing while writing the script Any question, please let me know. Thanks. Best Regards Fan Zhiju > -Original Message- > From: devel@edk2.groups.io [mailto:d

Re: [edk2-devel] [edk2-platform patch 2/2] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Fan, ZhijuX
There are several reasons why argparse is not used: 1. The logic and parameters of this script are simple. 2. This script is ported from another directory, Only functional changes have been made to it, and its architecture is basically unchanged, 3. Printing a Help Message when an error occ

[edk2-devel] [edk2-platform patch 1/2 V2] Platform/Intel:Add GenBiosId into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 GenBiosId is a tool to generate the BIOS ID binary file which uses the data from the configuration file. This tool can be run in both Py2 and Py3. This patch is going to add GenBiosId to Platform/Intel/Tools Cc: Liming Gao Cc: Bob Feng Cc:

Re: [edk2-devel] [edk2-platform patch 1/2] Platform/Intel:Add GenBiosId into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Leif Lindholm
On Fri, Jun 21, 2019 at 09:47:37AM +, Fan, ZhijuX wrote: > Hi: > > Thank you for your comments. The output 1 was designed as a standard error. > Function EdkLogger () sys.exit(1) "1" missing while writing the script > > > > > Any question, please let me know. Thanks. > > Best Regar

Re: [edk2-devel] [edk2-platform patch 2/2] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Leif Lindholm
On Fri, Jun 21, 2019 at 10:02:18AM +, Fan, ZhijuX wrote: > There are several reasons why argparse is not used: > > 1. The logic and parameters of this script are simple. But for others, having to relearn how each individual script works rather than having all of them use the same common mecha

Re: [edk2-devel] [edk2-platform patch 1/2 V2] Platform/Intel:Add GenBiosId into edk2-platforms/Platform/Intel/Tools

2019-06-21 Thread Leif Lindholm
On Fri, Jun 21, 2019 at 10:03:42AM +, Fan, ZhijuX wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 > > GenBiosId is a tool to generate the BIOS ID binary file which uses > the data from the configuration file. > This tool can be run in both Py2 and Py3. > > This patch is going

Re: [edk2-devel] [PATCH 1/2] LegacyBios: set NumberBbsEntries to the size of BbsTable

2019-06-21 Thread David Woodhouse
On Thu, 2019-06-20 at 22:35 +0200, Laszlo Ersek wrote: > > > I think your note on patch#2 is valuable too and should be captured in > > > the commit message body. Please consider formulating it with a bit more > > > neutral tone :) > > > > I would prefer to express that particular concern in 'diff

Re: [edk2-devel] [PATCH 0/4] Remove S3Lib and RecoveryLib

2019-06-21 Thread Zeng, Star
Removed-by: Star Zeng to the series. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Friday, June 21, 2019 11:00 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > >

[edk2-devel] [PATCH v3 1/2] MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase

2019-06-21 Thread Albecki, Mateusz
https://bugzilla.tianocore.org/show_bug.cgi?id=1882 The new notify phase allows platform to configure additional bus paramters in addition to parameters that can already be configured with capability override. Specifically we allow to configure bus width, clock frequency and driver strength. If pl

[edk2-devel] [PATCH v3 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol

2019-06-21 Thread Albecki, Mateusz
To allow platform greater control over the bus settings for SD card and eMMC card we have added a new notify phase to SdMmcOverrideProtocol called GetOperatingParam. This phase is signaled before SD card/eMMC initialization and allows platform to tweak the values in new structure called EDKII_SD

[edk2-devel] [PATCH v3 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-21 Thread Albecki, Mateusz
From: "Albecki, Mateusz" https://bugzilla.tianocore.org/show_bug.cgi?id=1882 Implement support for GetOperatingParamters notify phase in SdMmcHcDxe driver. GetOperatingParameters notify phase is signaled before we start card detection and initialization. Code has been updated for both eMMC and S

[edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Fix unaligned data transfer handling

2019-06-21 Thread Albecki, Mateusz
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1341 Since UFS specification requirs the data buffer specified in PRDT to be DWORD aligned in size we had a code in UfsInitUtpPrdt that aligned the data buffer by rounding down the buffer size to DWORD boundary. This meant that for SCSI commands

[edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Refactor UFS device presence detection

2019-06-21 Thread Albecki, Mateusz
In current implementation we are checking for device presence every time we execute UIC command. To make UfsExecUicCommands more generic checking device presence has been moved to UfsDeviceDetection. Cc: Hao A Wu Signed-off-by: Mateusz Albecki --- .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c

[edk2-devel] [PATCH 4/7] MdeModulePkg/UefiBootManagerLib: export EfiBootManagerGetBootDescription()

2019-06-21 Thread David Woodhouse
It would be useful for LegacyBiosDxe to be able to get descriptive names for block devices, for legacy boot options. It gets a bit confusing when they're all called "Harddisk". Since we have a collection of the special cases for various types of device already in BmGetBootDescription(), let's expo

[edk2-devel] [PATCH 1/7] OvmfPkg/LegacyBios: set NumberBbsEntries to the size of BbsTable

2019-06-21 Thread David Woodhouse
This is hard-coded in the IntThunk structure, and the additional entries will be needed for other devices like VirtIO and NVMe disks. So admit that they exist. Signed-off-by: David Woodhouse Acked-by: Laszlo Ersek --- OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 2 +- 1 file changed, 1 insertion(+)

[edk2-devel] [PATCH 2/7] OvmfPkg/LegacyBbs: Add boot entries for VirtIO and NVME devices

2019-06-21 Thread David Woodhouse
Iterate over the available block devices in much the same way as BdsLibEnumerateAllBootOption() does, but limiting to those devices which are PCI-backed, which can be represented in the BbsTable. One day we might need to extend the BbsTable to allow us to distinguish between different NVMe namespa

[edk2-devel] [PATCH 7/7] OvmfPkg: don't assign PCI BARs above 4GiB when CSM enabled

2019-06-21 Thread David Woodhouse
Mostly, this is only necessary for devices that the CSM might have native support for, such as VirtIO and NVMe; PciBusDxe will already degrade devices to 32-bit if they have an OpROM. However, there doesn't seem to be a generic way of requesting PciBusDxe to downgrade specific devices. There's In

[edk2-devel] [PATCH 6/7] MdeModulePkg/UefiBootManagerLib: describe VirtIO devices correctly

2019-06-21 Thread David Woodhouse
I know, I said it was Someone Else's Problem. But it annoyed me. My initial thought was to look for VIRTIO_DEVICE_PROTOCOL on the same handle but I don't think I can do that if I can't rely on VirtIO being present in the build. This will do. Signed-off-by: David Woodhouse --- .../UefiBootManage

[edk2-devel] [PATCH 3/7] OvmfPkg: Don't build in QemuVideoDxe when we have CSM

2019-06-21 Thread David Woodhouse
QemuVideoDxe installs its own legacy INT 10h handler for the benefit of systems like Windows 2008r2 which attempt to use INT 10h even when booted via EFI. This interacts extremely badly with a CSM actually attempting to install a real video BIOS. The last thing done before invoking a legacy OpROM

[edk2-devel] [PATCH 5/7] OvmfPkg/LegacyBiosDxe: Use EfiBootManagerGetBootDescription()

2019-06-21 Thread David Woodhouse
No longer call all NVMe & VirtIO devices just "Harddisk". Admittedly, VirtIO disks are now just called 'Misc Device' instead, but at least that is now Someone Else's Problemâ„¢. Signed-off-by: David Woodhouse --- OvmfPkg/Csm/LegacyBiosDxe/LegacyBbs.c | 46 - OvmfPkg/Csm/L