Re: [edk2-devel][Patch] IntelFspPkg&IntelFspWrapperPkg: Remove them

2019-06-11 Thread Chiu, Chasel
Just committed this fix. https://edk2.groups.io/g/devel/topic/31860753#41659 Thanks! Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, June 6, 2019 1:59 PM > To: Ni, Ray ; Chiu, Chasel ; Zeng, > Star > > Cc: devel@edk2.groups.io > Subject: RE: [edk2-devel][P

Re: [edk2-devel][Patch] IntelFspPkg&IntelFspWrapperPkg: Remove them

2019-06-11 Thread Ni, Ray
Chasel, Nate, Thanks. I will remove the two packages ASAP. > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, June 11, 2019 3:19 PM > To: Desimone, Nathaniel L ; Ni, Ray > ; Zeng, Star > Cc: devel@edk2.groups.io > Subject: RE: [edk2-devel][Patch] IntelFspPkg&IntelFspWrapperPkg: R

[edk2-devel] [Patch V3] EmulatorPkg: don't display the cpu current speed

2019-06-11 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1686 V3: I hope that changing the status of the mCpuSmbiosType4 wouldn't affect other features except showing CPU speed. The value is zero in NT32Pkg. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Zhiguang Liu ---

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

2019-06-11 Thread Jordan Justen
On 2019-06-10 18:43:07, Hao A Wu wrote: > The series is also available at: > https://github.com/hwu25/edk2/tree/ovmf_drop_framework_v2 > > V2 changes: > > * Update to module OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf has been > dropped, since the module is proposed to be removed in another ser

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

2019-06-11 Thread Wu, Hao A
> -Original Message- > From: David Woodhouse [mailto:dw...@infradead.org] > Sent: Tuesday, June 11, 2019 3:37 PM > To: Justen, Jordan L; Wu, Hao A; devel@edk2.groups.io > Cc: Ni, Ray; Laszlo Ersek; Ard Biesheuvel; Phillips, D Scott > Subject: Re: [PATCH v2 0/6] Ovmf: Drop IntelFramework[Mod

Re: [edk2-devel] [Patch V3] EmulatorPkg: don't display the cpu current speed

2019-06-11 Thread Jordan Justen
On 2019-06-11 00:32:27, Zhiguang Liu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1686 > > V3: I hope that changing the status of the mCpuSmbiosType4 > wouldn't affect other features except showing CPU speed. > The value is zero in NT32Pkg. > > Cc: Jordan Justen > Cc:

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

2019-06-11 Thread Wu, Hao A
> -Original Message- > From: David Woodhouse [mailto:dw...@infradead.org] > Sent: Tuesday, June 11, 2019 4:01 PM > To: Wu, Hao A; Justen, Jordan L; devel@edk2.groups.io > Cc: Ni, Ray; Laszlo Ersek; Ard Biesheuvel; Phillips, D Scott > Subject: Re: [PATCH v2 0/6] Ovmf: Drop IntelFramework[Mod

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Add dynamic PPTT table generation support

2019-06-11 Thread Sami Mujawar
Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 24 May 2019 01:07 PM To: devel@edk2.groups.io Cc: leif.lindh...@linaro.org; Sami Mujawar ; Alexei Fedorov ; Matteo Carlini ; Stephanie Hughes-Fitt ; nd Subject: [PATCH v1 1/1] DynamicTablesPkg: Add dynamic PPTT t

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Add dynamic PPTT table generation support

2019-06-11 Thread Sami Mujawar
Pushed as 8349b8683640..77db115601fb -Original Message- From: Sami Mujawar Sent: 11 June 2019 09:12 AM To: devel@edk2.groups.io Cc: nd Subject: RE: [PATCH v1 1/1] DynamicTablesPkg: Add dynamic PPTT table generation support Reviewed-by: Sami Mujawar -Original Message- From: Kr

Re: [edk2-devel] [edk2-platform patch 0/2] Import IntelSiliconPkg from edk2 repo master

2019-06-11 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Liming > Sent: Monday, June 10, 2019 11:36 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Ni, Ray > ; Chaganty, Rangasai V > Subject: [edk2-platform patch 0/2] Import IntelSiliconPkg from edk2 repo > master > > BZ: https://

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: GTDT updates for ACPI 6.3

2019-06-11 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov Alexei From: PierreGondois Sent: 06 June 2019 10:20 To: devel@edk2.groups.io Cc: Sami Mujawar; Alexei Fedorov; Matteo Carlini; Stephanie Hughes-Fitt; Pierre Gondois; nd Subject: [PATCH v1 1/1] DynamicTablesPkg: GTDT updates for ACPI

Re: [edk2-devel] [edk2-platform patch 0/2] Import IntelSiliconPkg from edk2 repo master

2019-06-11 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Gao, Liming Sent: Monday, June 10, 2019 8:36 AM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Ni, Ray ; Chaganty, Rangasai V Subject: [edk2-platform patch 0/2] Import IntelSiliconPkg from edk2 repo master BZ: https://bugzilla.tian

Re: [edk2-devel] [PATCH v1 0/2] DynamicTablesPkg: Fix line endings and disable deprecated APIs

2019-06-11 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov alexei.fedo...@arm.com -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42191): https://edk2.groups.io/g/devel/message/42191 Mute This Topic: https://groups.io/mt/30918515/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH for-next] MdeModulePkg/PciBusDxe: catch unimplemented extended config space reads

2019-06-11 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Wu, Hao A > Sent: Monday, June 10, 2019 3:04 PM > To: devel@edk2.groups.io; ler...@redhat.com; Ni, Ray > Cc: Alex Williamson ; Wang, Jian J > ; Ard Biesheuvel ; Zeng, > Star > Subject: RE: [edk2-devel] [PATCH for-next] MdeModulePkg/PciBu

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: GTDT updates for ACPI 6.3

2019-06-11 Thread Sami Mujawar
Reviewed-by: Sami Mujawar -Original Message- From: PierreGondois Sent: 06 June 2019 10:21 AM To: devel@edk2.groups.io Cc: Sami Mujawar ; Alexei Fedorov ; Matteo Carlini ; Stephanie Hughes-Fitt ; Pierre Gondois ; nd Subject: [PATCH v1 1/1] DynamicTablesPkg: GTDT updates for ACPI 6.3

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-06-11 Thread Leif Lindholm
On Tue, Jun 11, 2019 at 02:40:51AM +, Loh, Tien Hock wrote: > Leif, > > Since Haojian have a newer driver model that uses the > NonDiscoverableDeviceDxe, I believe we should be moving to use the > new driver. > > I'll try to test out the patches submitted by Haojian in the mean time. > Can yo

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-06-11 Thread Loh, Tien Hock
> -Original Message- > From: Leif Lindholm > Sent: Tuesday, June 11, 2019 5:09 PM > To: Loh, Tien Hock > Cc: 'Haojian Zhuang' ; 'devel@edk2.groups.io' > ; 'thlo...@gmail.com' ; 'Ard > Biesheuvel' > Subject: Re: [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand > polling > > On Tue, Jun

Re: [edk2-devel] [PATCH 1/2] BaseTools: add centralized location for git config files

2019-06-11 Thread Leif Lindholm
Right, I tend to think of configuration files as not-really-copyrightable. Would you like me to send a v2, or would you be OK with me adding # # Copyright (c) 2019, Linaro Ltd. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # to both files and pushing the series? Regards L

Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency

2019-06-11 Thread Leif Lindholm
On Tue, Jun 11, 2019 at 06:19:50AM +, Wu, Hao A wrote: > Can I go ahead to push this series? > Or should I wait someone for additional review? Go for it. My ACK applies to the series. Best Regards, Leif > Best Regards, > Hao Wu > > > > > On Mon, Jun 10, 2019 at 05:13:42AM +, Wu, Hao A

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-11 Thread Leif Lindholm
Hi Wu Hao, I am working on a proposal (and proof-of-concept) machine readable Maintainers.txt format, and a GetMaintainer.py script, based on the format used by QEMU. One of the key features of that format is the F: tag, which specifes a filesytem path (with wildcard support). While this is just

Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RDKQemu: stop using deprecated string conversion routines

2019-06-11 Thread Ard Biesheuvel
On Mon, 10 Jun 2019 at 21:01, Leif Lindholm wrote: > > On Mon, Jun 10, 2019 at 08:55:03PM +0200, Ard Biesheuvel wrote: > > On Mon, 10 Jun 2019 at 20:06, Leif Lindholm > > wrote: > > > > > > On Mon, Jun 10, 2019 at 04:20:06PM +0200, Ard Biesheuvel wrote: > > > > Stop using deprecated string conve

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: GTDT updates for ACPI 6.3

2019-06-11 Thread Sami Mujawar
Pushed as 77db115601fb..e8015f2facff -Original Message- From: Sami Mujawar Sent: 11 June 2019 09:55 AM To: devel@edk2.groups.io Cc: nd Subject: RE: [PATCH v1 1/1] DynamicTablesPkg: GTDT updates for ACPI 6.3 Reviewed-by: Sami Mujawar -Original Message- From: PierreGondois Sen

Re: [edk2-devel] [edk2-platforms PATCH] Platform/Socionext/DeveloperBox: add SMBIOS type 17 table

2019-06-11 Thread Ard Biesheuvel
On Tue, 11 Jun 2019 at 14:18, Masahisa Kojima wrote: > > This adds the SMBIOS type 17 table support for Developerbox platform. > The SPDs on a I2C bus is only accessible by the SCP, so SCP-firmware > stores SPDs in non-secure SRAM. > > This commit also reduces the uefi stack size to allocate space

[edk2-devel] edk2-docs hosted on legacy gitbook site - is migration to new version planned?

2019-06-11 Thread rebecca
I noticed the edk2-docs are hosted on the *legacy* gitbook.com site, at https://legacy.gitbook.com/@edk2-docs . Are there any plans to migrate to the new version (https://docs.gitbook.com/getting-started/migrating-from-the-previous-version)? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io

[edk2-devel] Upcoming Event: TianoCore Design / Bug Triage - EMEA - Wed, 06/12/2019 8:00am-9:00am #cal-reminder

2019-06-11 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design / Bug Triage - EMEA *When:* Wednesday, 12 June 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/695893389 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=488583 ) *Organizer:* Stephano Cetola stephano.cet...@linux.in

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/README: Update the network build flags

2019-06-11 Thread Laszlo Ersek
On 06/10/19 08:55, Gary Lin wrote: > The following network build flags changed due to the inclusion of > NetworkPkg/Network.fdf.inc. > > HTTP_BOOT_ENABLE -> NETWORK_HTTP_BOOT_ENABLE > TLS_ENABLE -> NETWORK_TLS_ENABLE > > This commit also adds NETWORK_ALLOW_HTTP_CONNECTIONS to reflect the > ch

Re: [edk2-devel] [edk2-announce] TianoCore Community Meeting Minutes

2019-06-11 Thread rebecca
[replying to devel@] On 2019-06-10 12:47, Stephano Cetola wrote: > > Documentation > - > Rebecca is hosting the Doxygen docs from packages on her server, and > it is probably better if we use a cloud service to host these, or > better yet, our current gitbooks system. However, there is

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-11 Thread Laszlo Ersek
On 06/10/19 09:16, Ni, Ray wrote: > Hao, > Can you please list the detailed sub-directories/modules/libraries for each > major feature, including those that are not covered by the major features? > This avoid misunderstanding and is also needed by the Maintainers.txt. I agree. Every module INF f

Re: [edk2-devel] [PATCH] BaseTools: Cannot store library cache of different arch together

2019-06-11 Thread Christian Rodriguez
The change looks good overall, but I'm concerned about the performance if there are multiple of the same library used by different modules. In this case the library will be copied once per arch per module. I'm not sure if it would make a giant impact, but just something to think about because yo

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-11 Thread Laszlo Ersek
On 06/11/19 11:51, Leif Lindholm wrote: > Hi Wu Hao, > > I am working on a proposal (and proof-of-concept) machine readable > Maintainers.txt format, and a GetMaintainer.py script, based on the > format used by QEMU. > > One of the key features of that format is the F: tag, which specifes a > fil

Re: [edk2-devel] edk2-docs hosted on legacy gitbook site - is migration to new version planned?

2019-06-11 Thread Laszlo Ersek
Hi, On 06/11/19 16:29, Rebecca Cran wrote: > I noticed the edk2-docs are hosted on the *legacy* gitbook.com site, at > https://legacy.gitbook.com/@edk2-docs . > > Are there any plans to migrate to the new version > (https://docs.gitbook.com/getting-started/migrating-from-the-previous-version)? i

Re: [edk2-devel] [edk2-platform patch 4/4] PurleyOpenBoardPkg: Update FDF to use the generic Microcode FFS rules

2019-06-11 Thread Zhou, Bowen
reviewed-by: Xiaohu Zhou -Original Message- From: Gao, Liming Sent: Tuesday, June 11, 2019 1:04 PM To: devel@edk2.groups.io Cc: Lu, Shifei A ; Zhou, Bowen Subject: [edk2-platform patch 4/4] PurleyOpenBoardPkg: Update FDF to use the generic Microcode FFS rules Signed-off-by: Liming Gao

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

2019-06-11 Thread David Woodhouse
On Tue, 2019-06-11 at 07:49 +, Wu, Hao A wrote: > Hello all, > > For the series: > [PATCH v2 00/10] Duplicate required CSM components for OVMF > https://edk2.groups.io/g/devel/message/41385 > > I sent it out on May 27th, and did not receive a confirmation from David > for about 2 weeks. I thi

[edk2-devel] [edk2-platforms PATCH] Platform/Socionext/DeveloperBox: add SMBIOS type 17 table

2019-06-11 Thread Masahisa Kojima
This adds the SMBIOS type 17 table support for Developerbox platform. The SPDs on a I2C bus is only accessible by the SCP, so SCP-firmware stores SPDs in non-secure SRAM. This commit also reduces the uefi stack size to allocate space for SPDs. It requires 2KB, 512bytes * 4 DIMMs. Signed-off-by: M

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

2019-06-11 Thread David Woodhouse
On Tue, 2019-06-11 at 00:35 -0700, Jordan Justen wrote: > I see that https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > mentions that there is "missing of reviewer/maintainer of the CSM > modules in OvmfPkg", so it will be dropped. Yet, I thought David > agreed to maintain that support as recent

Re: [edk2-devel] [edk2-announce] TianoCore Community Meeting Minutes

2019-06-11 Thread Stephano Cetola
On 6/11/2019 8:13 AM, Rebecca Cran wrote: I should clarify that I don't mind hosting the doxygen docs: there seems to be a move to have this sort of thing hosted on well-known cloud services though, which is why I raised it. Sure, that makes sense. We appreciate you taking the time to host th

Re: [edk2-devel] [PATCH for-next] MdeModulePkg/PciBusDxe: catch unimplemented extended config space reads

2019-06-11 Thread Laszlo Ersek
On 06/04/19 23:44, Laszlo Ersek wrote: > When assigning a physical PCIe device to a QEMU/KVM guest, PciBusDxe may > find that the extended config space is not (fully) implemented. In > LocatePciExpressCapabilityRegBlock(), "CapabilityEntry" may be read as > 0x_ at a given config space offse

[edk2-devel] UEFI SCT Build Broken

2019-06-11 Thread Ashish Singhal
Hello Eric/Supreeth, With the latest edk2 tag, UEFI SCT tip build is broken. Seems like it needs Guid/SalSystemTable.h header file which is not in edk2 tree any more. Is a fix for this already being looked at? Thanks Ashish --

Re: [edk2-devel] [PATCH v1 0/2] OVMF: Drop CSM support

2019-06-11 Thread Laszlo Ersek
On 06/11/19 08:47, Ard Biesheuvel wrote: > On Tue, 11 Jun 2019 at 03:30, Hao A Wu wrote: >> >> The series is also available at: >> https://github.com/hwu25/edk2/tree/ovmf_drop_csm >> >> The series will drop the CSM support in OvmfPkg and delete the unused >> modules. >> >> Cc: David Woodhouse >>

Re: [edk2-devel] RFC for Edk2-Library

2019-06-11 Thread Purma, Kondal R
Hi Sean , Its great that all python files must pass flake8 Python Style. I remember flake8 does not show errors for undefined member variables or instances . I feel this is one of most common use cases of code failures, due to typing errors and won't be visible unless test that use case. Are

Re: [edk2-devel] RFC for Edk2-ToolEnv

2019-06-11 Thread Purma, Kondal R
Hi Sean , Sorry I replied to wrong subject and it's about ToolEnv. It's great that all python files must pass flake8 Python Style. I remember flake8 does not show errors for undefined member variables or instances . I feel this is one of most common use cases of code failures, due to typing e

Re: [edk2-devel] UEFI SCT Build Broken

2019-06-11 Thread Supreeth Venkatesh
Ashish, We are working towards fixing the issue for the next SCT tag corresponding to edk2 tag. Can you please let us know whether you are referring to edk2 tip or which edk2 tag (edk2-stable201903)? If possible, could you log a bug entry in bugzillafor edk2-test/SCT component? Thanks, Supreet

Re: [edk2-devel] UEFI SCT Build Broken

2019-06-11 Thread Ashish Singhal
Supreeth, It is broken against both edk2 tip as well as latest edk2 tag edk2-stable201903. I have filed a bugzilla bug for the same. Thanks Ashish From: Supreeth Venkatesh Sent: Tuesday, June 11, 2019 1:36 PM

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option

2019-06-11 Thread Jonathan Watt
Since I haven't contributed before I'm not sure what the timeline for these things generally is. It's been a month though. Can the patch be pushed now? Regards, Jonathan On 08/05/2019 01:08, Tim Lewis wrote: > Yes, I would support it. Tim > > -Original Message- > From: Carsey, Jaben >

[edk2-devel] [RFC] EdkRepo - The Multi-Repository Tool for EDK II

2019-06-11 Thread Nate DeSimone
Hi All, This RFC is raised to add EdkRepo, the multi-repository tool for EDK II firmware development to TianoCore. EdkRepo is built on top of git. It is intended to automate common developer workflows for projects that use more than one git repository. For example many of the new projects in t

[edk2-devel] [PATCH 2/2] [staging/EdkRepo-Manifest]: Add EdkRepo manifest XML

2019-06-11 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 50 ++ README.md | 32 2 files changed, 82 insertions(+) create mode 100644 Mainta

[edk2-devel] [PATCH 0/2] EdkRepo - The Multi-Repository Tool for EDK II

2019-06-11 Thread Nate DeSimone
This patch series is raised to add the EdkRepo and EdkRepo-Manifest branches to the Edk2-Staging repository. These branches are added to host EdkRepo, the multi-repository tool for EDK II firmware development to TianoCore. For more details on EdkRepo, please see my RFC. Nate DeSimone (2): Add E

[edk2-devel] [PATCH 1/2] [staging/EdkRepo]: Add EdkRepo - The Multi-Repo Tool

2019-06-11 Thread Nate DeSimone
Signed-off-by: Nate DeSimone Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 50 ++ README.md | 32 2 files changed, 82 insertions(+) create mode 100644 Mainta

Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency

2019-06-11 Thread Wu, Hao A
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, June 11, 2019 5:39 PM > To: devel@edk2.groups.io; Wu, Hao A > Cc: 'Ard Biesheuvel'; ming.hu...@linaro.org; Ni, Ray > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop > IntelFramework

Re: [edk2-devel] [edk2-platform patch 2/4] ClevoOpenBoardPkg: Update FDF to use generic Microcode FFS rule

2019-06-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: Monday, June 10, 2019 10:04 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platform patch 2/4] ClevoOpenBoardPkg: Update FDF to use

Re: [edk2-devel] [edk2-platform patch 1/4] MinPlatformPkg: Add generic MICROCODE FFS Rules

2019-06-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Gao, Liming Sent: Monday, June 10, 2019 10:04 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-platform patch 1/4] MinPlatformPkg: Add generic MICROCODE FFS Rules BZ: https://bugzilla.tianocore.org

Re: [edk2-devel] [edk2-platform patch 3/4] KabylakeOpenBoardPkg: Update FDF to use the generic Microcode FFS rule

2019-06-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Gao, Liming Sent: Monday, June 10, 2019 10:04 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-platform patch 3/4] KabylakeOpenBoardPkg: Update FDF to use the generic Microcode FFS rule Signed-off-

Re: [edk2-devel] [PATCH 1/2] BaseTools: add centralized location for git config files

2019-06-11 Thread Bob Feng
OK. I will add the header when I do push. Reviewed-by: Bob Feng -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Tuesday, June 11, 2019 5:35 PM To: Feng, Bob C Cc: devel@edk2.groups.io; Gao, Liming ; Zhu, Yonghong ; Andrew Fish ; Laszlo Ersek ; Kinney, M

Re: [edk2-devel] [PATCH] SecurityPkg/HddPassword: Add a PCD to skip Hdd password prompt

2019-06-11 Thread Dong, Eric
Hi Maggie, Reviewed-by: Eric Dong And pushed: 9e2416ae2e1d26c6e6daa58353de519745bb322d Thanks, Eric > -Original Message- > From: Chu, Maggie > Sent: Monday, June 10, 2019 6:19 PM > To: devel@edk2.groups.io > Cc: Zhang, Chao B ; Yao, Jiewen > ; Dong, Eric > Subject: [PATCH] SecurityPkg

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

2019-06-11 Thread Wu, Hao A
> -Original Message- > From: Wu, Hao A > Sent: Tuesday, June 11, 2019 4:06 PM > To: 'David Woodhouse'; Justen, Jordan L; devel@edk2.groups.io > Cc: Ni, Ray; Laszlo Ersek; Ard Biesheuvel; Phillips, D Scott > Subject: RE: [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg > dependency > > >

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

2019-06-11 Thread Ni, Ray
Hao, Will the CSM duplication cause any code change that may impact CSM functionality? If no, how about firstly duplicate them first? David, Will this approach work for you? Thanks, Ray > -Original Message- > From: Wu, Hao A > Sent: Wednesday, June 12, 2019 9:19 AM > To: David Woodhous

Re: [edk2-devel] [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency

2019-06-11 Thread Wu, Hao A
> -Original Message- > From: Ni, Ray > Sent: Wednesday, June 12, 2019 10:04 AM > To: Wu, Hao A; David Woodhouse; Justen, Jordan L; devel@edk2.groups.io > Cc: Laszlo Ersek; Ard Biesheuvel; Phillips, D Scott > Subject: RE: [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg > dependency > >

[edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only

2019-06-11 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1900 Add the lacking instance to [Componnets] of dsc file for build only. Cc: Jian Wang Cc: Ting Ye Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao --- CryptoPkg/Crypto

[edk2-devel] [PATCH] SecurityPkg: Add lacking instances for build only

2019-06-11 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902 Add the lacking instance to the [Components] of dsc file for build only. Cc: Chao Zhang Cc: Jiewen Yao Cc: Jian Wang Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Cc: Leif Lindholm Signed-

[edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking instances for build only

2019-06-11 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1902 Add the lacking instance to the [Components] of dsc file for build only. Cc: Hao A Wu Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Cc: Leif Lindholm Signed-off-by: Zhichao gao --- SourceL

[edk2-devel] [PATCH] MdeModulePkg: Add lacking instances for build only

2019-06-11 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1857 Add the lacking instances to the [Components] of dsc file for build only. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Z

Re: [edk2-devel] [PATCH] BaseTools: Cannot store library cache of different arch together

2019-06-11 Thread Steven Shi
Hi Christian, For the extra IO accesses for duplicated library, I plan to introduce the CopyFileOnChange() function to solve it. Below is the CopyFileOnChange() BZ, and I haven't sent its patch yet. The CopyFileOnChange() will ensure only once IO store/restore access for each library. To avoid

[edk2-devel] [PATCH 0/2] Update Kabylake build steps.

2019-06-11 Thread Chiu, Chasel
KabylakeOpenBoardPkg no longer supported batch file build, it only supports build_bios.py. ReadMe.md should be updated and batch files should be removed. Test: both API mode and Dispatch mode can build successfully by build_bios.py Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Sig

[edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: Update Kabylake build steps.

2019-06-11 Thread Chiu, Chasel
https://bugzilla.tianocore.org/show_bug.cgi?id=1905 Remove build batch files because they are obsolete. Use build_bios.py from now. Test: both API mode and Dispatch mode can build successfully by build_bios.py Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Ch

[edk2-devel] [PATCH 1/2] Platform/Intel: Update Kabylake build steps.

2019-06-11 Thread Chiu, Chasel
https://bugzilla.tianocore.org/show_bug.cgi?id=1905 KabylakeOpenBoardPkg no longer supported batch file build, it only supports build_bios.py. ReadMe.md should be updated and batch files should be removed. Test: both API mode and Dispatch mode can build successfully by build_bios.py Cc: Mi

Re: [edk2-devel] [PATCH] BaseTools: Cannot store library cache of different arch together

2019-06-11 Thread Steven Shi
Sorry, the CopyFileOnChange() will ensure only once IO store/restore writing for each library. The extra IO read is ok. Thanks Steven Shi Intel\SSG\FID\Firmware Infrastructure From: Shi, Steven Sent: Wednesday, June 12, 2019 11:24 AM To: Rodriguez, Christian ; devel@edk2.groups.io Cc: Gao, Lim

Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices

2019-06-11 Thread Ravi Kumar Siadri
Hi, Can someone help me in clarifying my queries ?? Thanks, Ravi Kumar On Mon, Jun 10, 2019 at 3:55 PM Ravi Kumar Siadri < siadriravikumaru...@gmail.com> wrote: > Hi all, > > I have couple of queries regarding the > *EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL* attribute support in > *EFI_EXT_SCS

Re: [edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: Update Kabylake build steps.

2019-06-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Tuesday, June 11, 2019 8:29 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH 2/2] KabylakeOpenBoardPkg: Update Kabylake build steps. https://bugzilla.tianocor

Re: [edk2-devel] [PATCH 1/2] Platform/Intel: Update Kabylake build steps.

2019-06-11 Thread Nate DeSimone
It's good that we have the Python 2.x dependency documented for KabyLakeOpenBoardPkg now, but we really need to migrate it to Python 3.x since security updates for Python 2.x will be ending soon. Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Chi

Re: [edk2-devel] [PATCH v2 0/3] Common OBB verification feature

2019-06-11 Thread Yao, Jiewen
Thanks Jian. Some comment below: 0) Please add what unit test has been done. 1) Can we use UINT64 for Base and Length? typedef struct _HASHED_FV_INFO { UINT32 Base; UINT32 Length; UINT64 Flag; } HASHED_FV_INFO; 2) Can we remove the hard co

[edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial change for PeiAllocatePool

2019-06-11 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1901 The original logic is ASSERT if fail to create HOB. But that doesn't make sense for release version. So it is required to set the Buffer to null to indicate the failure. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Sta

Re: [edk2-devel] [edk2-platforms PATCH] Platform/Socionext/DeveloperBox: add SMBIOS type 17 table

2019-06-11 Thread Masahisa Kojima
Hi Ard, On Tue, 11 Jun 2019 at 22:01, Ard Biesheuvel wrote: > > On Tue, 11 Jun 2019 at 14:18, Masahisa Kojima > wrote: > > > > This adds the SMBIOS type 17 table support for Developerbox platform. > > The SPDs on a I2C bus is only accessible by the SCP, so SCP-firmware > > stores SPDs in non-sec

Re: [edk2-devel] [Patch V3] EmulatorPkg: don't display the cpu current speed

2019-06-11 Thread Zhiguang Liu
Thanks for the comments. I will change the commit message in the next version. But I don't think this is a issue worth making a major change. Given that the change is consistent with NT32, will you agree with this change? Best Regards, Zhiguang Liu >-Original Message- >From: Justen, Jorda

Re: [edk2-devel] RFC for Edk2-ToolEnv

2019-06-11 Thread Sean via Groups.Io
Both of these RFCs listed flake8 because that is what we have today and it should be relatively easy to get parity.  I am super happy to have you add/propose/provide pr with additional test capability like Pylint.  Thats one of the goals of adding this to tianocore. You can see what we are basi

[edk2-devel] [PATCH] ShellPkg/UefiShellLib: Set input pointer parameter to null if failure

2019-06-11 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1906 While failed to allocate memory to save the response, set the input/output parameter 'Response'(VOID **) to NULL to indicate the failure not only depend on the returned status. Cc: Jaben Carsey Cc: Ray Ni Cc: Liming