Re: [edk2-devel] another PR rejected by CI

2023-08-28 Thread Ard Biesheuvel
On Mon, 28 Aug 2023 at 20:37, Kinney, Michael D wrote: > > Hi Ard, > > I think your main question is how all developers can find the > details of any of these types of test failures. It is not > obvious until you notice there is a "Tests" tab on one of the > Azure Pipelines pages. > > The main in

Re: [edk2-devel] another PR rejected by CI

2023-08-28 Thread Oliver Smith-Denny
Another option, when the main pipeline page says there is an uncrustify error is to take the cmdline it ran with and append UNCRUSTIFY_IN_PLACE=TRUE to it. It will then auto-fixup any uncrustify errors (which obviously should be audited afterwards). I do this to avoid having to wade through numero

Re: [edk2-devel] another PR rejected by CI

2023-08-28 Thread Michael D Kinney
Hi Ard, I think your main question is how all developers can find the details of any of these types of test failures. It is not obvious until you notice there is a "Tests" tab on one of the Azure Pipelines pages. The main interface to developers for these types of failures is "Test" results in

Re: [edk2-devel] another PR rejected by CI

2023-08-28 Thread Taylor Beebe
Here's a git-patch so you can easily fix it: ---  OvmfPkg/IoMmuDxe/IoMmuBuffer.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c index 2764c35044ac..d66763263784 100644 --- a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c +++ b/Ov

Re: [edk2-devel] another PR rejected by CI

2023-08-28 Thread Mike Maslenkin
Hello! https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=100301&view=ms.vss-test-web.build-test-results-tab&runId=877528&resultId=16&paneView=attachments Uncrustify found formatting errors in IoMmuDxe/IoMmuBuffer.c See Standard_Error_Output.log in "attachments" It doesn't like t