Re: [edk2-devel] ECC: Won't somebody PLEASE think of the... test structures.

2020-09-25 Thread Laszlo Ersek
On 09/25/20 04:25, Bret Barkelew via groups.io wrote: > So for context, this is a new host-based test that should only run > within a platform OS, so intrinsics aren't the big deal that they > would be in FW code. > > But we do need to figure out how to simultaneously adhere to the > coding convent

Re: [EXTERNAL] Re: [edk2-devel] ECC: Won't somebody PLEASE think of the... test structures.

2020-09-24 Thread Bret Barkelew via groups.io
<mailto:af...@apple.com> Sent: Thursday, September 24, 2020 7:48 PM To: edk2-devel-groups-io<mailto:devel@edk2.groups.io>; Bret Barkelew<mailto:bret.barke...@microsoft.com> Cc: Ken Taylor<mailto:ken_tay...@phoenix.com> Subject: [EXTERNAL] Re: [edk2-devel] ECC: Won't

Re: [edk2-devel] ECC: Won't somebody PLEASE think of the... test structures.

2020-09-24 Thread Andrew Fish via groups.io
Bret, I’ve had this issue with EFI code too. It will compile with for DEBUG and RELEASE as the optimizer removes the memcpy/memset. So you only see a build failure when you compiler NOOPT (and there are no intrinsic libs). I mostly see this in platform code when I try to compile a single driver

Re: [edk2-devel] ECC: Won't somebody PLEASE think of the... test structures.

2020-09-24 Thread Bret Barkelew via groups.io
ber 24, 2020 7:26 PM To: Ken Taylor<mailto:ken_tay...@phoenix.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: [EXTERNAL] Re: [edk2-devel] ECC: Won't somebody PLEASE think of the... test structures. So for context, this is a new host-based test that should only run wi

Re: [edk2-devel] ECC: Won't somebody PLEASE think of the... test structures.

2020-09-24 Thread Bret Barkelew via groups.io
So for context, this is a new host-based test that should only run within a platform OS, so intrinsics aren’t the big deal that they would be in FW code. But we do need to figure out how to simultaneously adhere to the coding convention while enabling test authoring. Or we chose to not enforce q

Re: [edk2-devel] ECC: Won't somebody PLEASE think of the... test structures.

2020-09-24 Thread Ken Taylor
If the structure is a non-static local variable, most compilers will silently inject an intrinsic call to memcpy in function initialization. This leads to an intermittent linker error. If the compiler you use automatically supports an intrinsic memcpy in the given architecture or optimizes out