Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor

2021-03-03 Thread Michael Kubacki
rince ; gaolim...@byosoft.com.cn; Dong, Eric *Subject:* RE: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor Furthermore, is it the code that cannot cross the repo boundary, or the interface? Is there any use in defining the interface at a lower level such as MdeModulePkg? Then a pla

Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor

2021-03-03 Thread Ni, Ray
ubacki Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Luo, Heng ; Agyeman, Prince ; gaolim...@byosoft.com.cn; Dong, Eric Subject: RE: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor Furthermore, is it the code that cannot cross the repo boundary, or the int

Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor

2021-03-03 Thread Bret Barkelew via groups.io
edk2.groups.io; Ni, > Ray > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Luo, Heng ; Agyeman, > Prince ; > gaolim...@byosoft.com.cn; Dong, Eric > Subject: RE: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor > > > Hi Michael,

Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor

2021-03-03 Thread Ni, Ray
Agyeman, > Prince ; > gaolim...@byosoft.com.cn; Dong, Eric > Subject: RE: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor > > > Hi Michael, > > I didn't initiate any discussion on this yet. And I am not sure if this idea > could be accepted. > Fro

Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor

2021-03-03 Thread Guo Dong
th these advanced features on > different platforms. > > > > Thanks, > > Guo > > > > > >> -Original Message- > >> From: Ni, Ray > >> Sent: Monday, March 1, 2021 5:52 PM > >> To: Michael Kubacki ; > >> devel@edk2.gro

Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor

2021-03-03 Thread Michael Kubacki
simone, Nathaniel L ; Luo, Heng ; Agyeman, Prince ; gaolim...@byosoft.com.cn; Dong, Eric ; Dong, Guo Subject: RE: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor Michael, I am good with that. I am also curious how you merge all the different SPI flash implementation into one. Th

Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor

2021-03-03 Thread Guo Dong
i > > Sent: Tuesday, March 2, 2021 3:16 AM > > To: devel@edk2.groups.io; Ni, Ray > > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > > ; Luo, Heng ; > Agyeman, Prince ; > > gaolim...@byosoft.com.cn; Dong, Eric > > Subject: Re: [e

Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor

2021-03-01 Thread Ni, Ray
ngasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Luo, Heng ; Agyeman, > Prince ; > gaolim...@byosoft.com.cn; Dong, Eric > Subject: Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor > > Hi Ray, > > That sounds reasonable to me. > > I was att

Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor

2021-03-01 Thread Michael Kubacki
Hi Ray, That sounds reasonable to me. I was attempting to preserve the design that isolates the silicon-specific logic to a library via an interface to a silicon package. However, the real abstraction here is the firmware volume block protocol which could simply be produced by a silicon drive

Re: [edk2-devel] [edk2-platforms][RFC] SpiFlashCommonLib Refactor

2021-03-01 Thread Ni, Ray
Michael, I agree with your thoughts to consolidate the lib header and implementation to IntelSiliconPkg. I didn't read the different implementations. But the implementation consolidation means you see all the existing implementations are the same. Right? But why don't you put the driver in Inte