Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-09-03 Thread Chuong Tran
For this patch series: Reviewed-by: Chuong Tran Regards, Chuong On 8/7/2024 1:47 PM, Nhi Pham wrote: This updates the I2C library and implements SMBUS PEI/DXE drivers to support IPMI SSIF in the Mt. Jade platform. v2: - Refine the changes of the DwI2cLib per Leif's comments and update the

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-29 Thread Nhi Pham via groups.io
Pushed as 6146fd7abcf6..9d8eda62 Thanks, Nhi From: Chuong Tran OS Sent: Thursday, August 29, 2024 12:55 PM To: Nhi Pham OS ; devel@edk2.groups.io Cc: quic_llind...@quicinc.com ; Chuong Tran OS ; Rebecca Cran OS Subject: Re: [edk2-platforms][PATCH v2 0/5]

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-12 Thread Nhi Pham via groups.io
llind...@quicinc.com Cc: devel@edk2.groups.io ; Chuong Tran OS ; Rebecca Cran OS Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Hi Leif, I saw a comment from you in the Pull Request and I resolved it. Do you prefer to review in the Github PR? Should I send v3 to the ma

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-08 Thread Chang, Abner via groups.io
Chang, Abner ; devel@edk2.groups.io > Cc: quic_llind...@quicinc.com; Chuong Tran OS > ; Rebecca Cran OS > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF > support > > Caution: This message originated from an External Source. Use proper caution > when ope

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-08 Thread Nhi Pham via groups.io
ilto:chu...@os.amperecomputing.com>>; Rebecca Cran OS mailto:rebe...@os.amperecomputing.com>> *Subject:* RE: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support [AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, We already move edk2-platforms review

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-08 Thread Chang, Abner via groups.io
am OS Sent: Wednesday, August 7, 2024 3:35 PM To: Chang, Abner ; devel@edk2.groups.io Cc: quic_llind...@quicinc.com; Chuong Tran OS ; Rebecca Cran OS Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support [AMD Official Use Only - AMD Internal Distribution Only] Caution:

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-07 Thread Nhi Pham via groups.io
Hi Leif, I saw a comment from you in the Pull Request and I resolved it. Do you prefer to review in the Github PR? Should I send v3 to the mailing list? Regards, Nhi On 8/7/2024 1:47 PM, Nhi Pham wrote: > This updates the I2C library and implements SMBUS PEI/DXE drivers to > support IPMI SSIF i

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-07 Thread Chang, Abner via groups.io
:34 PM To: devel@edk2.groups.io ; Chang, Abner ; n...@os.amperecomputing.com Cc: chu...@os.amperecomputing.com ; rebe...@os.amperecomputing.com Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Caution: This message originated from an External Source. Use proper c

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-07 Thread Leif Lindholm
indholm *Sent:* Wednesday, August 7, 2024 6:23:46 PM *To:* Chang, Abner ; devel@edk2.groups.io ; n...@os.amperecomputing.com *Cc:* chu...@os.amperecomputing.com ; rebe...@os.amperecomputing.com *Subject:* Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Caution: This

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-07 Thread Chang, Abner via groups.io
if Lindholm Sent: Wednesday, August 7, 2024 6:23:46 PM To: Chang, Abner ; devel@edk2.groups.io ; n...@os.amperecomputing.com Cc: chu...@os.amperecomputing.com ; rebe...@os.amperecomputing.com Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Caution: This message

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-07 Thread Leif Lindholm
Err, no we haven't. Although we're in the process of doing that. / Leif On 2024-08-07 08:16, Chang, Abner wrote: [AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, We already move edk2-platforms review through GitHub PR. Could you please send the PR against edk2-platforms?

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-07 Thread Nhi Pham via groups.io
Cran OS Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support [AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, We already move edk2-platforms review through GitHub PR. Could you please send the PR against edk2-platforms? Thanks Abner > -

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-07 Thread Chang, Abner via groups.io
[AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, We already move edk2-platforms review through GitHub PR. Could you please send the PR against edk2-platforms? Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nhi Pham > via groups.io > Sent: W