Re: [edk2-devel] [RFC PATCH 05/10] MdeModulePkg: Define memory attribute PPI

2023-05-31 Thread Ard Biesheuvel
On Wed, 31 May 2023 at 10:56, Ni, Ray wrote: > > > > > > 2. > > > > > When a memory region is marked from not-present to present, > > PageTableLib > > > > expects > > > > > caller to supply all memory attributes (including RW, NX, etc.) as > > > > > the lib > > > > implementation doesn't > > > >

Re: [edk2-devel] [RFC PATCH 05/10] MdeModulePkg: Define memory attribute PPI

2023-05-31 Thread Ni, Ray
> > > > 2. > > > > When a memory region is marked from not-present to present, > PageTableLib > > > expects > > > > caller to supply all memory attributes (including RW, NX, etc.) as the > > > > lib > > > implementation doesn't > > > > want to carry any default attributes.. > > > > Do you think th

Re: [edk2-devel] [RFC PATCH 05/10] MdeModulePkg: Define memory attribute PPI

2023-05-31 Thread Ard Biesheuvel
On Wed, 31 May 2023 at 09:34, Ni, Ray wrote: > > > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Tuesday, May 30, 2023 3:32 PM > > To: Ni, Ray > > Cc: devel@edk2.groups.io; Yao, Jiewen ; Gerd > > Hoffmann ; Taylor Beebe ; Oliver > > Smith-Denny ; Bi, Dandan ; > > Gao, Liming

Re: [edk2-devel] [RFC PATCH 05/10] MdeModulePkg: Define memory attribute PPI

2023-05-31 Thread Ni, Ray
> -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, May 30, 2023 3:32 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; Yao, Jiewen ; Gerd > Hoffmann ; Taylor Beebe ; Oliver > Smith-Denny ; Bi, Dandan ; > Gao, Liming ; Kinney, Michael D > ; Leif Lindholm ; > Sunil V L ; Warkentin, A

Re: [edk2-devel] [RFC PATCH 05/10] MdeModulePkg: Define memory attribute PPI

2023-05-30 Thread Ard Biesheuvel
On Tue, 30 May 2023 at 09:15, Ni, Ray wrote: > > 1. > The PPI interface supports to set and clear any attributes with single > invocation. > That's much better than the existing UEFI protocol prototype which requires > caller to call the interfaces > twice to set and clear some attributes. > Ag

Re: [edk2-devel] [RFC PATCH 05/10] MdeModulePkg: Define memory attribute PPI

2023-05-30 Thread Ni, Ray
1. The PPI interface supports to set and clear any attributes with single invocation. That's much better than the existing UEFI protocol prototype which requires caller to call the interfaces twice to set and clear some attributes. So far I see two patterns for attributes setting: *. The patten