Re: [edk2-devel] [Patch 0/4] Normalize line endings to CRLF in ARM packages

2019-04-05 Thread Michael D Kinney
Leif, PatchCheck.py is complaining because lines in the file header that contain the license text for some files are using the wrong line endings. The script I wrote preserves the line ending style from the old license text when adding the SPDX identifier so the script would not have to figure ou

Re: [edk2-devel] [Patch 0/4] Normalize line endings to CRLF in ARM packages

2019-04-05 Thread Leif Lindholm
On Thu, Apr 04, 2019 at 05:00:36PM +, Kinney, Michael D wrote: > Leif, > > There were a few files when the license change patches > were created that failed PatchCheck.py. > > I am trying to resolve those before the license change > so the license change patches do not have any PatchCheck.py

Re: [edk2-devel] [Patch 0/4] Normalize line endings to CRLF in ARM packages

2019-04-04 Thread Kevin@Insyde
We would prefer separate patches. Kevin D Davis Insyde Software > On Apr 4, 2019, at 1:00 PM, Michael D Kinney > wrote: > > Leif, > > There were a few files when the license change patches > were created that failed PatchCheck.py. > > I am trying to resolve those before the license change >

Re: [edk2-devel] [Patch 0/4] Normalize line endings to CRLF in ARM packages

2019-04-04 Thread Michael D Kinney
Leif, There were a few files when the license change patches were created that failed PatchCheck.py. I am trying to resolve those before the license change so the license change patches do not have any PatchCheck.py failures. If I do these as part of the license change, then the change will look

Re: [edk2-devel] [Patch 0/4] Normalize line endings to CRLF in ARM packages

2019-04-04 Thread Laszlo Ersek
On 04/04/19 05:54, Leif Lindholm wrote: > Hi Mike, > > This looks fine. But I did have one thought: > If we're just about to touch pretty much every file in the tree anyway > - can we consider doing the full conversion to native line endings at > the same time? > > (This doesn't help the 'git bla

Re: [edk2-devel] [Patch 0/4] Normalize line endings to CRLF in ARM packages

2019-04-04 Thread Leif Lindholm
Hi Mike, This looks fine. But I did have one thought: If we're just about to touch pretty much every file in the tree anyway - can we consider doing the full conversion to native line endings at the same time? (This doesn't help the 'git blame' problem, it just reminded me.) / Leif On Wed,