Re: [edk2-devel] [PATCH v3 0/3] XCODE5 toolchain binary patching fix

2020-05-11 Thread Laszlo Ersek
On 05/07/20 15:06, Lendacky, Thomas wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 > > Commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass > XCODE5 tool chain") introduced binary patching in the > ExceptionHandlerAsm.nasm in order to support the XCODE5 toolcha

Re: [edk2-devel] [PATCH v3 0/3] XCODE5 toolchain binary patching fix

2020-05-08 Thread Dong, Eric
For this patch series: Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sent: Thursday, May 7, 2020 9:07 PM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard Biesheuvel ; Gao, > Liming ; Dong, Eric ; Ni, Ray

Re: [edk2-devel] [PATCH v3 0/3] XCODE5 toolchain binary patching fix

2020-05-08 Thread Liming Gao
Laszlo: This change is OK to me. It doesn't impact those platforms, because their SEC and PEI are IA32 only. This patch is to update SecPei library instance for X64 arch. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Laszlo Ersek > Sent: Friday, May 8, 2020 7:

Re: [edk2-devel] [PATCH v3 0/3] XCODE5 toolchain binary patching fix

2020-05-08 Thread Laszlo Ersek
Eric, Ray, Liming -- do you have comments please? I'm ready to push the series (it has two UefiCpuPkg patches and one OvmfPkg patch). Please consider specifically whether we should push the last patch at once. The last patch would prevent the following "edk2-platforms" DSC files from building wit