Re: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to BaseHashApiLib

2020-02-14 Thread Michael D Kinney
4 PM > To: devel@edk2.groups.io; Sukerkar, Amol N > ; Kinney, Michael D > > Cc: Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Gao, Liming > > Subject: RE: [edk2-devel] [PATCH v3 0/2] Enhancement > and Fixes to BaseHashApiLib > > Amol, > > Thanks for th

Re: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to BaseHashApiLib

2020-02-14 Thread Sukerkar, Amol N
v3 0/2] Enhancement and Fixes to BaseHashApiLib Amol, Thanks for the quick update. I see you changed the PCD to type UINT16. I think this was based on Jiewen feedback to use a set of TPM specific algorithms defines that were UINT16. However, the HASH define values being used are 32-bits and

Re: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to BaseHashApiLib

2020-02-14 Thread Michael D Kinney
Amol, Thanks for the quick update. I see you changed the PCD to type UINT16. I think this was based on Jiewen feedback to use a set of TPM specific algorithms defines that were UINT16. However, the HASH define values being used are 32-bits and everywhere else that those defines values are used