Re: [edk2-devel] [PATCH v3] MdeModulePkg: Add Platform Boot Options Protocol

2019-12-18 Thread Ashish Singhal
I have submitted a patch version 4. Thanks Ashish -Original Message- From: Ni, Ray Sent: Wednesday, December 18, 2019 1:43 AM To: Ashish Singhal ; devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A ; Gao, Zhichao Subject: RE: [PATCH v3] MdeModulePkg: Add Platform Boot Options Protocol E

Re: [edk2-devel] [PATCH v3] MdeModulePkg: Add Platform Boot Options Protocol

2019-12-18 Thread Ni, Ray
I am ok with adding EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL. > -Original Message- > From: Ashish Singhal > Sent: Wednesday, December 18, 2019 12:22 PM > To: Ni, Ray ; devel@edk2.groups.io; Wang, Jian J > ; Wu, Hao A > ; Gao, Zhichao > Subject: RE: [PATCH v3] MdeModulePkg: Add Platform Boot

Re: [edk2-devel] [PATCH v3] MdeModulePkg: Add Platform Boot Options Protocol

2019-12-17 Thread Ashish Singhal
Ray, I did not name the protocol this way because EmbeddedPkg already describes a protocol with a similar name that is PLATFORM_BOOT_MANAGER_PROTOCOL. If you think we can still go ahead with new protocol named EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL, I can make the necessary changes. I agree with

Re: [edk2-devel] [PATCH v3] MdeModulePkg: Add Platform Boot Options Protocol

2019-12-17 Thread Ni, Ray
Ashish, I prefer EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL and could have two fields for this protocol for now: Revision and RefreshAllBootOption (IN Options, IN OptionCount, OUT UpdatedOptions, OUT UpdatedOptionCount) Usually EDKII puts Count in second and buffer in first. The reason of using EDKII_