Re: [edk2-devel] [PATCH v2 11/30] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-11-13 Thread Chao Li
Hi Andrei, I agree with you, I will move LoongArch-specific stuff from UefiCpuPkg to MdePkg/Include/ in V3. And you are also saied record the idea of moving ArmMmuLib to CpuMmuLib, I would to say, this header is referenced from ArmPkg, and I plan to move the ArmMmuLib from ArmPkg to UefiCpuP

Re: [edk2-devel] [PATCH v2 11/30] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2023-11-08 Thread Andrei Warkentin
Hi Chao, I see that you're adding a header, CpuMmuLib.h, but this header is not generic - it includes a bunch of Loongson arch-specific "stuff". I agree in principle that there's room for a generic CpuMmuLib, and I don't think you ought to be on the hook to refactor ArmMmuLib, but I suggest mo