Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-12-17 Thread Nhi Pham via groups.io
Hi Leif, Thanks so much for merging it. Happy Holidays! Best regards, Nhi On 17/12/2021 22:56, Leif Lindholm wrote: Hi Nhi, I have now pushed this patch as c63a10ecb7d6, and will get back to the rest of the Altra port. / Leif On Thu, Sep 09, 2021 at 00:02:36 +0700, Nhi Pham wrote: Th

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-12-17 Thread Leif Lindholm
Hi Nhi, I have now pushed this patch as c63a10ecb7d6, and will get back to the rest of the Altra port. / Leif On Thu, Sep 09, 2021 at 00:02:36 +0700, Nhi Pham wrote: > Thanks Abner. > > I will correct the description for the function AcpiLocateTableBySignature > in the v3. > > Best regards

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-09-08 Thread Nhi Pham via groups.io
Thanks Abner. I will correct the description for the function AcpiLocateTableBySignature in the v3. Best regards, Nhi On 08/09/2021 11:53, Chang, Abner (HPS SW/FW Technologist) wrote: After below comments are addressed, Reviewed-by: Abner Chang -Original Message- From: devel@edk2

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-09-08 Thread Nhi Pham via groups.io
Hi Leif, Thanks for your reviewing. These functions in this patch are consumed in Ampere Mt. Jade platform. We can defer merging this patch until I send the v3 of Ampere Mt. Jade patchset out. Best regards, Nhi On 08/09/2021 01:00, Leif Lindholm wrote: Hi Nhi, On Fri, Sep 03, 2021 at 22:44:

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-09-07 Thread Abner Chang
After below comments are addressed, Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Nhi Pham via groups.io > Sent: Friday, September 3, 2021 11:44 PM > To: devel@edk2.groups.io > Cc: patc...@amperecomputing.com; Nhi

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-09-07 Thread Leif Lindholm
Hi Nhi, On Fri, Sep 03, 2021 at 22:44:23 +0700, Nhi Pham wrote: > This adds more helper functions that assist in calculating the checksum, > locating an ACPI table by signature, and updating an AML integer object. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaef