Re: [edk2-devel] [PATCH v2] MdePkg: add null version of RngLib

2019-11-13 Thread Wang, Jian J
Laszlo, > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, November 13, 2019 5:28 PM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Ard Biesheuvel ; Ni, Ray > > Subject: Re: [edk2-devel] [PATCH v2] MdePkg: add null v

Re: [edk2-devel] [PATCH v2] MdePkg: add null version of RngLib

2019-11-13 Thread Laszlo Ersek
On 11/13/19 09:43, Wang, Jian J wrote: > As requested by Ray, I'd like to mention more usage about this library > instance. > > To be more specific, if following components or functionalities are used in a > platform, the BaseRngLibNull should *not* be used. Instead, a non-Null version > of RngLib

Re: [edk2-devel] [PATCH v2] MdePkg: add null version of RngLib

2019-11-13 Thread Wang, Jian J
As requested by Ray, I'd like to mention more usage about this library instance. To be more specific, if following components or functionalities are used in a platform, the BaseRngLibNull should *not* be used. Instead, a non-Null version of RngLib must be used (like BaseRngLib for IA32/X64, or com

Re: [edk2-devel] [PATCH v2] MdePkg: add null version of RngLib

2019-11-13 Thread Wang, Jian J
Laszlo, Thanks for the comments. I agree all of them. Since there's still EBC listed in SUPPORTED_ARCHITECTURES in dsc file, I don't see any reason not to add it. But likewise, I'll leave the final decision to package maintainers. Regards, Jian > -Original Message- > From: Laszlo Ersek

Re: [edk2-devel] [PATCH v2] MdePkg: add null version of RngLib

2019-11-13 Thread Laszlo Ersek
Hi Jian, thanks for the update. Comments below: On 11/13/19 06:35, Jian J Wang wrote: >> v2: >> - Change the name from RngLibNull to BaseRngLibNull according to Laszlo's >>comments >> - Move the module from SecurityPkg to MdePkg according to Laszlo's comments >> - Update commit message acc

Re: [edk2-devel] [PATCH v2] MdePkg: add null version of RngLib

2019-11-13 Thread Liming Gao
The change is good. Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Wang, Jian J >Sent: Wednesday, November 13, 2019 1:35 PM >To: devel@edk2.groups.io >Cc: Kinney, Michael D ; Gao, Liming >; Laszlo Ersek ; Ard Biesheuvel